fs/lftest: Convert to new library
PATCH 1/1 fs/lftest: Convert to new library
From: Joerg Vehlow <[email protected]>
Additonal changes:
- Use temp directory instead of working dir
- 100 buffers is teh default now and can be changed using -n
- Removed some useless output (nseek, nwrite was always bufnum)
--- runtest/fs | 2 +- testcases/kernel/fs/lftest/lftest.c | 111 ++++++++++++---------------- 2 files changed, 49 insertions(+), 64 deletions(-)
runtest/fs +1 -1
@@ -58,7 +58,7 @@ ftest06 ftest06 ftest07 ftest07 ftest08 ftest08 -lftest01 lftest 100 +lftest01 lftest writetest01 writetest #Also run the fs_di (Data Integrity tests)
testcases/kernel/fs/lftest/lftest.c +48 -63
139 lines not on this page · raw message
Signature · 1 line
2.25.1
PATCH 1/1 fs/lftest: Convert to new library
Hi Joerg,
Quoted 4 lines
Additonal changes:
- Use temp directory instead of working dir
- 100 buffers is teh default now and can be changed using -n
- Removed some useless output (nseek, nwrite was always bufnum)
LGTM, going to merge it after Jan 2021 release.
Below are 2 tiny details I'll fix during merge.
...
runtest/fs ftest06 ftest06 · line 61
Quoted 7 lines
+++ b/runtest/fs
runtest/fs +1
-1@@ -58,7 +58,7 @@ ftest06 ftest06 ftest07 ftest07 ftest08 ftest08 -lftest01 lftest 100 +lftest01 lftest
Not sure if anybody uses runtest/fs_readonly, but we still haven't removed it. Thus it must be also updated:
-test_robind54 test_robind.sh -c "lftest 80"
+test_robind54 test_robind.sh -c "lftest"
...
Quoted 1 line
(quoted diff) +1
-0+++ b/testcases/kernel/fs/lftest/lftest.c
...
testcases/kernel/fs/lftest/lftest.c line 31
Quoted 2 lines
testcases/kernel/fs/lftest/lftest.c +2
-0+if (str_bufnum) { +if (tst_parse_int (str_bufnum ,&bufnum,0 ,INT_MAX )) {
nit: formatting:
if (tst_parse_int(str_bufnum, &bufnum, 0, INT_MAX)) {Review
Quoted 2 lines
(quoted diff) +2
-0+ tst_brk(TBROK, "Invalid buffer count '%s'", str_bufnum); + }
Kind regards,
Petr
PATCH 1/1 fs/lftest: Convert to new library
Hi Petr,
Review
Quoted 6 lines · Petr Vorel
Not sure if anybody uses runtest/fs_readonly, but we still haven't removed it.
Thus it must be also updated:(quoted diff) +1
-1-test_robind54 test_robind.sh -c "lftest 80" +test_robind54 test_robind.sh -c "lftest"
Oh did not see that...
The default parameter to lftest is now 100, so this should probably be +test_robind54 test_robind.sh -c "lftest -n 80
Don't know if it is important
J?rg
PATCH 1/1 fs/lftest: Convert to new library
Hi J?rg,
Quoted 10 lines
Hi Petr,
Review
Quoted 6 lines · Petr Vorel
Not sure if anybody uses runtest/fs_readonly, but we still haven't removed it.
Thus it must be also updated:(quoted diff) +1
-1-test_robind54 test_robind.sh -c "lftest 80" +test_robind54 test_robind.sh -c "lftest"Oh did not see that...
No big deal, these duplicities in runtest files are always confusing. Looking forward a day when we replace runtest files with something better.
Quoted 2 lines
The default parameter to lftest is now 100, so this should probably be +test_robind54
test_robind.sh-c "lftest -n 80
Correct.
Quoted 1 line
Don't know if it is important
No, it's probably not important, but merged with this change anyway.
Quoted 1 line
J?rg
Kind regards,
Petr