ARM64: use linux/types.h in kvm.h
PATCH 1/1 ARM64: use linux/types.h in kvm.h
We should always use linux/types.h instead of asm/types.h for consistency, and Kbuild actually warns about it:
./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>
This patch does as Kbuild asks us.
---
Found on ARM64 allmodconfig
arch/arm64/include/uapi/asm/kvm.h +1 -1
@@ -32,7 +32,7 @@#ifndef __ASSEMBLY__#include <linux/psci.h> -#include <asm/types.h> +#include <linux/types.h> #include <asm/ptrace.h> #define __KVM_HAVE_GUEST_DEBUG
Quoted 8 lines · Arnd Bergmann
We should always use
linux/types.hinstead ofasm/types.hfor consistency, andKbuildactually warns about it:
./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>This patch does as
Kbuildasks us.Signed-off-by Arnd Bergmann <[email protected]>
I don't see this error when building the kernel, does it require a special option to check for these things?
In any case, thanks for the patch, I have applied it.
-Christoffer
Quoted 4 lines · On Friday 13 November 2015 12:38:43 Christoffer Dall wrote:
Quoted 3 lines · Arnd Bergmann
We should always use
linux/types.hinstead ofasm/types.hfor consistency, andKbuildactually warns about it:
Quoted 8 lines
Quoted 5 lines
./usr/include/asm/kvm.h:35: include of <linux/types.h> is preferred over <asm/types.h>This patch does as
Kbuildasks us.Signed-off-by Arnd Bergmann <[email protected]>I don't see this error when building the kernel, does it require a special option to check for these things?
CONFIG_HEADERS_CHECK should be included in 'allmodconfig', which is the configuration I used. I think at the moment, allmodconfig builds fail, so you don't get to this point unless you also apply my other fixes.
Quoted 1 line
In any case, thanks for the patch, I have applied it.
Thanks!
Arnd