loop: unset GENHD_FL_NO_PART_SCAN on LOOP_CONFIGURE
PATCH v2 1/1 loop: unset GENHD_FL_NO_PART_SCAN on LOOP_CONFIGURE
When LOOP_CONFIGURE is used with LO_FLAGS_PARTSCAN we need to propagate this into the GENHD_FL_NO_PART_SCAN. LOOP_SETSTATUS does this, LOOP_CONFIGURE doesn't so far. Effect is that setting up a loopback device with partition scanning doesn't actually work when LOOP_CONFIGURE is issued, though it works fine with LOOP_SETSTATUS.
Let's correct that and propagate the flag in LOOP_CONFIGURE too.
--- drivers/block/loop.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/block/loop.c +2 -0
@@ -1171,6 +1171,8 @@ static int loop_configure(struct loop_device *lo, fmode_t mode,if (part_shift) lo->lo_flags |=LO_FLAGS_PARTSCAN ; partscan = lo->lo_flags &LO_FLAGS_PARTSCAN ; +if (partscan) + lo->lo_disk->flags &= ~GENHD_FL_NO_PART_SCAN ;/* Grab the block_device to prevent its destruction after we * put /dev/loopXX inode. Later in __loop_clr_fd() we bdput(bdev).
--
2.26.2
Quoted 7 lines · Lennart Poettering
When
LOOP_CONFIGUREis used withLO_FLAGS_PARTSCANwe need to propagate this into theGENHD_FL_NO_PART_SCAN.LOOP_SETSTATUSdoes this,LOOP_CONFIGUREdoesn't so far. Effect is that setting up a loopback device with partition scanning doesn't actually work whenLOOP_CONFIGUREis issued, though it works fine withLOOP_SETSTATUS.
Quoted 6 lines
Let's correct that and propagate the flag in
LOOP_CONFIGUREtoo.Fixes 3448914e8cc5("loop: Add LOOP_CONFIGURE ioctl")Signed-off-by Lennart Poettering <[email protected]>Acked-by Martijn Coenen <[email protected]>
Thanks, still looks good to me.
Quoted 19 lines
--- drivers/block/loop.c | 2 ++ 1 file changed, 2 insertions(+)drivers/block/loop.c +2
-1@@ -1171,6 +1171,8 @@ static int loop_configure(struct loop_device *lo, fmode_t mode,if (part_shift) lo->lo_flags |=LO_FLAGS_PARTSCAN ; partscan = lo->lo_flags &LO_FLAGS_PARTSCAN ; +if (partscan) + lo->lo_disk->flags &= ~GENHD_FL_NO_PART_SCAN ;/* Grab the block_device to prevent its destruction after we * put /dev/loopXX inode. Later in __loop_clr_fd() we bdput(bdev). -- 2.26.2
Quoted 8 lines · Martijn Coenen
Quoted 7 lines · Lennart Poettering
When
LOOP_CONFIGUREis used withLO_FLAGS_PARTSCANwe need to propagate this into theGENHD_FL_NO_PART_SCAN.LOOP_SETSTATUSdoes this,LOOP_CONFIGUREdoesn't so far. Effect is that setting up a loopback device with partition scanning doesn't actually work whenLOOP_CONFIGUREis issued, though it works fine withLOOP_SETSTATUS.
Quoted 8 lines
Quoted 6 lines
Let's correct that and propagate the flag in
LOOP_CONFIGUREtoo.Fixes 3448914e8cc5("loop: Add LOOP_CONFIGURE ioctl")Signed-off-by Lennart Poettering <[email protected]>Acked-by Martijn Coenen <[email protected]>Thanks, still looks good to me.
Applied.
Signature · 1 line
Jens Axboe