Skip to contentSkip to conversation

Move the definitions for rxe_av.network_type to uAPI

DISCUSSION Bob Pearson 2 participants 2 messages Oct 16, 2020 InfiniBand

lore
Share & tools
lore
#0 lore raw

Jason,

Your recent commit:

	commit e0d696d201dd5d31813787d9b61a42fc459eee89
	Author: Jason Gunthorpe <[email protected]>
	Date:   Thu Oct 15 20:42:18 2020 -0300

	RDMA/rxe: Move the definitions for rxe_av.network_type to uAPI

has some problems and so far I am having trouble making it work sensibly.

What you have done is to make the network_type field in rxe_av be private, (i.e. RXE_NETWORK_TYPE_XXX instead of RDMA_NETWORK_XXX). You then defined these private enums in rdma_uverbs_rxe.h. The problem is that there are more than one source of AVs those:

passed in user space send WQEs for UD traffic passed from kernel ULPs for UD traffic stored in the primary AV in QPs

The AVs created in the kernel get set by calling rdma_gid_attr_network_type() which returns RDMA_NETWORK_XXX not RXE_NETWORK_TYPE_XXX. This can be fixed by again making them the same, which you didn't do, but that means they really aren't private. Or, we can explicitly translate between them in the AV init code.

No rush but I still think the right answer is to let user space only have to deal with AHs and not AVs.

There was also a confusion between V6 and V4. I will submit a small patch that fixes that and makes the enums the same again which is more efficient than transocding them.

Bob

maintainer
#1 lore raw
Quoted 10 lines · Bob Pearson

Jason,

Your recent commit:

	commit e0d696d201dd5d31813787d9b61a42fc459eee89
	Author: Jason Gunthorpe <[email protected]>
	Date:   Thu Oct 15 20:42:18 2020 -0300

	RDMA/rxe: Move the definitions for rxe_av.network_type to uAPI
Quoted 6 lines

has some problems and so far I am having trouble making it work sensibly.

What you have done is to make the network_type field in rxe_av be private, (i.e. RXE_NETWORK_TYPE_XXX instead of RDMA_NETWORK_XXX). You then defined these private enums in rdma_uverbs_rxe.h. The problem is that there are more than one source of AVs those:

Bah, I missed rxe_av_fill_ip_info(), still it should just transcode for now.

Quoted 3 lines

There was also a confusion between V6 and V4. I will submit a small patch that fixes that and makes the enums the same again which is more efficient than transocding them.

Bah again. People need to check the stuff I write at 9pm :P

Jason