libbpf: Initialize *nl_pid so gcc 10 is happy
Subsystems (4)
PATCH 1/1 libbpf: Initialize *nl_pid so gcc 10 is happy
Builds of Fedora's kernel-tools package started to fail with "may be used uninitialized" warnings for nl_pid in bpf_set_link_xdp_fd() and bpf_get_link_xdp_info() on the s390 architecture.
Although libbpf_netlink_open() always returns a negative number when it does not set *nl_pid, the compiler does not determine this and thus believes the variable might be used uninitialized. Assuage gcc's fears by explicitly initializing nl_pid.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1807781
--- tools/lib/bpf/netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/lib/bpf/netlink.c +2 -2
@@ -142,7 +142,7 @@ static int __bpf_set_link_xdp_fd_replace(int ifindex, int fd, int old_fd,struct ifinfomsg ifinfo;char attrbuf[64 ]; } req; -__u32 nl_pid; +__u32 nl_pid =0 ; sock =libbpf_netlink_open (&nl_pid);if (sock <0 )
@@ -288,7 +288,7 @@ int bpf_get_link_xdp_info(int ifindex, struct xdp_link_info *info, {struct xdp_id_md xdp_id = {};int sock, ret; -__u32 nl_pid; +__u32 nl_pid =0 ;__u32 mask;if (flags & ~XDP_FLAGS_MASK || !info_size)
Signature · 1 line
2.26.0
Quoted 5 lines · Jeremy Cline
Builds of Fedora's kernel-tools package started to fail with "may be used uninitialized" warnings for
nl_pidinbpf_set_link_xdp_fd()andbpf_get_link_xdp_info()on the s390 architecture.
Quoted 8 lines
Although
libbpf_netlink_open()always returns a negative number when it does not set*nl_pid, the compiler does not determine this and thus believes the variable might be used uninitialized. Assuage gcc's fears by explicitly initializingnl_pid.Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1807781
Signed-off-by Jeremy Cline <[email protected]>---
Yep, unfortunately compiler is not that smart.
Quoted 28 lines
tools/lib/bpf/netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/lib/bpf/netlink.c +2
-3@@ -142,7 +142,7 @@ static int __bpf_set_link_xdp_fd_replace(int ifindex, int fd, int old_fd,struct ifinfomsg ifinfo;char attrbuf[64 ]; } req; -__u32 nl_pid; +__u32 nl_pid =0 ; sock =libbpf_netlink_open (&nl_pid);if (sock <0 )@@ -288,7 +288,7 @@ int bpf_get_link_xdp_info(int ifindex, struct xdp_link_info *info, {struct xdp_id_md xdp_id = {};int sock, ret; -__u32 nl_pid; +__u32 nl_pid =0 ;__u32 mask;if (flags & ~XDP_FLAGS_MASK || !info_size) --2.26.0
Quoted 11 lines · Jeremy Cline
Builds of Fedora's kernel-tools package started to fail with "may be used uninitialized" warnings for
nl_pidinbpf_set_link_xdp_fd()andbpf_get_link_xdp_info()on the s390 architecture.Although
libbpf_netlink_open()always returns a negative number when it does not set*nl_pid, the compiler does not determine this and thus believes the variable might be used uninitialized. Assuage gcc's fears by explicitly initializingnl_pid.Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1807781
Signed-off-by Jeremy Cline <[email protected]>
Applied, thanks!