Skip to contentSkip to conversation

nvme: add test for creating/deleting file-ns

PATCH Superseded Nilay Shroff 3 participants 4 messages Jun 19, 2024

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 nvme: add test for creating/deleting file-ns

This is regression test for commit be647e2c76b2 (nvme: use srcu for iterating namespace list)[1]. It is fixed in commit ff0ffe5b7c3c(nvme:
fix namespace removal list)[2].

This test uses a regular file backed loop device for creating and then deleting an NVMe namespace in a loop.

[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/

---
Changes from v2:
- Use defaults for creating and connecting to nvme target (Daniel)
Changes from v1:
- Add nvme prefix in the subject line instead of loop (Chaitanya)
- Enrich the commit log with details including link to regression discussion and fix commit (Chaitanya)
- Few other formatting cleanup (Chaitanya)
- Add fix commit information in the test header (Shinichiro)
- Instead of using default 1000 iteration for test,
set the test iteration count to 20 (Shinichiro)
- Update test case no. to nvme/052 (Shinichiro)

---
 tests/nvme/052     | 54 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/nvme/052.out |  2 ++
 2 files changed, 56 insertions(+)
 create mode 100755 tests/nvme/052
 create mode 100644 tests/nvme/052.out
tests/nvme/052 new file +54 -0
new file mode 100755
index 0000000..ec72e1f
@@ -0,0 +1,54 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-3.0+
+# Copyright (C) 2024 Nilay Shroff
+#
+# Regression test for commit be647e2c76b2(nvme: use srcu for iterating
+# namespace list). This regression is resolved with commit ff0ffe5b7c3c
+# (nvme: fix namespace removal list)
+
+. tests/nvme/rc
+
+DESCRIPTION="Test file-ns creation/deletion under one subsystem"
+
+requires() {
+	_nvme_requires
+	_have_loop
+	_require_nvme_trtype_is_loop
+}
+
+set_conditions() {
+	_set_nvme_trtype "$@"
+}
+
+test() {
+	echo "Running ${TEST_NAME}"
+
+	_setup_nvmet
+
+	local iterations=20
+
+	_nvmet_target_setup
+
+	_nvme_connect_subsys
+
+	# start iteration from ns-id 2 because ns-id 1 is created
+	# by default when nvme target is setup. Also ns-id 1 is
+	# deleted when nvme target is cleaned up.
+	for ((i = 2; i <= iterations; i++)); do {
+		truncate -s "${NVME_IMG_SIZE}" "$(_nvme_def_file_path).$i"
+		_create_nvmet_ns "${def_subsysnqn}" "${i}" "$(_nvme_def_file_path).$i"
+
+		# allow async request to be processed
+		sleep 1
+
+		_remove_nvmet_ns "${def_subsysnqn}" "${i}"
+		rm "$(_nvme_def_file_path).$i"
+	}
+	done
+
+	_nvme_disconnect_subsys >> "${FULL}" 2>&1
+
+	_nvmet_target_cleanup
+
+	echo "Test complete"
+}
tests/nvme/052.out new file +2 -0
new file mode 100644
index 0000000..f2d186d
@@ -0,0 +1,2 @@
+Running nvme/052
+Test complete
Signature · 1 line
2.45.1
#2 lore raw
In reply to Nilay Shroff

tests/nvme/052 line 42

Quoted 9 lines · Nilay Shroff
tests/nvme/052 new file +9 -0
+	# start iteration from ns-id 2 because ns-id 1 is created
+	# by default when nvme target is setup. Also ns-id 1 is
+	# deleted when nvme target is cleaned up.
+	for ((i = 2; i <= iterations; i++)); do {
+		truncate -s "${NVME_IMG_SIZE}" "$(_nvme_def_file_path).$i"
+		_create_nvmet_ns "${def_subsysnqn}" "${i}" "$(_nvme_def_file_path).$i"
+
+		# allow async request to be processed
+		sleep 1

This looks a bit fragile to ensure all request have been processed. Would it possible to wait on a state? E.g. something like

nvmf_wait_for_state()

?

Quoted 4 lines
tests/nvme/052 new file +4 -0
+
+		_remove_nvmet_ns "${def_subsysnqn}" "${i}"
+		rm "$(_nvme_def_file_path).$i"
+	}
#3 lore raw
Quoted 14 lines · Daniel Wagner

tests/nvme/052 line 42

Quoted 9 lines · Nilay Shroff
tests/nvme/052 new file +9 -0
+	# start iteration from ns-id 2 because ns-id 1 is created
+	# by default when nvme target is setup. Also ns-id 1 is
+	# deleted when nvme target is cleaned up.
+	for ((i = 2; i <= iterations; i++)); do {
+		truncate -s "${NVME_IMG_SIZE}" "$(_nvme_def_file_path).$i"
+		_create_nvmet_ns "${def_subsysnqn}" "${i}" "$(_nvme_def_file_path).$i"
+
+		# allow async request to be processed
+		sleep 1

This looks a bit fragile to ensure all request have been processed. Would it possible to wait on a state? E.g. something like

Quoted 3 lines

nvmf_wait_for_state()

?

OK that's a good idea! I think it's possible to wait using _find_nvme_ns() instead of using sleep here. We can write a wrapper around _find_nvme_ns() and wait until namespace is ready/created.

I will send next patch with the above change.

Quoted 6 lines

tests/nvme/052 line 46

Quoted 5 lines
tests/nvme/052 new file +4 -0
+
+		_remove_nvmet_ns "${def_subsysnqn}" "${i}"
+		rm "$(_nvme_def_file_path).$i"
+	}

Thanks,
--Nilay