Skip to contentSkip to conversation

release notes in commit messages

DISCUSSION Richard Purdie 2 participants 2 messages Sep 30, 2024 – Oct 1, 2024

lore
Share & tools
lore
#0 lore raw

Hi All,

I wanted to highlight to people that cut and pasting release notes into commit messages is annoying a few people:

https://github.com/openembedded/openembedded-core/commit/51fb98c6da61ad4faf5b00316e7075f3bbee9bc7#commitcomment-147394200

The issue is that usernames get pinged on the references when this gets into github.

There are a number of different perspectives on this but if people could trim the usernames out of such commit messages it would be helpful. It might be something to teach patchtest?

Cheers,

Richard

#1 lore raw
Quoted 13 lines

-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Richard Purdie
Sent: den 30 september 2024 22:34
To: openembedded-core <[email protected]>
Cc: Trevor Gamblin <[email protected]>
Subject: [OE-core] release notes in commit messages

Hi All,

I wanted to highlight to people that cut and pasting release notes into commit messages is annoying a few people:

Quoted 8 lines

https://github.com/openembedded/openembedded-core/commit/51fb98c6da61ad4faf5b00316e7075f3bbee9bc7#commitcomment-147394200

The issue is that usernames get pinged on the references when this gets into github.

There are a number of different perspectives on this but if people could trim the usernames out of such commit messages it would be helpful. It might be something to teach patchtest?

The real problem seems to be that GitHub triggers on "@username". So changing "@username" to "username" should be ok to keep the relevant information without causing annoyance.

However, based on the example above, I wonder how to make Patchtest differentiate between @Property (which should be left as is) and @asottile, @Avasam and @GTowers1 (which should be replaced)...

Quoted 4 lines

Cheers,

Richard

//Peter