Skip to contentSkip to conversation

kunit: use KUnit defconfig by default

PATCH In review Vitor Massaru Iha 3 participants 3 messages Apr 14, 2020 – May 22, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kunit: use KUnit defconfig by default

To improve the usability of KUnit, defconfig is used by default if no kunitconfig is present.

* https://bugzilla.kernel.org/show_bug.cgi?id=205259

---
 tools/testing/kunit/kunit.py | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)
tools/testing/kunit/kunit.py +3 -9
index 7dca74774dd2..4b98f6e75e4c 100755
@@ -23,8 +23,8 @@ import kunit_parser
 KunitResult = namedtuple('KunitResult', ['status','result'])
 
 KunitRequest = namedtuple('KunitRequest', ['raw_output','timeout', 'jobs',
-					   'build_dir', 'defconfig',
-					   'alltests', 'make_options'])
+					   'build_dir', 'alltests',
+					   'make_options'])
 
 KernelDirectoryPath = sys.argv[0].split('tools/testing/kunit/')[0]
 
@@ -118,10 +118,6 @@ def main(argv, linux=None):
 				'directory.',
 				type=str, default='', metavar='build_dir')
 
-	run_parser.add_argument('--defconfig',
-				help='Uses a default .kunitconfig.',
-				action='store_true')
-
 	run_parser.add_argument('--alltests',
 				help='Run all KUnit tests through allyesconfig',
 				action='store_true')
@@ -143,8 +139,7 @@ def main(argv, linux=None):
 				cli_args.build_dir,
 				kunit_kernel.kunitconfig_path)
 
-		if cli_args.defconfig:
-			create_default_kunitconfig()
+		create_default_kunitconfig()
 
 		if not linux:
 			linux = kunit_kernel.LinuxSourceTree()
@@ -153,7 +148,6 @@ def main(argv, linux=None):
 				       cli_args.timeout,
 				       cli_args.jobs,
 				       cli_args.build_dir,
-				       cli_args.defconfig,
 				       cli_args.alltests,
 				       cli_args.make_options)
 		result = run_tests(linux, request)
Signature · 1 line
2.25.1
maintainer
#2 lore raw
Quoted 11 lines · Brendan Higgins
Quoted 7 lines · Vitor Massaru Iha

To improve the usability of KUnit, defconfig is used by default if no kunitconfig is present.

* https://bugzilla.kernel.org/show_bug.cgi?id=205259

Applied the patch to kselftest/kunit on top of

45ba7a893ad89114e773b3dc32f6431354c465d6
kunit: kunit_tool: Separate out config/build/exec/parse

from David's work resolving merge conflicts. Please check if it is sane.

thanks,
-- Shuah