Skip to contentSkip to conversation

spi: bcm2835: no dev_err() on clk_get() -EPROBE_DEFER

PATCH In review Jim Quinlan 4 participants 6 messages Dec 16, 2019 – Dec 17, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover spi: bcm2835: no dev_err() on clk_get() -EPROBE_DEFER

Changes in v2:
- use dev_dbg() for -EPROBE_DEFER, dev_err() for other errors.

Jim Quinlan (1):
spi: bcm2835: no dev_err() on clk_get() -EPROBE_DEFER

 drivers/spi/spi-bcm2835.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 spi: bcm2835: no dev_err() on clk_get() -EPROBE_DEFER

Use dev_dbg() on -EPROBE_DEFER and dev_err() on all other errors.

---
 drivers/spi/spi-bcm2835.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/spi/spi-bcm2835.c +4 -1
index fb61a620effc..e4b57b751ce2 100644
@@ -1305,7 +1305,10 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
 	bs->clk = devm_clk_get(&pdev->dev, NULL);
 	if (IS_ERR(bs->clk)) {
 		err = PTR_ERR(bs->clk);
-		dev_err(&pdev->dev, "could not get clk: %d\n", err);
+		if (err == -EPROBE_DEFER)
+			dev_dbg(&pdev->dev, "could not get clk: %d\n", err);
+		else
+			dev_err(&pdev->dev, "could not get clk: %d\n", err);
 		goto out_controller_put;
 	}
 
Signature · 1 line
2.17.1
Reviewed-by on v2 1/1
#2 lore raw
Quoted 4 lines · Jim Quinlan

Use dev_dbg() on -EPROBE_DEFER and dev_err() on all other errors.

Quoted 21 lines
---
 drivers/spi/spi-bcm2835.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/spi/spi-bcm2835.c +4 -1
index fb61a620effc..e4b57b751ce2 100644
@@ -1305,7 +1305,10 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
 	bs->clk = devm_clk_get(&pdev->dev, NULL);
 	if (IS_ERR(bs->clk)) {
 		err = PTR_ERR(bs->clk);
-		dev_err(&pdev->dev, "could not get clk: %d\n", err);
+		if (err == -EPROBE_DEFER)
+			dev_dbg(&pdev->dev, "could not get clk: %d\n", err);
+		else
+			dev_err(&pdev->dev, "could not get clk: %d\n", err);
 		goto out_controller_put;
 	}
 
Signature · 1 line
Florian
maintainer
#4 lore raw

Applied "spi: bcm2835: no dev_err() on clk_get() -EPROBE_DEFER" to the spi tree

In reply to Jim Quinlan

The patch

spi: bcm2835: no dev_err() on clk_get() -EPROBE_DEFER

has been applied to the spi tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.6

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From f4dc4abdce4cc290555604107c04854a911b9441 Mon Sep 17 00:00:00 2001

From: Jim Quinlan <[email protected]>
Date: Mon, 16 Dec 2019 18:08:02 -0500
Subject: [PATCH] spi: bcm2835: no dev_err() on clk_get() -EPROBE_DEFER

Use dev_dbg() on -EPROBE_DEFER and dev_err() on all other errors.

---
 drivers/spi/spi-bcm2835.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/spi/spi-bcm2835.c +4 -1
index 69df79914504..b784c9fdf9ec 100644
@@ -1317,7 +1317,10 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
 	bs->clk = devm_clk_get(&pdev->dev, NULL);
 	if (IS_ERR(bs->clk)) {
 		err = PTR_ERR(bs->clk);
-		dev_err(&pdev->dev, "could not get clk: %d\n", err);
+		if (err == -EPROBE_DEFER)
+			dev_dbg(&pdev->dev, "could not get clk: %d\n", err);
+		else
+			dev_err(&pdev->dev, "could not get clk: %d\n", err);
 		goto out_controller_put;
 	}
 
Signature · 1 line
2.20.1
maintainer
#5 lore raw
In reply to Jim Quinlan
Quoted 2 lines · Jim Quinlan

Changes in v2:
- use dev_dbg() for -EPROBE_DEFER, dev_err() for other errors.

Please don't send cover letters for single patches, if there is anything that needs saying put it in the changelog of the patch or after the --- if it's administrative stuff. This reduces mail volume and ensures that any important information is recorded in the changelog rather than being lost.