Skip to contentSkip to conversation

drm/xe: Privatize struct xe_ggtt.

PATCH Superseded Maarten Lankhorst 4 participants 17 messages Jan 13 – Jan 14

Subsystems (3)

v4 of 8 Superseded Latest is v8 →

lore
Share & tools
lore
#0 lore raw

v4 cover drm/xe: Privatize struct xe_ggtt.

Clean up SRIOV-VF handling and pop the balloons, move struct xe_ggtt to xe_ggtt.c, and clean up the API's slightly by removing a separate xe_gtt_node_init() step.

This makes the xe_ggtt_node_allocated obsolete, as we only create allocated nodes now.

Changes since previous version:
- Move the changes to fix SRIOV-VF to first commit, otherwise it's broken between first and second commit on bisection.

Maarten Lankhorst (5):
drm/xe: Make xe_ggtt_node offset relative to starting offset drm/xe: Rewrite GGTT VF initialisation
drm/xe: Move struct xe_ggtt to xe_ggtt.c
drm/xe: Make xe_ggtt_node_insert return a node drm/xe: Remove xe_ggtt_node_allocated

 drivers/gpu/drm/xe/display/xe_fb_pin.c      |   3 +-
 drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c |   6 +-
 drivers/gpu/drm/xe/xe_device_types.h        |   2 -
 drivers/gpu/drm/xe/xe_ggtt.c                | 345 ++++++++------------
 drivers/gpu/drm/xe/xe_ggtt.h                |  12 +-
 drivers/gpu/drm/xe/xe_ggtt_types.h          |  60 +---
 drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c  |  36 +-
 drivers/gpu/drm/xe/xe_gt_sriov_vf.c         |   7 +-
 drivers/gpu/drm/xe/xe_tile_sriov_vf.c       | 198 +----------
 drivers/gpu/drm/xe/xe_tile_sriov_vf.h       |   3 -
 10 files changed, 163 insertions(+), 509 deletions(-)
Signature · 1 line
2.51.0
#1 lore raw

PATCH v4 1/5 drm/xe: Make xe_ggtt_node offset relative to starting offset

Fix all functions that use node->start to use xe_ggtt_node_addr, and add ggtt->start to node->start.

This will make node shifting for SRIOV-VF a one-liner, instead of manually changing each GGTT node's base address.

---
 drivers/gpu/drm/xe/xe_ggtt.c | 58 ++++++++++++++++++++++--------------
 1 file changed, 36 insertions(+), 22 deletions(-)
drivers/gpu/drm/xe/xe_ggtt.c +36 -22
index cb23d97845a86..4bdd2c94021cd 100644
@@ -300,7 +300,7 @@ static void __xe_ggtt_init_early(struct xe_ggtt *ggtt, u64 start, u64 size)
 {
 	ggtt->start = start;
 	ggtt->size = size;
-	drm_mm_init(&ggtt->mm, start, size);
+	drm_mm_init(&ggtt->mm, 0, size);
 }
 
 int xe_ggtt_init_kunit(struct xe_ggtt *ggtt, u32 start, u32 size)
@@ -402,7 +402,7 @@ static void xe_ggtt_initial_clear(struct xe_ggtt *ggtt)
 	/* Display may have allocated inside ggtt, so be careful with clearing here */
 	mutex_lock(&ggtt->lock);
 	drm_mm_for_each_hole(hole, &ggtt->mm, start, end)
-		xe_ggtt_clear(ggtt, start, end - start);
+		xe_ggtt_clear(ggtt, ggtt->start + start, end - start);
 
 	xe_ggtt_invalidate(ggtt);
 	mutex_unlock(&ggtt->lock);
@@ -419,7 +419,7 @@ static void ggtt_node_remove(struct xe_ggtt_node *node)
 
 	mutex_lock(&ggtt->lock);
 	if (bound)
-		xe_ggtt_clear(ggtt, node->base.start, node->base.size);
+		xe_ggtt_clear(ggtt, xe_ggtt_node_addr(node), node->base.size);
 	drm_mm_remove_node(&node->base);
 	node->base.size = 0;
 	mutex_unlock(&ggtt->lock);
@@ -574,13 +574,13 @@ int xe_ggtt_node_insert_balloon_locked(struct xe_ggtt_node *node, u64 start, u64
 	lockdep_assert_held(&ggtt->lock);
 
 	node->base.color = 0;
-	node->base.start = start;
+	node->base.start = start - ggtt->start;
 	node->base.size = end - start;
 
 	err = drm_mm_reserve_node(&ggtt->mm, &node->base);
 
 	if (xe_tile_WARN(ggtt->tile, err, "Failed to balloon GGTT %#llx-%#llx (%pe)\n",
-			 node->base.start, node->base.start + node->base.size, ERR_PTR(err)))
+			 xe_ggtt_node_addr(node), xe_ggtt_node_addr(node) + node->base.size, ERR_PTR(err)))
 		return err;
 
 	xe_ggtt_dump_node(ggtt, &node->base, "balloon");
@@ -771,7 +771,7 @@ static void xe_ggtt_map_bo(struct xe_ggtt *ggtt, struct xe_ggtt_node *node,
 	if (XE_WARN_ON(!node))
 		return;
 
-	start = node->base.start;
+	start = xe_ggtt_node_addr(node);
 	end = start + xe_bo_size(bo);
 
 	if (!xe_bo_is_vram(bo) && !xe_bo_is_stolen(bo)) {
@@ -892,6 +892,17 @@ static int __xe_ggtt_insert_bo_at(struct xe_ggtt *ggtt, struct xe_bo *bo,
 	}
 
 	mutex_lock(&ggtt->lock);
+	/*
+	 * all cases where start < ggtt_start when 0 is passed as argument are
+	 * set to 0, as negative offsets are invalid.
+	 */
+	if (start < ggtt->start)
+		start = 0;
+	else
+		start -= ggtt->start;
+
+	end -= ggtt->start;
+
 	err = drm_mm_insert_node_in_range(&ggtt->mm, &bo->ggtt_node[tile_id]->base,
 					  xe_bo_size(bo), alignment, 0, start, end, 0);
 	if (err) {
@@ -1003,16 +1014,17 @@ static u64 xe_encode_vfid_pte(u16 vfid)
 	return FIELD_PREP(GGTT_PTE_VFID, vfid) | XE_PAGE_PRESENT;
 }
 
-static void xe_ggtt_assign_locked(struct xe_ggtt *ggtt, const struct drm_mm_node *node, u16 vfid)
+static void xe_ggtt_assign_locked(const struct xe_ggtt_node *node, u16 vfid)
 {
-	u64 start = node->start;
-	u64 size = node->size;
+	struct xe_ggtt *ggtt = node->ggtt;
+	u64 start = xe_ggtt_node_addr(node);
+	u64 size = xe_ggtt_node_size(node);
 	u64 end = start + size - 1;
 	u64 pte = xe_encode_vfid_pte(vfid);
 
 	lockdep_assert_held(&ggtt->lock);
 
-	if (!drm_mm_node_allocated(node))
+	if (!xe_ggtt_node_allocated(node))
 		return;
 
 	while (start < end) {
@@ -1034,9 +1046,11 @@ static void xe_ggtt_assign_locked(struct xe_ggtt *ggtt, const struct drm_mm_node
  */
 void xe_ggtt_assign(const struct xe_ggtt_node *node, u16 vfid)
 {
-	mutex_lock(&node->ggtt->lock);
-	xe_ggtt_assign_locked(node->ggtt, &node->base, vfid);
-	mutex_unlock(&node->ggtt->lock);
+	if (!node)
+		return;
+
+	guard(mutex)(&node->ggtt->lock);
+	xe_ggtt_assign_locked(node, vfid);
 }
 
 /**
@@ -1058,14 +1072,14 @@ int xe_ggtt_node_save(struct xe_ggtt_node *node, void *dst, size_t size, u16 vfi
 	if (!node)
 		return -ENOENT;
 
-	guard(mutex)(&node->ggtt->lock);
+	ggtt = node->ggtt;
+	guard(mutex)(&ggtt->lock);
 
 	if (xe_ggtt_node_pt_size(node) != size)
 		return -EINVAL;
 
-	ggtt = node->ggtt;
-	start = node->base.start;
-	end = start + node->base.size - 1;
+	start = xe_ggtt_node_addr(node);
+	end = start + xe_ggtt_node_size(node) - 1;
 
 	while (start < end) {
 		pte = ggtt->pt_ops->ggtt_get_pte(ggtt, start);
@@ -1098,14 +1112,14 @@ int xe_ggtt_node_load(struct xe_ggtt_node *node, const void *src, size_t size, u
 	if (!node)
 		return -ENOENT;
 
-	guard(mutex)(&node->ggtt->lock);
+	ggtt = node->ggtt;
+	guard(mutex)(&ggtt->lock);
 
 	if (xe_ggtt_node_pt_size(node) != size)
 		return -EINVAL;
 
-	ggtt = node->ggtt;
-	start = node->base.start;
-	end = start + node->base.size - 1;
+	start = xe_ggtt_node_addr(node);
+	end = start + xe_ggtt_node_size(node) - 1;
 
 	while (start < end) {
 		vfid_pte = u64_replace_bits(*buf++, vfid, GGTT_PTE_VFID);
@@ -1212,7 +1226,7 @@ u64 xe_ggtt_read_pte(struct xe_ggtt *ggtt, u64 offset)
  */
 u64 xe_ggtt_node_addr(const struct xe_ggtt_node *node)
 {
-	return node->base.start;
+	return node->base.start + node->ggtt->start;
 }
 
 /**
Signature · 1 line
2.51.0
#2 lore raw

Re: [PATCH v4 1/5] drm/xe: Make xe_ggtt_node offset relative to starting offset

Quoted 4 lines · Maarten Lankhorst

Fix all functions that use node->start to use xe_ggtt_node_addr, and add ggtt->start to node->start.

This will make node shifting for SRIOV-VF a one-liner, instead of

SR-IOV VF

Quoted 30 lines

manually changing each GGTT node's base address.

---
 drivers/gpu/drm/xe/xe_ggtt.c | 58 ++++++++++++++++++++++--------------
 1 file changed, 36 insertions(+), 22 deletions(-)
drivers/gpu/drm/xe/xe_ggtt.c +2 -2
index cb23d97845a86..4bdd2c94021cd 100644
@@ -300,7 +300,7 @@ static void __xe_ggtt_init_early(struct xe_ggtt *ggtt, u64 start, u64 size)
 {
 	ggtt->start = start;
 	ggtt->size = size;
-	drm_mm_init(&ggtt->mm, start, size);
+	drm_mm_init(&ggtt->mm, 0, size);
 }
 
 int xe_ggtt_init_kunit(struct xe_ggtt *ggtt, u32 start, u32 size)
@@ -402,7 +402,7 @@ static void xe_ggtt_initial_clear(struct xe_ggtt *ggtt)
 	/* Display may have allocated inside ggtt, so be careful with clearing here */
 	mutex_lock(&ggtt->lock);
 	drm_mm_for_each_hole(hole, &ggtt->mm, start, end)
-		xe_ggtt_clear(ggtt, start, end - start);
+		xe_ggtt_clear(ggtt, ggtt->start + start, end - start);
 
 	xe_ggtt_invalidate(ggtt);
 	mutex_unlock(&ggtt->lock);

drivers/gpu/drm/xe/xe_ggtt.c static void ggtt_node_remove(struct xe_ggtt_node *node) · line 422

Quoted 5 lines
drivers/gpu/drm/xe/xe_ggtt.c +1 -1
@@ -419,7 +419,7 @@ static void ggtt_node_remove(struct xe_ggtt_node *node)
 
 	mutex_lock(&ggtt->lock);
 	if (bound)
-		xe_ggtt_clear(ggtt, node->base.start, node->base.size);
+		xe_ggtt_clear(ggtt, xe_ggtt_node_addr(node), node->base.size);

nit: maybe

		xe_ggtt_clear(ggtt, xe_ggtt_node_addr(node), xe_ggtt_node_size(node));

drivers/gpu/drm/xe/xe_ggtt.c int xe_ggtt_node_insert_balloon_locked(struct xe_ggtt_node *node, u64 start, u64 · line 577

Quoted 9 lines
drivers/gpu/drm/xe/xe_ggtt.c +1 -1
 	drm_mm_remove_node(&node->base);
 	node->base.size = 0;
 	mutex_unlock(&ggtt->lock);
@@ -574,13 +574,13 @@ int xe_ggtt_node_insert_balloon_locked(struct xe_ggtt_node *node, u64 start, u64
 	lockdep_assert_held(&ggtt->lock);
 
 	node->base.color = 0;
-	node->base.start = start;
+	node->base.start = start - ggtt->start;

nit: maybe we should add:

	xe_assert(xe, start >= ggtt->start);
Quoted 20 lines
drivers/gpu/drm/xe/xe_ggtt.c +2 -2
 	node->base.size = end - start;
 
 	err = drm_mm_reserve_node(&ggtt->mm, &node->base);
 
 	if (xe_tile_WARN(ggtt->tile, err, "Failed to balloon GGTT %#llx-%#llx (%pe)\n",
-			 node->base.start, node->base.start + node->base.size, ERR_PTR(err)))
+			 xe_ggtt_node_addr(node), xe_ggtt_node_addr(node) + node->base.size, ERR_PTR(err)))
 		return err;
 
 	xe_ggtt_dump_node(ggtt, &node->base, "balloon");
@@ -771,7 +771,7 @@ static void xe_ggtt_map_bo(struct xe_ggtt *ggtt, struct xe_ggtt_node *node,
 	if (XE_WARN_ON(!node))
 		return;
 
-	start = node->base.start;
+	start = xe_ggtt_node_addr(node);
 	end = start + xe_bo_size(bo);
 
 	if (!xe_bo_is_vram(bo) && !xe_bo_is_stolen(bo)) {

drivers/gpu/drm/xe/xe_ggtt.c static int __xe_ggtt_insert_bo_at(struct xe_ggtt *ggtt, struct xe_bo *bo, · line 897

Quoted 6 lines
drivers/gpu/drm/xe/xe_ggtt.c +3 -0
@@ -892,6 +892,17 @@ static int __xe_ggtt_insert_bo_at(struct xe_ggtt *ggtt, struct xe_bo *bo,
 	}
 
 	mutex_lock(&ggtt->lock);
+	/*
+	 * all cases where start < ggtt_start when 0 is passed as argument are
+	 * set to 0, as negative offsets are invalid.

but all start values < ggtt->start seems to be programming errors (except start == 0 which is like a "don't care" flag)

so maybe this should be just:

	xe_assert(xe, start >= ggtt->start || !start);
	xe_assert(xe, end >= ggtt->start);

	if (start) {
		start -= ggtt->start;
		end -= ggtt->start;
	}
Quoted 20 lines
drivers/gpu/drm/xe/xe_ggtt.c +9 -3
+	 */
+	if (start < ggtt->start)
+		start = 0;
+	else
+		start -= ggtt->start;
+
+	end -= ggtt->start;
+
 	err = drm_mm_insert_node_in_range(&ggtt->mm, &bo->ggtt_node[tile_id]->base,
 					  xe_bo_size(bo), alignment, 0, start, end, 0);
 	if (err) {
@@ -1003,16 +1014,17 @@ static u64 xe_encode_vfid_pte(u16 vfid)
 	return FIELD_PREP(GGTT_PTE_VFID, vfid) | XE_PAGE_PRESENT;
 }
 
-static void xe_ggtt_assign_locked(struct xe_ggtt *ggtt, const struct drm_mm_node *node, u16 vfid)
+static void xe_ggtt_assign_locked(const struct xe_ggtt_node *node, u16 vfid)
 {
-	u64 start = node->start;
-	u64 size = node->size;

drivers/gpu/drm/xe/xe_ggtt.c static u64 xe_encode_vfid_pte(u16 vfid) · line 1027

Quoted 10 lines
drivers/gpu/drm/xe/xe_ggtt.c +4 -1
+	struct xe_ggtt *ggtt = node->ggtt;
+	u64 start = xe_ggtt_node_addr(node);
+	u64 size = xe_ggtt_node_size(node);
 	u64 end = start + size - 1;
 	u64 pte = xe_encode_vfid_pte(vfid);
 
 	lockdep_assert_held(&ggtt->lock);
 
-	if (!drm_mm_node_allocated(node))
+	if (!xe_ggtt_node_allocated(node))

nit: this could be:

	if (!drm_mm_node_allocated(&node->base))

drivers/gpu/drm/xe/xe_ggtt.c static void xe_ggtt_assign_locked(struct xe_ggtt *ggtt, const struct drm_mm_node · line 1050

Quoted 12 lines
drivers/gpu/drm/xe/xe_ggtt.c +2 -3
 		return;
 
 	while (start < end) {
@@ -1034,9 +1046,11 @@ static void xe_ggtt_assign_locked(struct xe_ggtt *ggtt, const struct drm_mm_node
  */
 void xe_ggtt_assign(const struct xe_ggtt_node *node, u16 vfid)
 {
-	mutex_lock(&node->ggtt->lock);
-	xe_ggtt_assign_locked(node->ggtt, &node->base, vfid);
-	mutex_unlock(&node->ggtt->lock);
+	if (!node)
+		return;

calling xe_ggtt_assign(NULL) is a clear programming error, why do we want to hide it now?

drivers/gpu/drm/xe/xe_ggtt.c int xe_ggtt_node_save(struct xe_ggtt_node *node, void *dst, size_t size, u16 vfi · line 1076

Quoted 13 lines
drivers/gpu/drm/xe/xe_ggtt.c +5 -1
+
+	guard(mutex)(&node->ggtt->lock);
+	xe_ggtt_assign_locked(node, vfid);
 }
 
 /**
@@ -1058,14 +1072,14 @@ int xe_ggtt_node_save(struct xe_ggtt_node *node, void *dst, size_t size, u16 vfi
 	if (!node)
 		return -ENOENT;
 
-	guard(mutex)(&node->ggtt->lock);
+	ggtt = node->ggtt;
+	guard(mutex)(&ggtt->lock);

nit: nice but unrelated change

Quoted 13 lines
drivers/gpu/drm/xe/xe_ggtt.c +2 -3
 	if (xe_ggtt_node_pt_size(node) != size)
 		return -EINVAL;
 
-	ggtt = node->ggtt;
-	start = node->base.start;
-	end = start + node->base.size - 1;
+	start = xe_ggtt_node_addr(node);
+	end = start + xe_ggtt_node_size(node) - 1;
 
 	while (start < end) {
 		pte = ggtt->pt_ops->ggtt_get_pte(ggtt, start);

drivers/gpu/drm/xe/xe_ggtt.c int xe_ggtt_node_load(struct xe_ggtt_node *node, const void *src, size_t size, u · line 1116

Quoted 6 lines
drivers/gpu/drm/xe/xe_ggtt.c +2 -1
@@ -1098,14 +1112,14 @@ int xe_ggtt_node_load(struct xe_ggtt_node *node, const void *src, size_t size, u
 	if (!node)
 		return -ENOENT;
 
-	guard(mutex)(&node->ggtt->lock);
+	ggtt = node->ggtt;
+	guard(mutex)(&ggtt->lock);

ditto

Quoted 21 lines
drivers/gpu/drm/xe/xe_ggtt.c +3 -4
 	if (xe_ggtt_node_pt_size(node) != size)
 		return -EINVAL;
 
-	ggtt = node->ggtt;
-	start = node->base.start;
-	end = start + node->base.size - 1;
+	start = xe_ggtt_node_addr(node);
+	end = start + xe_ggtt_node_size(node) - 1;
 
 	while (start < end) {
 		vfid_pte = u64_replace_bits(*buf++, vfid, GGTT_PTE_VFID);
@@ -1212,7 +1226,7 @@ u64 xe_ggtt_read_pte(struct xe_ggtt *ggtt, u64 offset)
  */
 u64 xe_ggtt_node_addr(const struct xe_ggtt_node *node)
 {
-	return node->base.start;
+	return node->base.start + node->ggtt->start;
 }
 
 /**
#3 lore raw

Re: [PATCH v4 1/5] drm/xe: Make xe_ggtt_node offset relative to starting offset

Hey,

Den 2026-01-13 kl. 23:07, skrev Michal Wajdeczko:

Quoted 94 lines · Maarten Lankhorst
Quoted 4 lines

Fix all functions that use node->start to use xe_ggtt_node_addr, and add ggtt->start to node->start.

This will make node shifting for SRIOV-VF a one-liner, instead of

SR-IOV VF

Quoted 30 lines

manually changing each GGTT node's base address.

---
 drivers/gpu/drm/xe/xe_ggtt.c | 58 ++++++++++++++++++++++--------------
 1 file changed, 36 insertions(+), 22 deletions(-)
drivers/gpu/drm/xe/xe_ggtt.c +2 -2
index cb23d97845a86..4bdd2c94021cd 100644
@@ -300,7 +300,7 @@ static void __xe_ggtt_init_early(struct xe_ggtt *ggtt, u64 start, u64 size)
 {
 	ggtt->start = start;
 	ggtt->size = size;
-	drm_mm_init(&ggtt->mm, start, size);
+	drm_mm_init(&ggtt->mm, 0, size);
 }
 
 int xe_ggtt_init_kunit(struct xe_ggtt *ggtt, u32 start, u32 size)
@@ -402,7 +402,7 @@ static void xe_ggtt_initial_clear(struct xe_ggtt *ggtt)
 	/* Display may have allocated inside ggtt, so be careful with clearing here */
 	mutex_lock(&ggtt->lock);
 	drm_mm_for_each_hole(hole, &ggtt->mm, start, end)
-		xe_ggtt_clear(ggtt, start, end - start);
+		xe_ggtt_clear(ggtt, ggtt->start + start, end - start);
 
 	xe_ggtt_invalidate(ggtt);
 	mutex_unlock(&ggtt->lock);

drivers/gpu/drm/xe/xe_ggtt.c static void ggtt_node_remove(struct xe_ggtt_node *node) · line 422

Quoted 5 lines
drivers/gpu/drm/xe/xe_ggtt.c +1 -1
@@ -419,7 +419,7 @@ static void ggtt_node_remove(struct xe_ggtt_node *node)
 
 	mutex_lock(&ggtt->lock);
 	if (bound)
-		xe_ggtt_clear(ggtt, node->base.start, node->base.size);
+		xe_ggtt_clear(ggtt, xe_ggtt_node_addr(node), node->base.size);

nit: maybe

		xe_ggtt_clear(ggtt, xe_ggtt_node_addr(node), xe_ggtt_node_size(node));

drivers/gpu/drm/xe/xe_ggtt.c int xe_ggtt_node_insert_balloon_locked(struct xe_ggtt_node *node, u64 start, u64 · line 577

Quoted 9 lines
drivers/gpu/drm/xe/xe_ggtt.c +1 -1
 	drm_mm_remove_node(&node->base);
 	node->base.size = 0;
 	mutex_unlock(&ggtt->lock);
@@ -574,13 +574,13 @@ int xe_ggtt_node_insert_balloon_locked(struct xe_ggtt_node *node, u64 start, u64
 	lockdep_assert_held(&ggtt->lock);
 
 	node->base.color = 0;
-	node->base.start = start;
+	node->base.start = start - ggtt->start;

nit: maybe we should add:

	xe_assert(xe, start >= ggtt->start);
Quoted 20 lines
drivers/gpu/drm/xe/xe_ggtt.c +2 -2
 	node->base.size = end - start;
 
 	err = drm_mm_reserve_node(&ggtt->mm, &node->base);
 
 	if (xe_tile_WARN(ggtt->tile, err, "Failed to balloon GGTT %#llx-%#llx (%pe)\n",
-			 node->base.start, node->base.start + node->base.size, ERR_PTR(err)))
+			 xe_ggtt_node_addr(node), xe_ggtt_node_addr(node) + node->base.size, ERR_PTR(err)))
 		return err;
 
 	xe_ggtt_dump_node(ggtt, &node->base, "balloon");
@@ -771,7 +771,7 @@ static void xe_ggtt_map_bo(struct xe_ggtt *ggtt, struct xe_ggtt_node *node,
 	if (XE_WARN_ON(!node))
 		return;
 
-	start = node->base.start;
+	start = xe_ggtt_node_addr(node);
 	end = start + xe_bo_size(bo);
 
 	if (!xe_bo_is_vram(bo) && !xe_bo_is_stolen(bo)) {

drivers/gpu/drm/xe/xe_ggtt.c static int __xe_ggtt_insert_bo_at(struct xe_ggtt *ggtt, struct xe_bo *bo, · line 897

Quoted 6 lines
drivers/gpu/drm/xe/xe_ggtt.c +3 -0
@@ -892,6 +892,17 @@ static int __xe_ggtt_insert_bo_at(struct xe_ggtt *ggtt, struct xe_bo *bo,
 	}
 
 	mutex_lock(&ggtt->lock);
+	/*
+	 * all cases where start < ggtt_start when 0 is passed as argument are
+	 * set to 0, as negative offsets are invalid.

but all start values < ggtt->start seems to be programming errors (except start == 0 which is like a "don't care" flag)

Quoted 1 line

so maybe this should be just:

I think the asserts are ok to add, but why not handle it anyway instead of failing in a hard to debug way?

Quoted 35 lines
	xe_assert(xe, start >= ggtt->start || !start);
	xe_assert(xe, end >= ggtt->start);

	if (start) {
		start -= ggtt->start;
		end -= ggtt->start;
	}
Quoted 26 lines
drivers/gpu/drm/xe/xe_ggtt.c +12 -3
+	 */
+	if (start < ggtt->start)
+		start = 0;
+	else
+		start -= ggtt->start;
+
+	end -= ggtt->start;
+
 	err = drm_mm_insert_node_in_range(&ggtt->mm, &bo->ggtt_node[tile_id]->base,
 					  xe_bo_size(bo), alignment, 0, start, end, 0);
 	if (err) {
@@ -1003,16 +1014,17 @@ static u64 xe_encode_vfid_pte(u16 vfid)
 	return FIELD_PREP(GGTT_PTE_VFID, vfid) | XE_PAGE_PRESENT;
 }
 
-static void xe_ggtt_assign_locked(struct xe_ggtt *ggtt, const struct drm_mm_node *node, u16 vfid)
+static void xe_ggtt_assign_locked(const struct xe_ggtt_node *node, u16 vfid)
 {
-	u64 start = node->start;
-	u64 size = node->size;
+	struct xe_ggtt *ggtt = node->ggtt;
+	u64 start = xe_ggtt_node_addr(node);
+	u64 size = xe_ggtt_node_size(node);
 	u64 end = start + size - 1;
 	u64 pte = xe_encode_vfid_pte(vfid);
 
Quoted 8 lines

drivers/gpu/drm/xe/xe_ggtt.c static u64 xe_encode_vfid_pte(u16 vfid) · line 1027

Quoted 4 lines
drivers/gpu/drm/xe/xe_ggtt.c +1 -1
 	lockdep_assert_held(&ggtt->lock);
 
-	if (!drm_mm_node_allocated(node))
+	if (!xe_ggtt_node_allocated(node))

nit: this could be:

	if (!drm_mm_node_allocated(&node->base))

Perhaps, but I'm deleting it anyway in the last patch.

Quoted 14 lines

drivers/gpu/drm/xe/xe_ggtt.c static void xe_ggtt_assign_locked(struct xe_ggtt *ggtt, const struct drm_mm_node · line 1050

Quoted 12 lines
drivers/gpu/drm/xe/xe_ggtt.c +2 -3
 		return;
 
 	while (start < end) {
@@ -1034,9 +1046,11 @@ static void xe_ggtt_assign_locked(struct xe_ggtt *ggtt, const struct drm_mm_node
  */
 void xe_ggtt_assign(const struct xe_ggtt_node *node, u16 vfid)
 {
-	mutex_lock(&node->ggtt->lock);
-	xe_ggtt_assign_locked(node->ggtt, &node->base, vfid);
-	mutex_unlock(&node->ggtt->lock);
+	if (!node)
+		return;

calling xe_ggtt_assign(NULL) is a clear programming error, why do we want to hide it now?

There was already error handling in checking drm_mm_allocated(). That one will be removed soon, so this is the replacement.

Quoted 32 lines

drivers/gpu/drm/xe/xe_ggtt.c int xe_ggtt_node_save(struct xe_ggtt_node *node, void *dst, size_t size, u16 vfi · line 1076

Quoted 13 lines
drivers/gpu/drm/xe/xe_ggtt.c +5 -1
+
+	guard(mutex)(&node->ggtt->lock);
+	xe_ggtt_assign_locked(node, vfid);
 }
 
 /**
@@ -1058,14 +1072,14 @@ int xe_ggtt_node_save(struct xe_ggtt_node *node, void *dst, size_t size, u16 vfi
 	if (!node)
 		return -ENOENT;
 
-	guard(mutex)(&node->ggtt->lock);
+	ggtt = node->ggtt;
+	guard(mutex)(&ggtt->lock);

nit: nice but unrelated change

Quoted 16 lines
drivers/gpu/drm/xe/xe_ggtt.c +2 -3
 	if (xe_ggtt_node_pt_size(node) != size)
 		return -EINVAL;
 
-	ggtt = node->ggtt;
-	start = node->base.start;
-	end = start + node->base.size - 1;
+	start = xe_ggtt_node_addr(node);
+	end = start + xe_ggtt_node_size(node) - 1;
 
 	while (start < end) {
 		pte = ggtt->pt_ops->ggtt_get_pte(ggtt, start);
@@ -1098,14 +1112,14 @@ int xe_ggtt_node_load(struct xe_ggtt_node *node, const void *src, size_t size, u
 	if (!node)
 		return -ENOENT;
 
Quoted 5 lines

drivers/gpu/drm/xe/xe_ggtt.c int xe_ggtt_node_save(struct xe_ggtt_node *node, void *dst, size_t size, u16 vfi · line 1076

Quoted 3 lines
drivers/gpu/drm/xe/xe_ggtt.c +2 -1
-	guard(mutex)(&node->ggtt->lock);
+	ggtt = node->ggtt;
+	guard(mutex)(&ggtt->lock);

ditto

Yeah, but too small for a separate commit, which is why I added it to this one. :-)

Quoted 23 lines
Quoted 22 lines
drivers/gpu/drm/xe/xe_ggtt.c +3 -4
 	if (xe_ggtt_node_pt_size(node) != size)
 		return -EINVAL;
 
-	ggtt = node->ggtt;
-	start = node->base.start;
-	end = start + node->base.size - 1;
+	start = xe_ggtt_node_addr(node);
+	end = start + xe_ggtt_node_size(node) - 1;
 
 	while (start < end) {
 		vfid_pte = u64_replace_bits(*buf++, vfid, GGTT_PTE_VFID);
@@ -1212,7 +1226,7 @@ u64 xe_ggtt_read_pte(struct xe_ggtt *ggtt, u64 offset)
  */
 u64 xe_ggtt_node_addr(const struct xe_ggtt_node *node)
 {
-	return node->base.start;
+	return node->base.start + node->ggtt->start;
 }
 
 /**
#4 lore raw

PATCH v4 2/5 drm/xe: Rewrite GGTT VF initialisation

In reply to Maarten Lankhorst

The previous code was using a complicated system with 2 balloons to set GGTT size and adjust GGTT offset. While it works, it's overly complicated.

A better approach is to set the offset and size when initialising GGTT, this removes the need for adding balloons. The resize function only needs readjust ggtt->start to have GGTT at the new offset.

This removes the need to manipulate the internals of xe_ggtt outside of xe_ggtt, and cleans up a lot of now unneeded code.

---
 drivers/gpu/drm/xe/xe_device_types.h  |   2 -
 drivers/gpu/drm/xe/xe_ggtt.c          | 159 ++++-----------------
 drivers/gpu/drm/xe/xe_ggtt.h          |   5 +-
 drivers/gpu/drm/xe/xe_gt_sriov_vf.c   |   7 +-
 drivers/gpu/drm/xe/xe_tile_sriov_vf.c | 198 +-------------------------
 drivers/gpu/drm/xe/xe_tile_sriov_vf.h |   3 -
 6 files changed, 34 insertions(+), 340 deletions(-)
drivers/gpu/drm/xe/xe_device_types.h +0 -2
index 4dab3057f58d2..fa28477fe6fae 100644
@@ -221,8 +221,6 @@ struct xe_tile {
 			struct xe_lmtt lmtt;
 		} pf;
 		struct {
-			/** @sriov.vf.ggtt_balloon: GGTT regions excluded from use. */
-			struct xe_ggtt_node *ggtt_balloon[2];
 			/** @sriov.vf.self_config: VF configuration data */
 			struct xe_tile_sriov_vf_selfconfig self_config;
 		} vf;
drivers/gpu/drm/xe/xe_ggtt.c +27 -132

208 lines not on this page · raw message

drivers/gpu/drm/xe/xe_ggtt.h +1 -4
index 70d5e07ac4b66..49ea8e7ecc105 100644
@@ -19,10 +19,7 @@ int xe_ggtt_init(struct xe_ggtt *ggtt);
 
 struct xe_ggtt_node *xe_ggtt_node_init(struct xe_ggtt *ggtt);
 void xe_ggtt_node_fini(struct xe_ggtt_node *node);
-int xe_ggtt_node_insert_balloon_locked(struct xe_ggtt_node *node,
-				       u64 start, u64 size);
-void xe_ggtt_node_remove_balloon_locked(struct xe_ggtt_node *node);
-void xe_ggtt_shift_nodes_locked(struct xe_ggtt *ggtt, s64 shift);
+void xe_ggtt_shift_nodes(struct xe_ggtt *ggtt, u64 new_base);
 u64 xe_ggtt_start(struct xe_ggtt *ggtt);
 u64 xe_ggtt_size(struct xe_ggtt *ggtt);
 
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +2 -5
index d91c65dc34960..ea180a3ea7cb0 100644
@@ -489,7 +489,6 @@ u32 xe_gt_sriov_vf_gmdid(struct xe_gt *gt)
 static int vf_get_ggtt_info(struct xe_gt *gt)
 {
 	struct xe_tile *tile = gt_to_tile(gt);
-	struct xe_ggtt *ggtt = tile->mem.ggtt;
 	struct xe_guc *guc = &gt->uc.guc;
 	u64 start, size, ggtt_size;
 	s64 shift;
@@ -497,8 +496,6 @@ static int vf_get_ggtt_info(struct xe_gt *gt)
 
 	xe_gt_assert(gt, IS_SRIOV_VF(gt_to_xe(gt)));
 
-	guard(mutex)(&ggtt->lock);
-
 	err = guc_action_query_single_klv64(guc, GUC_KLV_VF_CFG_GGTT_START_KEY, &start);
 	if (unlikely(err))
 		return err;
@@ -524,10 +521,10 @@ static int vf_get_ggtt_info(struct xe_gt *gt)
 	xe_tile_sriov_vf_ggtt_base_store(tile, start);
 	xe_tile_sriov_vf_ggtt_store(tile, size);
 
-	if (shift && shift != start) {
+	if (ggtt_size) {
 		xe_gt_sriov_info(gt, "Shifting GGTT base by %lld to 0x%016llx\n",
 				 shift, start);
-		xe_tile_sriov_vf_fixup_ggtt_nodes_locked(gt_to_tile(gt), shift);
+		xe_ggtt_shift_nodes(tile->mem.ggtt, start);
 	}
 
 	if (xe_sriov_vf_migration_supported(gt_to_xe(gt))) {
drivers/gpu/drm/xe/xe_tile_sriov_vf.c +4 -194

236 lines not on this page · raw message

drivers/gpu/drm/xe/xe_tile_sriov_vf.h +0 -3
index 749f41504883c..f2bbc4fc57347 100644
@@ -10,9 +10,6 @@
 
 struct xe_tile;
 
-int xe_tile_sriov_vf_prepare_ggtt(struct xe_tile *tile);
-void xe_tile_sriov_vf_deballoon_ggtt_locked(struct xe_tile *tile);
-void xe_tile_sriov_vf_fixup_ggtt_nodes_locked(struct xe_tile *tile, s64 shift);
 u64 xe_tile_sriov_vf_ggtt(struct xe_tile *tile);
 void xe_tile_sriov_vf_ggtt_store(struct xe_tile *tile, u64 ggtt_size);
 u64 xe_tile_sriov_vf_ggtt_base(struct xe_tile *tile);
Signature · 1 line
2.51.0
#5 lore raw

Re: [PATCH v4 2/5] drm/xe: Rewrite GGTT VF initialisation

Quoted 5 lines · Maarten Lankhorst

The previous code was using a complicated system with 2 balloons to set GGTT size and adjust GGTT offset. While it works, it's overly complicated.

A better approach is to set the offset and size when initialising GGTT,

initializing (and in subject: initialization) ?

Quoted 49 lines

this removes the need for adding balloons. The resize function only needs readjust ggtt->start to have GGTT at the new offset.

This removes the need to manipulate the internals of xe_ggtt outside of xe_ggtt, and cleans up a lot of now unneeded code.

---
 drivers/gpu/drm/xe/xe_device_types.h  |   2 -
 drivers/gpu/drm/xe/xe_ggtt.c          | 159 ++++-----------------
 drivers/gpu/drm/xe/xe_ggtt.h          |   5 +-
 drivers/gpu/drm/xe/xe_gt_sriov_vf.c   |   7 +-
 drivers/gpu/drm/xe/xe_tile_sriov_vf.c | 198 +-------------------------
 drivers/gpu/drm/xe/xe_tile_sriov_vf.h |   3 -
 6 files changed, 34 insertions(+), 340 deletions(-)
drivers/gpu/drm/xe/xe_device_types.h +0 -2
index 4dab3057f58d2..fa28477fe6fae 100644
@@ -221,8 +221,6 @@ struct xe_tile {
 			struct xe_lmtt lmtt;
 		} pf;
 		struct {
-			/** @sriov.vf.ggtt_balloon: GGTT regions excluded from use. */
-			struct xe_ggtt_node *ggtt_balloon[2];
 			/** @sriov.vf.self_config: VF configuration data */
 			struct xe_tile_sriov_vf_selfconfig self_config;
 		} vf;
drivers/gpu/drm/xe/xe_ggtt.c +2 -2
index 4bdd2c94021cd..1c5397e3ed724 100644
@@ -71,8 +71,8 @@
  * struct xe_ggtt_node - A node in GGTT.
  *
  * This struct needs to be initialized (only-once) with xe_ggtt_node_init() before any node
- * insertion, reservation, or 'ballooning'.
- * It will, then, be finalized by either xe_ggtt_node_remove() or xe_ggtt_node_deballoon().
+ * insertion or reservation.
+ * It will, then, be finalized by xe_ggtt_node_remove().
  */
 struct xe_ggtt_node {
 	/** @ggtt: Back pointer to xe_ggtt where this region will be inserted at */
@@ -348,9 +348,15 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt)
 		ggtt_start = wopcm;
 		ggtt_size = (gsm_size / 8) * (u64)XE_PAGE_SIZE - ggtt_start;
 	} else {

drivers/gpu/drm/xe/xe_ggtt.c int xe_ggtt_init_early(struct xe_ggtt *ggtt) · line 357

Quoted 10 lines
drivers/gpu/drm/xe/xe_ggtt.c +7 -3
-		/* GGTT is expected to be 4GiB */
-		ggtt_start = wopcm;
-		ggtt_size = SZ_4G - ggtt_start;
+		ggtt_start = xe_tile_sriov_vf_ggtt_base(ggtt->tile);
+		ggtt_size = xe_tile_sriov_vf_ggtt(ggtt->tile);
+
+		if (ggtt_start < wopcm || ggtt_start > GUC_GGTT_TOP ||
+		    ggtt_size > GUC_GGTT_TOP - ggtt_start) {
+			xe_tile_err(ggtt->tile, "tile%u: Invalid GGTT configuration: %#llx-%#llx\n",
+				     ggtt->tile->id, ggtt_start, ggtt_start + ggtt_size - 1);

no need to add "tile%u" as it will be already included by the xe_tile_err()

Quoted 96 lines
drivers/gpu/drm/xe/xe_ggtt.c +3 -78
+			return -ERANGE;
+		}
 	}
 
 	ggtt->gsm = ggtt->tile->mmio.regs + SZ_8M;
@@ -378,17 +384,7 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt)
 	if (err)
 		return err;
 
-	err = devm_add_action_or_reset(xe->drm.dev, dev_fini_ggtt, ggtt);
-	if (err)
-		return err;
-
-	if (IS_SRIOV_VF(xe)) {
-		err = xe_tile_sriov_vf_prepare_ggtt(ggtt->tile);
-		if (err)
-			return err;
-	}
-
-	return 0;
+	return devm_add_action_or_reset(xe->drm.dev, dev_fini_ggtt, ggtt);
 }
 ALLOW_ERROR_INJECTION(xe_ggtt_init_early, ERRNO); /* See xe_pci_probe() */
 
@@ -539,119 +535,21 @@ static void xe_ggtt_invalidate(struct xe_ggtt *ggtt)
 	ggtt_invalidate_gt_tlb(ggtt->tile->media_gt);
 }
 
-static void xe_ggtt_dump_node(struct xe_ggtt *ggtt,
-			      const struct drm_mm_node *node, const char *description)
-{
-	char buf[10];
-
-	if (IS_ENABLED(CONFIG_DRM_XE_DEBUG)) {
-		string_get_size(node->size, 1, STRING_UNITS_2, buf, sizeof(buf));
-		xe_tile_dbg(ggtt->tile, "GGTT %#llx-%#llx (%s) %s\n",
-			    node->start, node->start + node->size, buf, description);
-	}
-}
-
-/**
- * xe_ggtt_node_insert_balloon_locked - prevent allocation of specified GGTT addresses
- * @node: the &xe_ggtt_node to hold reserved GGTT node
- * @start: the starting GGTT address of the reserved region
- * @end: then end GGTT address of the reserved region
- *
- * To be used in cases where ggtt->lock is already taken.
- * Use xe_ggtt_node_remove_balloon_locked() to release a reserved GGTT node.
- *
- * Return: 0 on success or a negative error code on failure.
- */
-int xe_ggtt_node_insert_balloon_locked(struct xe_ggtt_node *node, u64 start, u64 end)
-{
-	struct xe_ggtt *ggtt = node->ggtt;
-	int err;
-
-	xe_tile_assert(ggtt->tile, start < end);
-	xe_tile_assert(ggtt->tile, IS_ALIGNED(start, XE_PAGE_SIZE));
-	xe_tile_assert(ggtt->tile, IS_ALIGNED(end, XE_PAGE_SIZE));
-	xe_tile_assert(ggtt->tile, !drm_mm_node_allocated(&node->base));
-	lockdep_assert_held(&ggtt->lock);
-
-	node->base.color = 0;
-	node->base.start = start - ggtt->start;
-	node->base.size = end - start;
-
-	err = drm_mm_reserve_node(&ggtt->mm, &node->base);
-
-	if (xe_tile_WARN(ggtt->tile, err, "Failed to balloon GGTT %#llx-%#llx (%pe)\n",
-			 xe_ggtt_node_addr(node), xe_ggtt_node_addr(node) + node->base.size, ERR_PTR(err)))
-		return err;
-
-	xe_ggtt_dump_node(ggtt, &node->base, "balloon");
-	return 0;
-}
-
 /**
- * xe_ggtt_node_remove_balloon_locked - release a reserved GGTT region
- * @node: the &xe_ggtt_node with reserved GGTT region
- *
- * To be used in cases where ggtt->lock is already taken.
- * See xe_ggtt_node_insert_balloon_locked() for details.
- */
-void xe_ggtt_node_remove_balloon_locked(struct xe_ggtt_node *node)
-{
-	if (!xe_ggtt_node_allocated(node))
-		return;
-
-	lockdep_assert_held(&node->ggtt->lock);
-
-	xe_ggtt_dump_node(node->ggtt, &node->base, "remove-balloon");
-
-	drm_mm_remove_node(&node->base);
-}
-
-static void xe_ggtt_assert_fit(struct xe_ggtt *ggtt, u64 start, u64 size)

drivers/gpu/drm/xe/xe_ggtt.c static void xe_ggtt_invalidate(struct xe_ggtt *ggtt) · line 539

Quoted 10 lines
drivers/gpu/drm/xe/xe_ggtt.c +1 -9
-{
-	struct xe_tile *tile = ggtt->tile;
-
-	xe_tile_assert(tile, start >= ggtt->start);
-	xe_tile_assert(tile, start + size <= ggtt->start + ggtt->size);
-}
-
-/**
- * xe_ggtt_shift_nodes_locked - Shift GGTT nodes to adjust for a change in usable address range.
+ * xe_ggtt_shift_nodes - Shift GGTT nodes to adjust for a change in usable address range.

nit: add () after function name

and btw, shouldn't we rename this function now? maybe:

xe_ggtt_move(ggtt, new_start)

Quoted 75 lines
drivers/gpu/drm/xe/xe_ggtt.c +12 -39
  * @ggtt: the &xe_ggtt struct instance
- * @shift: change to the location of area provisioned for current VF
- *
- * This function moves all nodes from the GGTT VM, to a temp list. These nodes are expected
- * to represent allocations in range formerly assigned to current VF, before the range changed.
- * When the GGTT VM is completely clear of any nodes, they are re-added with shifted offsets.
+ * @new_start: new location of area provisioned for current VF
  *
- * The function has no ability of failing - because it shifts existing nodes, without
- * any additional processing. If the nodes were successfully existing at the old address,
- * they will do the same at the new one. A fail inside this function would indicate that
- * the list of nodes was either already damaged, or that the shift brings the address range
- * outside of valid bounds. Both cases justify an assert rather than error code.
+ * Adjust the base offset of the GGTT.
  */
-void xe_ggtt_shift_nodes_locked(struct xe_ggtt *ggtt, s64 shift)
+void xe_ggtt_shift_nodes(struct xe_ggtt *ggtt, u64 new_start)
 {
-	struct xe_tile *tile __maybe_unused = ggtt->tile;
-	struct drm_mm_node *node, *tmpn;
-	LIST_HEAD(temp_list_head);
-
-	lockdep_assert_held(&ggtt->lock);
+	guard(mutex)(&ggtt->lock);
 
-	if (IS_ENABLED(CONFIG_DRM_XE_DEBUG))
-		drm_mm_for_each_node_safe(node, tmpn, &ggtt->mm)
-			xe_ggtt_assert_fit(ggtt, node->start + shift, node->size);
+	xe_tile_assert(ggtt->tile, new_start >= xe_wopcm_size(tile_to_xe(ggtt->tile)));
+	xe_tile_assert(ggtt->tile, new_start + ggtt->size <= GUC_GGTT_TOP);
 
-	drm_mm_for_each_node_safe(node, tmpn, &ggtt->mm) {
-		drm_mm_remove_node(node);
-		list_add(&node->node_list, &temp_list_head);
-	}
-
-	list_for_each_entry_safe(node, tmpn, &temp_list_head, node_list) {
-		list_del(&node->node_list);
-		node->start += shift;
-		drm_mm_reserve_node(&ggtt->mm, node);
-		xe_tile_assert(tile, drm_mm_node_allocated(node));
-	}
+	WRITE_ONCE(ggtt->start, new_start);
 }
 
 static int xe_ggtt_node_insert_locked(struct xe_ggtt_node *node,
@@ -692,12 +590,8 @@ int xe_ggtt_node_insert(struct xe_ggtt_node *node, u32 size, u32 align)
  *
  * This function will allocate the struct %xe_ggtt_node and return its pointer.
  * This struct will then be freed after the node removal upon xe_ggtt_node_remove()
- * or xe_ggtt_node_remove_balloon_locked().
- *
- * Having %xe_ggtt_node struct allocated doesn't mean that the node is already
- * allocated in GGTT. Only xe_ggtt_node_insert(), allocation through
- * xe_ggtt_node_insert_transform(), or xe_ggtt_node_insert_balloon_locked() will ensure the node is inserted or reserved
- * in GGTT.
+ * Having %xe_ggtt_node struct allocated doesn't mean that the node is already allocated
+ * in GGTT. Only xe_ggtt_node_insert() will ensure the node is inserted or reserved in GGTT.
  *
  * Return: A pointer to %xe_ggtt_node struct on success. An ERR_PTR otherwise.
  **/
@@ -718,9 +612,9 @@ struct xe_ggtt_node *xe_ggtt_node_init(struct xe_ggtt *ggtt)
  * xe_ggtt_node_fini - Forcebly finalize %xe_ggtt_node struct
  * @node: the &xe_ggtt_node to be freed
  *
- * If anything went wrong with either xe_ggtt_node_insert(), xe_ggtt_node_insert_locked(),
- * or xe_ggtt_node_insert_balloon_locked(); and this @node is not going to be reused, then,
- * this function needs to be called to free the %xe_ggtt_node struct
+ * If anything went wrong with either xe_ggtt_node_insert() and this @node is
+ * not going to be reused, then this function needs to be called to free the
+ * %xe_ggtt_node struct
  **/
 void xe_ggtt_node_fini(struct xe_ggtt_node *node)
 {

drivers/gpu/drm/xe/xe_ggtt.c u64 xe_ggtt_read_pte(struct xe_ggtt *ggtt, u64 offset) · line 1123

Quoted 5 lines
drivers/gpu/drm/xe/xe_ggtt.c +1 -1
@@ -1226,7 +1120,8 @@ u64 xe_ggtt_read_pte(struct xe_ggtt *ggtt, u64 offset)
  */
 u64 xe_ggtt_node_addr(const struct xe_ggtt_node *node)
 {
-	return node->base.start + node->ggtt->start;
+	/* pairs with WRITE_ONCE in  xe_ggtt_shift_nodes() */
                                   ^^

double space

Quoted 42 lines
drivers/gpu/drm/xe/xe_ggtt.c +1 -0
+	return node->base.start + READ_ONCE(node->ggtt->start);
 }
 
 /**
drivers/gpu/drm/xe/xe_ggtt.h +1 -4
index 70d5e07ac4b66..49ea8e7ecc105 100644
@@ -19,10 +19,7 @@ int xe_ggtt_init(struct xe_ggtt *ggtt);
 
 struct xe_ggtt_node *xe_ggtt_node_init(struct xe_ggtt *ggtt);
 void xe_ggtt_node_fini(struct xe_ggtt_node *node);
-int xe_ggtt_node_insert_balloon_locked(struct xe_ggtt_node *node,
-				       u64 start, u64 size);
-void xe_ggtt_node_remove_balloon_locked(struct xe_ggtt_node *node);
-void xe_ggtt_shift_nodes_locked(struct xe_ggtt *ggtt, s64 shift);
+void xe_ggtt_shift_nodes(struct xe_ggtt *ggtt, u64 new_base);
 u64 xe_ggtt_start(struct xe_ggtt *ggtt);
 u64 xe_ggtt_size(struct xe_ggtt *ggtt);
 
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +0 -3
index d91c65dc34960..ea180a3ea7cb0 100644
@@ -489,7 +489,6 @@ u32 xe_gt_sriov_vf_gmdid(struct xe_gt *gt)
 static int vf_get_ggtt_info(struct xe_gt *gt)
 {
 	struct xe_tile *tile = gt_to_tile(gt);
-	struct xe_ggtt *ggtt = tile->mem.ggtt;
 	struct xe_guc *guc = &gt->uc.guc;
 	u64 start, size, ggtt_size;
 	s64 shift;
@@ -497,8 +496,6 @@ static int vf_get_ggtt_info(struct xe_gt *gt)
 
 	xe_gt_assert(gt, IS_SRIOV_VF(gt_to_xe(gt)));
 
-	guard(mutex)(&ggtt->lock);
-
 	err = guc_action_query_single_klv64(guc, GUC_KLV_VF_CFG_GGTT_START_KEY, &start);
 	if (unlikely(err))
 		return err;

drivers/gpu/drm/xe/xe_gt_sriov_vf.c static int vf_get_ggtt_info(struct xe_gt *gt) · line 524

Quoted 5 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +1 -1
@@ -524,10 +521,10 @@ static int vf_get_ggtt_info(struct xe_gt *gt)
 	xe_tile_sriov_vf_ggtt_base_store(tile, start);
 	xe_tile_sriov_vf_ggtt_store(tile, size);
 
-	if (shift && shift != start) {
+	if (ggtt_size) {

why this change? size will always be not 0 here

Quoted 201 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +1 -1
 		xe_gt_sriov_info(gt, "Shifting GGTT base by %lld to 0x%016llx\n",
 				 shift, start);
-		xe_tile_sriov_vf_fixup_ggtt_nodes_locked(gt_to_tile(gt), shift);
+		xe_ggtt_shift_nodes(tile->mem.ggtt, start);
 	}
 
 	if (xe_sriov_vf_migration_supported(gt_to_xe(gt))) {
drivers/gpu/drm/xe/xe_tile_sriov_vf.c +0 -166
index c9bac2cfdd044..24293521e0904 100644
@@ -14,173 +14,12 @@
 #include "xe_tile_sriov_vf.h"
 #include "xe_wopcm.h"
 
-static int vf_init_ggtt_balloons(struct xe_tile *tile)
-{
-	struct xe_ggtt *ggtt = tile->mem.ggtt;
-
-	xe_tile_assert(tile, IS_SRIOV_VF(tile_to_xe(tile)));
-
-	tile->sriov.vf.ggtt_balloon[0] = xe_ggtt_node_init(ggtt);
-	if (IS_ERR(tile->sriov.vf.ggtt_balloon[0]))
-		return PTR_ERR(tile->sriov.vf.ggtt_balloon[0]);
-
-	tile->sriov.vf.ggtt_balloon[1] = xe_ggtt_node_init(ggtt);
-	if (IS_ERR(tile->sriov.vf.ggtt_balloon[1])) {
-		xe_ggtt_node_fini(tile->sriov.vf.ggtt_balloon[0]);
-		return PTR_ERR(tile->sriov.vf.ggtt_balloon[1]);
-	}
-
-	return 0;
-}
-
-/**
- * xe_tile_sriov_vf_balloon_ggtt_locked - Insert balloon nodes to limit used GGTT address range.
- * @tile: the &xe_tile struct instance
- *
- * Return: 0 on success or a negative error code on failure.
- */
-static int xe_tile_sriov_vf_balloon_ggtt_locked(struct xe_tile *tile)
-{
-	u64 ggtt_base = tile->sriov.vf.self_config.ggtt_base;
-	u64 ggtt_size = tile->sriov.vf.self_config.ggtt_size;
-	struct xe_device *xe = tile_to_xe(tile);
-	u64 wopcm = xe_wopcm_size(xe);
-	u64 start, end;
-	int err;
-
-	xe_tile_assert(tile, IS_SRIOV_VF(xe));
-	xe_tile_assert(tile, ggtt_size);
-	lockdep_assert_held(&tile->mem.ggtt->lock);
-
-	/*
-	 * VF can only use part of the GGTT as allocated by the PF:
-	 *
-	 *      WOPCM                                  GUC_GGTT_TOP
-	 *      |<------------ Total GGTT size ------------------>|
-	 *
-	 *           VF GGTT base -->|<- size ->|
-	 *
-	 *      +--------------------+----------+-----------------+
-	 *      |////////////////////|   block  |\\\\\\\\\\\\\\\\\|
-	 *      +--------------------+----------+-----------------+
-	 *
-	 *      |<--- balloon[0] --->|<-- VF -->|<-- balloon[1] ->|
-	 */
-
-	if (ggtt_base < wopcm || ggtt_base > GUC_GGTT_TOP ||
-	    ggtt_size > GUC_GGTT_TOP - ggtt_base) {
-		xe_sriov_err(xe, "tile%u: Invalid GGTT configuration: %#llx-%#llx\n",
-			     tile->id, ggtt_base, ggtt_base + ggtt_size - 1);
-		return -ERANGE;
-	}
-
-	start = wopcm;
-	end = ggtt_base;
-	if (end != start) {
-		err = xe_ggtt_node_insert_balloon_locked(tile->sriov.vf.ggtt_balloon[0],
-							 start, end);
-		if (err)
-			return err;
-	}
-
-	start = ggtt_base + ggtt_size;
-	end = GUC_GGTT_TOP;
-	if (end != start) {
-		err = xe_ggtt_node_insert_balloon_locked(tile->sriov.vf.ggtt_balloon[1],
-							 start, end);
-		if (err) {
-			xe_ggtt_node_remove_balloon_locked(tile->sriov.vf.ggtt_balloon[0]);
-			return err;
-		}
-	}
-
-	return 0;
-}
-
-static int vf_balloon_ggtt(struct xe_tile *tile)
-{
-	struct xe_ggtt *ggtt = tile->mem.ggtt;
-	int err;
-
-	mutex_lock(&ggtt->lock);
-	err = xe_tile_sriov_vf_balloon_ggtt_locked(tile);
-	mutex_unlock(&ggtt->lock);
-
-	return err;
-}
-
-/**
- * xe_tile_sriov_vf_deballoon_ggtt_locked - Remove balloon nodes.
- * @tile: the &xe_tile struct instance
- */
-void xe_tile_sriov_vf_deballoon_ggtt_locked(struct xe_tile *tile)
-{
-	xe_tile_assert(tile, IS_SRIOV_VF(tile_to_xe(tile)));
-
-	xe_ggtt_node_remove_balloon_locked(tile->sriov.vf.ggtt_balloon[1]);
-	xe_ggtt_node_remove_balloon_locked(tile->sriov.vf.ggtt_balloon[0]);
-}
-
-static void vf_deballoon_ggtt(struct xe_tile *tile)
-{
-	mutex_lock(&tile->mem.ggtt->lock);
-	xe_tile_sriov_vf_deballoon_ggtt_locked(tile);
-	mutex_unlock(&tile->mem.ggtt->lock);
-}
-
-static void vf_fini_ggtt_balloons(struct xe_tile *tile)
-{
-	xe_tile_assert(tile, IS_SRIOV_VF(tile_to_xe(tile)));
-
-	xe_ggtt_node_fini(tile->sriov.vf.ggtt_balloon[1]);
-	xe_ggtt_node_fini(tile->sriov.vf.ggtt_balloon[0]);
-}
-
-static void cleanup_ggtt(struct drm_device *drm, void *arg)
-{
-	struct xe_tile *tile = arg;
-
-	vf_deballoon_ggtt(tile);
-	vf_fini_ggtt_balloons(tile);
-}
-
-/**
- * xe_tile_sriov_vf_prepare_ggtt - Prepare a VF's GGTT configuration.
- * @tile: the &xe_tile
- *
- * This function is for VF use only.
- *
- * Return: 0 on success or a negative error code on failure.
- */
-int xe_tile_sriov_vf_prepare_ggtt(struct xe_tile *tile)
-{
-	struct xe_device *xe = tile_to_xe(tile);
-	int err;
-
-	err = vf_init_ggtt_balloons(tile);
-	if (err)
-		return err;
-
-	err = vf_balloon_ggtt(tile);
-	if (err) {
-		vf_fini_ggtt_balloons(tile);
-		return err;
-	}
-
-	return drmm_add_action_or_reset(&xe->drm, cleanup_ggtt, tile);
-}
-
 /**
  * DOC: GGTT nodes shifting during VF post-migration recovery
  *
  * The first fixup applied to the VF KMD structures as part of post-migration
  * recovery is shifting nodes within &xe_ggtt instance. The nodes are moved
  * from range previously assigned to this VF, into newly provisioned area.
- * The changes include balloons, which are resized accordingly.
- *
- * The balloon nodes are there to eliminate unavailable ranges from use: one
- * reserves the GGTT area below the range for current VF, and another one
- * reserves area above.
  *
  * Below is a GGTT layout of example VF, with a certain address range assigned to
  * said VF, and inaccessible areas above and below:
@@ -198,10 +37,6 @@ int xe_tile_sriov_vf_prepare_ggtt(struct xe_tile *tile)
  *
  *  |<------- inaccessible for VF ------->|<VF owned>|<-- inaccessible for VF ->|
  *
- * GGTT nodes used for tracking allocations:
- *
- *      |<---------- balloon ------------>|<- nodes->|<----- balloon ------>|
- *
  * After the migration, GGTT area assigned to the VF might have shifted, either
  * to lower or to higher address. But we expect the total size and extra areas to
  * be identical, as migration can only happen between matching platforms.
@@ -219,37 +54,12 @@ int xe_tile_sriov_vf_prepare_ggtt(struct xe_tile *tile)
  * So the VF has a new slice of GGTT assigned, and during migration process, the
  * memory content was copied to that new area. But the &xe_ggtt nodes are still
  * tracking allocations using the old addresses. The nodes within VF owned area
- * have to be shifted, and balloon nodes need to be resized to properly mask out

drivers/gpu/drm/xe/xe_tile_sriov_vf.c int xe_tile_sriov_vf_prepare_ggtt(struct xe_tile *tile) · line 60

Quoted 10 lines
drivers/gpu/drm/xe/xe_tile_sriov_vf.c +2 -6
- * areas not owned by the VF.
- *
- * Fixed &xe_ggtt nodes used for tracking allocations:
- *
- *     |<------ balloon ------>|<- nodes->|<----------- balloon ----------->|
+ * have to be shifted, and the start offset for GGTT adjusted.
  *
- * Due to use of GPU profiles, we do not expect the old and new GGTT ares to
+ * Due to use of GPU profiles, we do not expect the old and new GGTT areas to
  * overlap; but our node shifting will fix addresses properly regardless.

nit: actually, this expectation is not so solid, thus the whole sentence can be dropped as it doesn't bring anything important

Quoted 26 lines
drivers/gpu/drm/xe/xe_tile_sriov_vf.c +0 -20
  */
 
-/**
- * xe_tile_sriov_vf_fixup_ggtt_nodes_locked - Shift GGTT allocations to match assigned range.
- * @tile: the &xe_tile struct instance
- * @shift: the shift value
- *
- * Since Global GTT is not virtualized, each VF has an assigned range
- * within the global space. This range might have changed during migration,
- * which requires all memory addresses pointing to GGTT to be shifted.
- */
-void xe_tile_sriov_vf_fixup_ggtt_nodes_locked(struct xe_tile *tile, s64 shift)
-{
-	struct xe_ggtt *ggtt = tile->mem.ggtt;
-
-	lockdep_assert_held(&ggtt->lock);
-
-	xe_tile_sriov_vf_deballoon_ggtt_locked(tile);
-	xe_ggtt_shift_nodes_locked(ggtt, shift);
-	xe_tile_sriov_vf_balloon_ggtt_locked(tile);
-}
-
 /**
  * xe_tile_sriov_vf_lmem - VF LMEM configuration.
  * @tile: the &xe_tile

drivers/gpu/drm/xe/xe_tile_sriov_vf.c u64 xe_tile_sriov_vf_ggtt_base(struct xe_tile *tile) · line 333

Quoted 4 lines
drivers/gpu/drm/xe/xe_tile_sriov_vf.c +0 -1
@@ -330,7 +140,7 @@ u64 xe_tile_sriov_vf_ggtt_base(struct xe_tile *tile)
 
 	xe_tile_assert(tile, IS_SRIOV_VF(tile_to_xe(tile)));
 
-	return config->ggtt_base;
	/* pairs with WRITE_ONCE in xe_tile_sriov_vf_ggtt_base_store */

drivers/gpu/drm/xe/xe_tile_sriov_vf.c void xe_tile_sriov_vf_ggtt_base_store(struct xe_tile *tile, u64 ggtt_base) · line 349

Quoted 9 lines
drivers/gpu/drm/xe/xe_tile_sriov_vf.c +1 -1
+	return READ_ONCE(config->ggtt_base);
 }
 
 /**
@@ -346,5 +156,5 @@ void xe_tile_sriov_vf_ggtt_base_store(struct xe_tile *tile, u64 ggtt_base)
 
 	xe_tile_assert(tile, IS_SRIOV_VF(tile_to_xe(tile)));
 
-	config->ggtt_base = ggtt_base;
	/* pairs with READ_ONCE in xe_tile_sriov_vf_ggtt_base */
Quoted 16 lines
drivers/gpu/drm/xe/xe_tile_sriov_vf.c +1 -0
+	WRITE_ONCE(config->ggtt_base, ggtt_base);
 }
drivers/gpu/drm/xe/xe_tile_sriov_vf.h +0 -3
index 749f41504883c..f2bbc4fc57347 100644
@@ -10,9 +10,6 @@
 
 struct xe_tile;
 
-int xe_tile_sriov_vf_prepare_ggtt(struct xe_tile *tile);
-void xe_tile_sriov_vf_deballoon_ggtt_locked(struct xe_tile *tile);
-void xe_tile_sriov_vf_fixup_ggtt_nodes_locked(struct xe_tile *tile, s64 shift);
 u64 xe_tile_sriov_vf_ggtt(struct xe_tile *tile);
 void xe_tile_sriov_vf_ggtt_store(struct xe_tile *tile, u64 ggtt_size);
 u64 xe_tile_sriov_vf_ggtt_base(struct xe_tile *tile);
#6 lore raw

Re: [PATCH v4 2/5] drm/xe: Rewrite GGTT VF initialisation

Hey,

Den 2026-01-13 kl. 23:53, skrev Michal Wajdeczko:

Quoted 10 lines · Maarten Lankhorst
Quoted 5 lines

The previous code was using a complicated system with 2 balloons to set GGTT size and adjust GGTT offset. While it works, it's overly complicated.

A better approach is to set the offset and size when initialising GGTT,

initializing (and in subject: initialization) ?

Yeah it's still valid English, but British spelling. I'll correct it.

Quoted 54 lines
Quoted 54 lines

this removes the need for adding balloons. The resize function only needs readjust ggtt->start to have GGTT at the new offset.

This removes the need to manipulate the internals of xe_ggtt outside of xe_ggtt, and cleans up a lot of now unneeded code.

---
 drivers/gpu/drm/xe/xe_device_types.h  |   2 -
 drivers/gpu/drm/xe/xe_ggtt.c          | 159 ++++-----------------
 drivers/gpu/drm/xe/xe_ggtt.h          |   5 +-
 drivers/gpu/drm/xe/xe_gt_sriov_vf.c   |   7 +-
 drivers/gpu/drm/xe/xe_tile_sriov_vf.c | 198 +-------------------------
 drivers/gpu/drm/xe/xe_tile_sriov_vf.h |   3 -
 6 files changed, 34 insertions(+), 340 deletions(-)
drivers/gpu/drm/xe/xe_device_types.h +0 -2
index 4dab3057f58d2..fa28477fe6fae 100644
@@ -221,8 +221,6 @@ struct xe_tile {
 			struct xe_lmtt lmtt;
 		} pf;
 		struct {
-			/** @sriov.vf.ggtt_balloon: GGTT regions excluded from use. */
-			struct xe_ggtt_node *ggtt_balloon[2];
 			/** @sriov.vf.self_config: VF configuration data */
 			struct xe_tile_sriov_vf_selfconfig self_config;
 		} vf;
drivers/gpu/drm/xe/xe_ggtt.c +3 -5
index 4bdd2c94021cd..1c5397e3ed724 100644
@@ -71,8 +71,8 @@
  * struct xe_ggtt_node - A node in GGTT.
  *
  * This struct needs to be initialized (only-once) with xe_ggtt_node_init() before any node
- * insertion, reservation, or 'ballooning'.
- * It will, then, be finalized by either xe_ggtt_node_remove() or xe_ggtt_node_deballoon().
+ * insertion or reservation.
+ * It will, then, be finalized by xe_ggtt_node_remove().
  */
 struct xe_ggtt_node {
 	/** @ggtt: Back pointer to xe_ggtt where this region will be inserted at */
@@ -348,9 +348,15 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt)
 		ggtt_start = wopcm;
 		ggtt_size = (gsm_size / 8) * (u64)XE_PAGE_SIZE - ggtt_start;
 	} else {
-		/* GGTT is expected to be 4GiB */
-		ggtt_start = wopcm;
-		ggtt_size = SZ_4G - ggtt_start;
+		ggtt_start = xe_tile_sriov_vf_ggtt_base(ggtt->tile);
Quoted 8 lines

drivers/gpu/drm/xe/xe_ggtt.c int xe_ggtt_init_early(struct xe_ggtt *ggtt) · line 357

Quoted 6 lines
drivers/gpu/drm/xe/xe_ggtt.c +6 -0
+		ggtt_size = xe_tile_sriov_vf_ggtt(ggtt->tile);
+
+		if (ggtt_start < wopcm || ggtt_start > GUC_GGTT_TOP ||
+		    ggtt_size > GUC_GGTT_TOP - ggtt_start) {
+			xe_tile_err(ggtt->tile, "tile%u: Invalid GGTT configuration: %#llx-%#llx\n",
+				     ggtt->tile->id, ggtt_start, ggtt_start + ggtt_size - 1);

no need to add "tile%u" as it will be already included by the xe_tile_err()

Ah right, I kept it when converting the xe_sriov_err below to a xe_tile_err. It's always going to be a VF anyway.

Quoted 101 lines
Quoted 101 lines
drivers/gpu/drm/xe/xe_ggtt.c +3 -82
+			return -ERANGE;
+		}
 	}
 
 	ggtt->gsm = ggtt->tile->mmio.regs + SZ_8M;
@@ -378,17 +384,7 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt)
 	if (err)
 		return err;
 
-	err = devm_add_action_or_reset(xe->drm.dev, dev_fini_ggtt, ggtt);
-	if (err)
-		return err;
-
-	if (IS_SRIOV_VF(xe)) {
-		err = xe_tile_sriov_vf_prepare_ggtt(ggtt->tile);
-		if (err)
-			return err;
-	}
-
-	return 0;
+	return devm_add_action_or_reset(xe->drm.dev, dev_fini_ggtt, ggtt);
 }
 ALLOW_ERROR_INJECTION(xe_ggtt_init_early, ERRNO); /* See xe_pci_probe() */
 
@@ -539,119 +535,21 @@ static void xe_ggtt_invalidate(struct xe_ggtt *ggtt)
 	ggtt_invalidate_gt_tlb(ggtt->tile->media_gt);
 }
 
-static void xe_ggtt_dump_node(struct xe_ggtt *ggtt,
-			      const struct drm_mm_node *node, const char *description)
-{
-	char buf[10];
-
-	if (IS_ENABLED(CONFIG_DRM_XE_DEBUG)) {
-		string_get_size(node->size, 1, STRING_UNITS_2, buf, sizeof(buf));
-		xe_tile_dbg(ggtt->tile, "GGTT %#llx-%#llx (%s) %s\n",
-			    node->start, node->start + node->size, buf, description);
-	}
-}
-
-/**
- * xe_ggtt_node_insert_balloon_locked - prevent allocation of specified GGTT addresses
- * @node: the &xe_ggtt_node to hold reserved GGTT node
- * @start: the starting GGTT address of the reserved region
- * @end: then end GGTT address of the reserved region
- *
- * To be used in cases where ggtt->lock is already taken.
- * Use xe_ggtt_node_remove_balloon_locked() to release a reserved GGTT node.
- *
- * Return: 0 on success or a negative error code on failure.
- */
-int xe_ggtt_node_insert_balloon_locked(struct xe_ggtt_node *node, u64 start, u64 end)
-{
-	struct xe_ggtt *ggtt = node->ggtt;
-	int err;
-
-	xe_tile_assert(ggtt->tile, start < end);
-	xe_tile_assert(ggtt->tile, IS_ALIGNED(start, XE_PAGE_SIZE));
-	xe_tile_assert(ggtt->tile, IS_ALIGNED(end, XE_PAGE_SIZE));
-	xe_tile_assert(ggtt->tile, !drm_mm_node_allocated(&node->base));
-	lockdep_assert_held(&ggtt->lock);
-
-	node->base.color = 0;
-	node->base.start = start - ggtt->start;
-	node->base.size = end - start;
-
-	err = drm_mm_reserve_node(&ggtt->mm, &node->base);
-
-	if (xe_tile_WARN(ggtt->tile, err, "Failed to balloon GGTT %#llx-%#llx (%pe)\n",
-			 xe_ggtt_node_addr(node), xe_ggtt_node_addr(node) + node->base.size, ERR_PTR(err)))
-		return err;
-
-	xe_ggtt_dump_node(ggtt, &node->base, "balloon");
-	return 0;
-}
-
 /**
- * xe_ggtt_node_remove_balloon_locked - release a reserved GGTT region
- * @node: the &xe_ggtt_node with reserved GGTT region
- *
- * To be used in cases where ggtt->lock is already taken.
- * See xe_ggtt_node_insert_balloon_locked() for details.
- */
-void xe_ggtt_node_remove_balloon_locked(struct xe_ggtt_node *node)
-{
-	if (!xe_ggtt_node_allocated(node))
-		return;
-
-	lockdep_assert_held(&node->ggtt->lock);
-
-	xe_ggtt_dump_node(node->ggtt, &node->base, "remove-balloon");
-
-	drm_mm_remove_node(&node->base);
-}
-
-static void xe_ggtt_assert_fit(struct xe_ggtt *ggtt, u64 start, u64 size)
-{
-	struct xe_tile *tile = ggtt->tile;
-
-	xe_tile_assert(tile, start >= ggtt->start);
Quoted 8 lines

drivers/gpu/drm/xe/xe_ggtt.c static void xe_ggtt_invalidate(struct xe_ggtt *ggtt) · line 539

Quoted 6 lines
drivers/gpu/drm/xe/xe_ggtt.c +1 -5
-	xe_tile_assert(tile, start + size <= ggtt->start + ggtt->size);
-}
-
-/**
- * xe_ggtt_shift_nodes_locked - Shift GGTT nodes to adjust for a change in usable address range.
+ * xe_ggtt_shift_nodes - Shift GGTT nodes to adjust for a change in usable address range.

nit: add () after function name

Seems to be about 50/50 whether () is used? Both ways are used extensively in xe, often within the same file.

Quoted 345 lines

and btw, shouldn't we rename this function now? maybe:

xe_ggtt_move(ggtt, new_start)

Quoted 75 lines
drivers/gpu/drm/xe/xe_ggtt.c +12 -39
  * @ggtt: the &xe_ggtt struct instance
- * @shift: change to the location of area provisioned for current VF
- *
- * This function moves all nodes from the GGTT VM, to a temp list. These nodes are expected
- * to represent allocations in range formerly assigned to current VF, before the range changed.
- * When the GGTT VM is completely clear of any nodes, they are re-added with shifted offsets.
+ * @new_start: new location of area provisioned for current VF
  *
- * The function has no ability of failing - because it shifts existing nodes, without
- * any additional processing. If the nodes were successfully existing at the old address,
- * they will do the same at the new one. A fail inside this function would indicate that
- * the list of nodes was either already damaged, or that the shift brings the address range
- * outside of valid bounds. Both cases justify an assert rather than error code.
+ * Adjust the base offset of the GGTT.
  */
-void xe_ggtt_shift_nodes_locked(struct xe_ggtt *ggtt, s64 shift)
+void xe_ggtt_shift_nodes(struct xe_ggtt *ggtt, u64 new_start)
 {
-	struct xe_tile *tile __maybe_unused = ggtt->tile;
-	struct drm_mm_node *node, *tmpn;
-	LIST_HEAD(temp_list_head);
-
-	lockdep_assert_held(&ggtt->lock);
+	guard(mutex)(&ggtt->lock);
 
-	if (IS_ENABLED(CONFIG_DRM_XE_DEBUG))
-		drm_mm_for_each_node_safe(node, tmpn, &ggtt->mm)
-			xe_ggtt_assert_fit(ggtt, node->start + shift, node->size);
+	xe_tile_assert(ggtt->tile, new_start >= xe_wopcm_size(tile_to_xe(ggtt->tile)));
+	xe_tile_assert(ggtt->tile, new_start + ggtt->size <= GUC_GGTT_TOP);
 
-	drm_mm_for_each_node_safe(node, tmpn, &ggtt->mm) {
-		drm_mm_remove_node(node);
-		list_add(&node->node_list, &temp_list_head);
-	}
-
-	list_for_each_entry_safe(node, tmpn, &temp_list_head, node_list) {
-		list_del(&node->node_list);
-		node->start += shift;
-		drm_mm_reserve_node(&ggtt->mm, node);
-		xe_tile_assert(tile, drm_mm_node_allocated(node));
-	}
+	WRITE_ONCE(ggtt->start, new_start);
 }
 
 static int xe_ggtt_node_insert_locked(struct xe_ggtt_node *node,
@@ -692,12 +590,8 @@ int xe_ggtt_node_insert(struct xe_ggtt_node *node, u32 size, u32 align)
  *
  * This function will allocate the struct %xe_ggtt_node and return its pointer.
  * This struct will then be freed after the node removal upon xe_ggtt_node_remove()
- * or xe_ggtt_node_remove_balloon_locked().
- *
- * Having %xe_ggtt_node struct allocated doesn't mean that the node is already
- * allocated in GGTT. Only xe_ggtt_node_insert(), allocation through
- * xe_ggtt_node_insert_transform(), or xe_ggtt_node_insert_balloon_locked() will ensure the node is inserted or reserved
- * in GGTT.
+ * Having %xe_ggtt_node struct allocated doesn't mean that the node is already allocated
+ * in GGTT. Only xe_ggtt_node_insert() will ensure the node is inserted or reserved in GGTT.
  *
  * Return: A pointer to %xe_ggtt_node struct on success. An ERR_PTR otherwise.
  **/
@@ -718,9 +612,9 @@ struct xe_ggtt_node *xe_ggtt_node_init(struct xe_ggtt *ggtt)
  * xe_ggtt_node_fini - Forcebly finalize %xe_ggtt_node struct
  * @node: the &xe_ggtt_node to be freed
  *
- * If anything went wrong with either xe_ggtt_node_insert(), xe_ggtt_node_insert_locked(),
- * or xe_ggtt_node_insert_balloon_locked(); and this @node is not going to be reused, then,
- * this function needs to be called to free the %xe_ggtt_node struct
+ * If anything went wrong with either xe_ggtt_node_insert() and this @node is
+ * not going to be reused, then this function needs to be called to free the
+ * %xe_ggtt_node struct
  **/
 void xe_ggtt_node_fini(struct xe_ggtt_node *node)
 {

drivers/gpu/drm/xe/xe_ggtt.c u64 xe_ggtt_read_pte(struct xe_ggtt *ggtt, u64 offset) · line 1123

Quoted 5 lines
drivers/gpu/drm/xe/xe_ggtt.c +1 -1
@@ -1226,7 +1120,8 @@ u64 xe_ggtt_read_pte(struct xe_ggtt *ggtt, u64 offset)
  */
 u64 xe_ggtt_node_addr(const struct xe_ggtt_node *node)
 {
-	return node->base.start + node->ggtt->start;
+	/* pairs with WRITE_ONCE in  xe_ggtt_shift_nodes() */
                                   ^^

double space

Quoted 42 lines
drivers/gpu/drm/xe/xe_ggtt.c +1 -0
+	return node->base.start + READ_ONCE(node->ggtt->start);
 }
 
 /**
drivers/gpu/drm/xe/xe_ggtt.h +1 -4
index 70d5e07ac4b66..49ea8e7ecc105 100644
@@ -19,10 +19,7 @@ int xe_ggtt_init(struct xe_ggtt *ggtt);
 
 struct xe_ggtt_node *xe_ggtt_node_init(struct xe_ggtt *ggtt);
 void xe_ggtt_node_fini(struct xe_ggtt_node *node);
-int xe_ggtt_node_insert_balloon_locked(struct xe_ggtt_node *node,
-				       u64 start, u64 size);
-void xe_ggtt_node_remove_balloon_locked(struct xe_ggtt_node *node);
-void xe_ggtt_shift_nodes_locked(struct xe_ggtt *ggtt, s64 shift);
+void xe_ggtt_shift_nodes(struct xe_ggtt *ggtt, u64 new_base);
 u64 xe_ggtt_start(struct xe_ggtt *ggtt);
 u64 xe_ggtt_size(struct xe_ggtt *ggtt);
 
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +0 -3
index d91c65dc34960..ea180a3ea7cb0 100644
@@ -489,7 +489,6 @@ u32 xe_gt_sriov_vf_gmdid(struct xe_gt *gt)
 static int vf_get_ggtt_info(struct xe_gt *gt)
 {
 	struct xe_tile *tile = gt_to_tile(gt);
-	struct xe_ggtt *ggtt = tile->mem.ggtt;
 	struct xe_guc *guc = &gt->uc.guc;
 	u64 start, size, ggtt_size;
 	s64 shift;
@@ -497,8 +496,6 @@ static int vf_get_ggtt_info(struct xe_gt *gt)
 
 	xe_gt_assert(gt, IS_SRIOV_VF(gt_to_xe(gt)));
 
-	guard(mutex)(&ggtt->lock);
-
 	err = guc_action_query_single_klv64(guc, GUC_KLV_VF_CFG_GGTT_START_KEY, &start);
 	if (unlikely(err))
 		return err;

drivers/gpu/drm/xe/xe_gt_sriov_vf.c static int vf_get_ggtt_info(struct xe_gt *gt) · line 524

Quoted 5 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +1 -1
@@ -524,10 +521,10 @@ static int vf_get_ggtt_info(struct xe_gt *gt)
 	xe_tile_sriov_vf_ggtt_base_store(tile, start);
 	xe_tile_sriov_vf_ggtt_store(tile, size);
 
-	if (shift && shift != start) {
+	if (ggtt_size) {

why this change? size will always be not 0 here

Quoted 206 lines
drivers/gpu/drm/xe/xe_gt_sriov_vf.c +1 -1
 		xe_gt_sriov_info(gt, "Shifting GGTT base by %lld to 0x%016llx\n",
 				 shift, start);
-		xe_tile_sriov_vf_fixup_ggtt_nodes_locked(gt_to_tile(gt), shift);
+		xe_ggtt_shift_nodes(tile->mem.ggtt, start);
 	}
 
 	if (xe_sriov_vf_migration_supported(gt_to_xe(gt))) {
drivers/gpu/drm/xe/xe_tile_sriov_vf.c +0 -171
index c9bac2cfdd044..24293521e0904 100644
@@ -14,173 +14,12 @@
 #include "xe_tile_sriov_vf.h"
 #include "xe_wopcm.h"
 
-static int vf_init_ggtt_balloons(struct xe_tile *tile)
-{
-	struct xe_ggtt *ggtt = tile->mem.ggtt;
-
-	xe_tile_assert(tile, IS_SRIOV_VF(tile_to_xe(tile)));
-
-	tile->sriov.vf.ggtt_balloon[0] = xe_ggtt_node_init(ggtt);
-	if (IS_ERR(tile->sriov.vf.ggtt_balloon[0]))
-		return PTR_ERR(tile->sriov.vf.ggtt_balloon[0]);
-
-	tile->sriov.vf.ggtt_balloon[1] = xe_ggtt_node_init(ggtt);
-	if (IS_ERR(tile->sriov.vf.ggtt_balloon[1])) {
-		xe_ggtt_node_fini(tile->sriov.vf.ggtt_balloon[0]);
-		return PTR_ERR(tile->sriov.vf.ggtt_balloon[1]);
-	}
-
-	return 0;
-}
-
-/**
- * xe_tile_sriov_vf_balloon_ggtt_locked - Insert balloon nodes to limit used GGTT address range.
- * @tile: the &xe_tile struct instance
- *
- * Return: 0 on success or a negative error code on failure.
- */
-static int xe_tile_sriov_vf_balloon_ggtt_locked(struct xe_tile *tile)
-{
-	u64 ggtt_base = tile->sriov.vf.self_config.ggtt_base;
-	u64 ggtt_size = tile->sriov.vf.self_config.ggtt_size;
-	struct xe_device *xe = tile_to_xe(tile);
-	u64 wopcm = xe_wopcm_size(xe);
-	u64 start, end;
-	int err;
-
-	xe_tile_assert(tile, IS_SRIOV_VF(xe));
-	xe_tile_assert(tile, ggtt_size);
-	lockdep_assert_held(&tile->mem.ggtt->lock);
-
-	/*
-	 * VF can only use part of the GGTT as allocated by the PF:
-	 *
-	 *      WOPCM                                  GUC_GGTT_TOP
-	 *      |<------------ Total GGTT size ------------------>|
-	 *
-	 *           VF GGTT base -->|<- size ->|
-	 *
-	 *      +--------------------+----------+-----------------+
-	 *      |////////////////////|   block  |\\\\\\\\\\\\\\\\\|
-	 *      +--------------------+----------+-----------------+
-	 *
-	 *      |<--- balloon[0] --->|<-- VF -->|<-- balloon[1] ->|
-	 */
-
-	if (ggtt_base < wopcm || ggtt_base > GUC_GGTT_TOP ||
-	    ggtt_size > GUC_GGTT_TOP - ggtt_base) {
-		xe_sriov_err(xe, "tile%u: Invalid GGTT configuration: %#llx-%#llx\n",
-			     tile->id, ggtt_base, ggtt_base + ggtt_size - 1);
-		return -ERANGE;
-	}
-
-	start = wopcm;
-	end = ggtt_base;
-	if (end != start) {
-		err = xe_ggtt_node_insert_balloon_locked(tile->sriov.vf.ggtt_balloon[0],
-							 start, end);
-		if (err)
-			return err;
-	}
-
-	start = ggtt_base + ggtt_size;
-	end = GUC_GGTT_TOP;
-	if (end != start) {
-		err = xe_ggtt_node_insert_balloon_locked(tile->sriov.vf.ggtt_balloon[1],
-							 start, end);
-		if (err) {
-			xe_ggtt_node_remove_balloon_locked(tile->sriov.vf.ggtt_balloon[0]);
-			return err;
-		}
-	}
-
-	return 0;
-}
-
-static int vf_balloon_ggtt(struct xe_tile *tile)
-{
-	struct xe_ggtt *ggtt = tile->mem.ggtt;
-	int err;
-
-	mutex_lock(&ggtt->lock);
-	err = xe_tile_sriov_vf_balloon_ggtt_locked(tile);
-	mutex_unlock(&ggtt->lock);
-
-	return err;
-}
-
-/**
- * xe_tile_sriov_vf_deballoon_ggtt_locked - Remove balloon nodes.
- * @tile: the &xe_tile struct instance
- */
-void xe_tile_sriov_vf_deballoon_ggtt_locked(struct xe_tile *tile)
-{
-	xe_tile_assert(tile, IS_SRIOV_VF(tile_to_xe(tile)));
-
-	xe_ggtt_node_remove_balloon_locked(tile->sriov.vf.ggtt_balloon[1]);
-	xe_ggtt_node_remove_balloon_locked(tile->sriov.vf.ggtt_balloon[0]);
-}
-
-static void vf_deballoon_ggtt(struct xe_tile *tile)
-{
-	mutex_lock(&tile->mem.ggtt->lock);
-	xe_tile_sriov_vf_deballoon_ggtt_locked(tile);
-	mutex_unlock(&tile->mem.ggtt->lock);
-}
-
-static void vf_fini_ggtt_balloons(struct xe_tile *tile)
-{
-	xe_tile_assert(tile, IS_SRIOV_VF(tile_to_xe(tile)));
-
-	xe_ggtt_node_fini(tile->sriov.vf.ggtt_balloon[1]);
-	xe_ggtt_node_fini(tile->sriov.vf.ggtt_balloon[0]);
-}
-
-static void cleanup_ggtt(struct drm_device *drm, void *arg)
-{
-	struct xe_tile *tile = arg;
-
-	vf_deballoon_ggtt(tile);
-	vf_fini_ggtt_balloons(tile);
-}
-
-/**
- * xe_tile_sriov_vf_prepare_ggtt - Prepare a VF's GGTT configuration.
- * @tile: the &xe_tile
- *
- * This function is for VF use only.
- *
- * Return: 0 on success or a negative error code on failure.
- */
-int xe_tile_sriov_vf_prepare_ggtt(struct xe_tile *tile)
-{
-	struct xe_device *xe = tile_to_xe(tile);
-	int err;
-
-	err = vf_init_ggtt_balloons(tile);
-	if (err)
-		return err;
-
-	err = vf_balloon_ggtt(tile);
-	if (err) {
-		vf_fini_ggtt_balloons(tile);
-		return err;
-	}
-
-	return drmm_add_action_or_reset(&xe->drm, cleanup_ggtt, tile);
-}
-
 /**
  * DOC: GGTT nodes shifting during VF post-migration recovery
  *
  * The first fixup applied to the VF KMD structures as part of post-migration
  * recovery is shifting nodes within &xe_ggtt instance. The nodes are moved
  * from range previously assigned to this VF, into newly provisioned area.
- * The changes include balloons, which are resized accordingly.
- *
- * The balloon nodes are there to eliminate unavailable ranges from use: one
- * reserves the GGTT area below the range for current VF, and another one
- * reserves area above.
  *
  * Below is a GGTT layout of example VF, with a certain address range assigned to
  * said VF, and inaccessible areas above and below:
@@ -198,10 +37,6 @@ int xe_tile_sriov_vf_prepare_ggtt(struct xe_tile *tile)
  *
  *  |<------- inaccessible for VF ------->|<VF owned>|<-- inaccessible for VF ->|
  *
- * GGTT nodes used for tracking allocations:
- *
- *      |<---------- balloon ------------>|<- nodes->|<----- balloon ------>|
- *
  * After the migration, GGTT area assigned to the VF might have shifted, either
  * to lower or to higher address. But we expect the total size and extra areas to
  * be identical, as migration can only happen between matching platforms.
@@ -219,37 +54,12 @@ int xe_tile_sriov_vf_prepare_ggtt(struct xe_tile *tile)
  * So the VF has a new slice of GGTT assigned, and during migration process, the
  * memory content was copied to that new area. But the &xe_ggtt nodes are still
  * tracking allocations using the old addresses. The nodes within VF owned area
- * have to be shifted, and balloon nodes need to be resized to properly mask out
- * areas not owned by the VF.
- *
- * Fixed &xe_ggtt nodes used for tracking allocations:
- *
- *     |<------ balloon ------>|<- nodes->|<----------- balloon ----------->|
Quoted 8 lines

drivers/gpu/drm/xe/xe_tile_sriov_vf.c int xe_tile_sriov_vf_prepare_ggtt(struct xe_tile *tile) · line 60

Quoted 5 lines
drivers/gpu/drm/xe/xe_tile_sriov_vf.c +2 -1
+ * have to be shifted, and the start offset for GGTT adjusted.
  *
- * Due to use of GPU profiles, we do not expect the old and new GGTT ares to
+ * Due to use of GPU profiles, we do not expect the old and new GGTT areas to
  * overlap; but our node shifting will fix addresses properly regardless.

nit: actually, this expectation is not so solid, thus the whole sentence can be dropped as it doesn't bring anything important

Ok, will do so!

Quoted 63 lines
Quoted 27 lines
drivers/gpu/drm/xe/xe_tile_sriov_vf.c +0 -20
  */
 
-/**
- * xe_tile_sriov_vf_fixup_ggtt_nodes_locked - Shift GGTT allocations to match assigned range.
- * @tile: the &xe_tile struct instance
- * @shift: the shift value
- *
- * Since Global GTT is not virtualized, each VF has an assigned range
- * within the global space. This range might have changed during migration,
- * which requires all memory addresses pointing to GGTT to be shifted.
- */
-void xe_tile_sriov_vf_fixup_ggtt_nodes_locked(struct xe_tile *tile, s64 shift)
-{
-	struct xe_ggtt *ggtt = tile->mem.ggtt;
-
-	lockdep_assert_held(&ggtt->lock);
-
-	xe_tile_sriov_vf_deballoon_ggtt_locked(tile);
-	xe_ggtt_shift_nodes_locked(ggtt, shift);
-	xe_tile_sriov_vf_balloon_ggtt_locked(tile);
-}
-
 /**
  * xe_tile_sriov_vf_lmem - VF LMEM configuration.
  * @tile: the &xe_tile

drivers/gpu/drm/xe/xe_tile_sriov_vf.c u64 xe_tile_sriov_vf_ggtt_base(struct xe_tile *tile) · line 333

Quoted 4 lines
drivers/gpu/drm/xe/xe_tile_sriov_vf.c +0 -1
@@ -330,7 +140,7 @@ u64 xe_tile_sriov_vf_ggtt_base(struct xe_tile *tile)
 
 	xe_tile_assert(tile, IS_SRIOV_VF(tile_to_xe(tile)));
 
-	return config->ggtt_base;
	/* pairs with WRITE_ONCE in xe_tile_sriov_vf_ggtt_base_store */

drivers/gpu/drm/xe/xe_tile_sriov_vf.c void xe_tile_sriov_vf_ggtt_base_store(struct xe_tile *tile, u64 ggtt_base) · line 349

Quoted 9 lines
drivers/gpu/drm/xe/xe_tile_sriov_vf.c +1 -1
+	return READ_ONCE(config->ggtt_base);
 }
 
 /**
@@ -346,5 +156,5 @@ void xe_tile_sriov_vf_ggtt_base_store(struct xe_tile *tile, u64 ggtt_base)
 
 	xe_tile_assert(tile, IS_SRIOV_VF(tile_to_xe(tile)));
 
-	config->ggtt_base = ggtt_base;
	/* pairs with READ_ONCE in xe_tile_sriov_vf_ggtt_base */
Quoted 16 lines
drivers/gpu/drm/xe/xe_tile_sriov_vf.c +1 -0
+	WRITE_ONCE(config->ggtt_base, ggtt_base);
 }
drivers/gpu/drm/xe/xe_tile_sriov_vf.h +0 -3
index 749f41504883c..f2bbc4fc57347 100644
@@ -10,9 +10,6 @@
 
 struct xe_tile;
 
-int xe_tile_sriov_vf_prepare_ggtt(struct xe_tile *tile);
-void xe_tile_sriov_vf_deballoon_ggtt_locked(struct xe_tile *tile);
-void xe_tile_sriov_vf_fixup_ggtt_nodes_locked(struct xe_tile *tile, s64 shift);
 u64 xe_tile_sriov_vf_ggtt(struct xe_tile *tile);
 void xe_tile_sriov_vf_ggtt_store(struct xe_tile *tile, u64 ggtt_size);
 u64 xe_tile_sriov_vf_ggtt_base(struct xe_tile *tile);
#7 lore raw

Re: [PATCH v4 2/5] drm/xe: Rewrite GGTT VF initialisation

Maarten Lankhorst <[email protected]> wrote on śro [2026-sty-14 10:55:02 +0100]:

Quoted 6 lines

Hey,

Den 2026-01-13 kl. 23:53, skrev Michal Wajdeczko:

Quoted 3 lines · Maarten Lankhorst

<snip>

Quoted 9 lines
Quoted 7 lines

drivers/gpu/drm/xe/xe_ggtt.c static void xe_ggtt_invalidate(struct xe_ggtt *ggtt) · line 539

Quoted 5 lines
drivers/gpu/drm/xe/xe_ggtt.c +1 -4
-}
-
-/**
- * xe_ggtt_shift_nodes_locked - Shift GGTT nodes to adjust for a change in usable address range.
+ * xe_ggtt_shift_nodes - Shift GGTT nodes to adjust for a change in usable address range.

nit: add () after function name

Seems to be about 50/50 whether () is used? Both ways are used extensively in xe, often within the same file.

Quoted 1 line

Based on https://docs.kernel.org/doc-guide/kernel-doc.html#function-documentation
we should use ()

Thanks
Piotr

</snip>

#8 lore raw

Re: [PATCH v4 2/5] drm/xe: Rewrite GGTT VF initialisation

Hey,

Den 2026-01-14 kl. 17:15, skrev Piotr Piórkowski:

Quoted 17 lines

Maarten Lankhorst <[email protected]> wrote on śro [2026-sty-14 10:55:02 +0100]:

Quoted 6 lines

Hey,

Den 2026-01-13 kl. 23:53, skrev Michal Wajdeczko:

Quoted 3 lines · Maarten Lankhorst

<snip>

Quoted 7 lines
Quoted 7 lines

drivers/gpu/drm/xe/xe_ggtt.c static void xe_ggtt_invalidate(struct xe_ggtt *ggtt) · line 539

Quoted 5 lines
drivers/gpu/drm/xe/xe_ggtt.c +1 -4
-}
-
-/**
- * xe_ggtt_shift_nodes_locked - Shift GGTT nodes to adjust for a change in usable address range.
+ * xe_ggtt_shift_nodes - Shift GGTT nodes to adjust for a change in usable address range.

nit: add () after function name

Quoted 6 lines
Quoted 2 lines

Seems to be about 50/50 whether () is used? Both ways are used extensively in xe, often within the same file.

Quoted 1 line

Based on https://docs.kernel.org/doc-guide/kernel-doc.html#function-documentation
we should use ()

It doesn't look like anyone else is really caring though.

~/nfs/linux$ git grep '* [a-zA-Z_()]* -' | wc -l
71222

~/nfs/linux$ git grep '* [a-zA-Z_()]* -' | grep '() -' | wc -l 15087

So using the () for annotating function is a minority.

#9 lore raw

PATCH v4 3/5 drm/xe: Move struct xe_ggtt to xe_ggtt.c

In reply to Maarten Lankhorst

From: Maarten Lankhorst <[email protected]>

No users left outside of xe_ggtt.c, so we can make the struct private.

This prevents us from accidentally touching it before init.

---
 drivers/gpu/drm/xe/xe_ggtt.c       | 55 +++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_ggtt.h       |  1 +
 drivers/gpu/drm/xe/xe_ggtt_types.h | 60 +-----------------------------
 3 files changed, 58 insertions(+), 58 deletions(-)
drivers/gpu/drm/xe/xe_ggtt.c +55 -0
index 1c5397e3ed724..85babe7ab43a0 100644
@@ -85,6 +85,61 @@ struct xe_ggtt_node {
 	bool invalidate_on_remove;
 };
 
+/**
+ * struct xe_ggtt_pt_ops - GGTT Page table operations
+ * Which can vary from platform to platform.
+ */
+struct xe_ggtt_pt_ops {
+	/** @pte_encode_flags: Encode PTE flags for a given BO */
+	u64 (*pte_encode_flags)(struct xe_bo *bo, u16 pat_index);
+
+	/** @ggtt_set_pte: Directly write into GGTT's PTE */
+	xe_ggtt_set_pte_fn ggtt_set_pte;
+
+	/** @ggtt_get_pte: Directly read from GGTT's PTE */
+	u64 (*ggtt_get_pte)(struct xe_ggtt *ggtt, u64 addr);
+};
+
+/**
+ * struct xe_ggtt - Main GGTT struct
+ *
+ * In general, each tile can contains its own Global Graphics Translation Table
+ * (GGTT) instance.
+ */
+struct xe_ggtt {
+	/** @tile: Back pointer to tile where this GGTT belongs */
+	struct xe_tile *tile;
+        /** @start: Start offset of GGTT */
+	u64 start;
+	/** @size: Total usable size of this GGTT */
+	u64 size;
+
+#define XE_GGTT_FLAGS_64K BIT(0)
+	/**
+	 * @flags: Flags for this GGTT
+	 * Acceptable flags:
+	 * - %XE_GGTT_FLAGS_64K - if PTE size is 64K. Otherwise, regular is 4K.
+	 */
+	unsigned int flags;
+	/** @scratch: Internal object allocation used as a scratch page */
+	struct xe_bo *scratch;
+	/** @lock: Mutex lock to protect GGTT data */
+	struct mutex lock;
+	/**
+	 *  @gsm: The iomem pointer to the actual location of the translation
+	 * table located in the GSM for easy PTE manipulation
+	 */
+	u64 __iomem *gsm;
+	/** @pt_ops: Page Table operations per platform */
+	const struct xe_ggtt_pt_ops *pt_ops;
+	/** @mm: The memory manager used to manage individual GGTT allocations */
+	struct drm_mm mm;
+	/** @access_count: counts GGTT writes */
+	unsigned int access_count;
+	/** @wq: Dedicated unordered work queue to process node removals */
+	struct workqueue_struct *wq;
+};
+
 static u64 xelp_ggtt_pte_flags(struct xe_bo *bo, u16 pat_index)
 {
 	u64 pte = XE_PAGE_PRESENT;
drivers/gpu/drm/xe/xe_ggtt.h +1 -0
index 49ea8e7ecc105..403eb5c0db49d 100644
@@ -9,6 +9,7 @@
 #include "xe_ggtt_types.h"
 
 struct drm_printer;
+struct xe_bo;
 struct xe_tile;
 struct drm_exec;
 
drivers/gpu/drm/xe/xe_ggtt_types.h +2 -58

74 lines not on this page · raw message

Signature · 1 line
2.51.0
#10 lore raw

PATCH v4 4/5 drm/xe: Make xe_ggtt_node_insert return a node

In reply to Maarten Lankhorst

This extra step is easier to handle inside xe_ggtt.c and makes xe_ggtt_node_allocated a simple null check instead, as the intermediate state 'allocated but not inserted' is no longer used.

Privatize xe_ggtt_node_fini() as it's no longer used outside of xe_ggtt.c

---
 drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c |  6 +-
 drivers/gpu/drm/xe/xe_ggtt.c                | 76 +++++++++------------
 drivers/gpu/drm/xe/xe_ggtt.h                |  5 +-
 drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c  | 24 +------
 4 files changed, 38 insertions(+), 73 deletions(-)
drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c +1 -5
index acddbedcf17cb..7aeee6680d78c 100644
@@ -38,12 +38,8 @@ static struct xe_bo *replacement_xe_managed_bo_create_pin_map(struct xe_device *
 	if (flags & XE_BO_FLAG_GGTT) {
 		struct xe_ggtt *ggtt = tile->mem.ggtt;
 
-		bo->ggtt_node[tile->id] = xe_ggtt_node_init(ggtt);
+		bo->ggtt_node[tile->id] = xe_ggtt_node_insert(ggtt, xe_bo_size(bo), SZ_4K);
 		KUNIT_ASSERT_NOT_ERR_OR_NULL(test, bo->ggtt_node[tile->id]);
-
-		KUNIT_ASSERT_EQ(test, 0,
-				xe_ggtt_node_insert(bo->ggtt_node[tile->id],
-						    xe_bo_size(bo), SZ_4K));
 	}
 
 	return bo;
drivers/gpu/drm/xe/xe_ggtt.c +32 -44

106 lines not on this page · raw message

drivers/gpu/drm/xe/xe_ggtt.h +2 -3
index 403eb5c0db49d..6d8679bcc38fb 100644
@@ -18,13 +18,12 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt);
 int xe_ggtt_init_kunit(struct xe_ggtt *ggtt, u32 reserved, u32 size);
 int xe_ggtt_init(struct xe_ggtt *ggtt);
 
-struct xe_ggtt_node *xe_ggtt_node_init(struct xe_ggtt *ggtt);
-void xe_ggtt_node_fini(struct xe_ggtt_node *node);
 void xe_ggtt_shift_nodes(struct xe_ggtt *ggtt, u64 new_base);
 u64 xe_ggtt_start(struct xe_ggtt *ggtt);
 u64 xe_ggtt_size(struct xe_ggtt *ggtt);
 
-int xe_ggtt_node_insert(struct xe_ggtt_node *node, u32 size, u32 align);
+struct xe_ggtt_node *
+xe_ggtt_node_insert(struct xe_ggtt *ggtt, u32 size, u32 align);
 struct xe_ggtt_node *
 xe_ggtt_node_insert_transform(struct xe_ggtt *ggtt,
 			      struct xe_bo *bo, u64 pte,
drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c +3 -21
index 9f2525f3cb379..a6414d164166e 100644
@@ -484,23 +484,9 @@ static int pf_distribute_config_ggtt(struct xe_tile *tile, unsigned int vfid, u6
 	return err ?: err2;
 }
 
-static void pf_release_ggtt(struct xe_tile *tile, struct xe_ggtt_node *node)
-{
-	if (xe_ggtt_node_allocated(node)) {
-		/*
-		 * explicit GGTT PTE assignment to the PF using xe_ggtt_assign()
-		 * is redundant, as PTE will be implicitly re-assigned to PF by
-		 * the xe_ggtt_clear() called by below xe_ggtt_remove_node().
-		 */
-		xe_ggtt_node_remove(node, false);
-	} else {
-		xe_ggtt_node_fini(node);
-	}
-}
-
 static void pf_release_vf_config_ggtt(struct xe_gt *gt, struct xe_gt_sriov_config *config)
 {
-	pf_release_ggtt(gt_to_tile(gt), config->ggtt_region);
+	xe_ggtt_node_remove(config->ggtt_region, false);
 	config->ggtt_region = NULL;
 }
 
@@ -535,14 +521,10 @@ static int pf_provision_vf_ggtt(struct xe_gt *gt, unsigned int vfid, u64 size)
 	if (!size)
 		return 0;
 
-	node = xe_ggtt_node_init(ggtt);
+	node = xe_ggtt_node_insert(ggtt, size, alignment);
 	if (IS_ERR(node))
 		return PTR_ERR(node);
 
-	err = xe_ggtt_node_insert(node, size, alignment);
-	if (unlikely(err))
-		goto err;
-
 	xe_ggtt_assign(node, vfid);
 	xe_gt_sriov_dbg_verbose(gt, "VF%u assigned GGTT %llx-%llx\n",
 				vfid, xe_ggtt_node_addr(node), xe_ggtt_node_addr(node) + size - 1);
@@ -554,7 +536,7 @@ static int pf_provision_vf_ggtt(struct xe_gt *gt, unsigned int vfid, u64 size)
 	config->ggtt_region = node;
 	return 0;
 err:
-	pf_release_ggtt(tile, node);
+	xe_ggtt_node_remove(node, false);
 	return err;
 }
 
Signature · 1 line
2.51.0
#11 lore raw

Re: [PATCH v4 4/5] drm/xe: Make xe_ggtt_node_insert return a node

Quoted 71 lines · Maarten Lankhorst

This extra step is easier to handle inside xe_ggtt.c and makes xe_ggtt_node_allocated a simple null check instead, as the intermediate state 'allocated but not inserted' is no longer used.

Privatize xe_ggtt_node_fini() as it's no longer used outside of xe_ggtt.c

---
 drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c |  6 +-
 drivers/gpu/drm/xe/xe_ggtt.c                | 76 +++++++++------------
 drivers/gpu/drm/xe/xe_ggtt.h                |  5 +-
 drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c  | 24 +------
 4 files changed, 38 insertions(+), 73 deletions(-)
drivers/gpu/drm/xe/tests/xe_guc_buf_kunit.c +1 -5
index acddbedcf17cb..7aeee6680d78c 100644
@@ -38,12 +38,8 @@ static struct xe_bo *replacement_xe_managed_bo_create_pin_map(struct xe_device *
 	if (flags & XE_BO_FLAG_GGTT) {
 		struct xe_ggtt *ggtt = tile->mem.ggtt;
 
-		bo->ggtt_node[tile->id] = xe_ggtt_node_init(ggtt);
+		bo->ggtt_node[tile->id] = xe_ggtt_node_insert(ggtt, xe_bo_size(bo), SZ_4K);
 		KUNIT_ASSERT_NOT_ERR_OR_NULL(test, bo->ggtt_node[tile->id]);
-
-		KUNIT_ASSERT_EQ(test, 0,
-				xe_ggtt_node_insert(bo->ggtt_node[tile->id],
-						    xe_bo_size(bo), SZ_4K));
 	}
 
 	return bo;
drivers/gpu/drm/xe/xe_ggtt.c +19 -1
index 85babe7ab43a0..7538ba13cbab7 100644
@@ -459,6 +459,11 @@ static void xe_ggtt_initial_clear(struct xe_ggtt *ggtt)
 	mutex_unlock(&ggtt->lock);
 }
 
+static void xe_ggtt_node_fini(struct xe_ggtt_node *node)
+{
+	kfree(node);
+}
+
 static void ggtt_node_remove(struct xe_ggtt_node *node)
 {
 	struct xe_ggtt *ggtt = node->ggtt;
@@ -614,68 +619,51 @@ static int xe_ggtt_node_insert_locked(struct xe_ggtt_node *node,
 					  mm_flags);
 }
 
+static struct xe_ggtt_node *xe_ggtt_node_init(struct xe_ggtt *ggtt)
+{
+	struct xe_ggtt_node *node = kzalloc(sizeof(*node), GFP_NOFS);
+
+	if (!node)
+		return ERR_PTR(-ENOMEM);
+
+	INIT_WORK(&node->delayed_removal_work, ggtt_node_remove_work_func);
+	node->ggtt = ggtt;
+
+	return node;
+}
+
 /**
  * xe_ggtt_node_insert - Insert a &xe_ggtt_node into the GGTT
- * @node: the &xe_ggtt_node to be inserted
+ * @ggtt: the @ggtt into which the node should be inserted.

drivers/gpu/drm/xe/xe_ggtt.c static int xe_ggtt_node_insert_locked(struct xe_ggtt_node *node, · line 643

Quoted 10 lines
drivers/gpu/drm/xe/xe_ggtt.c +2 -4
  * @size: size of the node
  * @align: alignment constrain of the node
  *
- * It cannot be called without first having called xe_ggtt_init() once.
- *
- * Return: 0 on success or a negative error code on failure.
+ * Return: &xe_ggtt_node on success or a ERR_PTR on failure.
  */
-int xe_ggtt_node_insert(struct xe_ggtt_node *node, u32 size, u32 align)
+struct xe_ggtt_node *xe_ggtt_node_insert(struct xe_ggtt *ggtt, u32 size, u32 align)

this should be now called:

	xe_ggtt_insert_node(ggtt, ...)

as it doesn't take a node param any more

drivers/gpu/drm/xe/xe_ggtt.c static int xe_ggtt_node_insert_locked(struct xe_ggtt_node *node, · line 649

Quoted 8 lines
drivers/gpu/drm/xe/xe_ggtt.c +3 -2
 {
+	struct xe_ggtt_node *node;
 	int ret;
 
-	if (!node || !node->ggtt)
-		return -ENOENT;
+	if (!ggtt)
+		return ERR_PTR(-ENOENT);

can't we drop this?
we don't expect this function be called with NULL
or after we fail to allocate xe_ggtt

drivers/gpu/drm/xe/xe_ggtt.c static int xe_ggtt_node_insert_locked(struct xe_ggtt_node *node, · line 655

Quoted 6 lines
drivers/gpu/drm/xe/xe_ggtt.c +4 -0
+
+	node = xe_ggtt_node_init(ggtt);
+	if (IS_ERR(node))
+		return node;
 
 	mutex_lock(&node->ggtt->lock);

we can now use:

  	mutex_lock(&ggtt->lock);
Quoted 125 lines
drivers/gpu/drm/xe/xe_ggtt.c +4 -37
 	ret = xe_ggtt_node_insert_locked(node, size, align,
 					 DRM_MM_INSERT_HIGH);
 	mutex_unlock(&node->ggtt->lock);
-
-	return ret;
-}
-
-/**
- * xe_ggtt_node_init - Initialize %xe_ggtt_node struct
- * @ggtt: the &xe_ggtt where the new node will later be inserted/reserved.
- *
- * This function will allocate the struct %xe_ggtt_node and return its pointer.
- * This struct will then be freed after the node removal upon xe_ggtt_node_remove()
- * Having %xe_ggtt_node struct allocated doesn't mean that the node is already allocated
- * in GGTT. Only xe_ggtt_node_insert() will ensure the node is inserted or reserved in GGTT.
- *
- * Return: A pointer to %xe_ggtt_node struct on success. An ERR_PTR otherwise.
- **/
-struct xe_ggtt_node *xe_ggtt_node_init(struct xe_ggtt *ggtt)
-{
-	struct xe_ggtt_node *node = kzalloc(sizeof(*node), GFP_NOFS);
-
-	if (!node)
-		return ERR_PTR(-ENOMEM);
-
-	INIT_WORK(&node->delayed_removal_work, ggtt_node_remove_work_func);
-	node->ggtt = ggtt;
+	if (ret) {
+		xe_ggtt_node_fini(node);
+		return ERR_PTR(ret);
+	}
 
 	return node;
 }
 
-/**
- * xe_ggtt_node_fini - Forcebly finalize %xe_ggtt_node struct
- * @node: the &xe_ggtt_node to be freed
- *
- * If anything went wrong with either xe_ggtt_node_insert() and this @node is
- * not going to be reused, then this function needs to be called to free the
- * %xe_ggtt_node struct
- **/
-void xe_ggtt_node_fini(struct xe_ggtt_node *node)
-{
-	kfree(node);
-}
-
 /**
  * xe_ggtt_node_allocated - Check if node is allocated in GGTT
  * @node: the &xe_ggtt_node to be inspected
drivers/gpu/drm/xe/xe_ggtt.h +2 -3
index 403eb5c0db49d..6d8679bcc38fb 100644
@@ -18,13 +18,12 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt);
 int xe_ggtt_init_kunit(struct xe_ggtt *ggtt, u32 reserved, u32 size);
 int xe_ggtt_init(struct xe_ggtt *ggtt);
 
-struct xe_ggtt_node *xe_ggtt_node_init(struct xe_ggtt *ggtt);
-void xe_ggtt_node_fini(struct xe_ggtt_node *node);
 void xe_ggtt_shift_nodes(struct xe_ggtt *ggtt, u64 new_base);
 u64 xe_ggtt_start(struct xe_ggtt *ggtt);
 u64 xe_ggtt_size(struct xe_ggtt *ggtt);
 
-int xe_ggtt_node_insert(struct xe_ggtt_node *node, u32 size, u32 align);
+struct xe_ggtt_node *
+xe_ggtt_node_insert(struct xe_ggtt *ggtt, u32 size, u32 align);
 struct xe_ggtt_node *
 xe_ggtt_node_insert_transform(struct xe_ggtt *ggtt,
 			      struct xe_bo *bo, u64 pte,
drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c +3 -21
index 9f2525f3cb379..a6414d164166e 100644
@@ -484,23 +484,9 @@ static int pf_distribute_config_ggtt(struct xe_tile *tile, unsigned int vfid, u6
 	return err ?: err2;
 }
 
-static void pf_release_ggtt(struct xe_tile *tile, struct xe_ggtt_node *node)
-{
-	if (xe_ggtt_node_allocated(node)) {
-		/*
-		 * explicit GGTT PTE assignment to the PF using xe_ggtt_assign()
-		 * is redundant, as PTE will be implicitly re-assigned to PF by
-		 * the xe_ggtt_clear() called by below xe_ggtt_remove_node().
-		 */
-		xe_ggtt_node_remove(node, false);
-	} else {
-		xe_ggtt_node_fini(node);
-	}
-}
-
 static void pf_release_vf_config_ggtt(struct xe_gt *gt, struct xe_gt_sriov_config *config)
 {
-	pf_release_ggtt(gt_to_tile(gt), config->ggtt_region);
+	xe_ggtt_node_remove(config->ggtt_region, false);
 	config->ggtt_region = NULL;
 }
 
@@ -535,14 +521,10 @@ static int pf_provision_vf_ggtt(struct xe_gt *gt, unsigned int vfid, u64 size)
 	if (!size)
 		return 0;
 
-	node = xe_ggtt_node_init(ggtt);
+	node = xe_ggtt_node_insert(ggtt, size, alignment);
 	if (IS_ERR(node))
 		return PTR_ERR(node);
 
-	err = xe_ggtt_node_insert(node, size, alignment);
-	if (unlikely(err))
-		goto err;
-
 	xe_ggtt_assign(node, vfid);
 	xe_gt_sriov_dbg_verbose(gt, "VF%u assigned GGTT %llx-%llx\n",
 				vfid, xe_ggtt_node_addr(node), xe_ggtt_node_addr(node) + size - 1);
@@ -554,7 +536,7 @@ static int pf_provision_vf_ggtt(struct xe_gt *gt, unsigned int vfid, u64 size)
 	config->ggtt_region = node;
 	return 0;
 err:
-	pf_release_ggtt(tile, node);
+	xe_ggtt_node_remove(node, false);
 	return err;
 }
 
#12 lore raw

PATCH v4 5/5 drm/xe: Remove xe_ggtt_node_allocated

In reply to Maarten Lankhorst

With the intermediate state gone, no longer useful. Just check against NULL where needed.

---
 drivers/gpu/drm/xe/display/xe_fb_pin.c     |  3 +--
 drivers/gpu/drm/xe/xe_ggtt.c               | 17 -----------------
 drivers/gpu/drm/xe/xe_ggtt.h               |  1 -
 drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c | 12 ++++++------
 4 files changed, 7 insertions(+), 26 deletions(-)
drivers/gpu/drm/xe/display/xe_fb_pin.c +1 -2
index d2c4e94180fa3..10915fb3151f4 100644
@@ -352,8 +352,7 @@ static void __xe_unpin_fb_vma(struct i915_vma *vma)
 
 	if (vma->dpt)
 		xe_bo_unpin_map_no_vm(vma->dpt);
-	else if (!xe_ggtt_node_allocated(vma->bo->ggtt_node[tile_id]) ||
-		 vma->bo->ggtt_node[tile_id] != vma->node)
+	else if (vma->bo->ggtt_node[tile_id] != vma->node)
 		xe_ggtt_node_remove(vma->node, false);
 
 	ttm_bo_reserve(&vma->bo->ttm, false, false, NULL);
drivers/gpu/drm/xe/xe_ggtt.c +0 -17
index 7538ba13cbab7..5e0225dab8462 100644
@@ -664,20 +664,6 @@ struct xe_ggtt_node *xe_ggtt_node_insert(struct xe_ggtt *ggtt, u32 size, u32 ali
 	return node;
 }
 
-/**
- * xe_ggtt_node_allocated - Check if node is allocated in GGTT
- * @node: the &xe_ggtt_node to be inspected
- *
- * Return: True if allocated, False otherwise.
- */
-bool xe_ggtt_node_allocated(const struct xe_ggtt_node *node)
-{
-	if (!node || !node->ggtt)
-		return false;
-
-	return drm_mm_node_allocated(&node->base);
-}
-
 /**
  * xe_ggtt_node_pt_size() - Get the size of page table entries needed to map a GGTT node.
  * @node: the &xe_ggtt_node
@@ -961,9 +947,6 @@ static void xe_ggtt_assign_locked(const struct xe_ggtt_node *node, u16 vfid)
 
 	lockdep_assert_held(&ggtt->lock);
 
-	if (!xe_ggtt_node_allocated(node))
-		return;
-
 	while (start < end) {
 		ggtt->pt_ops->ggtt_set_pte(ggtt, start, pte);
 		start += XE_PAGE_SIZE;
drivers/gpu/drm/xe/xe_ggtt.h +0 -1
index 6d8679bcc38fb..ffa3369927157 100644
@@ -30,7 +30,6 @@ xe_ggtt_node_insert_transform(struct xe_ggtt *ggtt,
 			      u64 size, u32 align,
 			      xe_ggtt_transform_cb transform, void *arg);
 void xe_ggtt_node_remove(struct xe_ggtt_node *node, bool invalidate);
-bool xe_ggtt_node_allocated(const struct xe_ggtt_node *node);
 size_t xe_ggtt_node_pt_size(const struct xe_ggtt_node *node);
 void xe_ggtt_map_bo_unlocked(struct xe_ggtt *ggtt, struct xe_bo *bo);
 int xe_ggtt_insert_bo(struct xe_ggtt *ggtt, struct xe_bo *bo, struct drm_exec *exec);
drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c +6 -6
index a6414d164166e..ca757742d2748 100644
@@ -281,7 +281,7 @@ static u32 encode_config_ggtt(u32 *cfg, const struct xe_gt_sriov_config *config,
 {
 	struct xe_ggtt_node *node = config->ggtt_region;
 
-	if (!xe_ggtt_node_allocated(node))
+	if (!node)
 		return 0;
 
 	return encode_ggtt(cfg, xe_ggtt_node_addr(node), xe_ggtt_node_size(node), details);
@@ -505,7 +505,7 @@ static int pf_provision_vf_ggtt(struct xe_gt *gt, unsigned int vfid, u64 size)
 
 	size = round_up(size, alignment);
 
-	if (xe_ggtt_node_allocated(config->ggtt_region)) {
+	if (config->ggtt_region) {
 		err = pf_distribute_config_ggtt(tile, vfid, 0, 0);
 		if (unlikely(err))
 			return err;
@@ -516,7 +516,7 @@ static int pf_provision_vf_ggtt(struct xe_gt *gt, unsigned int vfid, u64 size)
 		if (unlikely(err))
 			return err;
 	}
-	xe_gt_assert(gt, !xe_ggtt_node_allocated(config->ggtt_region));
+	xe_gt_assert(gt, !config->ggtt_region);
 
 	if (!size)
 		return 0;
@@ -546,7 +546,7 @@ static u64 pf_get_vf_config_ggtt(struct xe_gt *gt, unsigned int vfid)
 	struct xe_ggtt_node *node = config->ggtt_region;
 
 	xe_gt_assert(gt, xe_gt_is_main_type(gt));
-	return xe_ggtt_node_allocated(node) ? xe_ggtt_node_size(node) : 0;
+	return node ? xe_ggtt_node_size(node) : 0;
 }
 
 /**
@@ -2560,7 +2560,7 @@ int xe_gt_sriov_pf_config_release(struct xe_gt *gt, unsigned int vfid, bool forc
 
 static void pf_sanitize_ggtt(struct xe_ggtt_node *ggtt_region, unsigned int vfid)
 {
-	if (xe_ggtt_node_allocated(ggtt_region))
+	if (ggtt_region)
 		xe_ggtt_assign(ggtt_region, vfid);
 }
 
@@ -3019,7 +3019,7 @@ int xe_gt_sriov_pf_config_print_ggtt(struct xe_gt *gt, struct drm_printer *p)
 
 	for (n = 1; n <= total_vfs; n++) {
 		config = &gt->sriov.pf.vfs[n].config;
-		if (!xe_ggtt_node_allocated(config->ggtt_region))
+		if (!config->ggtt_region)
 			continue;
 
 		string_get_size(xe_ggtt_node_size(config->ggtt_region), 1, STRING_UNITS_2,
Signature · 1 line
2.51.0
#13 lore raw

✗ CI.checkpatch: warning for drm/xe: Privatize struct xe_ggtt. (rev2)

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: drm/xe: Privatize struct xe_ggtt. (rev2)
URL : https://patchwork.freedesktop.org/series/160006/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master ee83616c430ce70bd254bd2774d143a5733c8666
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 90fc11a03104e80763a3e6801524b4f3cbcf676e

Author: Maarten Lankhorst <[email protected]>
Date:   Tue Jan 13 13:18:07 2026 +0100

drm/xe: Remove xe_ggtt_node_allocated

With the intermediate state gone, no longer useful. Just check against NULL where needed.

+ /mt/dim checkpatch f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082 drm-intel ddd5c98cbb5e drm/xe: Make xe_ggtt_node offset relative to starting offset -:57: WARNING:LONG_LINE: line length of 107 exceeds 100 columns #57: FILE: drivers/gpu/drm/xe/xe_ggtt.c:583:
+ xe_ggtt_node_addr(node), xe_ggtt_node_addr(node) + node->base.size, ERR_PTR(err)))

total: 0 errors, 1 warnings, 0 checks, 143 lines checked
8b04cc3c4719 drm/xe: Rewrite GGTT VF initialisation
-:18: WARNING:BAD_SIGN_OFF: Co-developed-by: must be immediately followed by Signed-off-by:
#18:

-:61: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #61: FILE: drivers/gpu/drm/xe/xe_ggtt.c:357:
+ xe_tile_err(ggtt->tile, "tile%u: Invalid GGTT configuration: %#llx-%#llx\n",
+ ggtt->tile->id, ggtt_start, ggtt_start + ggtt_size - 1);

total: 0 errors, 1 warnings, 1 checks, 499 lines checked 466d2fa51fe7 drm/xe: Move struct xe_ggtt to xe_ggtt.c -:46: ERROR:CODE_INDENT: code indent should use tabs where possible #46: FILE: drivers/gpu/drm/xe/xe_ggtt.c:112:
+ /** @start: Start offset of GGTT */$

total: 1 errors, 0 warnings, 0 checks, 142 lines checked f5b310b39a5c drm/xe: Make xe_ggtt_node_insert return a node 90fc11a03104 drm/xe: Remove xe_ggtt_node_allocated

#14 lore raw

✓ CI.KUnit: success for drm/xe: Privatize struct xe_ggtt. (rev2)

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: drm/xe: Privatize struct xe_ggtt. (rev2)
URL : https://patchwork.freedesktop.org/series/160006/
State : success

== Summary ==

+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [12:23:39] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[12:23:43] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=25
[12:24:22] Starting KUnit Kernel (1/1)...
[12:24:22] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:24:23] ================== guc_buf (11 subtests) ===================
[12:24:23] [PASSED] test_smallest
[12:24:23] [PASSED] test_largest
[12:24:23] [PASSED] test_granular
[12:24:23] [PASSED] test_unique
[12:24:23] [PASSED] test_overlap
[12:24:23] [PASSED] test_reusable
[12:24:23] [PASSED] test_too_big
[12:24:23] [PASSED] test_flush
[12:24:23] [PASSED] test_lookup
[12:24:23] [PASSED] test_data
[12:24:23] [PASSED] test_class
[12:24:23] ===================== [PASSED] guc_buf =====================
[12:24:23] =================== guc_dbm (7 subtests) ===================
[12:24:23] [PASSED] test_empty
[12:24:23] [PASSED] test_default
[12:24:23] ======================== test_size  ========================
[12:24:23] [PASSED] 4
[12:24:23] [PASSED] 8
[12:24:23] [PASSED] 32
[12:24:23] [PASSED] 256
[12:24:23] ==================== [PASSED] test_size ====================
[12:24:23] ======================= test_reuse  ========================
[12:24:23] [PASSED] 4
[12:24:23] [PASSED] 8
[12:24:23] [PASSED] 32
[12:24:23] [PASSED] 256
[12:24:23] =================== [PASSED] test_reuse ====================
[12:24:23] =================== test_range_overlap  ====================
[12:24:23] [PASSED] 4
[12:24:23] [PASSED] 8
[12:24:23] [PASSED] 32
[12:24:23] [PASSED] 256
[12:24:23] =============== [PASSED] test_range_overlap ================
[12:24:23] =================== test_range_compact  ====================
[12:24:23] [PASSED] 4
[12:24:23] [PASSED] 8
[12:24:23] [PASSED] 32
[12:24:23] [PASSED] 256
[12:24:23] =============== [PASSED] test_range_compact ================
[12:24:23] ==================== test_range_spare  =====================
[12:24:23] [PASSED] 4
[12:24:23] [PASSED] 8
[12:24:23] [PASSED] 32
[12:24:23] [PASSED] 256
[12:24:23] ================ [PASSED] test_range_spare =================
[12:24:23] ===================== [PASSED] guc_dbm =====================
[12:24:23] =================== guc_idm (6 subtests) ===================
[12:24:23] [PASSED] bad_init
[12:24:23] [PASSED] no_init
[12:24:23] [PASSED] init_fini
[12:24:23] [PASSED] check_used
[12:24:23] [PASSED] check_quota
[12:24:23] [PASSED] check_all
[12:24:23] ===================== [PASSED] guc_idm =====================
[12:24:23] ================== no_relay (3 subtests) ===================
[12:24:23] [PASSED] xe_drops_guc2pf_if_not_ready
[12:24:23] [PASSED] xe_drops_guc2vf_if_not_ready
[12:24:23] [PASSED] xe_rejects_send_if_not_ready
[12:24:23] ==================== [PASSED] no_relay =====================
[12:24:23] ================== pf_relay (14 subtests) ==================
[12:24:23] [PASSED] pf_rejects_guc2pf_too_short
[12:24:23] [PASSED] pf_rejects_guc2pf_too_long
[12:24:23] [PASSED] pf_rejects_guc2pf_no_payload
[12:24:23] [PASSED] pf_fails_no_payload
[12:24:23] [PASSED] pf_fails_bad_origin
[12:24:23] [PASSED] pf_fails_bad_type
[12:24:23] [PASSED] pf_txn_reports_error
[12:24:23] [PASSED] pf_txn_sends_pf2guc
[12:24:23] [PASSED] pf_sends_pf2guc
[12:24:23] [SKIPPED] pf_loopback_nop
[12:24:23] [SKIPPED] pf_loopback_echo
[12:24:23] [SKIPPED] pf_loopback_fail
[12:24:23] [SKIPPED] pf_loopback_busy
[12:24:23] [SKIPPED] pf_loopback_retry
[12:24:23] ==================== [PASSED] pf_relay =====================
[12:24:23] ================== vf_relay (3 subtests) ===================
[12:24:23] [PASSED] vf_rejects_guc2vf_too_short
[12:24:23] [PASSED] vf_rejects_guc2vf_too_long
[12:24:23] [PASSED] vf_rejects_guc2vf_no_payload
[12:24:23] ==================== [PASSED] vf_relay =====================
[12:24:23] ================ pf_gt_config (6 subtests) =================
[12:24:23] [PASSED] fair_contexts_1vf
[12:24:23] [PASSED] fair_doorbells_1vf
[12:24:23] [PASSED] fair_ggtt_1vf
[12:24:23] ====================== fair_contexts  ======================
[12:24:23] [PASSED] 1 VF
[12:24:23] [PASSED] 2 VFs
[12:24:23] [PASSED] 3 VFs
[12:24:23] [PASSED] 4 VFs
[12:24:23] [PASSED] 5 VFs
[12:24:23] [PASSED] 6 VFs
[12:24:23] [PASSED] 7 VFs
[12:24:23] [PASSED] 8 VFs
[12:24:23] [PASSED] 9 VFs
[12:24:23] [PASSED] 10 VFs
[12:24:23] [PASSED] 11 VFs
[12:24:23] [PASSED] 12 VFs
[12:24:23] [PASSED] 13 VFs
[12:24:23] [PASSED] 14 VFs
[12:24:23] [PASSED] 15 VFs
[12:24:23] [PASSED] 16 VFs
[12:24:23] [PASSED] 17 VFs
[12:24:23] [PASSED] 18 VFs
[12:24:23] [PASSED] 19 VFs
[12:24:23] [PASSED] 20 VFs
[12:24:23] [PASSED] 21 VFs
[12:24:23] [PASSED] 22 VFs
[12:24:23] [PASSED] 23 VFs
[12:24:23] [PASSED] 24 VFs
[12:24:23] [PASSED] 25 VFs
[12:24:23] [PASSED] 26 VFs
[12:24:23] [PASSED] 27 VFs
[12:24:23] [PASSED] 28 VFs
[12:24:23] [PASSED] 29 VFs
[12:24:23] [PASSED] 30 VFs
[12:24:23] [PASSED] 31 VFs
[12:24:23] [PASSED] 32 VFs
[12:24:23] [PASSED] 33 VFs
[12:24:23] [PASSED] 34 VFs
[12:24:23] [PASSED] 35 VFs
[12:24:23] [PASSED] 36 VFs
[12:24:23] [PASSED] 37 VFs
[12:24:23] [PASSED] 38 VFs
[12:24:23] [PASSED] 39 VFs
[12:24:23] [PASSED] 40 VFs
[12:24:23] [PASSED] 41 VFs
[12:24:23] [PASSED] 42 VFs
[12:24:23] [PASSED] 43 VFs
[12:24:23] [PASSED] 44 VFs
[12:24:23] [PASSED] 45 VFs
[12:24:23] [PASSED] 46 VFs
[12:24:23] [PASSED] 47 VFs
[12:24:23] [PASSED] 48 VFs
[12:24:23] [PASSED] 49 VFs
[12:24:23] [PASSED] 50 VFs
[12:24:23] [PASSED] 51 VFs
[12:24:23] [PASSED] 52 VFs
[12:24:23] [PASSED] 53 VFs
[12:24:23] [PASSED] 54 VFs
[12:24:23] [PASSED] 55 VFs
[12:24:23] [PASSED] 56 VFs
[12:24:23] [PASSED] 57 VFs
[12:24:23] [PASSED] 58 VFs
[12:24:23] [PASSED] 59 VFs
[12:24:23] [PASSED] 60 VFs
[12:24:23] [PASSED] 61 VFs
[12:24:23] [PASSED] 62 VFs
[12:24:23] [PASSED] 63 VFs
[12:24:23] ================== [PASSED] fair_contexts ==================
[12:24:23] ===================== fair_doorbells  ======================
[12:24:23] [PASSED] 1 VF
[12:24:23] [PASSED] 2 VFs
[12:24:23] [PASSED] 3 VFs
[12:24:23] [PASSED] 4 VFs
[12:24:23] [PASSED] 5 VFs
[12:24:23] [PASSED] 6 VFs
[12:24:23] [PASSED] 7 VFs
[12:24:23] [PASSED] 8 VFs
[12:24:23] [PASSED] 9 VFs
[12:24:23] [PASSED] 10 VFs
[12:24:23] [PASSED] 11 VFs
[12:24:23] [PASSED] 12 VFs
[12:24:23] [PASSED] 13 VFs
[12:24:23] [PASSED] 14 VFs
[12:24:23] [PASSED] 15 VFs
[12:24:23] [PASSED] 16 VFs
[12:24:23] [PASSED] 17 VFs
[12:24:23] [PASSED] 18 VFs
[12:24:23] [PASSED] 19 VFs
[12:24:23] [PASSED] 20 VFs
[12:24:23] [PASSED] 21 VFs
[12:24:23] [PASSED] 22 VFs
[12:24:23] [PASSED] 23 VFs
[12:24:23] [PASSED] 24 VFs
[12:24:23] [PASSED] 25 VFs
[12:24:23] [PASSED] 26 VFs
[12:24:23] [PASSED] 27 VFs
[12:24:23] [PASSED] 28 VFs
[12:24:23] [PASSED] 29 VFs
[12:24:23] [PASSED] 30 VFs
[12:24:23] [PASSED] 31 VFs
[12:24:23] [PASSED] 32 VFs
[12:24:23] [PASSED] 33 VFs
[12:24:23] [PASSED] 34 VFs
[12:24:23] [PASSED] 35 VFs
[12:24:23] [PASSED] 36 VFs
[12:24:23] [PASSED] 37 VFs
[12:24:23] [PASSED] 38 VFs
[12:24:23] [PASSED] 39 VFs
[12:24:23] [PASSED] 40 VFs
[12:24:23] [PASSED] 41 VFs
[12:24:23] [PASSED] 42 VFs
[12:24:23] [PASSED] 43 VFs
[12:24:23] [PASSED] 44 VFs
[12:24:23] [PASSED] 45 VFs
[12:24:23] [PASSED] 46 VFs
[12:24:23] [PASSED] 47 VFs
[12:24:23] [PASSED] 48 VFs
[12:24:23] [PASSED] 49 VFs
[12:24:23] [PASSED] 50 VFs
[12:24:23] [PASSED] 51 VFs
[12:24:23] [PASSED] 52 VFs
[12:24:23] [PASSED] 53 VFs
[12:24:23] [PASSED] 54 VFs
[12:24:23] [PASSED] 55 VFs
[12:24:23] [PASSED] 56 VFs
[12:24:23] [PASSED] 57 VFs
[12:24:23] [PASSED] 58 VFs
[12:24:23] [PASSED] 59 VFs
[12:24:23] [PASSED] 60 VFs
[12:24:23] [PASSED] 61 VFs
[12:24:23] [PASSED] 62 VFs
[12:24:23] [PASSED] 63 VFs
[12:24:23] ================= [PASSED] fair_doorbells ==================
[12:24:23] ======================== fair_ggtt  ========================
[12:24:23] [PASSED] 1 VF
[12:24:23] [PASSED] 2 VFs
[12:24:23] [PASSED] 3 VFs
[12:24:23] [PASSED] 4 VFs
[12:24:23] [PASSED] 5 VFs
[12:24:23] [PASSED] 6 VFs
[12:24:23] [PASSED] 7 VFs
[12:24:23] [PASSED] 8 VFs
[12:24:23] [PASSED] 9 VFs
[12:24:23] [PASSED] 10 VFs
[12:24:23] [PASSED] 11 VFs
[12:24:23] [PASSED] 12 VFs
[12:24:23] [PASSED] 13 VFs
[12:24:23] [PASSED] 14 VFs
[12:24:23] [PASSED] 15 VFs
[12:24:23] [PASSED] 16 VFs
[12:24:23] [PASSED] 17 VFs
[12:24:23] [PASSED] 18 VFs
[12:24:23] [PASSED] 19 VFs
[12:24:23] [PASSED] 20 VFs
[12:24:23] [PASSED] 21 VFs
[12:24:23] [PASSED] 22 VFs
[12:24:23] [PASSED] 23 VFs
[12:24:23] [PASSED] 24 VFs
[12:24:23] [PASSED] 25 VFs
[12:24:23] [PASSED] 26 VFs
[12:24:23] [PASSED] 27 VFs
[12:24:23] [PASSED] 28 VFs
[12:24:23] [PASSED] 29 VFs
[12:24:23] [PASSED] 30 VFs
[12:24:23] [PASSED] 31 VFs
[12:24:23] [PASSED] 32 VFs
[12:24:23] [PASSED] 33 VFs
[12:24:23] [PASSED] 34 VFs
[12:24:23] [PASSED] 35 VFs
[12:24:23] [PASSED] 36 VFs
[12:24:23] [PASSED] 37 VFs
[12:24:23] [PASSED] 38 VFs
[12:24:23] [PASSED] 39 VFs
[12:24:23] [PASSED] 40 VFs
[12:24:23] [PASSED] 41 VFs
[12:24:23] [PASSED] 42 VFs
[12:24:23] [PASSED] 43 VFs
[12:24:23] [PASSED] 44 VFs
[12:24:23] [PASSED] 45 VFs
[12:24:23] [PASSED] 46 VFs
[12:24:23] [PASSED] 47 VFs
[12:24:23] [PASSED] 48 VFs
[12:24:23] [PASSED] 49 VFs
[12:24:23] [PASSED] 50 VFs
[12:24:23] [PASSED] 51 VFs
[12:24:23] [PASSED] 52 VFs
[12:24:23] [PASSED] 53 VFs
[12:24:23] [PASSED] 54 VFs
[12:24:23] [PASSED] 55 VFs
[12:24:23] [PASSED] 56 VFs
[12:24:23] [PASSED] 57 VFs
[12:24:23] [PASSED] 58 VFs
[12:24:23] [PASSED] 59 VFs
[12:24:23] [PASSED] 60 VFs
[12:24:23] [PASSED] 61 VFs
[12:24:23] [PASSED] 62 VFs
[12:24:23] [PASSED] 63 VFs
[12:24:23] ==================== [PASSED] fair_ggtt ====================
[12:24:23] ================== [PASSED] pf_gt_config ===================
[12:24:23] ===================== lmtt (1 subtest) =====================
[12:24:23] ======================== test_ops  =========================
[12:24:23] [PASSED] 2-level
[12:24:23] [PASSED] multi-level
[12:24:23] ==================== [PASSED] test_ops =====================
[12:24:23] ====================== [PASSED] lmtt =======================
[12:24:23] ================= pf_service (11 subtests) =================
[12:24:23] [PASSED] pf_negotiate_any
[12:24:23] [PASSED] pf_negotiate_base_match
[12:24:23] [PASSED] pf_negotiate_base_newer
[12:24:23] [PASSED] pf_negotiate_base_next
[12:24:23] [SKIPPED] pf_negotiate_base_older
[12:24:23] [PASSED] pf_negotiate_base_prev
[12:24:23] [PASSED] pf_negotiate_latest_match
[12:24:23] [PASSED] pf_negotiate_latest_newer
[12:24:23] [PASSED] pf_negotiate_latest_next
[12:24:23] [SKIPPED] pf_negotiate_latest_older
[12:24:23] [SKIPPED] pf_negotiate_latest_prev
[12:24:23] =================== [PASSED] pf_service ====================
[12:24:23] ================= xe_guc_g2g (2 subtests) ==================
[12:24:23] ============== xe_live_guc_g2g_kunit_default  ==============
[12:24:23] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ==========
[12:24:23] ============== xe_live_guc_g2g_kunit_allmem  ===============
[12:24:23] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ==========
[12:24:23] =================== [SKIPPED] xe_guc_g2g ===================
[12:24:23] =================== xe_mocs (2 subtests) ===================
[12:24:23] ================ xe_live_mocs_kernel_kunit  ================
[12:24:23] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[12:24:23] ================ xe_live_mocs_reset_kunit  =================
[12:24:23] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[12:24:23] ==================== [SKIPPED] xe_mocs =====================
[12:24:23] ================= xe_migrate (2 subtests) ==================
[12:24:23] ================= xe_migrate_sanity_kunit  =================
[12:24:23] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[12:24:23] ================== xe_validate_ccs_kunit  ==================
[12:24:23] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[12:24:23] =================== [SKIPPED] xe_migrate ===================
[12:24:23] ================== xe_dma_buf (1 subtest) ==================
[12:24:23] ==================== xe_dma_buf_kunit  =====================
[12:24:23] ================ [SKIPPED] xe_dma_buf_kunit ================
[12:24:23] =================== [SKIPPED] xe_dma_buf ===================
[12:24:23] ================= xe_bo_shrink (1 subtest) =================
[12:24:23] =================== xe_bo_shrink_kunit  ====================
[12:24:23] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[12:24:23] ================== [SKIPPED] xe_bo_shrink ==================
[12:24:23] ==================== xe_bo (2 subtests) ====================
[12:24:23] ================== xe_ccs_migrate_kunit  ===================
[12:24:23] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[12:24:23] ==================== xe_bo_evict_kunit  ====================
[12:24:23] =============== [SKIPPED] xe_bo_evict_kunit ================
[12:24:23] ===================== [SKIPPED] xe_bo ======================
[12:24:23] ==================== args (13 subtests) ====================
[12:24:23] [PASSED] count_args_test
[12:24:23] [PASSED] call_args_example
[12:24:23] [PASSED] call_args_test
[12:24:23] [PASSED] drop_first_arg_example
[12:24:23] [PASSED] drop_first_arg_test
[12:24:23] [PASSED] first_arg_example
[12:24:23] [PASSED] first_arg_test
[12:24:23] [PASSED] last_arg_example
[12:24:23] [PASSED] last_arg_test
[12:24:23] [PASSED] pick_arg_example
[12:24:23] [PASSED] if_args_example
[12:24:23] [PASSED] if_args_test
[12:24:23] [PASSED] sep_comma_example
[12:24:23] ====================== [PASSED] args =======================
[12:24:23] =================== xe_pci (3 subtests) ====================
[12:24:23] ==================== check_graphics_ip  ====================
[12:24:23] [PASSED] 12.00 Xe_LP
[12:24:23] [PASSED] 12.10 Xe_LP+
[12:24:23] [PASSED] 12.55 Xe_HPG
[12:24:23] [PASSED] 12.60 Xe_HPC
[12:24:23] [PASSED] 12.70 Xe_LPG
[12:24:23] [PASSED] 12.71 Xe_LPG
[12:24:23] [PASSED] 12.74 Xe_LPG+
[12:24:23] [PASSED] 20.01 Xe2_HPG
[12:24:23] [PASSED] 20.02 Xe2_HPG
[12:24:23] [PASSED] 20.04 Xe2_LPG
[12:24:23] [PASSED] 30.00 Xe3_LPG
[12:24:23] [PASSED] 30.01 Xe3_LPG
[12:24:23] [PASSED] 30.03 Xe3_LPG
[12:24:23] [PASSED] 30.04 Xe3_LPG
[12:24:23] [PASSED] 30.05 Xe3_LPG
[12:24:23] [PASSED] 35.11 Xe3p_XPC
[12:24:23] ================ [PASSED] check_graphics_ip ================
[12:24:23] ===================== check_media_ip  ======================
[12:24:23] [PASSED] 12.00 Xe_M
[12:24:23] [PASSED] 12.55 Xe_HPM
[12:24:23] [PASSED] 13.00 Xe_LPM+
[12:24:23] [PASSED] 13.01 Xe2_HPM
[12:24:23] [PASSED] 20.00 Xe2_LPM
[12:24:23] [PASSED] 30.00 Xe3_LPM
[12:24:23] [PASSED] 30.02 Xe3_LPM
[12:24:23] [PASSED] 35.00 Xe3p_LPM
[12:24:23] [PASSED] 35.03 Xe3p_HPM
[12:24:23] ================= [PASSED] check_media_ip ==================
[12:24:23] =================== check_platform_desc  ===================
[12:24:23] [PASSED] 0x9A60 (TIGERLAKE)
[12:24:23] [PASSED] 0x9A68 (TIGERLAKE)
[12:24:23] [PASSED] 0x9A70 (TIGERLAKE)
[12:24:23] [PASSED] 0x9A40 (TIGERLAKE)
[12:24:23] [PASSED] 0x9A49 (TIGERLAKE)
[12:24:23] [PASSED] 0x9A59 (TIGERLAKE)
[12:24:23] [PASSED] 0x9A78 (TIGERLAKE)
[12:24:23] [PASSED] 0x9AC0 (TIGERLAKE)
[12:24:23] [PASSED] 0x9AC9 (TIGERLAKE)
[12:24:23] [PASSED] 0x9AD9 (TIGERLAKE)
[12:24:23] [PASSED] 0x9AF8 (TIGERLAKE)
[12:24:23] [PASSED] 0x4C80 (ROCKETLAKE)
[12:24:23] [PASSED] 0x4C8A (ROCKETLAKE)
[12:24:23] [PASSED] 0x4C8B (ROCKETLAKE)
[12:24:23] [PASSED] 0x4C8C (ROCKETLAKE)
[12:24:23] [PASSED] 0x4C90 (ROCKETLAKE)
[12:24:23] [PASSED] 0x4C9A (ROCKETLAKE)
[12:24:23] [PASSED] 0x4680 (ALDERLAKE_S)
[12:24:23] [PASSED] 0x4682 (ALDERLAKE_S)
[12:24:23] [PASSED] 0x4688 (ALDERLAKE_S)
[12:24:23] [PASSED] 0x468A (ALDERLAKE_S)
[12:24:23] [PASSED] 0x468B (ALDERLAKE_S)
[12:24:23] [PASSED] 0x4690 (ALDERLAKE_S)
[12:24:23] [PASSED] 0x4692 (ALDERLAKE_S)
[12:24:23] [PASSED] 0x4693 (ALDERLAKE_S)
[12:24:23] [PASSED] 0x46A0 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x46A1 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x46A2 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x46A3 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x46A6 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x46A8 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x46AA (ALDERLAKE_P)
[12:24:23] [PASSED] 0x462A (ALDERLAKE_P)
[12:24:23] [PASSED] 0x4626 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x4628 (ALDERLAKE_P)
stty: 'standard input': Inappropriate ioctl for device
[12:24:23] [PASSED] 0x46B0 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x46B1 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x46B2 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x46B3 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x46C0 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x46C1 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x46C2 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x46C3 (ALDERLAKE_P)
[12:24:23] [PASSED] 0x46D0 (ALDERLAKE_N)
[12:24:23] [PASSED] 0x46D1 (ALDERLAKE_N)
[12:24:23] [PASSED] 0x46D2 (ALDERLAKE_N)
[12:24:23] [PASSED] 0x46D3 (ALDERLAKE_N)
[12:24:23] [PASSED] 0x46D4 (ALDERLAKE_N)
[12:24:23] [PASSED] 0xA721 (ALDERLAKE_P)
[12:24:23] [PASSED] 0xA7A1 (ALDERLAKE_P)
[12:24:23] [PASSED] 0xA7A9 (ALDERLAKE_P)
[12:24:23] [PASSED] 0xA7AC (ALDERLAKE_P)
[12:24:23] [PASSED] 0xA7AD (ALDERLAKE_P)
[12:24:23] [PASSED] 0xA720 (ALDERLAKE_P)
[12:24:23] [PASSED] 0xA7A0 (ALDERLAKE_P)
[12:24:23] [PASSED] 0xA7A8 (ALDERLAKE_P)
[12:24:23] [PASSED] 0xA7AA (ALDERLAKE_P)
[12:24:23] [PASSED] 0xA7AB (ALDERLAKE_P)
[12:24:23] [PASSED] 0xA780 (ALDERLAKE_S)
[12:24:23] [PASSED] 0xA781 (ALDERLAKE_S)
[12:24:23] [PASSED] 0xA782 (ALDERLAKE_S)
[12:24:23] [PASSED] 0xA783 (ALDERLAKE_S)
[12:24:23] [PASSED] 0xA788 (ALDERLAKE_S)
[12:24:23] [PASSED] 0xA789 (ALDERLAKE_S)
[12:24:23] [PASSED] 0xA78A (ALDERLAKE_S)
[12:24:23] [PASSED] 0xA78B (ALDERLAKE_S)
[12:24:23] [PASSED] 0x4905 (DG1)
[12:24:23] [PASSED] 0x4906 (DG1)
[12:24:23] [PASSED] 0x4907 (DG1)
[12:24:23] [PASSED] 0x4908 (DG1)
[12:24:23] [PASSED] 0x4909 (DG1)
[12:24:23] [PASSED] 0x56C0 (DG2)
[12:24:23] [PASSED] 0x56C2 (DG2)
[12:24:23] [PASSED] 0x56C1 (DG2)
[12:24:23] [PASSED] 0x7D51 (METEORLAKE)
[12:24:23] [PASSED] 0x7DD1 (METEORLAKE)
[12:24:23] [PASSED] 0x7D41 (METEORLAKE)
[12:24:23] [PASSED] 0x7D67 (METEORLAKE)
[12:24:23] [PASSED] 0xB640 (METEORLAKE)
[12:24:23] [PASSED] 0x56A0 (DG2)
[12:24:23] [PASSED] 0x56A1 (DG2)
[12:24:23] [PASSED] 0x56A2 (DG2)
[12:24:23] [PASSED] 0x56BE (DG2)
[12:24:23] [PASSED] 0x56BF (DG2)
[12:24:23] [PASSED] 0x5690 (DG2)
[12:24:23] [PASSED] 0x5691 (DG2)
[12:24:23] [PASSED] 0x5692 (DG2)
[12:24:23] [PASSED] 0x56A5 (DG2)
[12:24:23] [PASSED] 0x56A6 (DG2)
[12:24:23] [PASSED] 0x56B0 (DG2)
[12:24:23] [PASSED] 0x56B1 (DG2)
[12:24:23] [PASSED] 0x56BA (DG2)
[12:24:23] [PASSED] 0x56BB (DG2)
[12:24:23] [PASSED] 0x56BC (DG2)
[12:24:23] [PASSED] 0x56BD (DG2)
[12:24:23] [PASSED] 0x5693 (DG2)
[12:24:23] [PASSED] 0x5694 (DG2)
[12:24:23] [PASSED] 0x5695 (DG2)
[12:24:23] [PASSED] 0x56A3 (DG2)
[12:24:23] [PASSED] 0x56A4 (DG2)
[12:24:23] [PASSED] 0x56B2 (DG2)
[12:24:23] [PASSED] 0x56B3 (DG2)
[12:24:23] [PASSED] 0x5696 (DG2)
[12:24:23] [PASSED] 0x5697 (DG2)
[12:24:23] [PASSED] 0xB69 (PVC)
[12:24:23] [PASSED] 0xB6E (PVC)
[12:24:23] [PASSED] 0xBD4 (PVC)
[12:24:23] [PASSED] 0xBD5 (PVC)
[12:24:23] [PASSED] 0xBD6 (PVC)
[12:24:23] [PASSED] 0xBD7 (PVC)
[12:24:23] [PASSED] 0xBD8 (PVC)
[12:24:23] [PASSED] 0xBD9 (PVC)
[12:24:23] [PASSED] 0xBDA (PVC)
[12:24:23] [PASSED] 0xBDB (PVC)
[12:24:23] [PASSED] 0xBE0 (PVC)
[12:24:23] [PASSED] 0xBE1 (PVC)
[12:24:23] [PASSED] 0xBE5 (PVC)
[12:24:23] [PASSED] 0x7D40 (METEORLAKE)
[12:24:23] [PASSED] 0x7D45 (METEORLAKE)
[12:24:23] [PASSED] 0x7D55 (METEORLAKE)
[12:24:23] [PASSED] 0x7D60 (METEORLAKE)
[12:24:23] [PASSED] 0x7DD5 (METEORLAKE)
[12:24:23] [PASSED] 0x6420 (LUNARLAKE)
[12:24:23] [PASSED] 0x64A0 (LUNARLAKE)
[12:24:23] [PASSED] 0x64B0 (LUNARLAKE)
[12:24:23] [PASSED] 0xE202 (BATTLEMAGE)
[12:24:23] [PASSED] 0xE209 (BATTLEMAGE)
[12:24:23] [PASSED] 0xE20B (BATTLEMAGE)
[12:24:23] [PASSED] 0xE20C (BATTLEMAGE)
[12:24:23] [PASSED] 0xE20D (BATTLEMAGE)
[12:24:23] [PASSED] 0xE210 (BATTLEMAGE)
[12:24:23] [PASSED] 0xE211 (BATTLEMAGE)
[12:24:23] [PASSED] 0xE212 (BATTLEMAGE)
[12:24:23] [PASSED] 0xE216 (BATTLEMAGE)
[12:24:23] [PASSED] 0xE220 (BATTLEMAGE)
[12:24:23] [PASSED] 0xE221 (BATTLEMAGE)
[12:24:23] [PASSED] 0xE222 (BATTLEMAGE)
[12:24:23] [PASSED] 0xE223 (BATTLEMAGE)
[12:24:23] [PASSED] 0xB080 (PANTHERLAKE)
[12:24:23] [PASSED] 0xB081 (PANTHERLAKE)
[12:24:23] [PASSED] 0xB082 (PANTHERLAKE)
[12:24:23] [PASSED] 0xB083 (PANTHERLAKE)
[12:24:23] [PASSED] 0xB084 (PANTHERLAKE)
[12:24:23] [PASSED] 0xB085 (PANTHERLAKE)
[12:24:23] [PASSED] 0xB086 (PANTHERLAKE)
[12:24:23] [PASSED] 0xB087 (PANTHERLAKE)
[12:24:23] [PASSED] 0xB08F (PANTHERLAKE)
[12:24:23] [PASSED] 0xB090 (PANTHERLAKE)
[12:24:23] [PASSED] 0xB0A0 (PANTHERLAKE)
[12:24:23] [PASSED] 0xB0B0 (PANTHERLAKE)
[12:24:23] [PASSED] 0xFD80 (PANTHERLAKE)
[12:24:23] [PASSED] 0xFD81 (PANTHERLAKE)
[12:24:23] [PASSED] 0xD740 (NOVALAKE_S)
[12:24:23] [PASSED] 0xD741 (NOVALAKE_S)
[12:24:23] [PASSED] 0xD742 (NOVALAKE_S)
[12:24:23] [PASSED] 0xD743 (NOVALAKE_S)
[12:24:23] [PASSED] 0xD744 (NOVALAKE_S)
[12:24:23] [PASSED] 0xD745 (NOVALAKE_S)
[12:24:23] [PASSED] 0x674C (CRESCENTISLAND)
[12:24:23] =============== [PASSED] check_platform_desc ===============
[12:24:23] ===================== [PASSED] xe_pci ======================
[12:24:23] =================== xe_rtp (2 subtests) ====================
[12:24:23] =============== xe_rtp_process_to_sr_tests  ================
[12:24:23] [PASSED] coalesce-same-reg
[12:24:23] [PASSED] no-match-no-add
[12:24:23] [PASSED] match-or
[12:24:23] [PASSED] match-or-xfail
[12:24:23] [PASSED] no-match-no-add-multiple-rules
[12:24:23] [PASSED] two-regs-two-entries
[12:24:23] [PASSED] clr-one-set-other
[12:24:23] [PASSED] set-field
[12:24:23] [PASSED] conflict-duplicate
[12:24:23] [PASSED] conflict-not-disjoint
[12:24:23] [PASSED] conflict-reg-type
[12:24:23] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[12:24:23] ================== xe_rtp_process_tests  ===================
[12:24:23] [PASSED] active1
[12:24:23] [PASSED] active2
[12:24:23] [PASSED] active-inactive
[12:24:23] [PASSED] inactive-active
[12:24:23] [PASSED] inactive-1st_or_active-inactive
[12:24:23] [PASSED] inactive-2nd_or_active-inactive
[12:24:23] [PASSED] inactive-last_or_active-inactive
[12:24:23] [PASSED] inactive-no_or_active-inactive
[12:24:23] ============== [PASSED] xe_rtp_process_tests ===============
[12:24:23] ===================== [PASSED] xe_rtp ======================
[12:24:23] ==================== xe_wa (1 subtest) =====================
[12:24:23] ======================== xe_wa_gt  =========================
[12:24:23] [PASSED] TIGERLAKE B0
[12:24:23] [PASSED] DG1 A0
[12:24:23] [PASSED] DG1 B0
[12:24:23] [PASSED] ALDERLAKE_S A0
[12:24:23] [PASSED] ALDERLAKE_S B0
[12:24:23] [PASSED] ALDERLAKE_S C0
[12:24:23] [PASSED] ALDERLAKE_S D0
[12:24:23] [PASSED] ALDERLAKE_P A0
[12:24:23] [PASSED] ALDERLAKE_P B0
[12:24:23] [PASSED] ALDERLAKE_P C0
[12:24:23] [PASSED] ALDERLAKE_S RPLS D0
[12:24:23] [PASSED] ALDERLAKE_P RPLU E0
[12:24:23] [PASSED] DG2 G10 C0
[12:24:23] [PASSED] DG2 G11 B1
[12:24:23] [PASSED] DG2 G12 A1
[12:24:23] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0
[12:24:23] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0
[12:24:23] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0
[12:24:23] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0
[12:24:23] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0
[12:24:23] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1
[12:24:23] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0
[12:24:23] ==================== [PASSED] xe_wa_gt =====================
[12:24:23] ====================== [PASSED] xe_wa ======================
[12:24:23] ============================================================
[12:24:23] Testing complete. Ran 512 tests: passed: 494, skipped: 18
[12:24:23] Elapsed time: 43.904s total, 4.308s configuring, 39.079s building, 0.487s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [12:24:23] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[12:24:25] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=25
[12:24:55] Starting KUnit Kernel (1/1)...
[12:24:55] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:24:55] ============ drm_test_pick_cmdline (2 subtests) ============
[12:24:55] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[12:24:55] =============== drm_test_pick_cmdline_named  ===============
[12:24:55] [PASSED] NTSC
[12:24:55] [PASSED] NTSC-J
[12:24:55] [PASSED] PAL
[12:24:55] [PASSED] PAL-M
[12:24:55] =========== [PASSED] drm_test_pick_cmdline_named ===========
[12:24:55] ============== [PASSED] drm_test_pick_cmdline ==============
[12:24:55] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[12:24:55] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[12:24:55] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[12:24:55] =========== drm_validate_clone_mode (2 subtests) ===========
[12:24:55] ============== drm_test_check_in_clone_mode  ===============
[12:24:55] [PASSED] in_clone_mode
[12:24:55] [PASSED] not_in_clone_mode
[12:24:55] ========== [PASSED] drm_test_check_in_clone_mode ===========
[12:24:55] =============== drm_test_check_valid_clones  ===============
[12:24:55] [PASSED] not_in_clone_mode
[12:24:55] [PASSED] valid_clone
[12:24:55] [PASSED] invalid_clone
[12:24:55] =========== [PASSED] drm_test_check_valid_clones ===========
[12:24:55] ============= [PASSED] drm_validate_clone_mode =============
[12:24:55] ============= drm_validate_modeset (1 subtest) =============
[12:24:55] [PASSED] drm_test_check_connector_changed_modeset
[12:24:55] ============== [PASSED] drm_validate_modeset ===============
[12:24:55] ====== drm_test_bridge_get_current_state (2 subtests) ======
[12:24:55] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[12:24:55] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[12:24:55] ======== [PASSED] drm_test_bridge_get_current_state ========
[12:24:55] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[12:24:55] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[12:24:55] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[12:24:55] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[12:24:55] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[12:24:55] ============== drm_bridge_alloc (2 subtests) ===============
[12:24:55] [PASSED] drm_test_drm_bridge_alloc_basic
[12:24:55] [PASSED] drm_test_drm_bridge_alloc_get_put
[12:24:55] ================ [PASSED] drm_bridge_alloc =================
[12:24:55] ================== drm_buddy (8 subtests) ==================
[12:24:55] [PASSED] drm_test_buddy_alloc_limit
[12:24:55] [PASSED] drm_test_buddy_alloc_optimistic
[12:24:55] [PASSED] drm_test_buddy_alloc_pessimistic
[12:24:55] [PASSED] drm_test_buddy_alloc_pathological
[12:24:55] [PASSED] drm_test_buddy_alloc_contiguous
[12:24:55] [PASSED] drm_test_buddy_alloc_clear
[12:24:55] [PASSED] drm_test_buddy_alloc_range_bias
[12:24:55] [PASSED] drm_test_buddy_fragmentation_performance
[12:24:55] ==================== [PASSED] drm_buddy ====================
[12:24:55] ============= drm_cmdline_parser (40 subtests) =============
[12:24:55] [PASSED] drm_test_cmdline_force_d_only
[12:24:55] [PASSED] drm_test_cmdline_force_D_only_dvi
[12:24:55] [PASSED] drm_test_cmdline_force_D_only_hdmi
[12:24:55] [PASSED] drm_test_cmdline_force_D_only_not_digital
[12:24:55] [PASSED] drm_test_cmdline_force_e_only
[12:24:55] [PASSED] drm_test_cmdline_res
[12:24:55] [PASSED] drm_test_cmdline_res_vesa
[12:24:55] [PASSED] drm_test_cmdline_res_vesa_rblank
[12:24:55] [PASSED] drm_test_cmdline_res_rblank
[12:24:55] [PASSED] drm_test_cmdline_res_bpp
[12:24:55] [PASSED] drm_test_cmdline_res_refresh
[12:24:55] [PASSED] drm_test_cmdline_res_bpp_refresh
[12:24:55] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[12:24:55] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[12:24:55] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[12:24:55] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[12:24:55] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[12:24:55] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[12:24:55] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[12:24:55] [PASSED] drm_test_cmdline_res_margins_force_on
[12:24:55] [PASSED] drm_test_cmdline_res_vesa_margins
[12:24:55] [PASSED] drm_test_cmdline_name
[12:24:55] [PASSED] drm_test_cmdline_name_bpp
[12:24:55] [PASSED] drm_test_cmdline_name_option
[12:24:55] [PASSED] drm_test_cmdline_name_bpp_option
[12:24:55] [PASSED] drm_test_cmdline_rotate_0
[12:24:55] [PASSED] drm_test_cmdline_rotate_90
[12:24:55] [PASSED] drm_test_cmdline_rotate_180
[12:24:55] [PASSED] drm_test_cmdline_rotate_270
[12:24:55] [PASSED] drm_test_cmdline_hmirror
[12:24:55] [PASSED] drm_test_cmdline_vmirror
[12:24:55] [PASSED] drm_test_cmdline_margin_options
[12:24:55] [PASSED] drm_test_cmdline_multiple_options
[12:24:55] [PASSED] drm_test_cmdline_bpp_extra_and_option
[12:24:55] [PASSED] drm_test_cmdline_extra_and_option
[12:24:55] [PASSED] drm_test_cmdline_freestanding_options
[12:24:55] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[12:24:55] [PASSED] drm_test_cmdline_panel_orientation
[12:24:55] ================ drm_test_cmdline_invalid  =================
[12:24:55] [PASSED] margin_only
[12:24:55] [PASSED] interlace_only
[12:24:55] [PASSED] res_missing_x
[12:24:55] [PASSED] res_missing_y
[12:24:55] [PASSED] res_bad_y
[12:24:55] [PASSED] res_missing_y_bpp
[12:24:55] [PASSED] res_bad_bpp
[12:24:55] [PASSED] res_bad_refresh
[12:24:55] [PASSED] res_bpp_refresh_force_on_off
[12:24:55] [PASSED] res_invalid_mode
[12:24:55] [PASSED] res_bpp_wrong_place_mode
[12:24:55] [PASSED] name_bpp_refresh
[12:24:55] [PASSED] name_refresh
[12:24:55] [PASSED] name_refresh_wrong_mode
[12:24:55] [PASSED] name_refresh_invalid_mode
[12:24:55] [PASSED] rotate_multiple
[12:24:55] [PASSED] rotate_invalid_val
[12:24:55] [PASSED] rotate_truncated
[12:24:55] [PASSED] invalid_option
[12:24:55] [PASSED] invalid_tv_option
[12:24:55] [PASSED] truncated_tv_option
[12:24:55] ============ [PASSED] drm_test_cmdline_invalid =============
[12:24:55] =============== drm_test_cmdline_tv_options  ===============
[12:24:55] [PASSED] NTSC
[12:24:55] [PASSED] NTSC_443
[12:24:55] [PASSED] NTSC_J
[12:24:55] [PASSED] PAL
[12:24:55] [PASSED] PAL_M
[12:24:55] [PASSED] PAL_N
[12:24:55] [PASSED] SECAM
[12:24:55] [PASSED] MONO_525
[12:24:55] [PASSED] MONO_625
[12:24:55] =========== [PASSED] drm_test_cmdline_tv_options ===========
[12:24:55] =============== [PASSED] drm_cmdline_parser ================
[12:24:55] ========== drmm_connector_hdmi_init (20 subtests) ==========
[12:24:55] [PASSED] drm_test_connector_hdmi_init_valid
[12:24:55] [PASSED] drm_test_connector_hdmi_init_bpc_8
[12:24:55] [PASSED] drm_test_connector_hdmi_init_bpc_10
[12:24:55] [PASSED] drm_test_connector_hdmi_init_bpc_12
[12:24:55] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[12:24:55] [PASSED] drm_test_connector_hdmi_init_bpc_null
[12:24:55] [PASSED] drm_test_connector_hdmi_init_formats_empty
[12:24:55] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[12:24:55] === drm_test_connector_hdmi_init_formats_yuv420_allowed  ===
[12:24:55] [PASSED] supported_formats=0x9 yuv420_allowed=1
[12:24:55] [PASSED] supported_formats=0x9 yuv420_allowed=0
[12:24:55] [PASSED] supported_formats=0x3 yuv420_allowed=1
[12:24:55] [PASSED] supported_formats=0x3 yuv420_allowed=0
[12:24:55] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[12:24:55] [PASSED] drm_test_connector_hdmi_init_null_ddc
[12:24:55] [PASSED] drm_test_connector_hdmi_init_null_product
[12:24:55] [PASSED] drm_test_connector_hdmi_init_null_vendor
[12:24:55] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[12:24:55] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[12:24:55] [PASSED] drm_test_connector_hdmi_init_product_valid
[12:24:55] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[12:24:55] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[12:24:55] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[12:24:55] ========= drm_test_connector_hdmi_init_type_valid  =========
[12:24:55] [PASSED] HDMI-A
[12:24:55] [PASSED] HDMI-B
[12:24:55] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[12:24:55] ======== drm_test_connector_hdmi_init_type_invalid  ========
[12:24:55] [PASSED] Unknown
[12:24:55] [PASSED] VGA
[12:24:55] [PASSED] DVI-I
[12:24:55] [PASSED] DVI-D
[12:24:55] [PASSED] DVI-A
[12:24:55] [PASSED] Composite
[12:24:55] [PASSED] SVIDEO
[12:24:55] [PASSED] LVDS
[12:24:55] [PASSED] Component
[12:24:55] [PASSED] DIN
[12:24:55] [PASSED] DP
[12:24:55] [PASSED] TV
[12:24:55] [PASSED] eDP
[12:24:55] [PASSED] Virtual
[12:24:55] [PASSED] DSI
[12:24:55] [PASSED] DPI
[12:24:55] [PASSED] Writeback
[12:24:55] [PASSED] SPI
[12:24:55] [PASSED] USB
[12:24:55] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[12:24:55] ============ [PASSED] drmm_connector_hdmi_init =============
[12:24:55] ============= drmm_connector_init (3 subtests) =============
[12:24:55] [PASSED] drm_test_drmm_connector_init
[12:24:55] [PASSED] drm_test_drmm_connector_init_null_ddc
[12:24:55] ========= drm_test_drmm_connector_init_type_valid  =========
[12:24:55] [PASSED] Unknown
[12:24:55] [PASSED] VGA
[12:24:55] [PASSED] DVI-I
[12:24:55] [PASSED] DVI-D
[12:24:55] [PASSED] DVI-A
[12:24:55] [PASSED] Composite
[12:24:55] [PASSED] SVIDEO
[12:24:55] [PASSED] LVDS
[12:24:55] [PASSED] Component
[12:24:55] [PASSED] DIN
[12:24:55] [PASSED] DP
[12:24:55] [PASSED] HDMI-A
[12:24:55] [PASSED] HDMI-B
[12:24:55] [PASSED] TV
[12:24:55] [PASSED] eDP
[12:24:55] [PASSED] Virtual
[12:24:55] [PASSED] DSI
[12:24:55] [PASSED] DPI
[12:24:55] [PASSED] Writeback
[12:24:55] [PASSED] SPI
[12:24:55] [PASSED] USB
[12:24:55] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[12:24:55] =============== [PASSED] drmm_connector_init ===============
[12:24:55] ========= drm_connector_dynamic_init (6 subtests) ==========
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_init
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_init_properties
[12:24:55] ===== drm_test_drm_connector_dynamic_init_type_valid  ======
[12:24:55] [PASSED] Unknown
[12:24:55] [PASSED] VGA
[12:24:55] [PASSED] DVI-I
[12:24:55] [PASSED] DVI-D
[12:24:55] [PASSED] DVI-A
[12:24:55] [PASSED] Composite
[12:24:55] [PASSED] SVIDEO
[12:24:55] [PASSED] LVDS
[12:24:55] [PASSED] Component
[12:24:55] [PASSED] DIN
[12:24:55] [PASSED] DP
[12:24:55] [PASSED] HDMI-A
[12:24:55] [PASSED] HDMI-B
[12:24:55] [PASSED] TV
[12:24:55] [PASSED] eDP
[12:24:55] [PASSED] Virtual
[12:24:55] [PASSED] DSI
[12:24:55] [PASSED] DPI
[12:24:55] [PASSED] Writeback
[12:24:55] [PASSED] SPI
[12:24:55] [PASSED] USB
[12:24:55] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[12:24:55] ======== drm_test_drm_connector_dynamic_init_name  =========
[12:24:55] [PASSED] Unknown
[12:24:55] [PASSED] VGA
[12:24:55] [PASSED] DVI-I
[12:24:55] [PASSED] DVI-D
[12:24:55] [PASSED] DVI-A
[12:24:55] [PASSED] Composite
[12:24:55] [PASSED] SVIDEO
[12:24:55] [PASSED] LVDS
[12:24:55] [PASSED] Component
[12:24:55] [PASSED] DIN
[12:24:55] [PASSED] DP
[12:24:55] [PASSED] HDMI-A
[12:24:55] [PASSED] HDMI-B
[12:24:55] [PASSED] TV
[12:24:55] [PASSED] eDP
[12:24:55] [PASSED] Virtual
[12:24:55] [PASSED] DSI
[12:24:55] [PASSED] DPI
[12:24:55] [PASSED] Writeback
[12:24:55] [PASSED] SPI
[12:24:55] [PASSED] USB
[12:24:55] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[12:24:55] =========== [PASSED] drm_connector_dynamic_init ============
[12:24:55] ==== drm_connector_dynamic_register_early (4 subtests) =====
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[12:24:55] ====== [PASSED] drm_connector_dynamic_register_early =======
[12:24:55] ======= drm_connector_dynamic_register (7 subtests) ========
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[12:24:55] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[12:24:55] ========= [PASSED] drm_connector_dynamic_register ==========
[12:24:55] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[12:24:55] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[12:24:55] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[12:24:55] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[12:24:55] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[12:24:55] ========== drm_test_get_tv_mode_from_name_valid  ===========
[12:24:55] [PASSED] NTSC
[12:24:55] [PASSED] NTSC-443
[12:24:55] [PASSED] NTSC-J
[12:24:55] [PASSED] PAL
[12:24:55] [PASSED] PAL-M
[12:24:55] [PASSED] PAL-N
[12:24:55] [PASSED] SECAM
[12:24:55] [PASSED] Mono
[12:24:55] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[12:24:55] [PASSED] drm_test_get_tv_mode_from_name_truncated
[12:24:55] ============ [PASSED] drm_get_tv_mode_from_name ============
[12:24:55] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[12:24:55] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[12:24:55] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[12:24:55] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[12:24:55] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[12:24:55] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[12:24:55] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[12:24:55] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid  =
[12:24:55] [PASSED] VIC 96
[12:24:55] [PASSED] VIC 97
[12:24:55] [PASSED] VIC 101
[12:24:55] [PASSED] VIC 102
[12:24:55] [PASSED] VIC 106
[12:24:55] [PASSED] VIC 107
[12:24:55] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[12:24:55] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[12:24:55] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[12:24:55] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[12:24:55] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[12:24:55] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[12:24:55] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[12:24:55] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[12:24:55] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name  ====
[12:24:55] [PASSED] Automatic
[12:24:55] [PASSED] Full
[12:24:55] [PASSED] Limited 16:235
[12:24:55] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[12:24:55] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[12:24:55] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[12:24:55] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[12:24:55] === drm_test_drm_hdmi_connector_get_output_format_name  ====
[12:24:55] [PASSED] RGB
[12:24:55] [PASSED] YUV 4:2:0
[12:24:55] [PASSED] YUV 4:2:2
[12:24:55] [PASSED] YUV 4:4:4
[12:24:55] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[12:24:55] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[12:24:55] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[12:24:55] ============= drm_damage_helper (21 subtests) ==============
[12:24:55] [PASSED] drm_test_damage_iter_no_damage
[12:24:55] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[12:24:55] [PASSED] drm_test_damage_iter_no_damage_src_moved
[12:24:55] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[12:24:55] [PASSED] drm_test_damage_iter_no_damage_not_visible
[12:24:55] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[12:24:55] [PASSED] drm_test_damage_iter_no_damage_no_fb
[12:24:55] [PASSED] drm_test_damage_iter_simple_damage
[12:24:55] [PASSED] drm_test_damage_iter_single_damage
[12:24:55] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[12:24:55] [PASSED] drm_test_damage_iter_single_damage_outside_src
[12:24:55] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[12:24:55] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[12:24:55] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[12:24:55] [PASSED] drm_test_damage_iter_single_damage_src_moved
[12:24:55] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[12:24:55] [PASSED] drm_test_damage_iter_damage
[12:24:55] [PASSED] drm_test_damage_iter_damage_one_intersect
[12:24:55] [PASSED] drm_test_damage_iter_damage_one_outside
[12:24:55] [PASSED] drm_test_damage_iter_damage_src_moved
[12:24:55] [PASSED] drm_test_damage_iter_damage_not_visible
[12:24:55] ================ [PASSED] drm_damage_helper ================
[12:24:55] ============== drm_dp_mst_helper (3 subtests) ==============
[12:24:55] ============== drm_test_dp_mst_calc_pbn_mode  ==============
[12:24:55] [PASSED] Clock 154000 BPP 30 DSC disabled
[12:24:55] [PASSED] Clock 234000 BPP 30 DSC disabled
[12:24:55] [PASSED] Clock 297000 BPP 24 DSC disabled
[12:24:55] [PASSED] Clock 332880 BPP 24 DSC enabled
[12:24:55] [PASSED] Clock 324540 BPP 24 DSC enabled
[12:24:55] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[12:24:55] ============== drm_test_dp_mst_calc_pbn_div  ===============
[12:24:55] [PASSED] Link rate 2000000 lane count 4
[12:24:55] [PASSED] Link rate 2000000 lane count 2
[12:24:55] [PASSED] Link rate 2000000 lane count 1
[12:24:55] [PASSED] Link rate 1350000 lane count 4
[12:24:55] [PASSED] Link rate 1350000 lane count 2
[12:24:55] [PASSED] Link rate 1350000 lane count 1
[12:24:55] [PASSED] Link rate 1000000 lane count 4
[12:24:55] [PASSED] Link rate 1000000 lane count 2
[12:24:55] [PASSED] Link rate 1000000 lane count 1
[12:24:55] [PASSED] Link rate 810000 lane count 4
[12:24:55] [PASSED] Link rate 810000 lane count 2
[12:24:55] [PASSED] Link rate 810000 lane count 1
[12:24:55] [PASSED] Link rate 540000 lane count 4
[12:24:55] [PASSED] Link rate 540000 lane count 2
[12:24:55] [PASSED] Link rate 540000 lane count 1
[12:24:55] [PASSED] Link rate 270000 lane count 4
[12:24:55] [PASSED] Link rate 270000 lane count 2
[12:24:55] [PASSED] Link rate 270000 lane count 1
[12:24:55] [PASSED] Link rate 162000 lane count 4
[12:24:55] [PASSED] Link rate 162000 lane count 2
[12:24:55] [PASSED] Link rate 162000 lane count 1
[12:24:55] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[12:24:55] ========= drm_test_dp_mst_sideband_msg_req_decode  =========
[12:24:55] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[12:24:55] [PASSED] DP_POWER_UP_PHY with port number
[12:24:55] [PASSED] DP_POWER_DOWN_PHY with port number
[12:24:55] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[12:24:55] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[12:24:55] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[12:24:55] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[12:24:55] [PASSED] DP_QUERY_PAYLOAD with port number
[12:24:55] [PASSED] DP_QUERY_PAYLOAD with VCPI
[12:24:55] [PASSED] DP_REMOTE_DPCD_READ with port number
[12:24:55] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[12:24:55] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[12:24:55] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[12:24:55] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[12:24:55] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[12:24:55] [PASSED] DP_REMOTE_I2C_READ with port number
[12:24:55] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[12:24:55] [PASSED] DP_REMOTE_I2C_READ with transactions array
[12:24:55] [PASSED] DP_REMOTE_I2C_WRITE with port number
[12:24:55] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[12:24:55] [PASSED] DP_REMOTE_I2C_WRITE with data array
[12:24:55] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[12:24:55] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[12:24:55] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[12:24:55] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[12:24:55] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[12:24:55] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[12:24:55] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[12:24:55] ================ [PASSED] drm_dp_mst_helper ================
[12:24:55] ================== drm_exec (7 subtests) ===================
[12:24:55] [PASSED] sanitycheck
[12:24:55] [PASSED] test_lock
[12:24:55] [PASSED] test_lock_unlock
[12:24:55] [PASSED] test_duplicates
[12:24:55] [PASSED] test_prepare
[12:24:55] [PASSED] test_prepare_array
[12:24:55] [PASSED] test_multiple_loops
[12:24:55] ==================== [PASSED] drm_exec =====================
[12:24:55] =========== drm_format_helper_test (17 subtests) ===========
[12:24:55] ============== drm_test_fb_xrgb8888_to_gray8  ==============
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[12:24:55] ============= drm_test_fb_xrgb8888_to_rgb332  ==============
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[12:24:55] ============= drm_test_fb_xrgb8888_to_rgb565  ==============
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[12:24:55] ============ drm_test_fb_xrgb8888_to_xrgb1555  =============
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[12:24:55] ============ drm_test_fb_xrgb8888_to_argb1555  =============
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[12:24:55] ============ drm_test_fb_xrgb8888_to_rgba5551  =============
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[12:24:55] ============= drm_test_fb_xrgb8888_to_rgb888  ==============
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[12:24:55] ============= drm_test_fb_xrgb8888_to_bgr888  ==============
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[12:24:55] ============ drm_test_fb_xrgb8888_to_argb8888  =============
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[12:24:55] =========== drm_test_fb_xrgb8888_to_xrgb2101010  ===========
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[12:24:55] =========== drm_test_fb_xrgb8888_to_argb2101010  ===========
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[12:24:55] ============== drm_test_fb_xrgb8888_to_mono  ===============
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[12:24:55] ==================== drm_test_fb_swab  =====================
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ================ [PASSED] drm_test_fb_swab =================
[12:24:55] ============ drm_test_fb_xrgb8888_to_xbgr8888  =============
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[12:24:55] ============ drm_test_fb_xrgb8888_to_abgr8888  =============
[12:24:55] [PASSED] single_pixel_source_buffer
[12:24:55] [PASSED] single_pixel_clip_rectangle
[12:24:55] [PASSED] well_known_colors
[12:24:55] [PASSED] destination_pitch
[12:24:55] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[12:24:55] ================= drm_test_fb_clip_offset  =================
[12:24:55] [PASSED] pass through
[12:24:55] [PASSED] horizontal offset
[12:24:55] [PASSED] vertical offset
[12:24:55] [PASSED] horizontal and vertical offset
[12:24:55] [PASSED] horizontal offset (custom pitch)
[12:24:55] [PASSED] vertical offset (custom pitch)
[12:24:55] [PASSED] horizontal and vertical offset (custom pitch)
[12:24:55] ============= [PASSED] drm_test_fb_clip_offset =============
[12:24:55] =================== drm_test_fb_memcpy  ====================
[12:24:55] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[12:24:55] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[12:24:55] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[12:24:55] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[12:24:55] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[12:24:55] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[12:24:55] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[12:24:55] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[12:24:55] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[12:24:55] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[12:24:55] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[12:24:55] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[12:24:55] =============== [PASSED] drm_test_fb_memcpy ================
[12:24:55] ============= [PASSED] drm_format_helper_test ==============
[12:24:55] ================= drm_format (18 subtests) =================
[12:24:55] [PASSED] drm_test_format_block_width_invalid
[12:24:55] [PASSED] drm_test_format_block_width_one_plane
[12:24:55] [PASSED] drm_test_format_block_width_two_plane
[12:24:55] [PASSED] drm_test_format_block_width_three_plane
[12:24:55] [PASSED] drm_test_format_block_width_tiled
[12:24:55] [PASSED] drm_test_format_block_height_invalid
[12:24:55] [PASSED] drm_test_format_block_height_one_plane
[12:24:55] [PASSED] drm_test_format_block_height_two_plane
[12:24:55] [PASSED] drm_test_format_block_height_three_plane
[12:24:55] [PASSED] drm_test_format_block_height_tiled
[12:24:55] [PASSED] drm_test_format_min_pitch_invalid
[12:24:55] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[12:24:55] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[12:24:55] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[12:24:55] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[12:24:55] [PASSED] drm_test_format_min_pitch_two_plane
[12:24:55] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[12:24:55] [PASSED] drm_test_format_min_pitch_tiled
[12:24:55] =================== [PASSED] drm_format ====================
[12:24:55] ============== drm_framebuffer (10 subtests) ===============
[12:24:55] ========== drm_test_framebuffer_check_src_coords  ==========
[12:24:55] [PASSED] Success: source fits into fb
[12:24:55] [PASSED] Fail: overflowing fb with x-axis coordinate
[12:24:55] [PASSED] Fail: overflowing fb with y-axis coordinate
[12:24:55] [PASSED] Fail: overflowing fb with source width
[12:24:55] [PASSED] Fail: overflowing fb with source height
[12:24:55] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[12:24:55] [PASSED] drm_test_framebuffer_cleanup
[12:24:55] =============== drm_test_framebuffer_create  ===============
[12:24:55] [PASSED] ABGR8888 normal sizes
[12:24:55] [PASSED] ABGR8888 max sizes
[12:24:55] [PASSED] ABGR8888 pitch greater than min required
[12:24:55] [PASSED] ABGR8888 pitch less than min required
[12:24:55] [PASSED] ABGR8888 Invalid width
[12:24:55] [PASSED] ABGR8888 Invalid buffer handle
[12:24:55] [PASSED] No pixel format
[12:24:55] [PASSED] ABGR8888 Width 0
[12:24:55] [PASSED] ABGR8888 Height 0
[12:24:55] [PASSED] ABGR8888 Out of bound height * pitch combination
[12:24:55] [PASSED] ABGR8888 Large buffer offset
[12:24:55] [PASSED] ABGR8888 Buffer offset for inexistent plane
[12:24:55] [PASSED] ABGR8888 Invalid flag
[12:24:55] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[12:24:55] [PASSED] ABGR8888 Valid buffer modifier
[12:24:55] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[12:24:55] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[12:24:55] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[12:24:55] [PASSED] NV12 Normal sizes
[12:24:55] [PASSED] NV12 Max sizes
[12:24:55] [PASSED] NV12 Invalid pitch
[12:24:55] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[12:24:55] [PASSED] NV12 different  modifier per-plane
[12:24:55] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[12:24:55] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[12:24:55] [PASSED] NV12 Modifier for inexistent plane
[12:24:55] [PASSED] NV12 Handle for inexistent plane
[12:24:55] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[12:24:55] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[12:24:55] [PASSED] YVU420 Normal sizes
[12:24:55] [PASSED] YVU420 Max sizes
[12:24:55] [PASSED] YVU420 Invalid pitch
[12:24:55] [PASSED] YVU420 Different pitches
[12:24:55] [PASSED] YVU420 Different buffer offsets/pitches
[12:24:55] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[12:24:55] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[12:24:55] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[12:24:55] [PASSED] YVU420 Valid modifier
[12:24:55] [PASSED] YVU420 Different modifiers per plane
[12:24:55] [PASSED] YVU420 Modifier for inexistent plane
[12:24:55] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[12:24:55] [PASSED] X0L2 Normal sizes
[12:24:55] [PASSED] X0L2 Max sizes
[12:24:55] [PASSED] X0L2 Invalid pitch
[12:24:55] [PASSED] X0L2 Pitch greater than minimum required
[12:24:55] [PASSED] X0L2 Handle for inexistent plane
[12:24:55] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[12:24:55] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[12:24:55] [PASSED] X0L2 Valid modifier
[12:24:55] [PASSED] X0L2 Modifier for inexistent plane
[12:24:55] =========== [PASSED] drm_test_framebuffer_create ===========
[12:24:55] [PASSED] drm_test_framebuffer_free
[12:24:55] [PASSED] drm_test_framebuffer_init
[12:24:55] [PASSED] drm_test_framebuffer_init_bad_format
[12:24:55] [PASSED] drm_test_framebuffer_init_dev_mismatch
[12:24:55] [PASSED] drm_test_framebuffer_lookup
[12:24:55] [PASSED] drm_test_framebuffer_lookup_inexistent
[12:24:55] [PASSED] drm_test_framebuffer_modifiers_not_supported
[12:24:55] ================= [PASSED] drm_framebuffer =================
[12:24:55] ================ drm_gem_shmem (8 subtests) ================
[12:24:55] [PASSED] drm_gem_shmem_test_obj_create
[12:24:55] [PASSED] drm_gem_shmem_test_obj_create_private
[12:24:55] [PASSED] drm_gem_shmem_test_pin_pages
[12:24:55] [PASSED] drm_gem_shmem_test_vmap
[12:24:55] [PASSED] drm_gem_shmem_test_get_sg_table
[12:24:55] [PASSED] drm_gem_shmem_test_get_pages_sgt
[12:24:55] [PASSED] drm_gem_shmem_test_madvise
[12:24:55] [PASSED] drm_gem_shmem_test_purge
[12:24:55] ================== [PASSED] drm_gem_shmem ==================
[12:24:55] === drm_atomic_helper_connector_hdmi_check (27 subtests) ===
[12:24:55] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[12:24:55] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[12:24:55] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[12:24:55] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[12:24:55] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[12:24:55] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[12:24:55] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420  =======
[12:24:55] [PASSED] Automatic
[12:24:55] [PASSED] Full
[12:24:55] [PASSED] Limited 16:235
[12:24:55] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[12:24:55] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[12:24:55] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[12:24:55] [PASSED] drm_test_check_disable_connector
[12:24:55] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[12:24:55] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[12:24:55] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[12:24:55] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[12:24:55] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[12:24:55] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[12:24:55] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[12:24:55] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[12:24:55] [PASSED] drm_test_check_output_bpc_dvi
[12:24:55] [PASSED] drm_test_check_output_bpc_format_vic_1
[12:24:55] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[12:24:55] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[12:24:55] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[12:24:55] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[12:24:55] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[12:24:55] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[12:24:55] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[12:24:55] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[12:24:55] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[12:24:55] [PASSED] drm_test_check_broadcast_rgb_value
[12:24:55] [PASSED] drm_test_check_bpc_8_value
[12:24:55] [PASSED] drm_test_check_bpc_10_value
[12:24:55] [PASSED] drm_test_check_bpc_12_value
[12:24:55] [PASSED] drm_test_check_format_value
[12:24:55] [PASSED] drm_test_check_tmds_char_value
[12:24:55] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[12:24:55] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[12:24:55] [PASSED] drm_test_check_mode_valid
[12:24:55] [PASSED] drm_test_check_mode_valid_reject
[12:24:55] [PASSED] drm_test_check_mode_valid_reject_rate
[12:24:55] [PASSED] drm_test_check_mode_valid_reject_max_clock
[12:24:55] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[12:24:55] ================= drm_managed (2 subtests) =================
[12:24:55] [PASSED] drm_test_managed_release_action
[12:24:55] [PASSED] drm_test_managed_run_action
[12:24:55] =================== [PASSED] drm_managed ===================
[12:24:55] =================== drm_mm (6 subtests) ====================
[12:24:55] [PASSED] drm_test_mm_init
[12:24:55] [PASSED] drm_test_mm_debug
[12:24:55] [PASSED] drm_test_mm_align32
[12:24:55] [PASSED] drm_test_mm_align64
[12:24:55] [PASSED] drm_test_mm_lowest
[12:24:55] [PASSED] drm_test_mm_highest
[12:24:55] ===================== [PASSED] drm_mm ======================
[12:24:55] ============= drm_modes_analog_tv (5 subtests) =============
[12:24:55] [PASSED] drm_test_modes_analog_tv_mono_576i
[12:24:55] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[12:24:55] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[12:24:55] [PASSED] drm_test_modes_analog_tv_pal_576i
[12:24:55] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[12:24:55] =============== [PASSED] drm_modes_analog_tv ===============
[12:24:55] ============== drm_plane_helper (2 subtests) ===============
[12:24:55] =============== drm_test_check_plane_state  ================
[12:24:55] [PASSED] clipping_simple
[12:24:55] [PASSED] clipping_rotate_reflect
[12:24:55] [PASSED] positioning_simple
[12:24:55] [PASSED] upscaling
[12:24:55] [PASSED] downscaling
[12:24:55] [PASSED] rounding1
[12:24:55] [PASSED] rounding2
[12:24:55] [PASSED] rounding3
[12:24:55] [PASSED] rounding4
[12:24:55] =========== [PASSED] drm_test_check_plane_state ============
[12:24:55] =========== drm_test_check_invalid_plane_state  ============
[12:24:55] [PASSED] positioning_invalid
[12:24:55] [PASSED] upscaling_invalid
[12:24:55] [PASSED] downscaling_invalid
[12:24:55] ======= [PASSED] drm_test_check_invalid_plane_state ========
[12:24:55] ================ [PASSED] drm_plane_helper =================
[12:24:55] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[12:24:55] ====== drm_test_connector_helper_tv_get_modes_check  =======
[12:24:55] [PASSED] None
[12:24:55] [PASSED] PAL
[12:24:55] [PASSED] NTSC
[12:24:55] [PASSED] Both, NTSC Default
[12:24:55] [PASSED] Both, PAL Default
[12:24:55] [PASSED] Both, NTSC Default, with PAL on command-line
[12:24:55] [PASSED] Both, PAL Default, with NTSC on command-line
[12:24:55] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[12:24:55] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[12:24:55] ================== drm_rect (9 subtests) ===================
[12:24:55] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[12:24:55] [PASSED] drm_test_rect_clip_scaled_not_clipped
[12:24:55] [PASSED] drm_test_rect_clip_scaled_clipped
[12:24:55] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[12:24:55] ================= drm_test_rect_intersect  =================
[12:24:55] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[12:24:55] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[12:24:55] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[12:24:55] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[12:24:55] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[12:24:55] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[12:24:55] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[12:24:55] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[12:24:55] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[12:24:55] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[12:24:55] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[12:24:55] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[12:24:55] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[12:24:55] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[12:24:55] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[12:24:55] ============= [PASSED] drm_test_rect_intersect =============
[12:24:55] ================ drm_test_rect_calc_hscale  ================
[12:24:55] [PASSED] normal use
[12:24:55] [PASSED] out of max range
[12:24:55] [PASSED] out of min range
[12:24:55] [PASSED] zero dst
[12:24:55] [PASSED] negative src
[12:24:55] [PASSED] negative dst
[12:24:55] ============ [PASSED] drm_test_rect_calc_hscale ============
[12:24:55] ================ drm_test_rect_calc_vscale  ================
[12:24:55] [PASSED] normal use
stty: 'standard input': Inappropriate ioctl for device
[12:24:55] [PASSED] out of max range
[12:24:55] [PASSED] out of min range
[12:24:55] [PASSED] zero dst
[12:24:55] [PASSED] negative src
[12:24:55] [PASSED] negative dst
[12:24:55] ============ [PASSED] drm_test_rect_calc_vscale ============
[12:24:55] ================== drm_test_rect_rotate  ===================
[12:24:55] [PASSED] reflect-x
[12:24:55] [PASSED] reflect-y
[12:24:55] [PASSED] rotate-0
[12:24:55] [PASSED] rotate-90
[12:24:55] [PASSED] rotate-180
[12:24:55] [PASSED] rotate-270
[12:24:55] ============== [PASSED] drm_test_rect_rotate ===============
[12:24:55] ================ drm_test_rect_rotate_inv  =================
[12:24:55] [PASSED] reflect-x
[12:24:55] [PASSED] reflect-y
[12:24:55] [PASSED] rotate-0
[12:24:55] [PASSED] rotate-90
[12:24:55] [PASSED] rotate-180
[12:24:55] [PASSED] rotate-270
[12:24:55] ============ [PASSED] drm_test_rect_rotate_inv =============
[12:24:55] ==================== [PASSED] drm_rect =====================
[12:24:55] ============ drm_sysfb_modeset_test (1 subtest) ============
[12:24:55] ============ drm_test_sysfb_build_fourcc_list  =============
[12:24:55] [PASSED] no native formats
[12:24:55] [PASSED] XRGB8888 as native format
[12:24:55] [PASSED] remove duplicates
[12:24:55] [PASSED] convert alpha formats
[12:24:55] [PASSED] random formats
[12:24:55] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[12:24:55] ============= [PASSED] drm_sysfb_modeset_test ==============
[12:24:55] ================== drm_fixp (2 subtests) ===================
[12:24:55] [PASSED] drm_test_int2fixp
[12:24:55] [PASSED] drm_test_sm2fixp
[12:24:55] ==================== [PASSED] drm_fixp =====================
[12:24:55] ============================================================
[12:24:55] Testing complete. Ran 624 tests: passed: 624
[12:24:55] Elapsed time: 32.335s total, 1.611s configuring, 30.256s building, 0.418s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig [12:24:55] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[12:24:57] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=25
[12:25:06] Starting KUnit Kernel (1/1)...
[12:25:06] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:25:06] ================= ttm_device (5 subtests) ==================
[12:25:06] [PASSED] ttm_device_init_basic
[12:25:06] [PASSED] ttm_device_init_multiple
[12:25:06] [PASSED] ttm_device_fini_basic
[12:25:06] [PASSED] ttm_device_init_no_vma_man
[12:25:06] ================== ttm_device_init_pools  ==================
[12:25:06] [PASSED] No DMA allocations, no DMA32 required
[12:25:06] [PASSED] DMA allocations, DMA32 required
[12:25:06] [PASSED] No DMA allocations, DMA32 required
[12:25:06] [PASSED] DMA allocations, no DMA32 required
[12:25:06] ============== [PASSED] ttm_device_init_pools ==============
[12:25:06] =================== [PASSED] ttm_device ====================
[12:25:06] ================== ttm_pool (8 subtests) ===================
[12:25:06] ================== ttm_pool_alloc_basic  ===================
[12:25:06] [PASSED] One page
[12:25:06] [PASSED] More than one page
[12:25:06] [PASSED] Above the allocation limit
[12:25:06] [PASSED] One page, with coherent DMA mappings enabled
[12:25:06] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[12:25:06] ============== [PASSED] ttm_pool_alloc_basic ===============
[12:25:06] ============== ttm_pool_alloc_basic_dma_addr  ==============
[12:25:06] [PASSED] One page
[12:25:06] [PASSED] More than one page
[12:25:06] [PASSED] Above the allocation limit
[12:25:06] [PASSED] One page, with coherent DMA mappings enabled
[12:25:06] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[12:25:06] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[12:25:06] [PASSED] ttm_pool_alloc_order_caching_match
[12:25:06] [PASSED] ttm_pool_alloc_caching_mismatch
[12:25:06] [PASSED] ttm_pool_alloc_order_mismatch
[12:25:06] [PASSED] ttm_pool_free_dma_alloc
[12:25:06] [PASSED] ttm_pool_free_no_dma_alloc
[12:25:06] [PASSED] ttm_pool_fini_basic
[12:25:06] ==================== [PASSED] ttm_pool =====================
[12:25:06] ================ ttm_resource (8 subtests) =================
[12:25:06] ================= ttm_resource_init_basic  =================
[12:25:06] [PASSED] Init resource in TTM_PL_SYSTEM
[12:25:06] [PASSED] Init resource in TTM_PL_VRAM
[12:25:06] [PASSED] Init resource in a private placement
[12:25:06] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[12:25:06] ============= [PASSED] ttm_resource_init_basic =============
[12:25:06] [PASSED] ttm_resource_init_pinned
[12:25:06] [PASSED] ttm_resource_fini_basic
[12:25:06] [PASSED] ttm_resource_manager_init_basic
[12:25:06] [PASSED] ttm_resource_manager_usage_basic
[12:25:06] [PASSED] ttm_resource_manager_set_used_basic
[12:25:06] [PASSED] ttm_sys_man_alloc_basic
[12:25:06] [PASSED] ttm_sys_man_free_basic
[12:25:06] ================== [PASSED] ttm_resource ===================
[12:25:06] =================== ttm_tt (15 subtests) ===================
[12:25:06] ==================== ttm_tt_init_basic  ====================
[12:25:06] [PASSED] Page-aligned size
[12:25:06] [PASSED] Extra pages requested
[12:25:06] ================ [PASSED] ttm_tt_init_basic ================
[12:25:06] [PASSED] ttm_tt_init_misaligned
[12:25:06] [PASSED] ttm_tt_fini_basic
[12:25:06] [PASSED] ttm_tt_fini_sg
[12:25:06] [PASSED] ttm_tt_fini_shmem
[12:25:06] [PASSED] ttm_tt_create_basic
[12:25:06] [PASSED] ttm_tt_create_invalid_bo_type
[12:25:06] [PASSED] ttm_tt_create_ttm_exists
[12:25:06] [PASSED] ttm_tt_create_failed
[12:25:06] [PASSED] ttm_tt_destroy_basic
[12:25:06] [PASSED] ttm_tt_populate_null_ttm
[12:25:06] [PASSED] ttm_tt_populate_populated_ttm
[12:25:06] [PASSED] ttm_tt_unpopulate_basic
[12:25:06] [PASSED] ttm_tt_unpopulate_empty_ttm
[12:25:06] [PASSED] ttm_tt_swapin_basic
[12:25:06] ===================== [PASSED] ttm_tt ======================
[12:25:06] =================== ttm_bo (14 subtests) ===================
[12:25:06] =========== ttm_bo_reserve_optimistic_no_ticket  ===========
[12:25:06] [PASSED] Cannot be interrupted and sleeps
[12:25:06] [PASSED] Cannot be interrupted, locks straight away
[12:25:06] [PASSED] Can be interrupted, sleeps
[12:25:06] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[12:25:06] [PASSED] ttm_bo_reserve_locked_no_sleep
[12:25:06] [PASSED] ttm_bo_reserve_no_wait_ticket
[12:25:06] [PASSED] ttm_bo_reserve_double_resv
[12:25:06] [PASSED] ttm_bo_reserve_interrupted
[12:25:06] [PASSED] ttm_bo_reserve_deadlock
[12:25:06] [PASSED] ttm_bo_unreserve_basic
[12:25:06] [PASSED] ttm_bo_unreserve_pinned
[12:25:06] [PASSED] ttm_bo_unreserve_bulk
[12:25:06] [PASSED] ttm_bo_fini_basic
[12:25:06] [PASSED] ttm_bo_fini_shared_resv
[12:25:06] [PASSED] ttm_bo_pin_basic
[12:25:06] [PASSED] ttm_bo_pin_unpin_resource
[12:25:06] [PASSED] ttm_bo_multiple_pin_one_unpin
[12:25:06] ===================== [PASSED] ttm_bo ======================
[12:25:06] ============== ttm_bo_validate (21 subtests) ===============
[12:25:06] ============== ttm_bo_init_reserved_sys_man  ===============
[12:25:06] [PASSED] Buffer object for userspace
[12:25:06] [PASSED] Kernel buffer object
[12:25:06] [PASSED] Shared buffer object
[12:25:06] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[12:25:06] ============== ttm_bo_init_reserved_mock_man  ==============
[12:25:06] [PASSED] Buffer object for userspace
[12:25:06] [PASSED] Kernel buffer object
[12:25:06] [PASSED] Shared buffer object
[12:25:06] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[12:25:06] [PASSED] ttm_bo_init_reserved_resv
[12:25:06] ================== ttm_bo_validate_basic  ==================
[12:25:06] [PASSED] Buffer object for userspace
[12:25:06] [PASSED] Kernel buffer object
[12:25:06] [PASSED] Shared buffer object
[12:25:06] ============== [PASSED] ttm_bo_validate_basic ==============
[12:25:06] [PASSED] ttm_bo_validate_invalid_placement
[12:25:06] ============= ttm_bo_validate_same_placement  ==============
[12:25:06] [PASSED] System manager
[12:25:06] [PASSED] VRAM manager
[12:25:06] ========= [PASSED] ttm_bo_validate_same_placement ==========
[12:25:06] [PASSED] ttm_bo_validate_failed_alloc
[12:25:06] [PASSED] ttm_bo_validate_pinned
[12:25:06] [PASSED] ttm_bo_validate_busy_placement
[12:25:06] ================ ttm_bo_validate_multihop  =================
[12:25:06] [PASSED] Buffer object for userspace
[12:25:06] [PASSED] Kernel buffer object
[12:25:06] [PASSED] Shared buffer object
[12:25:06] ============ [PASSED] ttm_bo_validate_multihop =============
[12:25:06] ========== ttm_bo_validate_no_placement_signaled  ==========
[12:25:06] [PASSED] Buffer object in system domain, no page vector
[12:25:06] [PASSED] Buffer object in system domain with an existing page vector
[12:25:06] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[12:25:06] ======== ttm_bo_validate_no_placement_not_signaled  ========
[12:25:06] [PASSED] Buffer object for userspace
[12:25:06] [PASSED] Kernel buffer object
[12:25:06] [PASSED] Shared buffer object
[12:25:06] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[12:25:06] [PASSED] ttm_bo_validate_move_fence_signaled
[12:25:07] ========= ttm_bo_validate_move_fence_not_signaled  =========
[12:25:07] [PASSED] Waits for GPU
[12:25:07] [PASSED] Tries to lock straight away
[12:25:07] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[12:25:07] [PASSED] ttm_bo_validate_happy_evict
[12:25:07] [PASSED] ttm_bo_validate_all_pinned_evict
[12:25:07] [PASSED] ttm_bo_validate_allowed_only_evict
[12:25:07] [PASSED] ttm_bo_validate_deleted_evict
[12:25:07] [PASSED] ttm_bo_validate_busy_domain_evict
[12:25:07] [PASSED] ttm_bo_validate_evict_gutting
[12:25:07] [PASSED] ttm_bo_validate_recrusive_evict
stty: 'standard input': Inappropriate ioctl for device
[12:25:07] ================= [PASSED] ttm_bo_validate =================
[12:25:07] ============================================================
[12:25:07] Testing complete. Ran 101 tests: passed: 101
[12:25:07] Elapsed time: 11.096s total, 1.626s configuring, 9.253s building, 0.175s running

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel

#15 lore raw

✓ Xe.CI.BAT: success for drm/xe: Privatize struct xe_ggtt. (rev2)

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: drm/xe: Privatize struct xe_ggtt. (rev2)
URL : https://patchwork.freedesktop.org/series/160006/
State : success

== Summary ==

CI Bug Log - changes from xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082_BAT -> xe-pw-160006v2_BAT
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (12 -> 12)
------------------------------

No changes in participating hosts

Changes
-------

No changes found

Build changes
-------------

* Linux: xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082 -> xe-pw-160006v2

IGT_8699: 0b67ab25f2eb58b296872c8c34474b79353727d5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082: f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082
xe-pw-160006v2: 160006v2

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/index.html

#16 lore raw

✓ Xe.CI.Full: success for drm/xe: Privatize struct xe_ggtt. (rev2)

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: drm/xe: Privatize struct xe_ggtt. (rev2)
URL : https://patchwork.freedesktop.org/series/160006/
State : success

== Summary ==

CI Bug Log - changes from xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082_FULL -> xe-pw-160006v2_FULL
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (2 -> 2)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in xe-pw-160006v2_FULL that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_big_fb@linear-8bpp-rotate-90:
- shard-bmg: NOTRUN -> [SKIP][1] ([Intel XE#2327]) +2 other tests skip
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@[email protected]

* igt@kms_big_fb@y-tiled-addfb:
- shard-bmg: NOTRUN -> [SKIP][2] ([Intel XE#2328])
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@[email protected]

* igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
- shard-bmg: NOTRUN -> [SKIP][3] ([Intel XE#1124]) +6 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-10/igt@[email protected]

* igt@kms_bw@connected-linear-tiling-3-displays-2560x1440p:
- shard-bmg: NOTRUN -> [SKIP][4] ([Intel XE#2314] / [Intel XE#2894]) +1 other test skip
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-3/igt@[email protected]

* igt@kms_bw@linear-tiling-2-displays-1920x1080p:
- shard-bmg: NOTRUN -> [SKIP][5] ([Intel XE#367])
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-8/igt@[email protected]

* igt@kms_ccs@bad-pixel-format-4-tiled-dg2-mc-ccs:
- shard-bmg: NOTRUN -> [SKIP][6] ([Intel XE#2887]) +10 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@[email protected]

* igt@kms_ccs@crc-primary-rotation-180-4-tiled-lnl-ccs@pipe-c-dp-2:
- shard-bmg: NOTRUN -> [SKIP][7] ([Intel XE#2652] / [Intel XE#787]) +8 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-8/igt@kms_ccs@[email protected]

* igt@kms_ccs@crc-primary-suspend-4-tiled-dg2-mc-ccs:
- shard-bmg: NOTRUN -> [SKIP][8] ([Intel XE#3432]) +2 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@[email protected]

* igt@kms_chamelium_color@ctm-red-to-blue:
- shard-bmg: NOTRUN -> [SKIP][9] ([Intel XE#2325]) +1 other test skip
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-8/igt@[email protected]

* igt@kms_chamelium_edid@dp-edid-read:
- shard-bmg: NOTRUN -> [SKIP][10] ([Intel XE#2252]) +5 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-10/igt@[email protected]

* igt@kms_content_protection@content-type-change:
- shard-bmg: NOTRUN -> [SKIP][11] ([Intel XE#2341])
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-8/igt@[email protected]

* igt@kms_content_protection@dp-mst-type-1:
- shard-bmg: NOTRUN -> [SKIP][12] ([Intel XE#2390] / [Intel XE#6974])
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@[email protected]

* igt@kms_content_protection@lic-type-0@pipe-a-dp-2:
- shard-bmg: NOTRUN -> [FAIL][13] ([Intel XE#1178] / [Intel XE#3304]) +1 other test fail
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-10/igt@kms_content_protection@[email protected]

* igt@kms_cursor_crc@cursor-offscreen-512x512:
- shard-bmg: NOTRUN -> [SKIP][14] ([Intel XE#2321]) +1 other test skip
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-4/igt@[email protected]

* igt@kms_cursor_crc@cursor-random-32x32:
- shard-bmg: NOTRUN -> [SKIP][15] ([Intel XE#2320]) +3 other tests skip
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-3/igt@[email protected]

* igt@kms_dp_linktrain_fallback@dsc-fallback:
- shard-bmg: NOTRUN -> [SKIP][16] ([Intel XE#4331])
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-10/igt@[email protected]

* igt@kms_fbc_dirty_rect@fbc-dirty-rectangle-dirtyfb-tests:
- shard-bmg: NOTRUN -> [SKIP][17] ([Intel XE#4422])
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-8/igt@[email protected]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-lnl: [PASS][18] -> [FAIL][19] ([Intel XE#6831])
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-lnl-1/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-lnl-3/igt@[email protected]

* igt@kms_feature_discovery@display-4x:
- shard-bmg: NOTRUN -> [SKIP][20] ([Intel XE#1138])
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-10/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling:
- shard-bmg: NOTRUN -> [SKIP][21] ([Intel XE#2293] / [Intel XE#2380]) +2 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-4/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling.html

* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-bmg: NOTRUN -> [SKIP][22] ([Intel XE#2293]) +2 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-4/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-bmg: NOTRUN -> [SKIP][23] ([Intel XE#4141]) +12 other tests skip
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-pri-shrfb-draw-render:
- shard-bmg: NOTRUN -> [SKIP][24] ([Intel XE#2311]) +24 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-4/igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-pri-shrfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbcdrrs-tiling-y:
- shard-bmg: NOTRUN -> [SKIP][25] ([Intel XE#2352])
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-4/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-pgflip-blt:
- shard-bmg: NOTRUN -> [SKIP][26] ([Intel XE#2313]) +23 other tests skip
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@[email protected]

* igt@kms_hdr@bpc-switch@pipe-a-dp-2:
- shard-bmg: [PASS][27] -> [ABORT][28] ([Intel XE#6740]) +3 other tests abort
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-bmg-6/igt@kms_hdr@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-7/igt@kms_hdr@[email protected]

* igt@kms_hdr@static-swap:
- shard-bmg: NOTRUN -> [ABORT][29] ([Intel XE#6740]) +1 other test abort
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@[email protected]

* igt@kms_joiner@invalid-modeset-force-ultra-joiner:
- shard-bmg: NOTRUN -> [SKIP][30] ([Intel XE#6911]) +1 other test skip
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@[email protected]

* igt@kms_panel_fitting@legacy:
- shard-bmg: NOTRUN -> [SKIP][31] ([Intel XE#2486])
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-8/igt@[email protected]

* igt@kms_plane_multiple@tiling-yf:
- shard-bmg: NOTRUN -> [SKIP][32] ([Intel XE#5020])
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-c:
- shard-bmg: NOTRUN -> [SKIP][33] ([Intel XE#6886]) +4 other tests skip
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@kms_plane_scaling@[email protected]

* igt@kms_pm_dc@dc6-psr:
- shard-bmg: NOTRUN -> [SKIP][34] ([Intel XE#2392])
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-3/igt@[email protected]

* igt@kms_psr2_sf@psr2-cursor-plane-move-continuous-exceed-fully-sf:
- shard-bmg: NOTRUN -> [SKIP][35] ([Intel XE#1406] / [Intel XE#1489]) +4 other tests skip
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@kms_psr2_sf@psr2-cursor-plane-move-continuous-exceed-fully-sf.html

* igt@kms_psr2_su@page_flip-nv12:
- shard-bmg: NOTRUN -> [SKIP][36] ([Intel XE#1406] / [Intel XE#2387])
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-10/igt@kms_psr2_su@page_flip-nv12.html

* igt@kms_psr@psr-cursor-plane-onoff:
- shard-bmg: NOTRUN -> [SKIP][37] ([Intel XE#1406] / [Intel XE#2234] / [Intel XE#2850]) +13 other tests skip
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-3/igt@[email protected]

* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180:
- shard-bmg: NOTRUN -> [SKIP][38] ([Intel XE#2330])
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@[email protected]

* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90:
- shard-bmg: NOTRUN -> [SKIP][39] ([Intel XE#3414] / [Intel XE#3904]) +1 other test skip
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-8/igt@[email protected]

* igt@kms_sharpness_filter@filter-basic:
- shard-bmg: NOTRUN -> [SKIP][40] ([Intel XE#6503]) +2 other tests skip
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-4/igt@[email protected]

* igt@kms_tv_load_detect@load-detect:
- shard-bmg: NOTRUN -> [SKIP][41] ([Intel XE#2450])
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-4/igt@[email protected]

* igt@kms_vrr@lobf:
- shard-bmg: NOTRUN -> [SKIP][42] ([Intel XE#2168])
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-8/igt@[email protected]

* igt@xe_create@multigpu-create-massive-size:
- shard-bmg: NOTRUN -> [SKIP][43] ([Intel XE#2504])
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-8/igt@[email protected]

* igt@xe_eudebug@basic-vm-access-userptr:
- shard-bmg: NOTRUN -> [SKIP][44] ([Intel XE#4837]) +4 other tests skip
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@[email protected]

* igt@xe_eudebug_online@interrupt-other:
- shard-bmg: NOTRUN -> [SKIP][45] ([Intel XE#4837] / [Intel XE#6665])
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-4/igt@[email protected]

* igt@xe_eudebug_sriov@deny-eudebug:
- shard-bmg: NOTRUN -> [SKIP][46] ([Intel XE#5793])
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@[email protected]

* igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue-userptr:
- shard-bmg: NOTRUN -> [SKIP][47] ([Intel XE#2322]) +7 other tests skip
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-3/igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue-userptr.html

* igt@xe_exec_multi_queue@two-queues-preempt-mode-fault-dyn-priority-smem:
- shard-bmg: NOTRUN -> [SKIP][48] ([Intel XE#6874]) +22 other tests skip
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-10/igt@xe_exec_multi_queue@two-queues-preempt-mode-fault-dyn-priority-smem.html

* igt@xe_exec_reset@gt-reset-stress:
- shard-lnl: [PASS][49] -> [DMESG-WARN][50] ([Intel XE#7023])
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-lnl-1/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-lnl-3/igt@[email protected]

* igt@xe_exec_system_allocator@threads-many-large-execqueues-mmap-free-madvise:
- shard-bmg: [PASS][51] -> [ABORT][52] ([Intel XE#3970] / [Intel XE#5545])
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-bmg-4/igt@xe_exec_system_allocator@threads-many-large-execqueues-mmap-free-madvise.html
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-2/igt@xe_exec_system_allocator@threads-many-large-execqueues-mmap-free-madvise.html

* igt@xe_exec_system_allocator@threads-shared-vm-many-large-execqueues-mmap-free-huge-nomemset:
- shard-bmg: NOTRUN -> [SKIP][53] ([Intel XE#4943]) +17 other tests skip
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-9/igt@xe_exec_system_allocator@threads-shared-vm-many-large-execqueues-mmap-free-huge-nomemset.html

* igt@xe_live_ktest@xe_bo@xe_ccs_migrate_kunit:
- shard-bmg: NOTRUN -> [SKIP][54] ([Intel XE#2229])
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-8/igt@xe_live_ktest@xe_bo@xe_ccs_migrate_kunit.html

* igt@xe_multigpu_svm@mgpu-latency-prefetch:
- shard-bmg: NOTRUN -> [SKIP][55] ([Intel XE#6964]) +2 other tests skip
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-8/igt@[email protected]

* igt@xe_pat@pat-index-xehpc:
- shard-bmg: NOTRUN -> [SKIP][56] ([Intel XE#1420])
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-10/igt@[email protected]

* igt@xe_pxp@pxp-termination-key-update-post-rpm:
- shard-bmg: NOTRUN -> [SKIP][57] ([Intel XE#4733])
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-10/igt@[email protected]

* igt@xe_query@multigpu-query-invalid-uc-fw-version-mbz:
- shard-bmg: NOTRUN -> [SKIP][58] ([Intel XE#944])
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-8/igt@[email protected]

#### Possible fixes ####

* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-bmg: [FAIL][59] ([Intel XE#4633]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-bmg-8/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-3/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-lnl: [FAIL][61] ([Intel XE#301]) -> [PASS][62] +1 other test pass
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-lnl-1/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-lnl-2/igt@[email protected]

* igt@kms_vrr@cmrr@pipe-a-edp-1:
- shard-lnl: [FAIL][63] ([Intel XE#4459]) -> [PASS][64] +1 other test pass
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-lnl-4/igt@kms_vrr@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-lnl-5/igt@kms_vrr@[email protected]

* igt@kms_vrr@flipline:
- shard-lnl: [FAIL][65] ([Intel XE#4227]) -> [PASS][66] +1 other test pass
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-lnl-3/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-lnl-5/igt@[email protected]

* igt@testdisplay:
- shard-bmg: [ABORT][67] ([Intel XE#6740] / [Intel XE#6976]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-bmg-8/[email protected]
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-10/[email protected]

* igt@xe_evict@evict-beng-mixed-many-threads-small:
- shard-bmg: [INCOMPLETE][69] ([Intel XE#6321]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-bmg-3/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-4/igt@[email protected]

* igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma:
- shard-lnl: [FAIL][71] ([Intel XE#5625]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-lnl-7/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma.html
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-lnl-7/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma.html

* igt@xe_exec_system_allocator@threads-many-malloc-bo-unmap-nomemset:
- shard-bmg: [ABORT][73] ([Intel XE#3970]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-bmg-10/igt@xe_exec_system_allocator@threads-many-malloc-bo-unmap-nomemset.html
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-8/igt@xe_exec_system_allocator@threads-many-malloc-bo-unmap-nomemset.html

#### Warnings ####

* igt@kms_hdr@invalid-hdr:
- shard-bmg: [ABORT][75] ([Intel XE#6740]) -> [SKIP][76] ([Intel XE#1503])
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-bmg-3/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-4/igt@[email protected]

* igt@kms_tiled_display@basic-test-pattern:
- shard-bmg: [SKIP][77] ([Intel XE#2426]) -> [FAIL][78] ([Intel XE#1729])
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-bmg-7/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-2/igt@[email protected]

* igt@kms_tiled_display@basic-test-pattern-with-chamelium:
- shard-bmg: [SKIP][79] ([Intel XE#2509]) -> [SKIP][80] ([Intel XE#2426])
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082/shard-bmg-4/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/shard-bmg-1/igt@[email protected]

[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1138]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1138
[Intel XE#1178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1178
[Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406
[Intel XE#1420]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1420
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503
[Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729
[Intel XE#2168]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2168
[Intel XE#2229]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2229
[Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
[Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
[Intel XE#2293]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2293
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2314]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2314
[Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
[Intel XE#2321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2321
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2325]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2325
[Intel XE#2327]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2327
[Intel XE#2328]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2328
[Intel XE#2330]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2330
[Intel XE#2341]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2341
[Intel XE#2352]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2352
[Intel XE#2380]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2380
[Intel XE#2387]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2387
[Intel XE#2390]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2390
[Intel XE#2392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2392
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2450]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2450
[Intel XE#2486]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2486
[Intel XE#2504]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2504
[Intel XE#2509]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2509
[Intel XE#2652]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2652
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#2894]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2894
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#3304]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3304
[Intel XE#3414]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3414
[Intel XE#3432]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3432
[Intel XE#367]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/367
[Intel XE#3904]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3904
[Intel XE#3970]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3970
[Intel XE#4141]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4141
[Intel XE#4227]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4227
[Intel XE#4331]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4331
[Intel XE#4422]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4422
[Intel XE#4459]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4459
[Intel XE#4633]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4633
[Intel XE#4733]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4733
[Intel XE#4837]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4837
[Intel XE#4943]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4943
[Intel XE#5020]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5020
[Intel XE#5545]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5545
[Intel XE#5625]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5625
[Intel XE#5793]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5793
[Intel XE#6321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6321
[Intel XE#6503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6503
[Intel XE#6665]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6665
[Intel XE#6740]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6740
[Intel XE#6831]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6831
[Intel XE#6874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6874
[Intel XE#6886]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6886
[Intel XE#6911]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6911
[Intel XE#6964]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6964
[Intel XE#6974]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6974
[Intel XE#6976]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6976
[Intel XE#7023]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7023
[Intel XE#787]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/787
[Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944

Build changes
-------------

* Linux: xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082 -> xe-pw-160006v2

IGT_8699: 0b67ab25f2eb58b296872c8c34474b79353727d5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-4376-f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082: f7424dfbcb8f05a13bb1da2bed8e2212d2b7a082
xe-pw-160006v2: 160006v2

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-160006v2/index.html