Skip to contentSkip to conversation

arm: mm: replace snprintf in show functions with sysfs_emit

PATCH In review [email protected] 3 participants 3 messages Jul 13, 2023 – Jul 17, 2023 1 message not in the archive Arm (32-bit)

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 arm: mm: replace snprintf in show functions with sysfs_emit

coccicheck complains about the use of snprintf() in sysfs show functions.

Fix the coccicheck warning:
WARNING: use scnprintf or sprintf.

./arch/arm/mm/cache-l2x0-pmu.c:346:8-16: WARNING: use scnprintf or sprintf

---
 arch/arm/mm/cache-l2x0-pmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mm/cache-l2x0-pmu.c +1 -1
index 993fefdc167a..d20626451a2e 100644
@@ -343,7 +343,7 @@ static ssize_t l2x0_pmu_event_show(struct device *dev,
     struct l2x0_event_attribute *lattr;
 
     lattr = container_of(attr, typeof(*lattr), attr);
-    return snprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
+    return scnprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
 }
 
 static umode_t l2x0_pmu_event_attr_is_visible(struct kobject *kobj,

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 17 lines · On Thu, Jul 13, 2023 at 06:06:15PM +0800, [email protected] wrote:

coccicheck complains about the use of snprintf() in sysfs show functions.

Fix the coccicheck warning:
WARNING: use scnprintf or sprintf.

./arch/arm/mm/cache-l2x0-pmu.c:346:8-16: WARNING: use scnprintf or sprintf

---
 arch/arm/mm/cache-l2x0-pmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mm/cache-l2x0-pmu.c +0 -0
index 993fefdc167a..d20626451a2e 100644

arch/arm/mm/cache-l2x0-pmu.c static ssize_t l2x0_pmu_event_show(struct device *dev, · line 346

Quoted 5 lines
arch/arm/mm/cache-l2x0-pmu.c +1 -1
@@ -343,7 +343,7 @@ static ssize_t l2x0_pmu_event_show(struct device *dev,
     struct l2x0_event_attribute *lattr;
 
     lattr = container_of(attr, typeof(*lattr), attr);
-    return snprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
+    return scnprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);

This only serves to shut up a warning. On 32-bit ARM, there is utterly no way what so ever that "config=0x%x\n" could ever overflow 4096 bytes, or even 32 bytes!

Signature · 7 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

From: Russell King <[email protected]>

Quoted 25 lines

Sent: 13 July 2023 11:16
To: [email protected]
Cc: [email protected]; [email protected]
Subject: Re: Fwd: [PATCH] arm: mm: replace snprintf in show functions with sysfs_emit

Quoted 19 lines · On Thu, Jul 13, 2023 at 06:06:15PM +0800, [email protected] wrote:

coccicheck complains about the use of snprintf() in sysfs show functions.

Fix the coccicheck warning:
WARNING: use scnprintf or sprintf.

./arch/arm/mm/cache-l2x0-pmu.c:346:8-16: WARNING: use scnprintf or sprintf

---
 arch/arm/mm/cache-l2x0-pmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mm/cache-l2x0-pmu.c +0 -0
index 993fefdc167a..d20626451a2e 100644
@@ -343,7 +343,7 @@ static ssize_t l2x0_pmu_event_show(struct device *dev,
     struct l2x0_event_attribute *lattr;
 
Quoted 7 lines

arch/arm/mm/cache-l2x0-pmu.c static ssize_t l2x0_pmu_event_show(struct device *dev, · line 346

Quoted 3 lines
arch/arm/mm/cache-l2x0-pmu.c +1 -1
     lattr = container_of(attr, typeof(*lattr), attr);
-    return snprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);
+    return scnprintf(buf, PAGE_SIZE, "config=0x%x\n", lattr->config);

This only serves to shut up a warning. On 32-bit ARM, there is utterly no way what so ever that "config=0x%x\n" could ever overflow 4096 bytes, or even 32 bytes!

The code also doesn't match the commit message. Did you actually send the correct copy of all these patches?

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)