net/i40e: support enable/disable source pruning
PATCH v3 1/1 net/i40e: support enable/disable source pruning
VRRP advertisement packets are dropped on i40e PF device because when a MAC address is added to a device, packets originating from that MAC address are dropped.
This patch adds a PMD specific API to enable/disable source pruning to fix above issue.
Bugzilla ID: 648
---
v3: The i40e specific commands are moved todrivers/net/i40e/i40e_testpmd.c.
--- drivers/net/i40e/i40e_ethdev.c | 43 ++++++++++++++++ drivers/net/i40e/i40e_ethdev.h | 1 + drivers/net/i40e/i40e_testpmd.c | 88 +++++++++++++++++++++++++++++++++ drivers/net/i40e/rte_pmd_i40e.c | 20 ++++++++ drivers/net/i40e/rte_pmd_i40e.h | 17 +++++++ drivers/net/i40e/version.map | 1 + 6 files changed, 170 insertions(+)
drivers/net/i40e/i40e_ethdev.c +43 -0
@@ -5647,6 +5647,46 @@ i40e_enable_pf_lb(struct i40e_pf *pf) hw->aq.asq_last_status); } +/* i40e_pf_set_source_prune +* @pf: pointer to the pf structure +* @on: Enable/disable source prune +* +* set source prune on pf +*/ +int +i40e_pf_set_source_prune (struct i40e_pf *pf,int on) +{ +struct i40e_hw *hw =I40E_PF_TO_HW (pf); +struct i40e_vsi_context ctxt; +int ret; + +memset (&ctxt,0 ,sizeof (ctxt)); + ctxt.seid = pf->main_vsi_seid; + ctxt.pf_num = hw->pf_id; + ret =i40e_aq_get_vsi_params (hw, &ctxt,NULL ); +if (ret) { +PMD_DRV_LOG (ERR ,"cannot get pf vsi config, err %d, aq_err %d" , + ret, hw->aq.asq_last_status); +return ret; + } + ctxt.flags =I40E_AQ_VSI_TYPE_PF ; + ctxt.info.valid_sections = +rte_cpu_to_le_16 (I40E_AQ_VSI_PROP_SWITCH_VALID ); +if (on) + ctxt.info.switch_id &= + ~rte_cpu_to_le_16 (I40E_AQ_VSI_SW_ID_FLAG_LOCAL_LB ); +else + ctxt.info.switch_id |= +rte_cpu_to_le_16 (I40E_AQ_VSI_SW_ID_FLAG_LOCAL_LB ); + + ret =i40e_aq_update_vsi_params (hw, &ctxt,NULL ); +if (ret) +PMD_DRV_LOG (ERR ,"update vsi switch failed, aq_err=%d" , + hw->aq.asq_last_status); + +return ret; +} +/* Setup a VSI */ struct i40e_vsi * i40e_vsi_setup(struct i40e_pf *pf,
@@ -5704,6 +5744,9 @@ i40e_vsi_setup(struct i40e_pf *pf, } } +/* source prune is disabled to support VRRP in default*/ +i40e_pf_set_source_prune (pf,0 ); + vsi =rte_zmalloc ("i40e_vsi" ,sizeof (struct i40e_vsi ),0 );if (!vsi) {PMD_DRV_LOG (ERR ,"Failed to allocate memory for vsi" );
drivers/net/i40e/i40e_ethdev.h +1 -0
@@ -1430,6 +1430,7 @@ int i40e_pf_calc_configured_queues_num(struct i40e_pf *pf);int i40e_pf_reset_rss_reta (struct i40e_pf *pf);int i40e_pf_reset_rss_key (struct i40e_pf *pf);int i40e_pf_config_rss (struct i40e_pf *pf); +int i40e_pf_set_source_prune (struct i40e_pf *pf,int on);int i40e_set_rss_key (struct i40e_vsi *vsi,uint8_t *key,uint8_t key_len);int i40e_set_rss_lut (struct i40e_vsi *vsi,uint8_t *lut,uint16_t lut_size);int i40e_vf_representor_init (struct rte_eth_dev *ethdev,void *init_params);
drivers/net/i40e/i40e_testpmd.c +88 -0
100 lines not on this page · raw message
drivers/net/i40e/rte_pmd_i40e.c +20 -0
@@ -3282,3 +3282,23 @@ rte_pmd_i40e_set_switch_dev(uint16_t port_id, struct rte_eth_dev *switch_dev)return 0 ; } + +int +rte_pmd_i40e_set_pf_src_prune (uint16_t port,uint8_t on) +{ +struct rte_eth_dev *dev; +struct i40e_pf *pf; +int ret; + +RTE_ETH_VALID_PORTID_OR_ERR_RET (port, -ENODEV ); + + dev = &rte_eth_devices[port]; + +if (!is_i40e_supported (dev)) +return -ENOTSUP ; + + pf =I40E_DEV_PRIVATE_TO_PF (dev->data->dev_private); + + ret =i40e_pf_set_source_prune (pf, on); +return ret; +}
drivers/net/i40e/rte_pmd_i40e.h +17 -0
@@ -1134,6 +1134,23 @@ __rte_experimentalint rte_pmd_i40e_set_switch_dev (uint16_t port_id,struct rte_eth_dev *switch_dev); +/** +* Enable/Disable source prune on all the PF. +* +* @param port +* The port identifier of the Ethernet device. +* @param on +* 1 - Enable source prune. +* 0 - Disable source prune. +* @return +* - (0) if successful. +* - (-ENODEV) if *port* invalid. +* - (-EINVAL) if bad parameter. +*/ +__rte_experimental +int rte_pmd_i40e_set_pf_src_prune(uint16_t port, +uint8_t on); + #ifdef __cplusplus }#endif
drivers/net/i40e/version.map +1 -0
@@ -46,4 +46,5 @@ EXPERIMENTAL { rte_pmd_i40e_get_fdir_stats; rte_pmd_i40e_set_gre_key_len; rte_pmd_i40e_set_switch_dev; + rte_pmd_i40e_set_pf_src_prune; };
Signature · 1 line
2.25.1
Quoted 7 lines · Mingjin Ye
VRRP advertisement packets are dropped on i40e PF device because when a MAC address is added to a device, packets originating from that MAC address are dropped.
This patch adds a PMD specific API to enable/disable source pruning to fix above issue.
Quoted 8 lines
Bugzilla ID: 648
Fixes 94b3c1a72507 ("net/i40e: move testpmd commands")Fixes bce83974ba2c ("net/i40e: set Tx loopback from PF")Fixes 96974a6600ec ("net/i40e: move private APIs to a specific file")Fixes 689bba33272d ("i40e: add VEB switching support")Fixes 440499cf5376 ("net/i40e: support floating VEB")Fixes ef4c16fd9148 ("net/i40e: refactor RSS flow")
I see this as a new feature.
Please don't mark faulty any commit that touched this code (especially the ones that only moved code around).
This is confusing.
Quoted 1 line
This commit changes the default behavior, with no way to return to the old behavior (afaics).
Backporting it poses a risk of breaking existing applications.
Quoted 2 lines
Signed-off-by Mingjin Ye <[email protected]>
Signature · 1 line
David Marchand
Morten Brørup
Acked-byQuoted 10 lines
From: David Marchand [mailto:[email protected]]
Sent: Monday, 17 April 2023 09.11Quoted 6 lines · Mingjin Ye
VRRP advertisement packets are dropped on i40e PF device because when a MAC address is added to a device, packets originating from that MAC address are dropped.
This patch adds a PMD specific API to enable/disable source pruning to fix above issue.
Please amend the above sentence to mention that this patch changes the default behavior, e.g.:
This patch fixes the bug by disabling source pruning by default, and adds a PMD specific API to enable/disable source pruning.
Quoted 11 lines
Quoted 9 lines
Bugzilla ID: 648
Fixes 94b3c1a72507 ("net/i40e: move testpmd commands")Fixes bce83974ba2c ("net/i40e: set Tx loopback from PF")Fixes 96974a6600ec ("net/i40e: move private APIs to a specific file")Fixes 689bba33272d ("i40e: add VEB switching support")Fixes 440499cf5376 ("net/i40e: support floating VEB")Fixes ef4c16fd9148 ("net/i40e: refactor RSS flow")I see this as a new feature.
The main purpose of PMD change itself is to fix a bug (with low probability, but high impact if no workaround has been implemented in the application).
Adding the new function to set the source pruning behavior makes the code readable.
Quoted 6 lines
Please don't mark faulty any commit that touched this code (especially the ones that only moved code around).
This is confusing.
Quoted 7 lines
Quoted 1 line
Cc stable maintainers.This commit changes the default behavior, with no way to return to the old behavior (afaics).
Backporting it poses a risk of breaking existing applications.
Correct, but it also fixes a bug that may go unnoticed in applications until they are deployed in networks where VRRP is used.
The default behavior was extremely strange, and the new default behavior makes perfect sense.
NB: I wanted to add some arguments in favor of this bugfix, which I consider important. Please do not ignore David's warnings!
Quoted 2 lines
From: Morten Brørup
Sent: Monday, 17 April 2023 12.02
Resent to Luca's other email address. The debian.org address could not be reached due to SPF problems. (Luca has been informed directly.)
Quoted 60 lines
Quoted 11 lines
From: David Marchand [mailto:[email protected]]
Sent: Monday, 17 April 2023 09.11Quoted 6 lines · Mingjin Ye
VRRP advertisement packets are dropped on i40e PF device because when a MAC address is added to a device, packets originating from that MAC address are dropped.
This patch adds a PMD specific API to enable/disable source pruning to fix above issue.Please amend the above sentence to mention that this patch changes the default behavior, e.g.:
This patch fixes the bug by disabling source pruning by default, and adds a PMD specific API to enable/disable source pruning.
Quoted 11 lines
Quoted 9 lines
Bugzilla ID: 648
Fixes 94b3c1a72507 ("net/i40e: move testpmd commands")Fixes bce83974ba2c ("net/i40e: set Tx loopback from PF")Fixes 96974a6600ec ("net/i40e: move private APIs to a specific file")Fixes 689bba33272d ("i40e: add VEB switching support")Fixes 440499cf5376 ("net/i40e: support floating VEB")Fixes ef4c16fd9148 ("net/i40e: refactor RSS flow")I see this as a new feature.
The main purpose of PMD change itself is to fix a bug (with low probability, but high impact if no workaround has been implemented in the application).
Adding the new function to set the source pruning behavior makes the code readable.
Quoted 6 lines
Please don't mark faulty any commit that touched this code (especially the ones that only moved code around).
This is confusing.Quoted 7 lines
Quoted 1 line
Cc stable maintainers.This commit changes the default behavior, with no way to return to the old behavior (afaics).
Backporting it poses a risk of breaking existing applications.Correct, but it also fixes a bug that may go unnoticed in applications until they are deployed in networks where VRRP is used.
The default behavior was extremely strange, and the new default behavior makes perfect sense.
Acked-by Morten Brørup <[email protected]>NB: I wanted to add some arguments in favor of this bugfix, which I consider important. Please do not ignore David's warnings!
PATCH v4 1/1 net/i40e: support enable/disable source pruning
In reply to Mingjin YeVRRP advertisement packets are dropped on i40e PF device because when a MAC address is added to a device, packets originating from that MAC address are dropped.
This patch fixes the bug by disabling source pruning by default, and adds a PMD specific API to enable/disable source pruning.
Bugzilla ID: 648
---
v3: The i40e specific commands are moved todrivers/net/i40e/i40e_testpmd.c.
--
v4: Modify the commit log.
--- drivers/net/i40e/i40e_ethdev.c | 43 ++++++++++++++++ drivers/net/i40e/i40e_ethdev.h | 1 + drivers/net/i40e/i40e_testpmd.c | 88 +++++++++++++++++++++++++++++++++ drivers/net/i40e/rte_pmd_i40e.c | 20 ++++++++ drivers/net/i40e/rte_pmd_i40e.h | 17 +++++++ drivers/net/i40e/version.map | 1 + 6 files changed, 170 insertions(+)
drivers/net/i40e/i40e_ethdev.c +43 -0
@@ -5647,6 +5647,46 @@ i40e_enable_pf_lb(struct i40e_pf *pf) hw->aq.asq_last_status); } +/* i40e_pf_set_source_prune +* @pf: pointer to the pf structure +* @on: Enable/disable source prune +* +* set source prune on pf +*/ +int +i40e_pf_set_source_prune (struct i40e_pf *pf,int on) +{ +struct i40e_hw *hw =I40E_PF_TO_HW (pf); +struct i40e_vsi_context ctxt; +int ret; + +memset (&ctxt,0 ,sizeof (ctxt)); + ctxt.seid = pf->main_vsi_seid; + ctxt.pf_num = hw->pf_id; + ret =i40e_aq_get_vsi_params (hw, &ctxt,NULL ); +if (ret) { +PMD_DRV_LOG (ERR ,"cannot get pf vsi config, err %d, aq_err %d" , + ret, hw->aq.asq_last_status); +return ret; + } + ctxt.flags =I40E_AQ_VSI_TYPE_PF ; + ctxt.info.valid_sections = +rte_cpu_to_le_16 (I40E_AQ_VSI_PROP_SWITCH_VALID ); +if (on) + ctxt.info.switch_id &= + ~rte_cpu_to_le_16 (I40E_AQ_VSI_SW_ID_FLAG_LOCAL_LB ); +else + ctxt.info.switch_id |= +rte_cpu_to_le_16 (I40E_AQ_VSI_SW_ID_FLAG_LOCAL_LB ); + + ret =i40e_aq_update_vsi_params (hw, &ctxt,NULL ); +if (ret) +PMD_DRV_LOG (ERR ,"update vsi switch failed, aq_err=%d" , + hw->aq.asq_last_status); + +return ret; +} +/* Setup a VSI */ struct i40e_vsi * i40e_vsi_setup(struct i40e_pf *pf,
@@ -5704,6 +5744,9 @@ i40e_vsi_setup(struct i40e_pf *pf, } } +/* source prune is disabled to support VRRP in default*/ +i40e_pf_set_source_prune (pf,0 ); + vsi =rte_zmalloc ("i40e_vsi" ,sizeof (struct i40e_vsi ),0 );if (!vsi) {PMD_DRV_LOG (ERR ,"Failed to allocate memory for vsi" );
drivers/net/i40e/i40e_ethdev.h +1 -0
@@ -1430,6 +1430,7 @@ int i40e_pf_calc_configured_queues_num(struct i40e_pf *pf);int i40e_pf_reset_rss_reta (struct i40e_pf *pf);int i40e_pf_reset_rss_key (struct i40e_pf *pf);int i40e_pf_config_rss (struct i40e_pf *pf); +int i40e_pf_set_source_prune (struct i40e_pf *pf,int on);int i40e_set_rss_key (struct i40e_vsi *vsi,uint8_t *key,uint8_t key_len);int i40e_set_rss_lut (struct i40e_vsi *vsi,uint8_t *lut,uint16_t lut_size);int i40e_vf_representor_init (struct rte_eth_dev *ethdev,void *init_params);
drivers/net/i40e/i40e_testpmd.c +88 -0
100 lines not on this page · raw message
drivers/net/i40e/rte_pmd_i40e.c +20 -0
@@ -3282,3 +3282,23 @@ rte_pmd_i40e_set_switch_dev(uint16_t port_id, struct rte_eth_dev *switch_dev)return 0 ; } + +int +rte_pmd_i40e_set_pf_src_prune (uint16_t port,uint8_t on) +{ +struct rte_eth_dev *dev; +struct i40e_pf *pf; +int ret; + +RTE_ETH_VALID_PORTID_OR_ERR_RET (port, -ENODEV ); + + dev = &rte_eth_devices[port]; + +if (!is_i40e_supported (dev)) +return -ENOTSUP ; + + pf =I40E_DEV_PRIVATE_TO_PF (dev->data->dev_private); + + ret =i40e_pf_set_source_prune (pf, on); +return ret; +}
drivers/net/i40e/rte_pmd_i40e.h +17 -0
@@ -1134,6 +1134,23 @@ __rte_experimentalint rte_pmd_i40e_set_switch_dev (uint16_t port_id,struct rte_eth_dev *switch_dev); +/** +* Enable/Disable source prune on all the PF. +* +* @param port +* The port identifier of the Ethernet device. +* @param on +* 1 - Enable source prune. +* 0 - Disable source prune. +* @return +* - (0) if successful. +* - (-ENODEV) if *port* invalid. +* - (-EINVAL) if bad parameter. +*/ +__rte_experimental +int rte_pmd_i40e_set_pf_src_prune(uint16_t port, +uint8_t on); + #ifdef __cplusplus }#endif
drivers/net/i40e/version.map +1 -0
@@ -46,4 +46,5 @@ EXPERIMENTAL { rte_pmd_i40e_get_fdir_stats; rte_pmd_i40e_set_gre_key_len; rte_pmd_i40e_set_switch_dev; + rte_pmd_i40e_set_pf_src_prune; };
Signature · 1 line
2.25.1
Quoted 271 lines · MingjinX
VRRP advertisement packets are dropped on i40e PF device because when a MAC address is added to a device, packets originating from that MAC address are dropped.
This patch fixes the bug by disabling source pruning by default, and adds a PMD specific API to enable/disable source pruning.Bugzilla ID: 648
Signed-off-by Mingjin Ye <[email protected]>---
v3: The i40e specific commands are moved todrivers/net/i40e/i40e_testpmd.c.
--
v4: Modify the commit log.
---drivers/net/i40e/i40e_ethdev.c | 43 ++++++++++++++++ drivers/net/i40e/i40e_ethdev.h | 1 + drivers/net/i40e/i40e_testpmd.c | 88 +++++++++++++++++++++++++++++++++ drivers/net/i40e/rte_pmd_i40e.c | 20 ++++++++ drivers/net/i40e/rte_pmd_i40e.h | 17 +++++++ drivers/net/i40e/version.map | 1 + 6 files changed, 170 insertions(+)drivers/net/i40e/i40e_ethdev.c +40
-0@@ -5647,6 +5647,46 @@ i40e_enable_pf_lb(struct i40e_pf *pf) hw->aq.asq_last_status); } +/* i40e_pf_set_source_prune +* @pf: pointer to the pf structure +* @on: Enable/disable source prune +* +* set source prune on pf +*/ +int +i40e_pf_set_source_prune (struct i40e_pf *pf,int on) +{ +struct i40e_hw *hw =I40E_PF_TO_HW (pf); +struct i40e_vsi_context ctxt; +int ret; + +memset (&ctxt,0 ,sizeof (ctxt)); + ctxt.seid = pf->main_vsi_seid; + ctxt.pf_num = hw->pf_id; + ret =i40e_aq_get_vsi_params (hw, &ctxt,NULL ); +if (ret) { +PMD_DRV_LOG (ERR ,"cannot get pf vsi config, err %d, aq_err %d" , + ret, hw->aq.asq_last_status); +return ret; + } + ctxt.flags =I40E_AQ_VSI_TYPE_PF ; + ctxt.info.valid_sections = +rte_cpu_to_le_16 (I40E_AQ_VSI_PROP_SWITCH_VALID ); +if (on) + ctxt.info.switch_id &= + ~rte_cpu_to_le_16 (I40E_AQ_VSI_SW_ID_FLAG_LOCAL_LB ); +else + ctxt.info.switch_id |= +rte_cpu_to_le_16 (I40E_AQ_VSI_SW_ID_FLAG_LOCAL_LB ); + + ret =i40e_aq_update_vsi_params (hw, &ctxt,NULL ); +if (ret) +PMD_DRV_LOG (ERR ,"update vsi switch failed, aq_err=%d" , + hw->aq.asq_last_status); + +return ret; +} +/* Setup a VSI */ struct
i40e_vsi*
i40e_vsi_setup(structi40e_pf*pf,drivers/net/i40e/i40e_ethdev.c +3
-0@@ -5704,6 +5744,9 @@ i40e_vsi_setup(struct i40e_pf *pf, } } +/* source prune is disabled to support VRRP in default*/ +i40e_pf_set_source_prune (pf,0 ); + vsi =rte_zmalloc ("i40e_vsi" ,sizeof (struct i40e_vsi ),0 );if (!vsi) {PMD_DRV_LOG (ERR ,"Failed to allocate memory for vsi" );drivers/net/i40e/i40e_ethdev.h +1
-0@@ -1430,6 +1430,7 @@ int i40e_pf_calc_configured_queues_num(struct i40e_pf *pf);int i40e_pf_reset_rss_reta (struct i40e_pf *pf);int i40e_pf_reset_rss_key (struct i40e_pf *pf);int i40e_pf_config_rss (struct i40e_pf *pf); +int i40e_pf_set_source_prune (struct i40e_pf *pf,int on);int i40e_set_rss_key (struct i40e_vsi *vsi,uint8_t *key,uint8_t key_len);int i40e_set_rss_lut (struct i40e_vsi *vsi,uint8_t *lut,uint16_t lut_size);int i40e_vf_representor_init (struct rte_eth_dev *ethdev,void *init_params);drivers/net/i40e/i40e_testpmd.c +88
-0@@ -2446,6 +2446,84 @@ static cmdline_parse_inst_t cmd_ptype_mapping_update = { }, }; +/* *** configure source prune for port *** */ +struct cmd_config_src_prune_result { +cmdline_fixed_string_t port; +cmdline_fixed_string_t keyword; +cmdline_fixed_string_t port_all;/* valid if "allports" argument == 1 */ +uint16_t port_id;/* valid if "allports" argument == 0 */ +cmdline_fixed_string_t item; +cmdline_fixed_string_t enable; +}; + +static void cmd_config_pf_src_prune_parsed (void *parsed_result, + __rte_unused struct cmdline *cl, +void *allports) +{ +struct cmd_config_src_prune_result *res = parsed_result; +uint8_t enable; +uint16_t i; + +if (!strcmp (res->enable,"on" )) + enable =1 ; +else + enable =0 ; + +/* all ports */ +if (allports) { +RTE_ETH_FOREACH_DEV (i) +rte_pmd_i40e_set_pf_src_prune (i, enable); + }else { +rte_pmd_i40e_set_pf_src_prune (res->port_id, enable); + } +} + +static cmdline_parse_token_string_t cmd_config_src_prune_port = + TOKEN_STRING_INITIALIZER(struct cmd_config_src_prune_result, port, "port"); +static cmdline_parse_token_string_t cmd_config_src_prune_keyword = + TOKEN_STRING_INITIALIZER(struct cmd_config_src_prune_result, keyword, +"config" ); +static cmdline_parse_token_string_t cmd_config_src_prune_portall = + TOKEN_STRING_INITIALIZER(struct cmd_config_src_prune_result, port_all, +"all" ); +static cmdline_parse_token_num_t cmd_config_src_prune_port_id = + TOKEN_NUM_INITIALIZER(struct cmd_config_src_prune_result, port_id, +RTE_UINT16 ); +static cmdline_parse_token_string_t cmd_config_src_prune_item = + TOKEN_STRING_INITIALIZER(struct cmd_config_src_prune_result, + item,"i40e_src_prune" ); +static cmdline_parse_token_string_t cmd_config_src_prune_enable = + TOKEN_STRING_INITIALIZER(struct cmd_config_src_prune_result, enable, +"on#off" ); + +static cmdline_parse_inst_t cmd_config_src_prune_all = { + .f = cmd_config_pf_src_prune_parsed, + .data = (void *)1 , + .help_str ="port config all i40e_src_prune on|off: Set source pruning on all pf ports." , + .tokens = { + (void *)&cmd_config_src_prune_port, + (void *)&cmd_config_src_prune_keyword, + (void *)&cmd_config_src_prune_portall, + (void *)&cmd_config_src_prune_item, + (void *)&cmd_config_src_prune_enable, +NULL , + }, +}; + +static cmdline_parse_inst_t cmd_config_src_prune_specific = { + .f = cmd_config_pf_src_prune_parsed, + .data = (void *)0 , + .help_str ="port config <port_id> i40e_src_prune on|off: Set source pruning on specific pf port." , + .tokens = { + (void *)&cmd_config_src_prune_port, + (void *)&cmd_config_src_prune_keyword, + (void *)&cmd_config_src_prune_port_id, + (void *)&cmd_config_src_prune_item, + (void *)&cmd_config_src_prune_enable, +NULL , + }, +}; +static struct testpmd_driver_commands i40e_cmds = { .commands = { {@@ -2592,6 +2670,16 @@ static struct testpmd_driver_commands i40e_cmds = { " (pctype_id_0[,pctype_id_1]*) (flow_type_id)\n" " Update a flow type to pctype mapping item on a port\n", }, + { + &cmd_config_src_prune_all, +"port config all i40e_src_prune (on|off)\n" +" Set source pruning on pf port all.\n" + }, + { + &cmd_config_src_prune_specific, +"port config (port_id) i40e_src_prune (on|off)\n" +" Set source pruning on pf port_id.\n" + }, { NULL, NULL }, }, };drivers/net/i40e/rte_pmd_i40e.c +20
-0@@ -3282,3 +3282,23 @@ rte_pmd_i40e_set_switch_dev(uint16_t port_id, struct rte_eth_dev *switch_dev)return 0 ; } + +int +rte_pmd_i40e_set_pf_src_prune (uint16_t port,uint8_t on) +{ +struct rte_eth_dev *dev; +struct i40e_pf *pf; +int ret; + +RTE_ETH_VALID_PORTID_OR_ERR_RET (port, -ENODEV ); + + dev = &rte_eth_devices[port]; + +if (!is_i40e_supported (dev)) +return -ENOTSUP ; + + pf =I40E_DEV_PRIVATE_TO_PF (dev->data->dev_private); + + ret =i40e_pf_set_source_prune (pf, on); +return ret; +}drivers/net/i40e/rte_pmd_i40e.h +0
-0@@ -1134,6 +1134,23 @@ __rte_experimentalint
rte_pmd_i40e_set_switch_dev(uint16_t port_id, struct rte_eth_dev *switch_dev);drivers/net/i40e/rte_pmd_i40e.h +17
-0+/** +* Enable/Disable source prune on all the PF. +* +* @param port +* The port identifier of the Ethernet device. +* @param on +* 1 - Enable source prune. +* 0 - Disable source prune. +* @return +* - (0) if successful. +* - (-ENODEV) if *port* invalid. +* - (-EINVAL) if bad parameter. +*/ +__rte_experimental +int rte_pmd_i40e_set_pf_src_prune(uint16_t port, +uint8_t on); +#ifdef
__cplusplus
}
#endifdrivers/net/i40e/version.map +1
-0@@ -46,4 +46,5 @@ EXPERIMENTAL { rte_pmd_i40e_get_fdir_stats; rte_pmd_i40e_set_gre_key_len; rte_pmd_i40e_set_switch_dev; + rte_pmd_i40e_set_pf_src_prune; };
Quoted 3 lines
—
2.25.1
The patch appears to correct the issue reported in bug 648.
Quoted 27 lines
-----Original Message-----
From: Mingjin Ye <[email protected]>
Sent: Monday, April 17, 2023 9:52 AM
To: [email protected]
Cc: Yang, Qiming <[email protected]>; [email protected]; Zhou, YidingX <[email protected]>; Ye, MingjinX <[email protected]>; Zhang, Yuying <[email protected]>; Xing, Beilei <[email protected]>
Subject: [PATCH v3] net/i40e: support enable/disable source pruningVRRP advertisement packets are dropped on i40e PF device because when a MAC address is added to a device, packets originating from that MAC address are dropped.
This patch adds a PMD specific API to enable/disable source pruning to fix above issue.Bugzilla ID: 648
Fixes 94b3c1a72507 ("net/i40e: move testpmd commands")Fixes bce83974ba2c ("net/i40e: set Tx loopback from PF")Fixes 96974a6600ec ("net/i40e: move private APIs to a specific file")Fixes 689bba33272d ("i40e: add VEB switching support")Fixes 440499cf5376 ("net/i40e: support floating VEB")Fixes ef4c16fd9148 ("net/i40e: refactor RSS flow")
Quoted 1 line
Signed-off-by Mingjin Ye <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi