Skip to contentSkip to conversation

Code levels in error log entries

DISCUSSION Matt Spinler 2 participants 4 messages Mar 21, 2018 – Apr 30, 2018

lore
Share & tools
lore
#0 lore raw

For IBM systems, we need to add the current code level to each error log object as it's created to make it easier on the lives of support personnel. It would be a new interface (or maybe use an existing code version one) on the /xyz/openbmc_project/logging/entry/X objects.

Does anyone here that also uses error logs have an opinion on if they would also be interested in this or not, so it would go into the common logging code?

Unless others are interested in it, I plan on putting it in an IBM specific repository. (or maybe turn on with a configure option?)

Thanks

#1 lore raw
Quoted 11 lines · Matt Spinler

For IBM systems, we need to add the current code level to each error log object as it's created to make it easier on the lives of support personnel. It would be a new interface (or maybe use an existing code version one) on the /xyz/openbmc_project/logging/entry/X objects.

Does anyone here that also uses error logs have an opinion on if they would also be interested in this or not, so it would go into the common logging code?

Unless others are interested in it, I plan on putting it in an IBM specific repository. (or maybe turn on with a configure option?)

After some additional discussion, we decided this would be useful enough to warrant putting it into the base error logging code. I plan on adding the xyz.openbmc_project.Software.Version interface to the logging objects and populating it with the VERSION_ID field from /etc/os-release.

Quoted 2 lines

Thanks

#2 lore raw
Quoted 10 lines · Matt Spinler
Quoted 9 lines · Matt Spinler

For IBM systems, we need to add the current code level to each error log object as it's created to make it easier on the lives of support personnel.  It would be a new interface (or maybe use an existing code version one) on the /xyz/openbmc_project/logging/entry/X objects.

Does anyone here that also uses error logs have an opinion on if they would also be interested in this or not, so it would go into the common logging code?

Quoted 8 lines
Quoted 2 lines

Unless others are interested in it, I plan on putting it in an IBM specific repository.  (or maybe turn on with a configure option?)

After some additional discussion, we decided this would be useful enough to warrant putting it into the base error logging code.  I plan on adding the xyz.openbmc_project.Software.Version interface to the logging objects and populating it with the VERSION_ID field from /etc/os-release.

I see the Version interface also has a 'VersionPurpose' enum property. What would you populate that with? VersionPurpose.BMC? What if the error was from host and the version required was that of the host firmware?

Also, the value that gets into the /etc/os-release is known to the os-release recipe, so you could provide that to the logging recipe at build time (ipmi does something similar).

Quoted 5 lines
Quoted 5 lines

Thanks

Thanks,
Deepak

#3 lore raw
Quoted 20 lines · Deepak Kodihalli
Quoted 10 lines · Matt Spinler
Quoted 9 lines · Matt Spinler

For IBM systems, we need to add the current code level to each error log object as it's created to make it easier on the lives of support personnel.  It would be a new interface (or maybe use an existing code version one) on the /xyz/openbmc_project/logging/entry/X objects.

Does anyone here that also uses error logs have an opinion on if they would also be interested in this or not, so it would go into the common logging code?

Quoted 8 lines
Quoted 2 lines

Unless others are interested in it, I plan on putting it in an IBM specific repository.  (or maybe turn on with a configure option?)

After some additional discussion, we decided this would be useful enough to warrant putting it into the base error logging code.  I plan on adding the xyz.openbmc_project.Software.Version interface to the logging objects and populating it with the VERSION_ID field from /etc/os-release.

Quoted 4 lines

I see the Version interface also has a 'VersionPurpose' enum property. What would you populate that with? VersionPurpose.BMC? What if the error was from host and the version required was that of the host firmware?

I was always planning on putting the BMC code version into this. In the case of OpenPower, the host already includes their code version in their embedded PEL error I believe.

Quoted 4 lines

Also, the value that gets into the /etc/os-release is known to the os-release recipe, so you could provide that to the logging recipe at build time (ipmi does something similar).

Thanks. Will look into that.

Quoted 9 lines
Quoted 6 lines
Quoted 6 lines

Thanks

Thanks,
Deepak