Skip to contentSkip to conversation

arm64: dts: allwinner: a64: Add overlay for Realtek

RFC In review Peter Robinson 3 participants 5 messages Apr 19, 2025 – Apr 21, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

RFC 1/1 arm64: dts: allwinner: a64: Add overlay for Realtek

Add overlay for the Pine64 Realtek rtl8723bs WiFi module that works on the Pine64/64+/SoPine devices.

I've looked at overlays for other vendors, such as available for some of the Rockchip devices, and I believe I have this mostly correct but would like some feedback both on if I have everything needed for Allwinner devices, but also what's needed to be able to use a single overlay across more than one device.

This is dependent on the following [1] patch series.

Peter

[1] https://lore.kernel.org/linux-devicetree/[email protected]/t/#u

---
 arch/arm64/boot/dts/allwinner/Makefile        |  6 ++++
 .../allwinner/sun50i-a64-pine64-realtek.dtso  | 30 +++++++++++++++++++
 2 files changed, 36 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso
arch/arm64/boot/dts/allwinner/Makefile +6 -0
index 00bed412ee31..be991f8d8110 100644
@@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-olinuxino-emmc.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-plus.dtb sun50i-a64-pine64.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-realtek.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinebook.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.0.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.1.dtb
@@ -52,3 +53,8 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-2024.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-h.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-plus.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-sp.dtb
+
+# Overlays
+sun50i-a64-pine64-realtek-dtbs      := sun50i-a64-pine64.dtb sun50i-a64-pine64-realtek.dtbo
+sun50i-a64-pine64-lts-realtek-dtbs  := sun50i-a64-pine64-lts.dtb sun50i-a64-pine64-realtek.dtbo
+sun50i-a64-pine64-plus-realtek-dtbs := sun50i-a64-pine64-plus.dtb sun50i-a64-pine64-realtek.dtbo
arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso new file +30 -0
new file mode 100644
index 000000000000..51b57a46e23f
@@ -0,0 +1,30 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+// Copyright (c) 2025 Peter Robinson
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+
+&mmc1 {
+	status = "okay";
+
+	rtl8723bs: wifi@1 {
+		reg = <1>;
+		interrupt-parent = <&r_pio>;
+		interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 */
+		interrupt-names = "host-wake";
+	};
+};
+
+&uart1 {
+	status = "okay";
+
+	bluetooth {
+		compatible = "realtek,rtl8723bs-bt";
+		device-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
+		enable-gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
+		host-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* PL5 */
+	};
+};
Signature · 1 line
2.49.0
#1 lore raw

Hello Peter,

Quoted 47 lines · Peter Robinson

Add overlay for the Pine64 Realtek rtl8723bs WiFi module that works on the Pine64/64+/SoPine devices.

I've looked at overlays for other vendors, such as available for some of the Rockchip devices, and I believe I have this mostly correct but would like some feedback both on if I have everything needed for Allwinner devices, but also what's needed to be able to use a single overlay across more than one device.

This is dependent on the following [1] patch series.

Peter

[1] https://lore.kernel.org/linux-devicetree/[email protected]/t/#u

---
 arch/arm64/boot/dts/allwinner/Makefile        |  6 ++++
 .../allwinner/sun50i-a64-pine64-realtek.dtso  | 30 +++++++++++++++++++
 2 files changed, 36 insertions(+)
 create mode 100644 

arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso

arch/arm64/boot/dts/allwinner/Makefile +0 -0
index 00bed412ee31..be991f8d8110 100644
@@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += 

sun50i-a64-olinuxino-emmc.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-plus.dtb
sun50i-a64-pine64.dtb

arch/arm64/boot/dts/allwinner/Makefile +1 -0
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-realtek.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinebook.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.0.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.1.dtb
@@ -52,3 +53,8 @@ dtb-$(CONFIG_ARCH_SUNXI) +=

sun50i-h700-anbernic-rg35xx-2024.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-h.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-plus.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-sp.dtb

arch/arm64/boot/dts/allwinner/Makefile +3 -0
+
+# Overlays
+sun50i-a64-pine64-realtek-dtbs      := sun50i-a64-pine64.dtb
Quoted 5 lines

sun50i-a64-pine64-realtek.dtbo +sun50i-a64-pine64-lts-realtek-dtbs := sun50i-a64-pine64-lts.dtb sun50i-a64-pine64-realtek.dtbo +sun50i-a64-pine64-plus-realtek-dtbs := sun50i-a64-pine64-plus.dtb sun50i-a64-pine64-realtek.dtbo

Thanks for the patch, having this DT overlay makes perfectly sense to me. The only possible issues may arise from the resulting size increase of the compiled .dtb files, caused by the implicit inclusion of symbols.

However, please see an earlier linux-rockchip thread [2] that shows the desired layout of the additions to the Makefile, which was determined through a few rounds of discussion.

Finally, I think we should choose a slightly better name for the DT overlay, instead of "sun50i-a64-pine64-realtek.dtso", in which "-realtek" seems a bit to vague. Perhaps "-wifi-bt-addon" as the filename suffix would fit better, and it's virtually guaranteed that there will be no new version of that add-on board, so there should be no potential for name clashing.

As a minor suggestion, the patch subject should also be tweaked a bit, because "Realtek" is also a bit too vague there.

[2] https://lore.kernel.org/linux-rockchip/[email protected]/

Quoted 38 lines

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso new file mode 100644
index 000000000000..51b57a46e23f

arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso new file +30 -0
@@ -0,0 +1,30 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+// Copyright (c) 2025 Peter Robinson
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+
+&mmc1 {
+	status = "okay";
+
+	rtl8723bs: wifi@1 {
+		reg = <1>;
+		interrupt-parent = <&r_pio>;
+		interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 */
+		interrupt-names = "host-wake";
+	};
+};
+
+&uart1 {
+	status = "okay";
+
+	bluetooth {
+		compatible = "realtek,rtl8723bs-bt";
+		device-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
+		enable-gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
+		host-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* PL5 */
+	};
+};
#2 lore raw
Quoted 62 lines · Dragan Simic

Hello Peter,

Quoted 48 lines · Peter Robinson

Add overlay for the Pine64 Realtek rtl8723bs WiFi module that works on the Pine64/64+/SoPine devices.

I've looked at overlays for other vendors, such as available for some of the Rockchip devices, and I believe I have this mostly correct but would like some feedback both on if I have everything needed for Allwinner devices, but also what's needed to be able to use a single overlay across more than one device.

This is dependent on the following [1] patch series.

Peter

[1] https://lore.kernel.org/linux-devicetree/[email protected]/t/#u

---
 arch/arm64/boot/dts/allwinner/Makefile        |  6 ++++
 .../allwinner/sun50i-a64-pine64-realtek.dtso  | 30 
+++++++++++++++++++
 2 files changed, 36 insertions(+)
 create mode 100644 

arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso

arch/arm64/boot/dts/allwinner/Makefile +0 -0
index 00bed412ee31..be991f8d8110 100644
@@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += 

sun50i-a64-olinuxino-emmc.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-plus.dtb
sun50i-a64-pine64.dtb

arch/arm64/boot/dts/allwinner/Makefile +1 -0
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-realtek.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinebook.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.0.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.1.dtb
@@ -52,3 +53,8 @@ dtb-$(CONFIG_ARCH_SUNXI) +=

sun50i-h700-anbernic-rg35xx-2024.dtb
dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-h.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-plus.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-sp.dtb

arch/arm64/boot/dts/allwinner/Makefile +3 -0
+
+# Overlays
+sun50i-a64-pine64-realtek-dtbs      := sun50i-a64-pine64.dtb
Quoted 5 lines

sun50i-a64-pine64-realtek.dtbo +sun50i-a64-pine64-lts-realtek-dtbs := sun50i-a64-pine64-lts.dtb sun50i-a64-pine64-realtek.dtbo +sun50i-a64-pine64-plus-realtek-dtbs := sun50i-a64-pine64-plus.dtb sun50i-a64-pine64-realtek.dtbo

Thanks for the patch, having this DT overlay makes perfectly sense to me. The only possible issues may arise from the resulting size increase of the compiled .dtb files, caused by the implicit inclusion of symbols.

Quoted 3 lines

However, please see an earlier linux-rockchip thread [2] that shows the desired layout of the additions to the Makefile, which was determined through a few rounds of discussion.

Please, see another linux-rockchip thread [3][4] for more examples of the DT-overlay-related additions to the Makefile, which includes a rather neat comment block to be copied over.

Quoted 11 lines

Finally, I think we should choose a slightly better name for the DT overlay, instead of "sun50i-a64-pine64-realtek.dtso", in which "-realtek" seems a bit to vague. Perhaps "-wifi-bt-addon" as the filename suffix would fit better, and it's virtually guaranteed that there will be no new version of that add-on board, so there should be no potential for name clashing.

As a minor suggestion, the patch subject should also be tweaked a bit, because "Realtek" is also a bit too vague there.

[2] https://lore.kernel.org/linux-rockchip/[email protected]/

Having the above-mentioned ML thread [3][4] in mind, I think that "-wifi-bt" should actually be fine as the filename suffix. It would also result in some kind of consistency.

Finally, I'd suggest that you merge all three patches into a single series, because that's how they naturally fit together.

[3] https://lore.kernel.org/linux-rockchip/[email protected]/
[4] https://lore.kernel.org/linux-rockchip/[email protected]/

Quoted 38 lines
Quoted 38 lines

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso new file mode 100644
index 000000000000..51b57a46e23f

arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso new file +30 -0
@@ -0,0 +1,30 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+// Copyright (c) 2025 Peter Robinson
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+
+&mmc1 {
+	status = "okay";
+
+	rtl8723bs: wifi@1 {
+		reg = <1>;
+		interrupt-parent = <&r_pio>;
+		interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 */
+		interrupt-names = "host-wake";
+	};
+};
+
+&uart1 {
+	status = "okay";
+
+	bluetooth {
+		compatible = "realtek,rtl8723bs-bt";
+		device-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
+		enable-gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
+		host-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* PL5 */
+	};
+};
#3 lore raw
In reply to Dragan Simic
Quoted 67 lines · 在 2025-04-19星期六的 20:08 +0200,Dragan Simic写道:

Hello Peter,

Quoted 49 lines · Peter Robinson

Add overlay for the Pine64 Realtek rtl8723bs WiFi module that works on the Pine64/64+/SoPine devices.

I've looked at overlays for other vendors, such as available for some of the Rockchip devices, and I believe I have this mostly correct but would like some feedback both on if I have everything needed for Allwinner devices, but also what's needed to be able to use a single overlay across more than one device.

This is dependent on the following [1] patch series.

Peter

[1]
https://lore.kernel.org/linux-devicetree/[email protected]/t/#u

---
 arch/arm64/boot/dts/allwinner/Makefile        |  6 ++++ .../allwinner/sun50i-a64-pine64-realtek.dtso  | 30
+++++++++++++++++++

 2 files changed, 36 insertions(+)

 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso

arch/arm64/boot/dts/allwinner/Makefile +0 -0
index 00bed412ee31..be991f8d8110 100644
@@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += 

sun50i-a64-olinuxino-emmc.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-plus.dtb sun50i-a64-pine64.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-realtek.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinebook.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.0.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.1.dtb

arch/arm64/boot/dts/allwinner/Makefile +0 -0
@@ -52,3 +53,8 @@ dtb-$(CONFIG_ARCH_SUNXI) +=

sun50i-h700-anbernic-rg35xx-2024.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-h.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-plus.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-sp.dtb

arch/arm64/boot/dts/allwinner/Makefile +3 -0
+
+# Overlays
+sun50i-a64-pine64-realtek-dtbs      := sun50i-a64-pine64.dtb
Quoted 5 lines

sun50i-a64-pine64-realtek.dtbo +sun50i-a64-pine64-lts-realtek-dtbs  := sun50i-a64-pine64-lts.dtb sun50i-a64-pine64-realtek.dtbo +sun50i-a64-pine64-plus-realtek-dtbs := sun50i-a64-pine64-plus.dtb sun50i-a64-pine64-realtek.dtbo

Thanks for the patch, having this DT overlay makes perfectly sense to me.  The only possible issues may arise from the resulting size increase of the compiled .dtb files, caused by the implicit inclusion of symbols.

However, please see an earlier linux-rockchip thread [2] that shows the desired layout of the additions to the Makefile, which was determined through a few rounds of discussion.

Quoted 6 lines

Finally, I think we should choose a slightly better name for the DT overlay, instead of "sun50i-a64-pine64-realtek.dtso", in which "-realtek" seems a bit to vague.  Perhaps "-wifi-bt-addon" as the filename suffix would fit better, and it's virtually guaranteed that there will be no new version of that add-on board, so there should be no potential for name clashing.

Yes. In fact I think Pine64 messed up with pinouts of Wi-Fi modules and only the RTL8723BS module works with Pine A64. (The Broadcom/Ampak ones only work with Rockchip boards, as what I assumed.)

Quoted 49 lines

As a minor suggestion, the patch subject should also be tweaked a bit, because "Realtek" is also a bit too vague there.

[2]
https://lore.kernel.org/linux-rockchip/[email protected]/

Quoted 41 lines

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso new file mode 100644
index 000000000000..51b57a46e23f

arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso new file +26 -0
@@ -0,0 +1,30 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+// Copyright (c) 2025 Peter Robinson
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+
+&mmc1 {
+       status = "okay";
+
+       rtl8723bs: wifi@1 {
+               reg = <1>;
+               interrupt-parent = <&r_pio>;
+               interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 */
+               interrupt-names = "host-wake";
+       };
+};
+
+&uart1 {
+       status = "okay";
+
+       bluetooth {
+               compatible = "realtek,rtl8723bs-bt";
+               device-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;

/* PL6 */
+               enable-gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
+               host-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* PL5 */
+       };
+};

#4 lore raw

Hello Icenowy,

Quoted 75 lines · Icenowy Zheng
Quoted 67 lines · 在 2025-04-19星期六的 20:08 +0200,Dragan Simic写道:

Hello Peter,

Quoted 49 lines · Peter Robinson

Add overlay for the Pine64 Realtek rtl8723bs WiFi module that works on the Pine64/64+/SoPine devices.

I've looked at overlays for other vendors, such as available for some of the Rockchip devices, and I believe I have this mostly correct but would like some feedback both on if I have everything needed for Allwinner devices, but also what's needed to be able to use a single overlay across more than one device.

This is dependent on the following [1] patch series.

Peter

[1]
https://lore.kernel.org/linux-devicetree/[email protected]/t/#u

---
 arch/arm64/boot/dts/allwinner/Makefile        |  6 ++++ .../allwinner/sun50i-a64-pine64-realtek.dtso  | 30
+++++++++++++++++++

 2 files changed, 36 insertions(+)

 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-realtek.dtso

arch/arm64/boot/dts/allwinner/Makefile +0 -0
index 00bed412ee31..be991f8d8110 100644
@@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_SUNXI) +=

sun50i-a64-olinuxino-emmc.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-orangepi-win.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-lts.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-plus.dtb sun50i-a64-pine64.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pine64-realtek.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinebook.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.0.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinephone-1.1.dtb

arch/arm64/boot/dts/allwinner/Makefile +0 -0
@@ -52,3 +53,8 @@ dtb-$(CONFIG_ARCH_SUNXI) +=

sun50i-h700-anbernic-rg35xx-2024.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-h.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-plus.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-sp.dtb

arch/arm64/boot/dts/allwinner/Makefile +3 -0
+
+# Overlays
+sun50i-a64-pine64-realtek-dtbs      := sun50i-a64-pine64.dtb
Quoted 5 lines

sun50i-a64-pine64-realtek.dtbo +sun50i-a64-pine64-lts-realtek-dtbs  := sun50i-a64-pine64-lts.dtb sun50i-a64-pine64-realtek.dtbo +sun50i-a64-pine64-plus-realtek-dtbs := sun50i-a64-pine64-plus.dtb sun50i-a64-pine64-realtek.dtbo

Thanks for the patch, having this DT overlay makes perfectly sense to me.  The only possible issues may arise from the resulting size increase of the compiled .dtb files, caused by the implicit inclusion of symbols.

However, please see an earlier linux-rockchip thread [2] that shows the desired layout of the additions to the Makefile, which was determined through a few rounds of discussion.

Quoted 6 lines

Finally, I think we should choose a slightly better name for the DT overlay, instead of "sun50i-a64-pine64-realtek.dtso", in which "-realtek" seems a bit to vague.  Perhaps "-wifi-bt-addon" as the filename suffix would fit better, and it's virtually guaranteed that there will be no new version of that add-on board, so there should be no potential for name clashing.

Quoted 3 lines

Yes. In fact I think Pine64 messed up with pinouts of Wi-Fi modules and only the RTL8723BS module works with Pine A64. (The Broadcom/Ampak ones only work with Rockchip boards, as what I assumed.)

Yes, I can confirm that the two Pine64 WiFi+BT module variants aren't interchangeable. I forgot the details about the actual hardware differences, but they're large enough to be incompatible, which is quite unfortunate.

Quoted 5 lines
Quoted 5 lines

As a minor suggestion, the patch subject should also be tweaked a bit, because "Realtek" is also a bit too vague there.

[2]
https://lore.kernel.org/linux-rockchip/[email protected]/