Skip to contentSkip to conversation

cpuidle: psci: Extend information in log about OSI/PC mode

PATCH In review Ulf Hansson 4 participants 6 messages Oct 20, 2022 – Oct 28, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpuidle: psci: Extend information in log about OSI/PC mode

It's useful to understand whether we are using OS-initiated (OSI) mode or Platform Coordinated (PC) mode, when initializing the CPU PM domains. Therefore, let's extend the print in the log after a successful probe with this information.

---
 drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/cpuidle/cpuidle-psci-domain.c +2 -1
index 821984947ed9..c80cf9ddabd8 100644
@@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
 	if (ret)
 		goto remove_pd;
 
-	pr_info("Initialized CPU PM domain topology\n");
+	pr_info("Initialized CPU PM domain topology using %s mode\n",
+		use_osi ? "OSI" : "PC");
 	return 0;
 
 put_node:
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Ulf Hansson

It's useful to understand whether we are using OS-initiated (OSI) mode or Platform Coordinated (PC) mode, when initializing the CPU PM domains. Therefore, let's extend the print in the log after a successful probe with this information.

Looks good to me.

Signature · 7 lines
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Acked-by on v1 1/1
#2 lore raw
In reply to Ulf Hansson
Quoted 9 lines · Ulf Hansson

It's useful to understand whether we are using OS-initiated (OSI) mode or Platform Coordinated (PC) mode, when initializing the CPU PM domains. Therefore, let's extend the print in the log after a successful probe with this information.

---
  drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 8 lines
With best wishes
Dmitry


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw
In reply to Ulf Hansson
Quoted 16 lines · Ulf Hansson

It's useful to understand whether we are using OS-initiated (OSI) mode or Platform Coordinated (PC) mode, when initializing the CPU PM domains. Therefore, let's extend the print in the log after a successful probe with this information.

---
 drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/cpuidle/cpuidle-psci-domain.c +0 -0
index 821984947ed9..c80cf9ddabd8 100644

drivers/cpuidle/cpuidle-psci-domain.c static int psci_cpuidle_domain_probe(struct platform_device *pdev)

Quoted 10 lines
drivers/cpuidle/cpuidle-psci-domain.c +2 -2
@@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
        if (ret)
                goto remove_pd;
 
-       pr_info("Initialized CPU PM domain topology\n");
+       pr_info("Initialized CPU PM domain topology using %s mode\n",
+               use_osi ? "OSI" : "PC");
        return 0;
 
 put_node:
--

Am I expected to pick up this one?

#4 lore raw
Quoted 26 lines · Rafael J. Wysocki
Quoted 24 lines · Ulf Hansson

It's useful to understand whether we are using OS-initiated (OSI) mode or Platform Coordinated (PC) mode, when initializing the CPU PM domains. Therefore, let's extend the print in the log after a successful probe with this information.

---
 drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/cpuidle/cpuidle-psci-domain.c +2 -1
index 821984947ed9..c80cf9ddabd8 100644
@@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
        if (ret)
                goto remove_pd;
 
-       pr_info("Initialized CPU PM domain topology\n");
+       pr_info("Initialized CPU PM domain topology using %s mode\n",
+               use_osi ? "OSI" : "PC");
        return 0;
 
Quoted 4 lines

drivers/cpuidle/cpuidle-psci-domain.c static int psci_cpuidle_domain_probe(struct platform_device *pdev)

Quoted 2 lines
drivers/cpuidle/cpuidle-psci-domain.c +0 -1
 put_node:
--

Am I expected to pick up this one?

Yes, please!

Kind regards
Uffe

#5 lore raw
Quoted 28 lines · Ulf Hansson
Quoted 26 lines · Rafael J. Wysocki
Quoted 24 lines · Ulf Hansson

It's useful to understand whether we are using OS-initiated (OSI) mode or Platform Coordinated (PC) mode, when initializing the CPU PM domains. Therefore, let's extend the print in the log after a successful probe with this information.

---
 drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/cpuidle/cpuidle-psci-domain.c +2 -1
index 821984947ed9..c80cf9ddabd8 100644
@@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
        if (ret)
                goto remove_pd;
 
-       pr_info("Initialized CPU PM domain topology\n");
+       pr_info("Initialized CPU PM domain topology using %s mode\n",
+               use_osi ? "OSI" : "PC");
        return 0;
 
Quoted 6 lines
Quoted 4 lines

drivers/cpuidle/cpuidle-psci-domain.c static int psci_cpuidle_domain_probe(struct platform_device *pdev)

Quoted 2 lines
drivers/cpuidle/cpuidle-psci-domain.c +0 -1
 put_node:
--

Am I expected to pick up this one?

Yes, please!

Done, thanks!