Skip to contentSkip to conversation

Initial environment variables

U-Boot Ron Madrid 3 participants 4 messages Jul 16, 2009

lore
Share & tools
lore

Ron Madrid

author
#0 lore raw
Quoted 13 lines
Quoted 1 line · Ron Madrid

When I submitted patches for my new board SIMPC8313 I

recall being told that

Quoted 1 line

I had inappropriately initialized some of my

environment variables. Most

Quoted 1 line

specifically I am interested in having default

serverip, ipaddr, and ethaddr

Quoted 1 line

environment variables. Is this most

appropriately done with a specific

Quoted 1 line

#define (such as #define CONFIG_SERVERIP) or within

#define

Quoted 8 lines
Quoted 3 lines

CONFIG_EXTRA_ENV_SETTINGS?

You can set CONFIGs for all of these things in your own private build
and they'll work, but they're inappropriate for main-line U-boot. I
hope the reasoning is obvious.

I'm do not understand why and I see in several include/configs/*.h files that these environment variable are being set as default. I'm guessing that there's something that I'm missing.

Ron

#1 lore raw
Quoted 9 lines · On Thursday 16 July 2009 16:46:36 Ron Madrid wrote:
Quoted 9 lines
Quoted 7 lines · Ron Madrid

When I submitted patches for my new board SIMPC8313 I recall being told that I had inappropriately initialized some of my environment variables. Most specifically I am interested in having default serverip, ipaddr, and ethaddr environment variables. Is this most appropriately done with a specific
#define (such as #define CONFIG_SERVERIP) or within #define CONFIG_EXTRA_ENV_SETTINGS?

Quoted 7 lines
Quoted 3 lines

You can set CONFIGs for all of these things in your own private build and they'll work, but they're inappropriate for main-line U-boot. I hope the reasoning is obvious.

I'm do not understand why and I see in several include/configs/*.h files that these environment variable are being set as default. I'm guessing that there's something that I'm missing.

the board maintainer decides the default env values, not board users. Ben's comment was probably on the assumption that you are in the latter category. -mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090716/35e8a217/attachment.pgp

#2 lore raw

Dear Mike Frysinger,

Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 4 lines

I'm do not understand why and I see in several include/configs/*.h files that these environment variable are being set as default. I'm guessing that there's something that I'm missing.

the board maintainer decides the default env values, not board users. Ben's comment was probably on the assumption that you are in the latter category.

That's only the first stage.

After that, the custodian decides what is acceptable for mainline, and after that the project mainainer - ummm, that's me.

And we do not accept any "default network configurations" in mainline.

I'm really fed up by zillions of devices all coming up with the very same MAC address just because the board vendor (1) has no clue and (2) is too stingy to buy a block of MAC addresses.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I know engineers. They love to change things.             - Dr. McCoy
#3 lore raw
Quoted 11 lines · On Thursday 16 July 2009 18:21:57 Wolfgang Denk wrote:
Quoted 7 lines · Mike Frysinger
Quoted 3 lines

I'm do not understand why and I see in several include/configs/*.h files that these environment variable are being set as default. I'm guessing that there's something that I'm missing.

the board maintainer decides the default env values, not board users. Ben's comment was probably on the assumption that you are in the latter category.

That's only the first stage.

Quoted 8 lines

After that, the custodian decides what is acceptable for mainline, and after that the project mainainer - ummm, that's me.

And we do not accept any "default network configurations" in mainline.

I'm really fed up by zillions of devices all coming up with the very same MAC address just because the board vendor (1) has no clue and (2) is too stingy to buy a block of MAC addresses.

we arent talking mac addresses here which i agree -- any default/hardcoding there is wrong
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090716/2a7d2a7f/attachment.pgp