Remove the pins-are-numbered DT property
Subsystems (6)
v2 cover Remove the pins-are-numbered DT property
During the review of my MT8365 support patchset
(https://lore.kernel.org/linux-mediatek/[email protected]/),
the issue of the "pins-are-numbered" DeviceTree property has come up.
This property is unique to Mediatek MT65xx and STM32 pinctrls, and doesn't seem to serve any purpose (both the Mediatek and STM32 drivers simply refuse to deal with a device unless pins-are-numbered is set to true).
There is no other use of this property in the kernel or in other projects using DeviceTrees (checked u-boot and FreeBSD -- in both of those, the flag is present in Mediatek and STM devicetrees, but not used anywhere).
There is also no known use in userspace (in fact, a userland application relying on the property would be broken because it would get true on any Mediatek or STM chipset and false on all others, even though other chipsets use numbered pins).
This patchset removes all uses of pins-are-numbered and marks the property as deprecated.
v2:
- Deprecate the property instead of removing it completely from schemas
- squash some related commits
Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml | 5 ++--- Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 7 +++---- arch/arm/boot/dts/mt2701.dtsi | 1 - arch/arm/boot/dts/mt7623.dtsi | 1 - arch/arm/boot/dts/mt8135.dtsi | 1 - arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 1 - arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 1 - arch/arm/boot/dts/stm32h743.dtsi | 1 - arch/arm/boot/dts/stm32mp131.dtsi | 1 - arch/arm/boot/dts/stm32mp151.dtsi | 2 -- arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 1 - arch/arm64/boot/dts/mediatek/mt8167.dtsi | 1 - arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 1 - arch/arm64/boot/dts/mediatek/mt8173.dtsi | 1 - arch/arm64/boot/dts/mediatek/mt8516.dtsi | 1 - drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 6 ------ drivers/pinctrl/stm32/pinctrl-stm32.c | 5 ----- 17 files changed, 5 insertions(+), 32 deletions(-)
PATCH v2 1/7 pinctrl: mediatek: common: Remove check for pins-are-numbered
Remove the check for the unnecessary pins-are-numbered Devicetree property.
--- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/pinctrl/mediatek/pinctrl-mtk-common.c +0 -6
@@ -1057,7 +1057,6 @@ int mtk_pctrl_init(struct platform_device *pdev,struct pinctrl_pin_desc *pins;struct mtk_pinctrl *pctl;struct device_node *np = pdev->dev.of_node, *node; -struct property *prop;int ret, i; pctl =devm_kzalloc (&pdev->dev,sizeof (*pctl),GFP_KERNEL );
@@ -1066,11 +1065,6 @@ int mtk_pctrl_init(struct platform_device *pdev,platform_set_drvdata (pdev, pctl); - prop =of_find_property (np,"pins-are-numbered" ,NULL ); -if (!prop) -return dev_err_probe (dev, -EINVAL , -"only support pins-are-numbered format\n" ); - node =of_parse_phandle (np,"mediatek,pctl-regmap" ,0 );if (node) { pctl->regmap1 =syscon_node_to_regmap (node);
Signature · 1 line
2.38.1
PATCH v2 2/7 pinctrl: stm32: Remove check for pins-are-numbered
In reply to Bernhard RosenkränzerRemove the check for the unnecessary pins-are-numbered DeviceTree property
--- drivers/pinctrl/stm32/pinctrl-stm32.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/pinctrl/stm32/pinctrl-stm32.c +0 -5
@@ -1499,11 +1499,6 @@ int stm32_pctl_probe(struct platform_device *pdev)if (!match_data)return -EINVAL ; -if (!device_property_present (dev,"pins-are-numbered" )) { -dev_err (dev,"only support pins-are-numbered format\n" ); -return -EINVAL ; - } - pctl =devm_kzalloc (dev,sizeof (*pctl),GFP_KERNEL );if (!pctl)return -ENOMEM ;
Signature · 1 line
2.38.1
PATCH v2 3/7 dt-bindings: pinctrl: mediatek,mt65xx: Deprecate pins-are-numbered
In reply to Bernhard RosenkränzerMake pins-are-numbered optional and deprecate it
--- .../devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml +2 -3
@@ -31,7 +31,8 @@ properties: pins-are-numbered: $ref: /schemas/types.yaml#/definitions/flag description: | - Specify the subnodes are using numbered pinmux to specify pins. + Specify the subnodes are using numbered pinmux to specify pins. (UNUSED) + deprecated: true gpio-controller: true
@@ -62,7 +63,6 @@ properties: required: - compatible - - pins-are-numbered - gpio-controller - "#gpio-cells"
@@ -150,7 +150,6 @@ examples: compatible = "mediatek,mt8135-pinctrl"; reg = <0 0x1000B000 0 0x1000>; mediatek,pctl-regmap = <&syscfg_pctl_a>, <&syscfg_pctl_b>; - pins-are-numbered; gpio-controller; #gpio-cells = <2>; interrupt-controller;
Signature · 1 line
2.38.1
Re: [PATCH v2 3/7] dt-bindings: pinctrl: mediatek,mt65xx: Deprecate pins-are-numbered
Quoted 3 lines · Bernhard Rosenkränzer
Make pins-are-numbered optional and deprecate it
Signed-off-by Bernhard Rosenkränzer <[email protected]>
Quoted 34 lines
--- .../devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml +2
-3@@ -31,7 +31,8 @@ properties: pins-are-numbered: $ref: /schemas/types.yaml#/definitions/flag description: | - Specify the subnodes are using numbered pinmux to specify pins. + Specify the subnodes are using numbered pinmux to specify pins. (UNUSED) + deprecated: true gpio-controller: true@@ -62,7 +63,6 @@ properties: required: - compatible - - pins-are-numbered - gpio-controller - "#gpio-cells"@@ -150,7 +150,6 @@ examples: compatible = "mediatek,mt8135-pinctrl"; reg = <0 0x1000B000 0 0x1000>; mediatek,pctl-regmap = <&syscfg_pctl_a>, <&syscfg_pctl_b>; - pins-are-numbered; gpio-controller; #gpio-cells = <2>; interrupt-controller;
Re: [PATCH v2 3/7] dt-bindings: pinctrl: mediatek,mt65xx: Deprecate pins-are-numbered
In reply to Bernhard RosenkränzerQuoted 5 lines · Bernhard Rosenkränzer
Make pins-are-numbered optional and deprecate it
Signed-off-by Bernhard Rosenkränzer <[email protected]>--- .../devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml | 5 ++
Best regards,
Krzysztof
PATCH v2 4/7 dt-bindings: pinctrl: st,stm32: Deprecate pins-are-numbered
In reply to Bernhard RosenkränzerDeprecate the pins-are-numbered property
--- .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml +3 -4
@@ -34,7 +34,9 @@ properties: const: 1 ranges: true - pins-are-numbered: true + pins-are-numbered: + $ref: /schemas/types.yaml#/definitions/flag + deprecated: true hwlocks: true interrupts:
@@ -206,7 +208,6 @@ required: - '#address-cells' - '#size-cells' - ranges - - pins-are-numbered additionalProperties: false
@@ -220,7 +221,6 @@ examples: #size-cells = <1>; compatible = "st,stm32f429-pinctrl"; ranges = <0 0x40020000 0x3000>; - pins-are-numbered; gpioa: gpio@0 { gpio-controller;
@@ -238,7 +238,6 @@ examples: #size-cells = <1>; compatible = "st,stm32f429-pinctrl"; ranges = <0 0x50020000 0x3000>; - pins-are-numbered; gpiob: gpio@1000 { gpio-controller;
Signature · 1 line
2.38.1
Re: [PATCH v2 4/7] dt-bindings: pinctrl: st,stm32: Deprecate pins-are-numbered
Quoted 3 lines · Bernhard Rosenkränzer
Deprecate the pins-are-numbered property
Signed-off-by Bernhard Rosenkränzer <[email protected]>
Quoted 43 lines
--- .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml +3
-4@@ -34,7 +34,9 @@ properties: const: 1 ranges: true - pins-are-numbered: true + pins-are-numbered: + $ref: /schemas/types.yaml#/definitions/flag + deprecated: true hwlocks: true interrupts:@@ -206,7 +208,6 @@ required: - '#address-cells' - '#size-cells' - ranges - - pins-are-numbered additionalProperties: false@@ -220,7 +221,6 @@ examples: #size-cells = <1>; compatible = "st,stm32f429-pinctrl"; ranges = <0 0x40020000 0x3000>; - pins-are-numbered; gpioa: gpio@0 { gpio-controller;@@ -238,7 +238,6 @@ examples: #size-cells = <1>; compatible = "st,stm32f429-pinctrl"; ranges = <0 0x50020000 0x3000>; - pins-are-numbered; gpiob: gpio@1000 { gpio-controller;
Re: [PATCH v2 4/7] dt-bindings: pinctrl: st,stm32: Deprecate pins-are-numbered
In reply to Bernhard RosenkränzerQuoted 4 lines · Bernhard Rosenkränzer
Deprecate the pins-are-numbered property
Signed-off-by Bernhard Rosenkränzer <[email protected]>---
Best regards,
Krzysztof
PATCH v2 5/7 arm64: dts: mediatek: Remove pins-are-numbered property
In reply to Bernhard RosenkränzerRemove the unnecessary pins-are-numbered property from arm64 Mediatek DeviceTrees
--- arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 1 - arch/arm64/boot/dts/mediatek/mt8167.dtsi | 1 - arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 1 - arch/arm64/boot/dts/mediatek/mt8173.dtsi | 1 - arch/arm64/boot/dts/mediatek/mt8516.dtsi | 1 - 5 files changed, 5 deletions(-)
arch/arm64/boot/dts/mediatek/mt2712e.dtsi +0 -1
@@ -270,7 +270,6 @@ pio: pinctrl@10005000 { compatible = "mediatek,mt2712-pinctrl"; reg = <0 0x1000b000 0 0x1000>; mediatek,pctl-regmap = <&syscfg_pctl_a>; - pins-are-numbered; gpio-controller; #gpio-cells = <2>; interrupt-controller;
arch/arm64/boot/dts/mediatek/mt8167.dtsi +0 -1
@@ -117,7 +117,6 @@ pio: pinctrl@1000b000 { compatible = "mediatek,mt8167-pinctrl"; reg = <0 0x1000b000 0 0x1000>; mediatek,pctl-regmap = <&syscfg_pctl>; - pins-are-numbered; gpio-controller; #gpio-cells = <2>; interrupt-controller;
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +0 -1
@@ -929,7 +929,6 @@ clock: mt6397clock { pio6397: pinctrl { compatible = "mediatek,mt6397-pinctrl"; - pins-are-numbered; gpio-controller; #gpio-cells = <2>; };
arch/arm64/boot/dts/mediatek/mt8173.dtsi +0 -1
@@ -375,7 +375,6 @@ pio: pinctrl@1000b000 { compatible = "mediatek,mt8173-pinctrl"; reg = <0 0x1000b000 0 0x1000>; mediatek,pctl-regmap = <&syscfg_pctl_a>; - pins-are-numbered; gpio-controller; #gpio-cells = <2>; interrupt-controller;
arch/arm64/boot/dts/mediatek/mt8516.dtsi +0 -1
@@ -229,7 +229,6 @@ pio: pinctrl@1000b000 { compatible = "mediatek,mt8516-pinctrl"; reg = <0 0x1000b000 0 0x1000>; mediatek,pctl-regmap = <&syscfg_pctl>; - pins-are-numbered; gpio-controller; #gpio-cells = <2>; interrupt-controller;
Signature · 1 line
2.38.1
PATCH v2 6/7 ARM: dts: mediatek: Remove pins-are-numbered property
In reply to Bernhard RosenkränzerRemove the unnecessary pins-are-numbered property from Mediatek ARM DeviceTrees
--- arch/arm/boot/dts/mt2701.dtsi | 1 - arch/arm/boot/dts/mt7623.dtsi | 1 - arch/arm/boot/dts/mt8135.dtsi | 1 - 3 files changed, 3 deletions(-)
arch/arm/boot/dts/mt2701.dtsi +0 -1
@@ -178,7 +178,6 @@ pio: pinctrl@1000b000 { compatible = "mediatek,mt2701-pinctrl"; reg = <0 0x1000b000 0 0x1000>; mediatek,pctl-regmap = <&syscfg_pctl_a>; - pins-are-numbered; gpio-controller; #gpio-cells = <2>; interrupt-controller;
arch/arm/boot/dts/mt7623.dtsi +0 -1
@@ -253,7 +253,6 @@ pio: pinctrl@10005000 { compatible = "mediatek,mt7623-pinctrl"; reg = <0 0x1000b000 0 0x1000>; mediatek,pctl-regmap = <&syscfg_pctl_a>; - pins-are-numbered; gpio-controller; #gpio-cells = <2>; interrupt-controller;
arch/arm/boot/dts/mt8135.dtsi +0 -1
@@ -152,7 +152,6 @@ pio: pinctrl@10005000 { compatible = "mediatek,mt8135-pinctrl"; reg = <0 0x1000b000 0 0x1000>; mediatek,pctl-regmap = <&syscfg_pctl_a &syscfg_pctl_b>; - pins-are-numbered; gpio-controller; #gpio-cells = <2>; interrupt-controller;
Signature · 1 line
2.38.1
PATCH v2 7/7 ARM: dts: stm32: Remove the pins-are-numbered property
In reply to Bernhard RosenkränzerRemove the pins-are-numbered property from STM32 DeviceTrees
--- arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 1 - arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 1 - arch/arm/boot/dts/stm32h743.dtsi | 1 - arch/arm/boot/dts/stm32mp131.dtsi | 1 - arch/arm/boot/dts/stm32mp151.dtsi | 2 -- 5 files changed, 6 deletions(-)
arch/arm/boot/dts/stm32f4-pinctrl.dtsi +0 -1
@@ -51,7 +51,6 @@ pinctrl: pinctrl@40020000 { ranges = <0 0x40020000 0x3000>; interrupt-parent = <&exti>; st,syscfg = <&syscfg 0x8>; - pins-are-numbered; gpioa: gpio@40020000 { gpio-controller;
arch/arm/boot/dts/stm32f7-pinctrl.dtsi +0 -1
@@ -15,7 +15,6 @@ pinctrl: pinctrl@40020000 { ranges = <0 0x40020000 0x3000>; interrupt-parent = <&exti>; st,syscfg = <&syscfg 0x8>; - pins-are-numbered; gpioa: gpio@40020000 { gpio-controller;
arch/arm/boot/dts/stm32h743.dtsi +0 -1
@@ -588,7 +588,6 @@ pinctrl: pinctrl@58020000 { ranges = <0 0x58020000 0x3000>; interrupt-parent = <&exti>; st,syscfg = <&syscfg 0x8>; - pins-are-numbered; gpioa: gpio@58020000 { gpio-controller;
arch/arm/boot/dts/stm32mp131.dtsi +0 -1
@@ -549,7 +549,6 @@ pinctrl: pinctrl@50002000 { ranges = <0 0x50002000 0x8400>; interrupt-parent = <&exti>; st,syscfg = <&exti 0x60 0xff>; - pins-are-numbered; gpioa: gpio@50002000 { gpio-controller;
arch/arm/boot/dts/stm32mp151.dtsi +0 -2
@@ -1660,7 +1660,6 @@ pinctrl: pinctrl@50002000 { ranges = <0 0x50002000 0xa400>; interrupt-parent = <&exti>; st,syscfg = <&exti 0x60 0xff>; - pins-are-numbered; gpioa: gpio@50002000 { gpio-controller;
@@ -1789,7 +1788,6 @@ pinctrl_z: pinctrl@54004000 { #size-cells = <1>; compatible = "st,stm32mp157-z-pinctrl"; ranges = <0 0x54004000 0x400>; - pins-are-numbered; interrupt-parent = <&exti>; st,syscfg = <&exti 0x60 0xff>;
Signature · 1 line
2.38.1
Re: [PATCH v2 7/7] ARM: dts: stm32: Remove the pins-are-numbered property
Quoted 3 lines · Bernhard Rosenkränzer
Remove the pins-are-numbered property from STM32 DeviceTrees
Signed-off-by Bernhard Rosenkränzer <[email protected]>
Quoted 76 lines
--- arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 1 - arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 1 - arch/arm/boot/dts/stm32h743.dtsi | 1 - arch/arm/boot/dts/stm32mp131.dtsi | 1 - arch/arm/boot/dts/stm32mp151.dtsi | 2 -- 5 files changed, 6 deletions(-)arch/arm/boot/dts/stm32f4-pinctrl.dtsi +0
-1@@ -51,7 +51,6 @@ pinctrl: pinctrl@40020000 { ranges = <0 0x40020000 0x3000>; interrupt-parent = <&exti>; st,syscfg = <&syscfg 0x8>; - pins-are-numbered; gpioa: gpio@40020000 { gpio-controller;arch/arm/boot/dts/stm32f7-pinctrl.dtsi +0
-1@@ -15,7 +15,6 @@ pinctrl: pinctrl@40020000 { ranges = <0 0x40020000 0x3000>; interrupt-parent = <&exti>; st,syscfg = <&syscfg 0x8>; - pins-are-numbered; gpioa: gpio@40020000 { gpio-controller;arch/arm/boot/dts/stm32h743.dtsi +0
-1@@ -588,7 +588,6 @@ pinctrl: pinctrl@58020000 { ranges = <0 0x58020000 0x3000>; interrupt-parent = <&exti>; st,syscfg = <&syscfg 0x8>; - pins-are-numbered; gpioa: gpio@58020000 { gpio-controller;arch/arm/boot/dts/stm32mp131.dtsi +0
-1@@ -549,7 +549,6 @@ pinctrl: pinctrl@50002000 { ranges = <0 0x50002000 0x8400>; interrupt-parent = <&exti>; st,syscfg = <&exti 0x60 0xff>; - pins-are-numbered; gpioa: gpio@50002000 { gpio-controller;arch/arm/boot/dts/stm32mp151.dtsi +0
-2@@ -1660,7 +1660,6 @@ pinctrl: pinctrl@50002000 { ranges = <0 0x50002000 0xa400>; interrupt-parent = <&exti>; st,syscfg = <&exti 0x60 0xff>; - pins-are-numbered; gpioa: gpio@50002000 { gpio-controller;@@ -1789,7 +1788,6 @@ pinctrl_z: pinctrl@54004000 { #size-cells = <1>; compatible = "st,stm32mp157-z-pinctrl"; ranges = <0 0x54004000 0x400>; - pins-are-numbered; interrupt-parent = <&exti>; st,syscfg = <&exti 0x60 0xff>;