adt7462: Fix pin 28 monitoring
PATCH 1/1 adt7462: Fix pin 28 monitoring
The ADT7462_PIN28_VOLT value is a 4-bit field, so the corresponding shift must be 4.
Signed-off-by Roger Blofeld <[email protected]>
---
My mailer will whitespace damage the inline copy of the patch. The attached version should be OK.
drivers/hwmon/adt7462.c +1 -1
@@ -97,7 +97,7 @@ I2C_CLIENT_INSMOD_1(adt7462);#define ADT7462_PIN24_SHIFT 6#define ADT7462_PIN26_VOLT_INPUT 0x08#define ADT7462_PIN25_VOLT_INPUT 0x20 -#define ADT7462_PIN28_SHIFT 6/* cfg3 */ +#define ADT7462_PIN28_SHIFT 4/* cfg3 */ #define ADT7462_PIN28_VOLT 0x5#define ADT7462_REG_ALARM1 0xB8
The ADT7462_PIN28_VOLT value is a 4-bit field, so the corresponding shift must be 4.
Signed-off-by Roger Blofeld <[email protected]>
---
drivers/hwmon/adt7462.c +1 -1
@@ -97,7 +97,7 @@ I2C_CLIENT_INSMOD_1(adt7462);#define ADT7462_PIN24_SHIFT 6#define ADT7462_PIN26_VOLT_INPUT 0x08#define ADT7462_PIN25_VOLT_INPUT 0x20 -#define ADT7462_PIN28_SHIFT 6/* cfg3 */ +#define ADT7462_PIN28_SHIFT 4/* cfg3 */ #define ADT7462_PIN28_VOLT 0x5#define ADT7462_REG_ALARM1 0xB8
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Hi Roger,
Quoted 12 lines · roger blofeld
The
ADT7462_PIN28_VOLTvalue is a 4-bit field, so the corresponding shift must be 4.Signed-off-by Roger Blofeld <[email protected]>---
My mailer will whitespace damage the inline copy of the patch. The attached version should be OK.drivers/hwmon/adt7462.c +0
-0
drivers/hwmon/adt7462.c I2C_CLIENT_INSMOD_1(adt7462); · line 103
Quoted 8 lines
drivers/hwmon/adt7462.c +1
-1@@ -97,7 +97,7 @@ I2C_CLIENT_INSMOD_1(adt7462);#define ADT7462_PIN24_SHIFT 6#define ADT7462_PIN26_VOLT_INPUT 0x08#define ADT7462_PIN25_VOLT_INPUT 0x20 -#define ADT7462_PIN28_SHIFT 6/* cfg3 */ +#define ADT7462_PIN28_SHIFT 4/* cfg3 */ #define ADT7462_PIN28_VOLT 0x5#define ADT7462_REG_ALARM1 0xB8
Correct. Applied, thanks.
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors