Skip to contentSkip to conversation

arm32: Avoid using solaris syntax for .section directive

PATCH In review Khem Raj 2 participants 3 messages Aug 1, 2023

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 arm32: Avoid using solaris syntax for .section directive

Assembler from binutils 2.41 rejects this syntax

.section "name"[, flags...]

where flags could be #alloc, #write, #execstr
Switch to using ELF syntax

.section name[, "flags"[, @type]]

[1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119

---
 xen/arch/arm/arm32/proc-v7.S | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
xen/arch/arm/arm32/proc-v7.S +3 -3
index c90a31d80f..6d3d19b873 100644
@@ -29,7 +29,7 @@ brahma15mp_init:
         mcr   CP32(r0, ACTLR)
         mov   pc, lr
 
-        .section ".proc.info", #alloc
+        .section .proc.info, "a"
         .type __v7_ca15mp_proc_info, #object
 __v7_ca15mp_proc_info:
         .long 0x410FC0F0             /* Cortex-A15 */
@@ -38,7 +38,7 @@ __v7_ca15mp_proc_info:
         .long caxx_processor
         .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info
 
-        .section ".proc.info", #alloc
+        .section .proc.info, "a"
         .type __v7_ca7mp_proc_info, #object
 __v7_ca7mp_proc_info:
         .long 0x410FC070             /* Cortex-A7 */
@@ -47,7 +47,7 @@ __v7_ca7mp_proc_info:
         .long caxx_processor
         .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info
 
-        .section ".proc.info", #alloc
+        .section .proc.info, "a"
         .type __v7_brahma15mp_proc_info, #object
 __v7_brahma15mp_proc_info:
         .long 0x420F00F0             /* Broadcom Brahma-B15 */
Signature · 1 line
2.41.0
#1 lore raw

Hi,

Quoted 7 lines · Khem Raj

Assembler from binutils 2.41 rejects this syntax

.section "name"[, flags...]

where flags could be #alloc, #write, #execstr

s/execstr/execinstr + there is also #exclude and #tls if you want to list them all

Quoted 5 lines

Switch to using ELF syntax

.section name[, "flags"[, @type]]

[1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119

I think it would be better to add a link to 2.41 docs instead or to refer to the following commit of binutils:
4cb88cfae843 "PR11601, Solaris assembler compatibility doesn't work"

Quoted 38 lines
---
 xen/arch/arm/arm32/proc-v7.S | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
xen/arch/arm/arm32/proc-v7.S +3 -4
index c90a31d80f..6d3d19b873 100644
@@ -29,7 +29,7 @@ brahma15mp_init:
         mcr   CP32(r0, ACTLR)
         mov   pc, lr
 
-        .section ".proc.info", #alloc
+        .section .proc.info, "a"
         .type __v7_ca15mp_proc_info, #object
 __v7_ca15mp_proc_info:
         .long 0x410FC0F0             /* Cortex-A15 */
@@ -38,7 +38,7 @@ __v7_ca15mp_proc_info:
         .long caxx_processor
         .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info
 
-        .section ".proc.info", #alloc
+        .section .proc.info, "a"
         .type __v7_ca7mp_proc_info, #object
 __v7_ca7mp_proc_info:
         .long 0x410FC070             /* Cortex-A7 */
@@ -47,7 +47,7 @@ __v7_ca7mp_proc_info:
         .long caxx_processor
         .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info
 
-        .section ".proc.info", #alloc
+        .section .proc.info, "a"
         .type __v7_brahma15mp_proc_info, #object
 __v7_brahma15mp_proc_info:
         .long 0x420F00F0             /* Broadcom Brahma-B15 */
--
Quoted 3 lines

2.41.0

The patch looks good but a fast grep shows that ".section .dtb,#alloc" in arch/arm/dtb.S would also want to be changed (I do not have gas 2.41, so you can check it by specifying dtb to be included in Xen image through "menuconfig->Common Features->Absolute path to device tree blob")

~Michal

author
#2 lore raw
Quoted 55 lines · Michal Orzel

Hi,

Quoted 7 lines · Khem Raj

Assembler from binutils 2.41 rejects this syntax

.section "name"[, flags...]

where flags could be #alloc, #write, #execstr

s/execstr/execinstr + there is also #exclude and #tls if you want to list them all

Quoted 5 lines

Switch to using ELF syntax

.section name[, "flags"[, @type]]

[1] https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119

I think it would be better to add a link to 2.41 docs instead or to refer to the following commit of binutils:
4cb88cfae843 "PR11601, Solaris assembler compatibility doesn't work"

Quoted 32 lines
---
 xen/arch/arm/arm32/proc-v7.S | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
xen/arch/arm/arm32/proc-v7.S +2 -2
index c90a31d80f..6d3d19b873 100644
@@ -29,7 +29,7 @@ brahma15mp_init:
         mcr   CP32(r0, ACTLR)
         mov   pc, lr
 
-        .section ".proc.info", #alloc
+        .section .proc.info, "a"
         .type __v7_ca15mp_proc_info, #object
 __v7_ca15mp_proc_info:
         .long 0x410FC0F0             /* Cortex-A15 */
@@ -38,7 +38,7 @@ __v7_ca15mp_proc_info:
         .long caxx_processor
         .size __v7_ca15mp_proc_info, . - __v7_ca15mp_proc_info
 
-        .section ".proc.info", #alloc
+        .section .proc.info, "a"
         .type __v7_ca7mp_proc_info, #object
 __v7_ca7mp_proc_info:
         .long 0x410FC070             /* Cortex-A7 */
@@ -47,7 +47,7 @@ __v7_ca7mp_proc_info:
         .long caxx_processor
         .size __v7_ca7mp_proc_info, . - __v7_ca7mp_proc_info
 
Quoted 13 lines
Quoted 9 lines
xen/arch/arm/arm32/proc-v7.S +1 -2
-        .section ".proc.info", #alloc
+        .section .proc.info, "a"
         .type __v7_brahma15mp_proc_info, #object
 __v7_brahma15mp_proc_info:
         .long 0x420F00F0             /* Broadcom Brahma-B15 */
--

2.41.0

The patch looks good but a fast grep shows that ".section .dtb,#alloc" in arch/arm/dtb.S would also want to be changed (I do not have gas 2.41, so you can check it by specifying dtb to be included in Xen image through "menuconfig->Common Features->Absolute path to device tree blob")

thanks will add it to v2 as well

Quoted 2 lines

~Michal