ACPI: Add APEI GHES table generation support
Quoted 17 lines
Quoted 7 lines · On Fri, 15 Nov 2019 14:32:47 +0000 gengdongjiu <[email protected]> wrote:
Quoted 7 lines
Review
Quoted 3 lines
+ */
(quoted diff) +2
-0+static void acpi_ghes_build_notify(GArray *table, const uint8_t +type)typically format should be
build_WHAT(), so
build_ghes_hw_error_notification()Quoted 6 lines
Quoted 2 lines
And I'd move this out into its own patch.
this applies to other trivial in-depended sub-tables, that take all data needed to construct them from supplied arguments.I very used your suggested method in previous series[1], but other maintainer suggested to move this function to this file, because he think only GHES used it
Quoted 6 lines
Using this file is ok, what I've meant for you to split function from this patch into a separate smaller patch.
With the way code split now I have to review 2 big complex patches at the same which makes reviewing hard and I have a hard time convincing myself that code it correct.
Moving small self-contained chunks of code in to separate smaller patches makes review easier.
Ok, got it. Thanks very much for the explanations