Skip to contentSkip to conversation

drm/amd/display: fix documentation for amdgpu_dm_update_freesync_caps()

PATCH In review Alex Deucher 3 participants 3 messages Aug 30, 2022 – Aug 31, 2022

Subsystems (3)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amd/display: fix documentation for amdgpu_dm_update_freesync_caps()

Document missing parameter.

Fixes 8889a13f99e5 ("drm/amd/display: Add some extra kernel doc to amdgpu_dm")
Cc Rodrigo Siqueira <[email protected]>
Cc Harry Wentland <[email protected]>

---

v2: fix aconnector too.

 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2 -1
index 9d5ec1ea23a6..b053c13a81a5 100644
@@ -9936,7 +9936,8 @@ static int parse_hdmi_amd_vsdb(struct amdgpu_dm_connector *aconnector,
 /**
  * amdgpu_dm_update_freesync_caps - Update Freesync capabilities
  *
- * @aconnector: Connector to query.
+ * @connector: Connector to query.
+ * @edid: EDID from monitor
  *
  * Amdgpu supports Freesync in DP and HDMI displays, and it is required to keep
  * track of some of the display information in the internal data struct used by
Signature · 1 line
2.37.1
#1 lore raw

Hi Alex,

Quoted 8 lines · On Tue, 30 Aug 2022 17:57:52 -0400 Alex Deucher <[email protected]>…

Document missing parameter.

Fixes 8889a13f99e5 ("drm/amd/display: Add some extra kernel doc to amdgpu_dm")
Cc Rodrigo Siqueira <[email protected]>
Cc Harry Wentland <[email protected]>
Quoted 6 lines

---

v2: fix aconnector too.

 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, looks good.

Signature · 2 lines
Cheers,
Stephen Rothwell
Reviewed-by on v1 1/1
#2 lore raw
In reply to Alex Deucher
Quoted 19 lines · Alex Deucher

Document missing parameter.

Fixes 8889a13f99e5 ("drm/amd/display: Add some extra kernel doc to amdgpu_dm")
Cc Rodrigo Siqueira <[email protected]>
Cc Harry Wentland <[email protected]>

---

v2: fix aconnector too.

  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -0
index 9d5ec1ea23a6..b053c13a81a5 100644

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int parse_hdmi_amd_vsdb(struct amdgpu_dm_connector *aconnector, · line 9943

Quoted 9 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2 -1
@@ -9936,7 +9936,8 @@ static int parse_hdmi_amd_vsdb(struct amdgpu_dm_connector *aconnector,
  /**
   * amdgpu_dm_update_freesync_caps - Update Freesync capabilities
   *
- * @aconnector: Connector to query.
+ * @connector: Connector to query.
+ * @edid: EDID from monitor
   *
   * Amdgpu supports Freesync in DP and HDMI displays, and it is required to keep
   * track of some of the display information in the internal data struct used by

And applied to amd-staging-drm-next.

Thanks
Siqueira