rcu/tree_plugin: Fix nohz status in stall warning
PATCH 1/1 rcu/tree_plugin: Fix nohz status in stall warning
Fix stall warning, to show correct nohz marker.
--- kernel/rcu/tree_plugin.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/rcu/tree_plugin.h +1 -1
@@ -1659,7 +1659,7 @@ static void print_cpu_stall_fast_no_hz(char *cp, int cpu) rdp->last_accelerate &0xffff , jiffies &0xffff ,".l" [rdp->all_lazy],".L" [!rcu_segcblist_n_nonlazy_cbs (&rdp->cblist)], - ".D"[!rdp->tick_nohz_enabled_snap]); + ".D"[!!rdp->tick_nohz_enabled_snap]); }#else /* #ifdef CONFIG_RCU_FAST_NO_HZ */
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Quoted 3 lines · Neeraj Upadhyay
Fix stall warning, to show correct nohz marker.
Signed-off-by Neeraj Upadhyay <[email protected]>
Good eyes, thank you!
I applied and pushed all three with modified commit logs. Please check to make sure that I didn't mess anything up. If testing and reviews are OK, I expect to submit them for the v5.2 merge window.
I had to hand-apply this one, so in future patches could you please generate them against -rcu? It may be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
Thanx, Paul
Quoted 21 lines
--- kernel/rcu/tree_plugin.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/rcu/tree_plugin.h +1
-1@@ -1659,7 +1659,7 @@ static void print_cpu_stall_fast_no_hz(char *cp, int cpu) rdp->last_accelerate &0xffff , jiffies &0xffff ,".l" [rdp->all_lazy],".L" [!rcu_segcblist_n_nonlazy_cbs (&rdp->cblist)], - ".D"[!rdp->tick_nohz_enabled_snap]); + ".D"[!!rdp->tick_nohz_enabled_snap]); }#else /* #ifdef CONFIG_RCU_FAST_NO_HZ */ Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Quoted 11 lines · Paul E. McKenney
Quoted 3 lines · Neeraj Upadhyay
Fix stall warning, to show correct nohz marker.
Signed-off-by Neeraj Upadhyay <[email protected]>Good eyes, thank you!
I applied and pushed all three with modified commit logs. Please check to make sure that I didn't mess anything up. If testing and reviews are OK, I expect to submit them for the v5.2 merge window.
Quoted 7 lines
I had to hand-apply this one, so in future patches could you please generate them against -rcu? It may be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.gitThanx, Paul
Thanks Paul, I reviewed the patches on -rcu; they look good. Thanks for applying them! I will move my codebase to -rcu, for all future work.
Thanks
Neeraj
Quoted 22 lines
Quoted 21 lines
--- kernel/rcu/tree_plugin.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/rcu/tree_plugin.h +1
-1@@ -1659,7 +1659,7 @@ static void print_cpu_stall_fast_no_hz(char *cp, int cpu) rdp->last_accelerate &0xffff , jiffies &0xffff ,".l" [rdp->all_lazy],".L" [!rcu_segcblist_n_nonlazy_cbs (&rdp->cblist)], - ".D"[!rdp->tick_nohz_enabled_snap]); + ".D"[!!rdp->tick_nohz_enabled_snap]); }#else /* #ifdef CONFIG_RCU_FAST_NO_HZ */ Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation