mfd: add tps6594x support for Jacinto platforms
Subsystems (5)
v3 cover mfd: add tps6594x support for Jacinto platforms
This patchset series adds support for the TPS6594x PMIC along with initial support for its RTC + GPIO interface, and poweroff sequence.
Additionally, add usage of the PMIC for the various Jacintor platforms devicetree's.
Changes from v1:
* Corrected devicetree documentation issues found with dt-schema
* Changed MFD references to PMIC reflecting the more valid use of driver
* Cleaning up variable naming and ordering within functions
* Adding gpio + regulator cells for upcoming driver support
* Switching from .probe to .probe_new API
* Revising comments within drivers to be more concise
* Adding device tree nodes for j721s2 and j721e platforms
Changes from v2:
* Adding gpio-tps6594x driver support
* Enabling gpio cell in MFD driver
* Adding device tree nodes for k3-*dts platforms
Keerthy (3):
MFD: TPS6594x: Add new PMIC device driver for TPS6594x chips
rtc: rtc-tps6594x: Add support for TPS6594X PMIC RTC
arm64: dts: ti: k3-j7200-common-proc-board: Add TPS6594x PMIC node
Matt Ranostay (4):
Documentation: tps6594x: Add DT bindings for the TPS6594x PMIC
gpio: tps6594x: add GPIO support for TPS6594x PMIC
arm64: dts: ti: k3-j721e-common-proc-board: Add TPS6594x PMIC node
arm64: dts: ti: k3-j721s2-common-proc-board: Add TPS6594x PMIC node
.../devicetree/bindings/mfd/ti,tps6594x.yaml | 67 +++++++ .../dts/ti/k3-j7200-common-proc-board.dts | 17 ++ .../dts/ti/k3-j721e-common-proc-board.dts | 17 ++ .../dts/ti/k3-j721s2-common-proc-board.dts | 17 ++ drivers/gpio/Kconfig | 7 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-tps6594x.c | 142 ++++++++++++++ drivers/mfd/Kconfig | 14 ++ drivers/mfd/Makefile | 1 + drivers/mfd/tps6594x.c | 120 ++++++++++++ drivers/rtc/Kconfig | 10 + drivers/rtc/Makefile | 1 + drivers/rtc/rtc-tps6594x.c | 181 ++++++++++++++++++ include/linux/mfd/tps6594x.h | 90 +++++++++ 14 files changed, 685 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml create mode 100644 drivers/gpio/gpio-tps6594x.c create mode 100644 drivers/mfd/tps6594x.c create mode 100644 drivers/rtc/rtc-tps6594x.c create mode 100644 include/linux/mfd/tps6594x.h
Signature · 1 line
2.38.GIT
PATCH v3 1/7 Documentation: tps6594x: Add DT bindings for the TPS6594x PMIC
--- .../devicetree/bindings/mfd/ti,tps6594x.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml
Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml new file +67 -0
@@ -0,0 +1,67 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/ti,tps6594x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TPS6594x Power Management Integrated Circuit (PMIC) + +maintainers: + - Keerthy <[email protected]> + +properties: + compatible: + contains: + enum: + - ti,tps6594x + + reg: + const: 0x48 + description: I2C slave address + + ti,system-power-controller: + type: boolean + description: PMIC is controlling the system power. + + rtc: + type: object + $ref: /schemas/rtc/rtc.yaml# + unevaluatedProperties: false + properties: + compatible: + const: ti,tps6594x-rtc + + gpio: + type: object + unevaluatedProperties: false + properties: + compatible: + const: ti,tps6594x-gpio + +additionalProperties: false + +required: + - compatible + - reg + +examples: + - | + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + pmic: pmic@48 { + compatible = "ti,tps6594x"; + reg = <0x48>; + + rtc { + compatible = "ti,tps6594x-rtc"; + }; + + gpio { + compatible = "ti,tps6594x-gpio"; + }; + }; + }; + +...
Signature · 1 line
2.38.GIT
Re: [PATCH v3 1/7] Documentation: tps6594x: Add DT bindings for the TPS6594x PMIC
On 09/11/2022 07:55, Matt Ranostay wrote:
Missing commit msg.
Use subject prefixes matching the subsystem (git log --oneline -- ...).
Quoted 16 lines
Signed-off-by Matt Ranostay <[email protected]>--- .../devicetree/bindings/mfd/ti,tps6594x.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/ti,tps6594x.yamlDocumentation/devicetree/bindings/mfd/ti,tps6594x.yaml new file +4
-0@@ -0,0 +1,67 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/ti,tps6594x.yaml#
Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml line 14
Quoted 10 lines
Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml new file +10
-0+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TPS6594x Power Management Integrated Circuit (PMIC) + +maintainers: + - Keerthy <[email protected]> + +properties: + compatible: + contains:
Drop contains.
Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml line 16
Quoted 2 lines
Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml new file +2
-0+ enum: + - ti,tps6594x
No wildcards in compatibles.
Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml line 20
Quoted 4 lines
Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml new file +4
-0+ + reg: + const: 0x48 + description: I2C slave address
Drop description.
Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml line 32
Quoted 12 lines
Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml new file +12
-0+ + ti,system-power-controller: + type: boolean + description: PMIC is controlling the system power. + + rtc: + type: object + $ref: /schemas/rtc/rtc.yaml# + unevaluatedProperties: false + properties: + compatible: + const: ti,tps6594x-rtc
No wildcards in compatibles.
Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml line 39
Quoted 7 lines
Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml new file +7
-0+ + gpio: + type: object + unevaluatedProperties: false + properties: + compatible: + const: ti,tps6594x-gpio
No wildcards in compatibles.
Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml line 67
Quoted 7 lines
Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml new file +6
-0+ +additionalProperties: false + +required: + - compatible +...
Best regards,
Krzysztof
PATCH v3 2/7 MFD: TPS6594x: Add new PMIC device driver for TPS6594x chips
In reply to Matt RanostayFrom: Keerthy <[email protected]>
The TPS6594x chip is a PMIC, and contains the following components:
- GPIO controller
- RTC
However initially only RTC is supported.
--- drivers/mfd/Kconfig | 14 ++++ drivers/mfd/Makefile | 1 + drivers/mfd/tps6594x.c | 120 +++++++++++++++++++++++++++++++++++ include/linux/mfd/tps6594x.h | 84 ++++++++++++++++++++++++ 4 files changed, 219 insertions(+) create mode 100644 drivers/mfd/tps6594x.c create mode 100644 include/linux/mfd/tps6594x.h
drivers/mfd/Kconfig +14 -0
@@ -1596,6 +1596,20 @@ config MFD_TI_LP873X This driver can also be built as a module. If so, the module will be called lp873x. +config MFD_TPS6594X + tristate "TI TPS6594X Power Management IC" + depends on I2C && OF + select MFD_CORE + select REGMAP_I2C + help + If you say yes here then you get support for the TPS6594X series of + Power Management Integrated Circuits (PMIC). + These include voltage regulators, RTS, configurable + General Purpose Outputs (GPO) that are used in portable devices. + + This driver can also be built as a module. If so, the module + will be called tps6594x. + config MFD_TI_LP87565 tristate "TI LP87565 Power Management IC" depends on I2C && OF
drivers/mfd/Makefile +1 -0
@@ -101,6 +101,7 @@ obj-$(CONFIG_MFD_TPS65910) += tps65910.o obj-$(CONFIG_MFD_TPS65912) += tps65912-core.o obj-$(CONFIG_MFD_TPS65912_I2C) += tps65912-i2c.o obj-$(CONFIG_MFD_TPS65912_SPI) += tps65912-spi.o +obj-$(CONFIG_MFD_TPS6594X) += tps6594x.o obj-$(CONFIG_MENELAUS) += menelaus.o obj-$(CONFIG_TWL4030_CORE) += twl-core.o twl4030-irq.o twl6030-irq.o
drivers/mfd/tps6594x.c new file +120 -0
120 lines not on this page · raw message
include/linux/mfd/tps6594x.h new file +84 -0
84 lines not on this page · raw message
Signature · 1 line
2.38.GIT
Re: [PATCH v3 2/7] MFD: TPS6594x: Add new PMIC device driver for TPS6594x chips
Quoted 2 lines · Matt Ranostay
From: Keerthy <[email protected]>
Use subject prefixes matching the subsystem (git log --oneline -- ...).
Quoted 76 lines
The TPS6594x chip is a PMIC, and contains the following components:
- GPIO controller
- RTCHowever initially only RTC is supported.
Signed-off-by Keerthy <[email protected]>Signed-off-by Matt Ranostay <[email protected]>--- drivers/mfd/Kconfig | 14 ++++ drivers/mfd/Makefile | 1 + drivers/mfd/tps6594x.c | 120 +++++++++++++++++++++++++++++++++++ include/linux/mfd/tps6594x.h | 84 ++++++++++++++++++++++++ 4 files changed, 219 insertions(+) create mode 100644 drivers/mfd/tps6594x.c create mode 100644 include/linux/mfd/tps6594x.hdrivers/mfd/Kconfig +14
-0@@ -1596,6 +1596,20 @@ config MFD_TI_LP873X This driver can also be built as a module. If so, the module will be called lp873x. +config MFD_TPS6594X + tristate "TI TPS6594X Power Management IC" + depends on I2C && OF + select MFD_CORE + select REGMAP_I2C + help + If you say yes here then you get support for the TPS6594X series of + Power Management Integrated Circuits (PMIC). + These include voltage regulators, RTS, configurable + General Purpose Outputs (GPO) that are used in portable devices. + + This driver can also be built as a module. If so, the module + will be called tps6594x. + config MFD_TI_LP87565 tristate "TI LP87565 Power Management IC" depends on I2C && OFdrivers/mfd/Makefile +1
-0@@ -101,6 +101,7 @@ obj-$(CONFIG_MFD_TPS65910) += tps65910.o obj-$(CONFIG_MFD_TPS65912) += tps65912-core.o obj-$(CONFIG_MFD_TPS65912_I2C) += tps65912-i2c.o obj-$(CONFIG_MFD_TPS65912_SPI) += tps65912-spi.o +obj-$(CONFIG_MFD_TPS6594X) += tps6594x.o obj-$(CONFIG_MENELAUS) += menelaus.o obj-$(CONFIG_TWL4030_CORE) += twl-core.o twl4030-irq.o twl6030-irq.odrivers/mfd/tps6594x.c new file +15
-0@@ -0,0 +1,120 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Driver for tps6594x PMIC chips +* +* Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com/ +* Author: Keerthy <[email protected]> +*/ + +#include <linux/of.h> +#include <linux/of_device.h> +#include <linux/mfd/core.h> +#include <linux/mfd/tps6594x.h> +#include <linux/module.h> +#include <linux/i2c.h> +#include <linux/regmap.h>
drivers/mfd/tps6594x.c line 25
Quoted 10 lines
drivers/mfd/tps6594x.c new file +10
-0+ +static const struct regmap_config tps6594x_regmap_config = { + .reg_bits =8 , + .val_bits =8 , + .max_register =TPS6594X_REG_MAX , +}; + +static const struct mfd_cell tps6594x_cells[] = { + { .name ="tps6594x-gpio" }, + { .name ="tps6594x-rtc" },
You have compatibles for children, so use them.
Quoted 34 lines
drivers/mfd/tps6594x.c new file +34
-0+}; + +static struct tps6594x *tps; + +static void tps6594x_power_off (void ) +{ +regmap_write (tps->regmap,TPS6594X_FSM_NSLEEP_TRIGGERS , +TPS6594X_FSM_NSLEEP_NSLEEP1B |TPS6594X_FSM_NSLEEP_NSLEEP2B ); + +regmap_write (tps->regmap,TPS6594X_INT_STARTUP , +TPS6594X_INT_STARTUP_NPWRON_START_INT | +TPS6594X_INT_STARTUP_ENABLE_INT |TPS6594X_INT_STARTUP_RTC_INT | +TPS6594X_INT_STARTUP_SOFT_REBOOT_INT ); + +regmap_write (tps->regmap,TPS6594X_INT_MISC , +TPS6594X_INT_MISC_BIST_PASS_INT | +TPS6594X_INT_MISC_EXT_CLK_INT |TPS6594X_INT_MISC_TWARN_INT ); + +regmap_write (tps->regmap,TPS6594X_CONFIG_1 , +TPS6594X_CONFIG_NSLEEP1_MASK |TPS6594X_CONFIG_NSLEEP2_MASK ); + +regmap_write (tps->regmap,TPS6594X_FSM_I2C_TRIGGERS , +TPS6594X_FSM_I2C_TRIGGERS_I2C0 ); +} + +static int tps6594x_probe (struct i2c_client *client) +{ +struct tps6594x *ddata; +struct device_node *node = client->dev.of_node; +unsigned int otpid; +int ret; + + ddata =devm_kzalloc (&client->dev,sizeof (*ddata),GFP_KERNEL ); +if (!ddata)
drivers/mfd/tps6594x.c line 69
Quoted 10 lines
drivers/mfd/tps6594x.c new file +10
-0+return -ENOMEM ; + + ddata->dev = &client->dev; + + ddata->regmap =devm_regmap_init_i2c (client, &tps6594x_regmap_config); +if (IS_ERR (ddata->regmap)) { + ret =PTR_ERR (ddata->regmap); +dev_err (ddata->dev, +"Failed to initialize register map: %d\n" , ret); +return ret;
return dev_err_probe
drivers/mfd/tps6594x.c line 75
Quoted 6 lines
drivers/mfd/tps6594x.c new file +6
-0+ } + + ret =regmap_read (ddata->regmap,TPS6594X_REG_DEV_REV , &otpid); +if (ret) { +dev_err (ddata->dev,"Failed to read OTP ID\n" ); +return ret;
return dev_err_probe
drivers/mfd/tps6594x.c line 85
Quoted 10 lines
drivers/mfd/tps6594x.c new file +10
-0+ } + + ddata->rev = otpid; +i2c_set_clientdata (client, ddata); + + ret =mfd_add_devices (ddata->dev,PLATFORM_DEVID_AUTO , tps6594x_cells, +ARRAY_SIZE (tps6594x_cells),NULL ,0 ,NULL ); +if (ret) { +dev_err (ddata->dev,"Failed to register cells\n" ); +return ret;
return dev_err_probe
drivers/mfd/tps6594x.c line 94
Quoted 9 lines
drivers/mfd/tps6594x.c new file +9
-0+ } + + tps = ddata; + +if (of_property_read_bool (node,"ti,system-power-controller" )) + pm_power_off = tps6594x_power_off; + +return 0 ; +}
Best regards,
Krzysztof
PATCH v3 3/7 rtc: rtc-tps6594x: Add support for TPS6594X PMIC RTC
In reply to Matt RanostayFrom: Keerthy <[email protected]>
Add support for TPS6594X PMIC RTC. However, currently only get/set of time + date functionality is supported.
--- drivers/rtc/Kconfig | 10 ++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc-tps6594x.c | 181 +++++++++++++++++++++++++++++++++++++ 3 files changed, 192 insertions(+) create mode 100644 drivers/rtc/rtc-tps6594x.c
drivers/rtc/Kconfig +10 -0
@@ -588,6 +588,16 @@ config RTC_DRV_TPS65910 This driver can also be built as a module. If so, the module will be called rtc-tps65910. +config RTC_DRV_TPS6594X + tristate "TI TPS6594X RTC driver" + depends on MFD_TPS6594X + help + If you say yes here you get support for the RTC of TI TPS6594X series PMIC + chips. + + This driver can also be built as a module. If so, the module + will be called rtc-tps6594x. + config RTC_DRV_RC5T583 tristate "RICOH 5T583 RTC driver" depends on MFD_RC5T583
drivers/rtc/Makefile +1 -0
@@ -176,6 +176,7 @@ obj-$(CONFIG_RTC_DRV_TEST) += rtc-test.o obj-$(CONFIG_RTC_DRV_TI_K3) += rtc-ti-k3.o obj-$(CONFIG_RTC_DRV_TPS6586X) += rtc-tps6586x.o obj-$(CONFIG_RTC_DRV_TPS65910) += rtc-tps65910.o +obj-$(CONFIG_RTC_DRV_TPS6594X) += rtc-tps6594x.o obj-$(CONFIG_RTC_DRV_TWL4030) += rtc-twl.o obj-$(CONFIG_RTC_DRV_V3020) += rtc-v3020.o obj-$(CONFIG_RTC_DRV_VT8500) += rtc-vt8500.o
drivers/rtc/rtc-tps6594x.c new file +181 -0
181 lines not on this page · raw message
Signature · 1 line
2.38.GIT
Re: [PATCH v3 3/7] rtc: rtc-tps6594x: Add support for TPS6594X PMIC RTC
Quoted 19 lines · Matt Ranostay
From: Keerthy <[email protected]>
Add support for TPS6594X PMIC RTC. However, currently only get/set of time + date functionality is supported.
Signed-off-by Keerthy <[email protected]>Signed-off-by Matt Ranostay <[email protected]>--- drivers/rtc/Kconfig | 10 ++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc-tps6594x.c | 181 +++++++++++++++++++++++++++++++++++++ 3 files changed, 192 insertions(+) create mode 100644 drivers/rtc/rtc-tps6594x.cdrivers/rtc/Kconfig +0
-0
drivers/rtc/Kconfig config RTC_DRV_TPS65910 · line 593
Quoted 6 lines
drivers/rtc/Kconfig +3
-0@@ -588,6 +588,16 @@ config RTC_DRV_TPS65910 This driver can also be built as a module. If so, the module will be called rtc-tps65910. +config RTC_DRV_TPS6594X + tristate "TI TPS6594X RTC driver" + depends on MFD_TPS6594X
Perhaps: || COMPILE_TEST
(and test it)
Quoted 7 lines
drivers/rtc/Kconfig +7
-0+ help + If you say yes here you get support for the RTC of TI TPS6594X series PMIC + chips. + + This driver can also be built as a module. If so, the module + will be called rtc-tps6594x. +
(...)
drivers/rtc/Kconfig
Quoted 8 lines
drivers/rtc/Kconfig +8
-0+ +static int tps6594x_rtc_probe(struct platform_device *pdev) +{ + struct tps6594x *tps6594x = dev_get_drvdata(pdev->dev.parent); + struct tps6594x_rtc *tps6594x_rtc = NULL; + int ret; + + tps6594x_rtc = devm_kzalloc(&pdev->dev, sizeof(struct tps6594x_rtc), GFP_KERNEL);
That's not Linux coding style. Line is too long - wrapping is at 80. sizeof(*), not struct.
Quoted 11 lines
drivers/rtc/Kconfig +11
-0+ if (!tps6594x_rtc) + return -ENOMEM; + + tps6594x_rtc->dev = &pdev->dev; + platform_set_drvdata(pdev, tps6594x_rtc); + + /* Start RTC */ + ret = regmap_update_bits(tps6594x->regmap, TPS6594X_RTC_CTRL_1, + TPS6594X_RTC_CTRL_REG_STOP_RTC, + TPS6594X_RTC_CTRL_REG_STOP_RTC); + if (ret < 0) {
drivers/rtc/Kconfig
Quoted 10 lines
drivers/rtc/Kconfig +10
-0+ dev_err(&pdev->dev, "RTC_CTRL write failed, err = %d\n", ret); + return ret; + } + + tps6594x_rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name, + &tps6594x_rtc_ops, THIS_MODULE); + if (IS_ERR(tps6594x_rtc->rtc)) { + ret = PTR_ERR(tps6594x_rtc->rtc); + dev_err(&pdev->dev, "RTC register failed, err = %d\n", ret); + return ret;
return dev_err_probe
Best regards,
Krzysztof
Alexandre Belloni
maintainerRe: [PATCH v3 3/7] rtc: rtc-tps6594x: Add support for TPS6594X PMIC RTC
In reply to Matt RanostayHello,
drivers/rtc/rtc-tps6594x.c line 7
Quoted 13 lines · Matt Ranostay
drivers/rtc/rtc-tps6594x.c new file +7
-0@@ -0,0 +1,181 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* +* rtc-tps6594x.c -- TPS6594x Real Time Clock driver. +* +* Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com +* +* TODO: alarm support
Is this TODO actually useful? :)
drivers/rtc/rtc-tps6594x.c line 39
Quoted 11 lines
drivers/rtc/rtc-tps6594x.c new file +11
-0+static int tps6594x_rtc_read_time (struct device *dev,struct rtc_time *tm) +{ +unsigned char rtc_data[TPS6594X_NUM_TIME_REGS ]; +struct tps6594x *tps6594x =dev_get_drvdata (dev->parent); +int ret; + +/* Reset TPS6594X_RTC_CTRL_REG_GET_TIME bit to zero, required for latch */ + ret =regmap_update_bits (tps6594x->regmap,TPS6594X_RTC_CTRL_1 , +TPS6594X_RTC_CTRL_REG_GET_TIME ,0 ); +if (ret <0 ) { +dev_err (dev,"RTC CTRL reg update failed, err: %d\n" , ret);
I would avoid these messages that are not actually actionable.
Quoted 49 lines
drivers/rtc/rtc-tps6594x.c new file +49
-0+return ret; + } + +/* Copy RTC counting registers to static registers or latches */ + ret =regmap_update_bits (tps6594x->regmap,TPS6594X_RTC_CTRL_1 , +TPS6594X_RTC_CTRL_REG_GET_TIME ,TPS6594X_RTC_CTRL_REG_GET_TIME ); +if (ret <0 ) { +dev_err (dev,"RTC CTRL reg update failed, err: %d\n" , ret); +return ret; + } + + ret =regmap_bulk_read (tps6594x->regmap,TPS6594X_RTC_SECONDS , + rtc_data,TPS6594X_NUM_TIME_REGS ); +if (ret <0 ) { +dev_err (dev,"RTC_SECONDS reg read failed, err = %d\n" , ret); +return ret; + } + + tm->tm_sec =bcd2bin (rtc_data[0 ]); + tm->tm_min =bcd2bin (rtc_data[1 ]); + tm->tm_hour =bcd2bin (rtc_data[2 ]); + tm->tm_mday =bcd2bin (rtc_data[3 ]); + tm->tm_mon =bcd2bin (rtc_data[4 ]) -1 ; + tm->tm_year =bcd2bin (rtc_data[5 ]) +100 ; + +return ret; +} + +static int tps6594x_rtc_set_time (struct device *dev,struct rtc_time *tm) +{ +unsigned char rtc_data[TPS6594X_NUM_TIME_REGS ]; +struct tps6594x *tps6594x =dev_get_drvdata (dev->parent); +int ret, retries =5 ; +unsigned int val; + + rtc_data[0 ] =bin2bcd (tm->tm_sec); + rtc_data[1 ] =bin2bcd (tm->tm_min); + rtc_data[2 ] =bin2bcd (tm->tm_hour); + rtc_data[3 ] =bin2bcd (tm->tm_mday); + rtc_data[4 ] =bin2bcd (tm->tm_mon +1 ); + rtc_data[5 ] =bin2bcd (tm->tm_year -100 ); + +/* Stop RTC while updating the RTC time registers */ + ret =regmap_update_bits (tps6594x->regmap,TPS6594X_RTC_CTRL_1 , +TPS6594X_RTC_CTRL_REG_STOP_RTC ,0 ); +if (ret <0 ) { +dev_err (dev,"RTC stop failed, err = %d\n" , ret); +return ret; + }
drivers/rtc/rtc-tps6594x.c line 98
Quoted 10 lines
drivers/rtc/rtc-tps6594x.c new file +10
-0+ +/* Waiting till RTC isn't running */ +do { + ret =regmap_read (tps6594x->regmap,TPS6594X_RTC_STATUS , &val); +if (ret <0 ) { +dev_err (dev,"RTC_STATUS reg read failed, err = %d\n" , ret); +return ret; + } +msleep (20 ); + }while (--retries && (val &TPS6594X_RTC_STATUS_RUN ));
Maybe you should go for regmap_read_poll_timeout.
Quoted 39 lines
drivers/rtc/rtc-tps6594x.c new file +39
-0+ +if (!retries) { +dev_err (dev,"RTC_STATUS is still RUNNING\n" ); +return -ETIMEDOUT ; + } + + ret =regmap_bulk_write (tps6594x->regmap,TPS6594X_RTC_SECONDS , + rtc_data,TPS6594X_NUM_TIME_REGS ); +if (ret <0 ) { +dev_err (dev,"RTC_SECONDS reg write failed, err = %d\n" , ret); +return ret; + } + +/* Start back RTC */ + ret =regmap_update_bits (tps6594x->regmap,TPS6594X_RTC_CTRL_1 , +TPS6594X_RTC_CTRL_REG_STOP_RTC , +TPS6594X_RTC_CTRL_REG_STOP_RTC ); +if (ret <0 ) +dev_err (dev,"RTC start failed, err = %d\n" , ret); + +return ret; +} + +static const struct rtc_class_ops tps6594x_rtc_ops = { + .read_time = tps6594x_rtc_read_time, + .set_time = tps6594x_rtc_set_time, +}; + +static int tps6594x_rtc_probe (struct platform_device *pdev) +{ +struct tps6594x *tps6594x =dev_get_drvdata (pdev->dev.parent); +struct tps6594x_rtc *tps6594x_rtc =NULL ; +int ret; + + tps6594x_rtc =devm_kzalloc (&pdev->dev,sizeof (struct tps6594x_rtc ),GFP_KERNEL ); +if (!tps6594x_rtc) +return -ENOMEM ; + + tps6594x_rtc->dev = &pdev->dev;
drivers/rtc/rtc-tps6594x.c line 147
Quoted 10 lines
drivers/rtc/rtc-tps6594x.c new file +10
-0+platform_set_drvdata (pdev, tps6594x_rtc); + +/* Start RTC */ + ret =regmap_update_bits (tps6594x->regmap,TPS6594X_RTC_CTRL_1 , +TPS6594X_RTC_CTRL_REG_STOP_RTC , +TPS6594X_RTC_CTRL_REG_STOP_RTC ); +if (ret <0 ) { +dev_err (&pdev->dev,"RTC_CTRL write failed, err = %d\n" , ret); +return ret; + }
It doesn't make sense to start the RTC in probe as it is probably already started and time is kept properly or it is not started and then you can use this information in tps6594x_rtc_read_time as you know the time is not correct.
I'd rather ensure it is started in tps6594x_rtc_set_time.
drivers/rtc/rtc-tps6594x.c line 128
Quoted 2 lines
drivers/rtc/rtc-tps6594x.c new file +2
-0+ + tps6594x_rtc->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
This is deprecated, please use devm_rtc_allocate_device() and devm_rtc_register_device(). You also need to set the range properly.
drivers/rtc/rtc-tps6594x.c line 153
Quoted 4 lines
drivers/rtc/rtc-tps6594x.c new file +4
-0+ &tps6594x_rtc_ops, THIS_MODULE); +if (IS_ERR (tps6594x_rtc->rtc)) { + ret =PTR_ERR (tps6594x_rtc->rtc); +dev_err (&pdev->dev,"RTC register failed, err = %d\n" , ret);
This message is useless as the core aloready pronts an error on registration failure.
Quoted 31 lines
drivers/rtc/rtc-tps6594x.c new file +28
-0+return ret; + } + +return 0 ; +} + +#ifdef CONFIG_OF +static const struct of_device_id of_tps6594x_rtc_match[] = { + { .compatible ="ti,tps6594x-rtc" , }, + {}, +}; +MODULE_DEVICE_TABLE (of, of_tps6594x_rtc_match); +#endif + +static struct platform_driver tps6594x_rtc_driver = { + .probe = tps6594x_rtc_probe, + .driver = { + .name ="tps6594x-rtc" , + .of_match_table =of_match_ptr (of_tps6594x_rtc_match), + }, +}; + +module_platform_driver (tps6594x_rtc_driver); + +MODULE_ALIAS ("platform:tps6594x_rtc" ); +MODULE_DESCRIPTION ("TI TPS6594x series RTC driver" ); +MODULE_AUTHOR ("Keerthy J <[email protected]>" ); +MODULE_LICENSE ("GPL" );Signature · 1 line
2.38.GIT
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v3 4/7 gpio: tps6594x: add GPIO support for TPS6594x PMIC
In reply to Matt RanostayAdd support for TPS6594X PMICs GPIO interface that has 11 that can be configured as input or outputs.
--- drivers/gpio/Kconfig | 7 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-tps6594x.c | 142 +++++++++++++++++++++++++++++++++++ include/linux/mfd/tps6594x.h | 6 ++ 4 files changed, 156 insertions(+) create mode 100644 drivers/gpio/gpio-tps6594x.c
drivers/gpio/Kconfig +7 -0
@@ -1405,6 +1405,13 @@ config GPIO_TPS65912 help This driver supports TPS65912 GPIO chip. +config GPIO_TPS6594X + tristate "TI TPS6594X GPIO driver" + depends on MFD_TPS6594X + help + Select this option to enable GPIO driver for the TPS6954X + PMIC chip family. There are 11 GPIOs that can be configured. + config GPIO_TPS68470 tristate "TPS68470 GPIO" depends on INTEL_SKL_INT3472
drivers/gpio/Makefile +1 -0
@@ -158,6 +158,7 @@ obj-$(CONFIG_GPIO_TPS65218) += gpio-tps65218.o obj-$(CONFIG_GPIO_TPS6586X) += gpio-tps6586x.o obj-$(CONFIG_GPIO_TPS65910) += gpio-tps65910.o obj-$(CONFIG_GPIO_TPS65912) += gpio-tps65912.o +obj-$(CONFIG_GPIO_TPS6594X) += gpio-tps6594x.o obj-$(CONFIG_GPIO_TPS68470) += gpio-tps68470.o obj-$(CONFIG_GPIO_TQMX86) += gpio-tqmx86.o obj-$(CONFIG_GPIO_TS4800) += gpio-ts4800.o
drivers/gpio/gpio-tps6594x.c new file +142 -0
142 lines not on this page · raw message
include/linux/mfd/tps6594x.h +6 -0
@@ -21,6 +21,12 @@#define TPS6594X_FSM_I2C_TRIGGERS 0x85#define TPS6594X_FSM_NSLEEP_TRIGGERS 0x86 +#define TPS6594X_GPIO1_CONF 0x31 +#define TPS6594X_GPIO_OUT_1 0x3d +#define TPS6594X_GPIO_OUT_2 0x3e +#define TPS6594X_GPIO_IN_1 0x3f +#define TPS6594X_GPIO_IN_2 0x40 +#define TPS6594X_RTC_SECONDS 0xb5#define TPS6594X_RTC_MINUTES 0xb6#define TPS6594X_RTC_HOURS 0xb7
Signature · 1 line
2.38.GIT
Re: [PATCH v3 4/7] gpio: tps6594x: add GPIO support for TPS6594x PMIC
Quoted 18 lines · Matt Ranostay
Add support for TPS6594X PMICs GPIO interface that has 11 that can be configured as input or outputs.
Tested-by Keerthy <[email protected]>Signed-off-by Matt Ranostay <[email protected]>--- drivers/gpio/Kconfig | 7 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-tps6594x.c | 142 +++++++++++++++++++++++++++++++++++ include/linux/mfd/tps6594x.h | 6 ++ 4 files changed, 156 insertions(+) create mode 100644 drivers/gpio/gpio-tps6594x.cdrivers/gpio/Kconfig +0
-0
drivers/gpio/Kconfig config GPIO_TPS65912 · line 1410
Quoted 6 lines
drivers/gpio/Kconfig +3
-0@@ -1405,6 +1405,13 @@ config GPIO_TPS65912 help This driver supports TPS65912 GPIO chip. +config GPIO_TPS6594X + tristate "TI TPS6594X GPIO driver" + depends on MFD_TPS6594X
Maybe || COMPILE_TEST?
Quoted 4 lines
drivers/gpio/Kconfig +4
-0+ help + Select this option to enable GPIO driver for the TPS6954X + PMIC chip family. There are 11 GPIOs that can be configured. +
(...)
drivers/gpio/Kconfig
Quoted 7 lines
drivers/gpio/Kconfig +7
-0+ +static int tps6594x_gpio_probe(struct platform_device *pdev) +{ + struct tps6594x *tps = dev_get_drvdata(pdev->dev.parent); + struct tps6594x_gpio *gpio; + + gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);
and here you did it correctly... I don't get why your two patches differ.
Quoted 10 lines
drivers/gpio/Kconfig +10
-0+ if (!gpio) + return -ENOMEM; + + gpio->tps = dev_get_drvdata(pdev->dev.parent); + gpio->gpio_chip = template_chip; + gpio->gpio_chip.parent = tps->dev; + + return devm_gpiochip_add_data(&pdev->dev, &gpio->gpio_chip, gpio); +} +
drivers/gpio/Kconfig
Quoted 10 lines
drivers/gpio/Kconfig +10
-0+static const struct of_device_id of_tps6594x_gpio_match[] = { + { .compatible = "ti,tps6594x-gpio", }, + {}, +}; +MODULE_DEVICE_TABLE(of, of_tps6594x_gpio_match); + +static struct platform_driver tps6594x_gpio_driver = { + .driver = { + .name = "tps6594x-gpio", + .of_match_table = of_match_ptr(of_tps6594x_gpio_match),
Drop of_match_ptr(). It comes with maybe_unused, which you do not have here.
Best regards,
Krzysztof
Re: [PATCH v3 4/7] gpio: tps6594x: add GPIO support for TPS6594x PMIC
In reply to Matt RanostayQuoted 5 lines · Matt Ranostay
Add support for TPS6594X PMICs GPIO interface that has 11 that can be configured as input or outputs.
Tested-by Keerthy <[email protected]>Signed-off-by Matt Ranostay <[email protected]>
(...)
drivers/gpio/Kconfig config GPIO_TPS65912 · line 1413
Quoted 6 lines
drivers/gpio/Kconfig +6
-0+config GPIO_TPS6594X + tristate "TI TPS6594X GPIO driver" + depends on MFD_TPS6594X + help + Select this option to enable GPIO driver for the TPS6954X + PMIC chip family. There are 11 GPIOs that can be configured.
select GPIO_REGMAP
This driver is an archetypical example of a driver that can make great use of GPIO_REGMAP helpers, so rewrite it to use them.
Look in drivers/gpio/gpio-sl28cpld.c for an example.
Yours,
Linus Walleij
Re: [PATCH v3 4/7] gpio: tps6594x: add GPIO support for TPS6594x PMIC
Quoted 16 lines · Linus Walleij
Quoted 5 lines · Matt Ranostay
Add support for TPS6594X PMICs GPIO interface that has 11 that can be configured as input or outputs.
Tested-by Keerthy <[email protected]>Signed-off-by Matt Ranostay <[email protected]>(...)
drivers/gpio/Kconfig config GPIO_TPS65912 · line 1413
Quoted 6 lines
drivers/gpio/Kconfig +6
-0+config GPIO_TPS6594X + tristate "TI TPS6594X GPIO driver" + depends on MFD_TPS6594X + help + Select this option to enable GPIO driver for the TPS6954X + PMIC chip family. There are 11 GPIOs that can be configured.
Quoted 5 lines
select
GPIO_REGMAPThis driver is an archetypical example of a driver that can make great use of
GPIO_REGMAPhelpers, so rewrite it to use them.
Look indrivers/gpio/gpio-sl28cpld.cfor an example.
Linus,
Those helpers look great for this usecase on the surface but however I think there could be some issues. For GPIO direction it isn't configured by a bitmap on a register(s) but by a bit on a range of registers (with a register for each GPIOx).
For set/get values the gpio helper would work though.
- Matt
Quoted 3 lines
Yours,
Linus Walleij
Re: [PATCH v3 4/7] gpio: tps6594x: add GPIO support for TPS6594x PMIC
Quoted 23 lines · Matt Ranostay
Quoted 16 lines · Linus Walleij
Quoted 5 lines · Matt Ranostay
Add support for TPS6594X PMICs GPIO interface that has 11 that can be configured as input or outputs.
Tested-by Keerthy <[email protected]>Signed-off-by Matt Ranostay <[email protected]>(...)
drivers/gpio/Kconfig config GPIO_TPS65912 · line 1413
Quoted 6 lines
drivers/gpio/Kconfig +6
-0+config GPIO_TPS6594X + tristate "TI TPS6594X GPIO driver" + depends on MFD_TPS6594X + help + Select this option to enable GPIO driver for the TPS6954X + PMIC chip family. There are 11 GPIOs that can be configured.Quoted 5 lines
select
GPIO_REGMAPThis driver is an archetypical example of a driver that can make great use of
GPIO_REGMAPhelpers, so rewrite it to use them.
Look indrivers/gpio/gpio-sl28cpld.cfor an example.
Quoted 7 lines
Linus,
Those helpers look great for this usecase on the surface but however I think there could be some issues. For GPIO direction it isn't configured by a bitmap on a register(s) but by a bit on a range of registers (with a register for each GPIOx).
For set/get values the gpio helper would work though.
Isn't is possible to just use parts of the GPIO_REGMAP helpers? I thought it's designed like such.
Michael Walle will know what to do with your usecase, and whether to use it or not, let's page him!
Yours,
Linus Walleij
Re: [PATCH v3 4/7] gpio: tps6594x: add GPIO support for TPS6594x PMIC
Quoted 30 lines · Linus Walleij
Quoted 29 lines · Matt Ranostay
Quoted 16 lines · Linus Walleij
Quoted 5 lines · Matt Ranostay
Add support for TPS6594X PMICs GPIO interface that has 11 that can be configured as input or outputs.
Tested-by Keerthy <[email protected]>Signed-off-by Matt Ranostay <[email protected]>(...)
drivers/gpio/Kconfig config GPIO_TPS65912 · line 1413
Quoted 6 lines
drivers/gpio/Kconfig +6
-0+config GPIO_TPS6594X + tristate "TI TPS6594X GPIO driver" + depends on MFD_TPS6594X + help + Select this option to enable GPIO driver for the TPS6954X + PMIC chip family. There are 11 GPIOs that can be configured.Quoted 5 lines
select
GPIO_REGMAPThis driver is an archetypical example of a driver that can make great use of
GPIO_REGMAPhelpers, so rewrite it to use them.
Look indrivers/gpio/gpio-sl28cpld.cfor an example.Linus,
Those helpers look great for this usecase on the surface but however I think there could be some issues. For GPIO direction it isn't configured by a bitmap on a register(s) but by a bit on a range of registers (with a register for each GPIOx).
Quoted 8 lines
Quoted 1 line
For set/get values the gpio helper would work though.
Isn't is possible to just use parts of the
GPIO_REGMAPhelpers? I thought it's designed like such.Michael Walle will know what to do with your usecase, and whether to use it or not, let's page him!
So after looking around a bit and digging into the helper code I found this drivers/pinctrl/bcm/pinctrl-bcm63xx.c which has a example on how to override the reg_mask_xlate function which could be used for changing the stride, and mask based on the base address.
Currently have coded up using the gpio regmap helper. Will run through some testing first and then submit for review.
- Matt
Quoted 2 lines
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v3 4/7] gpio: tps6594x: add GPIO support for TPS6594x PMIC
Hi,
Am 2022-11-11 09:58, schrieb Matt Ranostay:
Quoted 25 lines · Linus Walleij
Quoted 24 lines · Matt Ranostay
Quoted 23 lines · Linus Walleij
Quoted 21 lines · Matt Ranostay
Quoted 6 lines
Add support for TPS6594X PMICs GPIO interface that has 11 that can be configured as input or outputs.
Tested-by Keerthy <[email protected]>Signed-off-by Matt Ranostay <[email protected]>(...)
drivers/gpio/Kconfig config GPIO_TPS65912 · line 1413
Quoted 6 lines
drivers/gpio/Kconfig +6
-0+config GPIO_TPS6594X + tristate "TI TPS6594X GPIO driver" + depends on MFD_TPS6594X + help + Select this option to enable GPIO driver for the TPS6954X + PMIC chip family. There are 11 GPIOs that can be configured.select
GPIO_REGMAPThis driver is an archetypical example of a driver that can make great use of
GPIO_REGMAPhelpers, so rewrite it to use them.
Look indrivers/gpio/gpio-sl28cpld.cfor an example.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Linus,
Those helpers look great for this usecase on the surface but however I think there could be some issues. For GPIO direction it isn't configured by a bitmap on a register(s) but by a bit on a range of registers (with a register for each GPIOx).
As long as there is only one register to be changed per pin/action, .reg_mask_xlate should work, as you've already found out.
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
For set/get values the gpio helper would work though.
Isn't is possible to just use parts of the
GPIO_REGMAPhelpers? I thought it's designed like such.
No, you can't use them as they are kept private, along with the needed struct gpio_regmap. Which was intentional back then as it should be easier to change the implementation or add features without its use being spread all over the gpio drivers.
We could change that though - or just add the needed feature to gpio-regmap if it looks generic enough.
Quoted 11 lines
Quoted 4 lines
Michael Walle will know what to do with your usecase, and whether to use it or not, let's page him!
So after looking around a bit and digging into the helper code I found this
drivers/pinctrl/bcm/pinctrl-bcm63xx.cwhich has a example on how to override thereg_mask_xlatefunction which could be used for changing the stride, and mask
based on the base address.
Quoted 3 lines
Currently have coded up using the gpio regmap helper. Will run through some testing
first and then submit for review.
Sounds promising.
-michael
PATCH v3 5/7 arm64: dts: ti: k3-j7200-common-proc-board: Add TPS6594x PMIC node
In reply to Matt RanostayFrom: Keerthy <[email protected]>
Add TPS6594x PMIC, GPIO, and RTC definitions for J7200 common processor board device tree.
--- .../boot/dts/ti/k3-j7200-common-proc-board.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts +17 -0
@@ -333,3 +333,20 @@ &pcie1_ep { num-lanes = <2>; status = "disabled"; }; + +&wkup_i2c0 { + status = "okay"; + tps6594x: tps6594x@48 { + compatible = "ti,tps6594x"; + reg = <0x48>; + ti,system-power-controller; + + rtc { + compatible = "ti,tps6594x-rtc"; + }; + + gpio { + compatible = "ti,tps6594x-gpio"; + }; + }; +};
Signature · 1 line
2.38.GIT
Re: [PATCH v3 5/7] arm64: dts: ti: k3-j7200-common-proc-board: Add TPS6594x PMIC node
Quoted 16 lines · Matt Ranostay
From: Keerthy <[email protected]>
Add TPS6594x PMIC, GPIO, and RTC definitions for J7200 common processor board device tree.
Signed-off-by Keerthy <[email protected]>Signed-off-by Matt Ranostay <[email protected]>--- .../boot/dts/ti/k3-j7200-common-proc-board.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts +0
-0
arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts &pcie1_ep { · line 339
Quoted 7 lines
arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts +4
-0@@ -333,3 +333,20 @@ &pcie1_ep { num-lanes = <2>; status = "disabled"; }; + +&wkup_i2c0 { + status = "okay"; + tps6594x: tps6594x@48 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
PATCH v3 6/7 arm64: dts: ti: k3-j721e-common-proc-board: Add TPS6594x PMIC node
In reply to Matt RanostayAdd TPS6594x PMIC, GPIO, and RTC definitions for J721E common processor board device tree.
--- .../boot/dts/ti/k3-j721e-common-proc-board.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +17 -0
@@ -904,3 +904,20 @@ &main_mcan2 { pinctrl-0 = <&main_mcan2_pins_default>; phys = <&transceiver4>; }; + +&wkup_i2c0 { + status = "okay"; + tps6594x: tps6594x@48 { + compatible = "ti,tps6594x"; + reg = <0x48>; + ti,system-power-controller; + + rtc { + compatible = "ti,tps6594x-rtc"; + }; + + gpio { + compatible = "ti,tps6594x-gpio"; + }; + }; +};
Signature · 1 line
2.38.GIT
Re: [PATCH v3 6/7] arm64: dts: ti: k3-j721e-common-proc-board: Add TPS6594x PMIC node
Quoted 13 lines · Matt Ranostay
Add TPS6594x PMIC, GPIO, and RTC definitions for J721E common processor board device tree.
Signed-off-by Matt Ranostay <[email protected]>--- .../boot/dts/ti/k3-j721e-common-proc-board.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +0
-0
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts &main_mcan2 { · line 910
Quoted 7 lines
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +4
-0@@ -904,3 +904,20 @@ &main_mcan2 { pinctrl-0 = <&main_mcan2_pins_default>; phys = <&transceiver4>; }; + +&wkup_i2c0 { + status = "okay"; + tps6594x: tps6594x@48 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
PATCH v3 7/7 arm64: dts: ti: k3-j721s2-common-proc-board: Add TPS6594x PMIC node
In reply to Matt RanostayAdd TPS6594x PMIC, GPIO, and RTC definitions for j721s2 common processor board device tree.
--- .../boot/dts/ti/k3-j721s2-common-proc-board.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts +17 -0
@@ -309,3 +309,20 @@ &mcu_mcan1 { pinctrl-0 = <&mcu_mcan1_pins_default>; phys = <&transceiver2>; }; + +&wkup_i2c0 { + status = "okay"; + tps6594x: tps6594x@48 { + compatible = "ti,tps6594x"; + reg = <0x48>; + ti,system-power-controller; + + rtc { + compatible = "ti,tps6594x-rtc"; + }; + + gpio { + compatible = "ti,tps6594x-gpio"; + }; + }; +};
Signature · 1 line
2.38.GIT
Re: [PATCH v3 7/7] arm64: dts: ti: k3-j721s2-common-proc-board: Add TPS6594x PMIC node
Quoted 13 lines · Matt Ranostay
Add TPS6594x PMIC, GPIO, and RTC definitions for j721s2 common processor board device tree.
Signed-off-by Matt Ranostay <[email protected]>--- .../boot/dts/ti/k3-j721s2-common-proc-board.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts +0
-0
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts &mcu_mcan1 { · line 316
Quoted 8 lines
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts +5
-0@@ -309,3 +309,20 @@ &mcu_mcan1 { pinctrl-0 = <&mcu_mcan1_pins_default>; phys = <&transceiver2>; }; + +&wkup_i2c0 { + status = "okay"; + tps6594x: tps6594x@48 { + compatible = "ti,tps6594x";
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof