cifs: call pagecache_isize_extended() in cifs_setsize() when extending
Subsystems (3)
PATCH 1/1 cifs: call pagecache_isize_extended() in cifs_setsize() when extending
cifs_setsize() calls truncate_pagecache() but skips pagecache_isize_extended() on extension. truncate_setsize() shows the correct pattern:
i_size_write(inode, newsize);
if (newsize > oldsize)
pagecache_isize_extended(inode, oldsize, newsize);
truncate_pagecache(inode, newsize);pagecache_isize_extended() zeroes the tail of the page straddling old EOF. Without it, dirty bytes in that region can be written back to the server, exposing stale data in the newly extended range.
--- fs/smb/client/inode.c | 2 ++ 1 file changed, 2 insertions(+)
fs/smb/client/inode.c +2 -0
@@ -3059,6 +3059,8 @@ void cifs_setsize(struct inode *inode, loff_t offset) inode->i_blocks = blocks;spin_unlock (&inode->i_lock);inode_set_mtime_to_ts (inode,inode_set_ctime_current (inode)); +if (offset > old_size) +pagecache_isize_extended (inode, old_size, offset);truncate_pagecache (inode, offset);netfs_wait_for_outstanding_io (inode); }
Signature · 1 line
2.55.0
Quoted 10 lines · Frank Sorenson
cifs_setsize()callstruncate_pagecache()but skipspagecache_isize_extended()on extension.truncate_setsize()shows the correct pattern:i_size_write(inode, newsize); if (newsize > oldsize) pagecache_isize_extended(inode, oldsize, newsize); truncate_pagecache(inode, newsize);
Quoted 7 lines
pagecache_isize_extended()zeroes the tail of the page straddling old EOF. Without it, dirty bytes in that region can be written back to the server, exposing stale data in the newly extended range.Cc David Howells <[email protected]>Signed-off-by Frank Sorenson <[email protected]>
Thanks.
Quoted 9 lines · Frank Sorenson
cifs_setsize()callstruncate_pagecache()but skipspagecache_isize_extended()on extension.truncate_setsize()shows the correct pattern:i_size_write(inode, newsize); if (newsize > oldsize) pagecache_isize_extended(inode, oldsize, newsize); truncate_pagecache(inode, newsize);
Quoted 4 lines
pagecache_isize_extended()zeroes the tail of the page straddling old EOF. Without it, dirty bytes in that region can be written back to the server, exposing stale data in the newly extended range.
...
Applied.