Skip to contentSkip to conversation

disable_local_APIC() is only available when CONFIG_X86_LOCAL_APIC is defined

PATCH In review Jesper Juhl 1 participant 2 messages Sep 4, 2005 – Sep 5, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 disable_local_APIC() is only available when CONFIG_X86_LOCAL_APIC is defined

`disable_local_APIC' is only available when CONFIG_X86_LOCAL_APIC is defined :

arch/i386/kernel/crash.c: In function `crash_nmi_callback':
arch/i386/kernel/crash.c:153: warning: implicit declaration of function disable_local_APIC' arch/i386/kernel/crash.c: In function nmi_shootdown_cpus':
arch/i386/kernel/crash.c:195: warning: implicit declaration of function `disable_local_APIC'

There may be a better fix, but the below seems to do the trick.

arch/i386/kernel/crash.c +4 -0
@@ -150,7 +150,9 @@ static int crash_nmi_callback(struct pt_
 		regs = &fixed_regs;
 	}
 	crash_save_this_cpu(regs, cpu);
+#ifdef CONFIG_X86_LOCAL_APIC
 	disable_local_APIC();
+#endif
 	atomic_dec(&waiting_for_crash_ipi);
 	/* Assume hlt works */
 	halt();
@@ -190,7 +192,9 @@ static void nmi_shootdown_cpus(void)
 	}
 
 	/* Leave the nmi callback set */
+#ifdef CONFIG_X86_LOCAL_APIC
 	disable_local_APIC();
+#endif
 }
 #else
 static void nmi_shootdown_cpus(void)
#1 lore raw
Quoted 10 lines · Jesper Juhl

`disable_local_APIC' is only available when CONFIG_X86_LOCAL_APIC is defined :

arch/i386/kernel/crash.c: In function `crash_nmi_callback':
arch/i386/kernel/crash.c:153: warning: implicit declaration of function disable_local_APIC' arch/i386/kernel/crash.c: In function nmi_shootdown_cpus':
arch/i386/kernel/crash.c:195: warning: implicit declaration of function `disable_local_APIC'

There may be a better fix, but the below seems to do the trick.

[snip]

I guess the better fix is to just provide a dummy function in the case of CONFIG_X86_LOCAL_APIC not being defined.
If so, just let me know and I'll cook up a patch to do that, instead of the ugly ifdef's.

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html