iio: adc: ti-adc081c: Select IIO_TRIGGERED_BUFFER to prevent build errors
PATCH 1/1 iio: adc: ti-adc081c: Select IIO_TRIGGERED_BUFFER to prevent build errors
Commit 08e05d1fce5c ("ti-adc081c: Initial triggered buffer support") added triggered buffer support but that also requires CONFIG_IIO_TRIGGERED_BUFFER, otherwise we get errors from linker such as:
drivers/built-in.o: In function `adc081c_remove':
drivers/iio/adc/ti-adc081c.c:225: undefined reference to `iio_triggered_buffer_cleanup'
Fix these by explicitly selecting both CONFIG_IIO_TRIGGERED_BUFFER and CONFIG_IIO_BUFFER in Kconfig for the driver.
--- drivers/iio/adc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/iio/adc/Kconfig +2 -0
@@ -400,6 +400,8 @@ config ROCKCHIP_SARADC config TI_ADC081C tristate "Texas Instruments ADC081C/ADC101C/ADC121C family" depends on I2C + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help If you say yes here you get support for Texas Instruments ADC081C, ADC101C and ADC121C ADC chips.
Signature · 1 line
2.9.3
Jonathan Cameron
maintainerQuoted 11 lines · Mika Westerberg
Commit
08e05d1fce5c("ti-adc081c: Initial triggered buffer support") added triggered buffer support but that also requiresCONFIG_IIO_TRIGGERED_BUFFER, otherwise we get errors from linker such as:
drivers/built-in.o: In function `adc081c_remove':
drivers/iio/adc/ti-adc081c.c:225: undefined reference to `iio_triggered_buffer_cleanup'Fix these by explicitly selecting both
CONFIG_IIO_TRIGGERED_BUFFERandCONFIG_IIO_BUFFERinKconfigfor the driver.Signed-off-by Mika Westerberg <[email protected]>
Applied to the fixes-togreg-post-rc1 branch of iio.git which I'll send a pull request for once the merge window is closed. Strange this one got through the autobuilders (less strange that it snuck past me reviewing it ;(
Fengguang, any thoughts?
Thanks,
Jonathan
Quoted 18 lines
--- drivers/iio/adc/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/iio/adc/Kconfig +2
-0@@ -400,6 +400,8 @@ config ROCKCHIP_SARADC config TI_ADC081C tristate "Texas Instruments ADC081C/ADC101C/ADC121C family" depends on I2C + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help If you say yes here you get support for Texas Instruments ADC081C, ADC101C and ADC121C ADC chips.
Quoted 11 lines · Jonathan Cameron
Quoted 10 lines · Mika Westerberg
Commit
08e05d1fce5c("ti-adc081c: Initial triggered buffer support") added triggered buffer support but that also requiresCONFIG_IIO_TRIGGERED_BUFFER, otherwise we get errors from linker such as:
drivers/built-in.o: In function `adc081c_remove':
drivers/iio/adc/ti-adc081c.c:225: undefined reference to `iio_triggered_buffer_cleanup'Fix these by explicitly selecting both
CONFIG_IIO_TRIGGERED_BUFFERandCONFIG_IIO_BUFFERinKconfigfor the driver.
Quoted 7 lines
Quoted 1 line
Signed-off-by Mika Westerberg <[email protected]>Applied to the fixes-togreg-post-rc1 branch of iio.git which I'll send a pull request for once the merge window is closed. Strange this one got through the autobuilders (less strange that it snuck past me reviewing it ;(
Fengguang, any thoughts?
Sorry I find no log for that error and noticed 08e05d1fce5c is half year old which is not contained in any recent updated trees. Many things could have been changed/fixed during the time -- if you look at
https://lists.01.org/pipermail/kbuild-all/2016-May/thread.html
There are significant less error reports in May, which probably impacts late April as well -- at the time the commit is introduced. Then the problems are discovered and the report number is restored to over 1000 in June.
Thanks,
Fengguang
Quoted 30 lines · Fengguang Wu
Quoted 2 lines · Jonathan Cameron
Quoted 1 line · Mika Westerberg
Commit
08e05d1fce5c("ti-adc081c: Initial triggered buffer support")added
Quoted 1 line
Quoted 1 line
triggered buffer support but that also requires
CONFIG_IIO_TRIGGERED_BUFFER,Quoted 4 lines
Quoted 4 lines
otherwise we get errors from linker such as:
drivers/built-in.o: In function `adc081c_remove':
drivers/iio/adc/ti-adc081c.c:225: undefined reference to`iio_triggered_buffer_cleanup'
Quoted 2 lines
Quoted 2 lines
Fix these by explicitly selecting both
CONFIG_IIO_TRIGGERED_BUFFERand
Quoted 9 lines
Quoted 3 lines
CONFIG_IIO_BUFFERinKconfigfor the driver.Signed-off-by Mika Westerberg <[email protected]>Applied to the fixes-togreg-post-rc1 branch of iio.git which I'll send a pull request for once the merge window is closed. Strange this one got through the autobuilders (less strange that it snuck past me reviewing it ;(
Fengguang, any thoughts?
Sorry I find no log for that error and noticed
08e05d1fce5cis half year old which is not contained in any recent updated trees. Many things could have been changed/fixed during the time -- if you look athttps://lists.01.org/pipermail/kbuild-all/2016-May/thread.html
Quoted 7 lines
There are significant less error reports in May, which probably impacts late April as well -- at the time the commit is introduced. Then the problems are discovered and the report number is restored to over 1000 in June.
Thanks,
Fengguang
Cool. I hadn't registered it was that old.
Thank
Jonathan
Signature · 1 line
Sent from my Android device with K-9 Mail. Please excuse my brevity.