drivers: iio: Drop unnecessary explicit casting
PATCH 1/1 drivers: iio: Drop unnecessary explicit casting
Provide correct specifiers while printing error logs to discard the use of unnecessary explicit casting.
---
Based on previous conversations which can be found here [1].
[1] https://marc.info/?l=linux-iio&m=158427554607223&w=2
--- drivers/iio/accel/kxsd9-i2c.c | 4 ++-- drivers/iio/gyro/bmg160_i2c.c | 4 ++-- drivers/iio/gyro/bmg160_spi.c | 4 ++-- drivers/iio/gyro/mpu3050-i2c.c | 4 ++-- drivers/iio/imu/bmi160/bmi160_i2c.c | 4 ++-- drivers/iio/imu/bmi160/bmi160_spi.c | 4 ++-- drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 4 ++-- drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c | 4 ++-- drivers/iio/magnetometer/bmc150_magn_spi.c | 4 ++-- 9 files changed, 18 insertions(+), 18 deletions(-)
drivers/iio/accel/kxsd9-i2c.c +2 -2
@@ -21,8 +21,8 @@ static int kxsd9_i2c_probe(struct i2c_client *i2c, regmap =devm_regmap_init_i2c (i2c, &config);if (IS_ERR (regmap)) { -dev_err (&i2c->dev,"Failed to register i2c regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&i2c->dev,"Failed to register i2c regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }
drivers/iio/gyro/bmg160_i2c.c +2 -2
@@ -21,8 +21,8 @@ static int bmg160_i2c_probe(struct i2c_client *client, regmap =devm_regmap_init_i2c (client, &bmg160_regmap_i2c_conf);if (IS_ERR (regmap)) { -dev_err (&client->dev,"Failed to register i2c regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&client->dev,"Failed to register i2c regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }
drivers/iio/gyro/bmg160_spi.c +2 -2
@@ -19,8 +19,8 @@ static int bmg160_spi_probe(struct spi_device *spi) regmap =devm_regmap_init_spi (spi, &bmg160_regmap_spi_conf);if (IS_ERR (regmap)) { -dev_err (&spi->dev,"Failed to register spi regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&spi->dev,"Failed to register spi regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }
drivers/iio/gyro/mpu3050-i2c.c +2 -2
@@ -51,8 +51,8 @@ static int mpu3050_i2c_probe(struct i2c_client *client, regmap =devm_regmap_init_i2c (client, &mpu3050_i2c_regmap_config);if (IS_ERR (regmap)) { -dev_err (&client->dev,"Failed to register i2c regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&client->dev,"Failed to register i2c regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }
drivers/iio/imu/bmi160/bmi160_i2c.c +2 -2
@@ -24,8 +24,8 @@ static int bmi160_i2c_probe(struct i2c_client *client, regmap =devm_regmap_init_i2c (client, &bmi160_regmap_config);if (IS_ERR (regmap)) { -dev_err (&client->dev,"Failed to register i2c regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&client->dev,"Failed to register i2c regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }
drivers/iio/imu/bmi160/bmi160_spi.c +2 -2
@@ -20,8 +20,8 @@ static int bmi160_spi_probe(struct spi_device *spi) regmap =devm_regmap_init_spi (spi, &bmi160_regmap_config);if (IS_ERR (regmap)) { -dev_err (&spi->dev,"Failed to register spi regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&spi->dev,"Failed to register spi regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }return bmi160_core_probe (&spi->dev, regmap, id->name, true);
drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c +2 -2
@@ -122,8 +122,8 @@ static int inv_mpu_probe(struct i2c_client *client, regmap =devm_regmap_init_i2c (client, &inv_mpu_regmap_config);if (IS_ERR (regmap)) { -dev_err (&client->dev,"Failed to register i2c regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&client->dev,"Failed to register i2c regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }
drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c +2 -2
@@ -53,8 +53,8 @@ static int inv_mpu_probe(struct spi_device *spi) regmap =devm_regmap_init_spi (spi, &inv_mpu_regmap_config);if (IS_ERR (regmap)) { -dev_err (&spi->dev,"Failed to register spi regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&spi->dev,"Failed to register spi regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }
drivers/iio/magnetometer/bmc150_magn_spi.c +2 -2
@@ -22,8 +22,8 @@ static int bmc150_magn_spi_probe(struct spi_device *spi) regmap =devm_regmap_init_spi (spi, &bmc150_magn_regmap_config);if (IS_ERR (regmap)) { -dev_err (&spi->dev,"Failed to register spi regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&spi->dev,"Failed to register spi regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }return bmc150_magn_probe (&spi->dev, regmap, spi->irq, id->name);
Signature · 1 line
2.20.1
Jonathan Cameron
maintainerQuoted 4 lines · On Wed, 18 Mar 2020 15:37:54 +0530 Nishant Malpani <[email protected]>…
Provide correct specifiers while printing error logs to discard the use of unnecessary explicit casting.
Signed-off-by Nishant Malpani <[email protected]>
Looks good in general, but I'd prefer one patch per driver (all in a series for easy applying).
The reason is that these may need to be applied by someone as a precursor to an actual fix. If we have them as one big set they have to do considerably more work to use them than if we keep the patches independent for each of the drivers.
Except in very rare cases we try to avoid patches that cover multiple otherwise independent bits of code.
Thanks,
Jonathan
Quoted 152 lines
---
Based on previous conversations which can be found here [1].
[1] https://marc.info/?l=linux-iio&m=158427554607223&w=2
--- drivers/iio/accel/kxsd9-i2c.c | 4 ++-- drivers/iio/gyro/bmg160_i2c.c | 4 ++-- drivers/iio/gyro/bmg160_spi.c | 4 ++-- drivers/iio/gyro/mpu3050-i2c.c | 4 ++-- drivers/iio/imu/bmi160/bmi160_i2c.c | 4 ++-- drivers/iio/imu/bmi160/bmi160_spi.c | 4 ++-- drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 4 ++-- drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c | 4 ++-- drivers/iio/magnetometer/bmc150_magn_spi.c | 4 ++-- 9 files changed, 18 insertions(+), 18 deletions(-)drivers/iio/accel/kxsd9-i2c.c +2
-2@@ -21,8 +21,8 @@ static int kxsd9_i2c_probe(struct i2c_client *i2c, regmap =devm_regmap_init_i2c (i2c, &config);if (IS_ERR (regmap)) { -dev_err (&i2c->dev,"Failed to register i2c regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&i2c->dev,"Failed to register i2c regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }drivers/iio/gyro/bmg160_i2c.c +2
-2@@ -21,8 +21,8 @@ static int bmg160_i2c_probe(struct i2c_client *client, regmap =devm_regmap_init_i2c (client, &bmg160_regmap_i2c_conf);if (IS_ERR (regmap)) { -dev_err (&client->dev,"Failed to register i2c regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&client->dev,"Failed to register i2c regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }drivers/iio/gyro/bmg160_spi.c +2
-2@@ -19,8 +19,8 @@ static int bmg160_spi_probe(struct spi_device *spi) regmap =devm_regmap_init_spi (spi, &bmg160_regmap_spi_conf);if (IS_ERR (regmap)) { -dev_err (&spi->dev,"Failed to register spi regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&spi->dev,"Failed to register spi regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }drivers/iio/gyro/mpu3050-i2c.c +2
-2@@ -51,8 +51,8 @@ static int mpu3050_i2c_probe(struct i2c_client *client, regmap =devm_regmap_init_i2c (client, &mpu3050_i2c_regmap_config);if (IS_ERR (regmap)) { -dev_err (&client->dev,"Failed to register i2c regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&client->dev,"Failed to register i2c regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }drivers/iio/imu/bmi160/bmi160_i2c.c +2
-2@@ -24,8 +24,8 @@ static int bmi160_i2c_probe(struct i2c_client *client, regmap =devm_regmap_init_i2c (client, &bmi160_regmap_config);if (IS_ERR (regmap)) { -dev_err (&client->dev,"Failed to register i2c regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&client->dev,"Failed to register i2c regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }drivers/iio/imu/bmi160/bmi160_spi.c +2
-2@@ -20,8 +20,8 @@ static int bmi160_spi_probe(struct spi_device *spi) regmap =devm_regmap_init_spi (spi, &bmi160_regmap_config);if (IS_ERR (regmap)) { -dev_err (&spi->dev,"Failed to register spi regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&spi->dev,"Failed to register spi regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }return bmi160_core_probe (&spi->dev, regmap, id->name, true);drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c +2
-2@@ -122,8 +122,8 @@ static int inv_mpu_probe(struct i2c_client *client, regmap =devm_regmap_init_i2c (client, &inv_mpu_regmap_config);if (IS_ERR (regmap)) { -dev_err (&client->dev,"Failed to register i2c regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&client->dev,"Failed to register i2c regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c +2
-2@@ -53,8 +53,8 @@ static int inv_mpu_probe(struct spi_device *spi) regmap =devm_regmap_init_spi (spi, &inv_mpu_regmap_config);if (IS_ERR (regmap)) { -dev_err (&spi->dev,"Failed to register spi regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&spi->dev,"Failed to register spi regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }drivers/iio/magnetometer/bmc150_magn_spi.c +2
-2@@ -22,8 +22,8 @@ static int bmc150_magn_spi_probe(struct spi_device *spi) regmap =devm_regmap_init_spi (spi, &bmc150_magn_regmap_config);if (IS_ERR (regmap)) { -dev_err (&spi->dev,"Failed to register spi regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&spi->dev,"Failed to register spi regmap %ld\n" , +PTR_ERR (regmap));return PTR_ERR (regmap); }return bmc150_magn_probe (&spi->dev, regmap, spi->irq, id->name);
Quoted 2 lines · Nishant Malpani
Provide correct specifiers while printing error logs to discard the use of unnecessary explicit casting.
[]
drivers/iio/accel/kxsd9-i2c.c
Quoted 1 line
drivers/iio/accel/kxsd9-i2c.c +0
-0
[]
drivers/iio/accel/kxsd9-i2c.c static int kxsd9_i2c_probe(struct i2c_client *i2c, · line 25
Quoted 8 lines
drivers/iio/accel/kxsd9-i2c.c +2
-2@@ -21,8 +21,8 @@ static int kxsd9_i2c_probe(struct i2c_client *i2c, regmap =devm_regmap_init_i2c (i2c, &config);if (IS_ERR (regmap)) { -dev_err (&i2c->dev,"Failed to register i2c regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&i2c->dev,"Failed to register i2c regmap %ld\n" , +PTR_ERR (regmap));
Another option would be to use %pe to print the error identifier and not the error number
etc...
Quoted 8 lines · Joe Perches
Quoted 2 lines · Nishant Malpani
Provide correct specifiers while printing error logs to discard the use of unnecessary explicit casting.
[]
drivers/iio/accel/kxsd9-i2c.c
Quoted 1 line
drivers/iio/accel/kxsd9-i2c.c +0
-0[]
Quoted 2 lines
drivers/iio/accel/kxsd9-i2c.c +0
-0@@ -21,8 +21,8 @@ static int kxsd9_i2c_probe(struct i2c_client *i2c,
Quoted 10 lines
drivers/iio/accel/kxsd9-i2c.c static int kxsd9_i2c_probe(struct i2c_client *i2c, · line 25
Quoted 6 lines
drivers/iio/accel/kxsd9-i2c.c +2
-2regmap =devm_regmap_init_i2c (i2c, &config);if (IS_ERR (regmap)) { -dev_err (&i2c->dev,"Failed to register i2c regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&i2c->dev,"Failed to register i2c regmap %ld\n" , +PTR_ERR (regmap));Another option would be to use %pe to print the error identifier and not the error number
By 'error identifier' you mean the symbolic error name (as described in docs [1]), right? Yes, to me, it makes sense too, as it would be more "readable" during debugging. Jonathan, if you agree, do I send a patchset replacing with %pe specifier for all the drivers in consideration?
With regards,
Nishant Malpani
[1] https://www.kernel.org/doc/html/latest/core-api/printk-formats.html#error-pointers
Quoted 3 lines
etc...
Quoted 19 lines · Nishant Malpani
Quoted 8 lines · Joe Perches
Quoted 2 lines · Nishant Malpani
Provide correct specifiers while printing error logs to discard the use of unnecessary explicit casting.
[]
drivers/iio/accel/kxsd9-i2c.c
Quoted 1 line
drivers/iio/accel/kxsd9-i2c.c +0
-0[]
Quoted 2 lines
drivers/iio/accel/kxsd9-i2c.c +0
-0@@ -21,8 +21,8 @@ static int kxsd9_i2c_probe(struct i2c_client *i2c,Quoted 10 lines
drivers/iio/accel/kxsd9-i2c.c static int kxsd9_i2c_probe(struct i2c_client *i2c, · line 25
Quoted 6 lines
drivers/iio/accel/kxsd9-i2c.c +2
-2regmap =devm_regmap_init_i2c (i2c, &config);if (IS_ERR (regmap)) { -dev_err (&i2c->dev,"Failed to register i2c regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&i2c->dev,"Failed to register i2c regmap %ld\n" , +PTR_ERR (regmap));Another option would be to use %pe to print the error identifier and not the error number
Quoted 2 lines
By 'error identifier' you mean the symbolic error name (as described in docs [1]), right?
Yes
Jonathan Cameron
maintainerQuoted 18 lines · On Sat, 21 Mar 2020 05:26:52 -0700 Joe Perches <[email protected]> wrote:
Quoted 2 lines · Nishant Malpani
Provide correct specifiers while printing error logs to discard the use of unnecessary explicit casting.
[]
drivers/iio/accel/kxsd9-i2c.c
Quoted 1 line
drivers/iio/accel/kxsd9-i2c.c +0
-0[]
drivers/iio/accel/kxsd9-i2c.c static int kxsd9_i2c_probe(struct i2c_client *i2c, · line 25
Quoted 8 lines
drivers/iio/accel/kxsd9-i2c.c +2
-2@@ -21,8 +21,8 @@ static int kxsd9_i2c_probe(struct i2c_client *i2c, regmap =devm_regmap_init_i2c (i2c, &config);if (IS_ERR (regmap)) { -dev_err (&i2c->dev,"Failed to register i2c regmap %d\n" , - (int )PTR_ERR (regmap)); +dev_err (&i2c->dev,"Failed to register i2c regmap %ld\n" , +PTR_ERR (regmap));Another option would be to use %pe to print the error identifier and not the error number
Quoted 3 lines
etc...
Indeed that would be even better. I'd missed that one being added to the magic of prink :)
Jonathan