Skip to contentSkip to conversation

gcc-9.2: Security fix for CVE-2019-14250

PATCH In review Armin Kuster 3 participants 8 messages Aug 31, 2019 – Sep 3, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gcc-9.2: Security fix for CVE-2019-14250

Affects: <= 9.2

---
 meta/recipes-devtools/gcc/gcc-9.2.inc         |  1 +
 .../gcc/gcc-9.2/CVE-2019-14250.patch          | 44 +++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 meta/recipes-devtools/gcc/gcc-9.2/CVE-2019-14250.patch
meta/recipes-devtools/gcc/gcc-9.2.inc +1 -0
index 1c3e200dab..01d3bf0f32 100644
@@ -64,6 +64,7 @@ SRC_URI = "\
            file://0034-fix-segmentation-fault-in-precompiled-header-generat.patch \
            file://0035-Fix-for-testsuite-failure.patch \
            file://0036-Re-introduce-spe-commandline-options.patch \
+           file://CVE-2019-14250.patch \
 "
 S = "${TMPDIR}/work-shared/gcc-${PV}-${PR}/gcc-${PV}"
 SRC_URI[md5sum] = "3818ad8600447f05349098232c2ddc78"
meta/recipes-devtools/gcc/gcc-9.2/CVE-2019-14250.patch new file +44 -0

44 lines not on this page · raw message

Signature · 1 line
2.17.1
#1 lore raw

thud and zeus are providing 2 gcc versions each that need fixing.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#2 lore raw
Quoted 1 line · Adrian Bunk

thud and zeus are providing 2 gcc versions each that need fixing.

That is a true statement. What are you expecting?

- armin

Quoted 4 lines

cu
Adrian

#3 lore raw
Quoted 5 lines · On Sun, Sep 01, 2019 at 10:07:13AM -0700, akuster808 wrote:
Quoted 1 line · Adrian Bunk

thud and zeus are providing 2 gcc versions each that need fixing.

That is a true statement. What are you expecting?

The other versions also being fixed?

gcc-8 being fixed in warrior before it gets fixed in master would be the wrong order, and would introduce a security regression in master.

The code should be nearly identical in warrior and master, so fixing this also in gcc-8 in master should be trivial.

Fixing gcc-7 in thud would be a bonus.

Quoted 1 line

- armin

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#4 lore raw
Quoted 6 lines · Adrian Bunk
Quoted 4 lines · On Sun, Sep 01, 2019 at 10:07:13AM -0700, akuster808 wrote:
Quoted 1 line · Adrian Bunk

thud and zeus are providing 2 gcc versions each that need fixing.

That is a true statement. What are you expecting?

The other versions also being fixed?

By whom?

Quoted 3 lines

gcc-8 being fixed in warrior before it gets fixed in master would be the wrong order, and would introduce a security regression in master.

Warrior mainline does not have this fix nor does Thud. There is nothing wrong doing all the prep-work so changes can land in the the proper order. I am fine if they don't get accepted.

Quoted 3 lines

The code should be nearly identical in warrior and master, so fixing this also in gcc-8 in master should be trivial.

If I find some additional free time and resources, I might be able to swing that. We currently don't validate the Alt gcc's and they add a maintenance burden.

IMHO, the older one should be dropped, like we did for Warrior.

Quoted 2 lines

Fixing gcc-7 in thud would be a bonus.

Patches welcome for the bonus.

- armin

Quoted 5 lines
Quoted 2 lines

- armin

cu
Adrian

author
#5 lore raw
In reply to Adrian Bunk
Quoted 9 lines · Adrian Bunk
Quoted 4 lines · On Sun, Sep 01, 2019 at 10:07:13AM -0700, akuster808 wrote:
Quoted 1 line · Adrian Bunk

thud and zeus are providing 2 gcc versions each that need fixing.

That is a true statement. What are you expecting?

The other versions also being fixed?

gcc-8 being fixed in warrior before it gets fixed in master would be the wrong order, and would introduce a security regression in master.

sent a patch. hope it is what is meant by the above.

Quoted 10 lines

The code should be nearly identical in warrior and master, so fixing this also in gcc-8 in master should be trivial.

Fixing gcc-7 in thud would be a bonus.

Quoted 1 line

- armin

cu
Adrian

#6 lore raw
Quoted 5 lines · On Mon, Sep 02, 2019 at 02:33:02PM -0700, akuster808 wrote:
Quoted 2 lines · Adrian Bunk
Quoted 1 line · On Sun, Sep 01, 2019 at 10:07:13AM -0700, akuster808 wrote:
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines · Adrian Bunk
Quoted 1 line

thud and zeus are providing 2 gcc versions each that need fixing.

That is a true statement. What are you expecting?

The other versions also being fixed?

gcc-8 being fixed in warrior before it gets fixed in master would be the wrong order, and would introduce a security regression in master.

sent a patch. hope it is what is meant by the above.

Thanks a lot!

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#7 lore raw
In reply to akuster808
Quoted 5 lines · On Mon, Sep 02, 2019 at 02:33:02PM -0700, akuster808 wrote:
Quoted 2 lines · Adrian Bunk
Quoted 1 line · On Sun, Sep 01, 2019 at 10:07:13AM -0700, akuster808 wrote:
Quoted 14 lines
Quoted 7 lines
Quoted 3 lines · Adrian Bunk
Quoted 1 line

thud and zeus are providing 2 gcc versions each that need fixing.

That is a true statement. What are you expecting?

The other versions also being fixed?

gcc-8 being fixed in warrior before it gets fixed in master would be the wrong order, and would introduce a security regression in master.

sent a patch. hope it is what is meant by the above.

Quoted 5 lines

The code should be nearly identical in warrior and master, so fixing this also in gcc-8 in master should be trivial.

Fixing gcc-7 in thud would be a bonus.

FWIW, gcc-7-branch of https://github.com/gcc-mirror/gcc.git has this fix already.

-Mikko

commit 740d8b3baeea47cd5407be1752c5159223f77042

Author:     rguenth <rguenth@138bc75d-0d04-0410-961f-82ee72b054a4>
AuthorDate: Thu Jul 25 10:50:47 2019 +0000
Commit:     rguenth <rguenth@138bc75d-0d04-0410-961f-82ee72b054a4>
CommitDate: Thu Jul 25 10:50:47 2019 +0000
    2019-07-25  Richard Biener  <[email protected]>
    
        PR lto/90924
        Backport from mainline
        2019-07-12  Ren Kimura  <[email protected]>
    
        * simple-object-elf.c (simple_object_elf_match): Check zero value
        shstrndx.
    
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gcc-7-branch@273795 138bc75d-0d04-0410-961f-82ee72b054a4
libiberty/ChangeLog +9 -0
index b785e71..0ecdec0 100644
@@ -1,3 +1,12 @@
+2019-07-25  Richard Biener  <[email protected]>
+
+       PR lto/90924
+       Backport from mainline
+       2019-07-12  Ren Kimura  <[email protected]>
+
+       * simple-object-elf.c (simple_object_elf_match): Check zero value
+       shstrndx.
+
 2018-12-06  Release Manager
 
        * GCC 7.4.0 released.