Add NULL check for s_fence->parent
Subsystems (4)
PATCH 1/1 Add NULL check for s_fence->parent
NULL check is added for s_fence->parent.
Signed-off-by Arvind Yadav <[email protected]>
--- drivers/gpu/drm/scheduler/sched_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/scheduler/sched_main.c +2 -1
@@ -829,7 +829,8 @@ drm_sched_get_cleanup_job(struct drm_gpu_scheduler *sched) job =list_first_entry_or_null (&sched->pending_list, struct drm_sched_job, list); -if (job &&dma_fence_is_signaled (job->s_fence->parent)) { +if (job && job->s_fence->parent && +dma_fence_is_signaled (job->s_fence->parent)) {/* remove job from pending_list */ list_del_init (&job->list);
Signature · 1 line
2.25.1
Am 30.09.22 um 10:38 schrieb Arvind Yadav:
Quoted 1 line
NULL check is added for
s_fence->parent.
I've send a patch to fix this as well and this here is actually the wrong way around.
We want to free up the job when there isn't any parent fence any more.
Regards,
Christian.
Quoted 20 lines
Signed-off-by Arvind Yadav <[email protected]>--- drivers/gpu/drm/scheduler/sched_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/scheduler/sched_main.c +2
-1@@ -829,7 +829,8 @@ drm_sched_get_cleanup_job(struct drm_gpu_scheduler *sched) job =list_first_entry_or_null (&sched->pending_list, struct drm_sched_job, list); -if (job &&dma_fence_is_signaled (job->s_fence->parent)) { +if (job && job->s_fence->parent && +dma_fence_is_signaled (job->s_fence->parent)) {/* remove job from pending_list */ list_del_init (&job->list);