gitlab-ci.yml: Install libattr1-dev and libcap-dev to test virtio-9p
PATCH 1/1 gitlab-ci.yml: Install libattr1-dev and libcap-dev to test virtio-9p
So far the gitlab-ci was not testing virtio-9p yet, since we did not install libattr1-dev and libcap-dev in any of the pipelines. Do it now to get some more test coverage.
--- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
.gitlab-ci.yml +1 -1
@@ -59,7 +59,7 @@ build-user: build-clang: script: - - apt-get install -y -qq clang libsdl2-dev + - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-dev xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev librbd-dev - ./configure --cc=clang --cxx=clang++ --enable-werror --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu
Signature · 1 line
2.18.1
Quoted 14 lines · On Thu, 5 Sep 2019 13:17:29 +0200 Thomas Huth <[email protected]> wrote:
So far the gitlab-ci was not testing virtio-9p yet, since we did not install libattr1-dev and libcap-dev in any of the pipelines. Do it now to get some more test coverage.
Signed-off-by Thomas Huth <[email protected]>--- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-).gitlab-ci.yml +0
-0
.gitlab-ci.yml build-user: · line 65
Quoted 8 lines
.gitlab-ci.yml +1
-1@@ -59,7 +59,7 @@ build-user: build-clang: script: - - apt-get install -y -qq clang libsdl2-dev + - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-dev xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev librbd-dev - ./configure --cc=clang --cxx=clang++ --enable-werror --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu
I don't know gitlab-ci at all but shouldn't these libs be added to some other builds as well ?
Apart from that, this change looks okay so:
Quoted 18 lines · Greg Kurz
Quoted 15 lines · On Thu, 5 Sep 2019 13:17:29 +0200 Thomas Huth <[email protected]> wrote:
So far the gitlab-ci was not testing virtio-9p yet, since we did not install libattr1-dev and libcap-dev in any of the pipelines. Do it now to get some more test coverage.
Signed-off-by Thomas Huth <[email protected]>--- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-).gitlab-ci.yml +0
-0@@ -59,7 +59,7 @@ build-user:
Quoted 10 lines
.gitlab-ci.yml build-user: · line 65
Quoted 7 lines
.gitlab-ci.yml +1
-1build-clang: script: - - apt-get install -y -qq clang libsdl2-dev + - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-dev xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev librbd-dev - ./configure --cc=clang --cxx=clang++ --enable-werror --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmuI don't know gitlab-ci at all but shouldn't these libs be added to some other builds as well ?
Currently the "features" are distributed over the different pipelines, so that the build in total does not take too long. Looking at how long the travis stuff takes, I'd also like to try to keep it short here.
Thomas