Skip to contentSkip to conversation

net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW

PATCH In review Pawel Wodkowski 2 participants 3 messages Aug 10, 2020 – Sep 2, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW

Flows like IP4 / UDP / RAW are not working because after parsing RTE_FLOW_ITEM_TYPE_RAW item pointer is not advanced. This make whole parsing fail.

Fixes f35fec63dde1 ("net/ixgbe: enable flex bytes for generic flow API")
---
 drivers/net/ixgbe/ixgbe_flow.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ixgbe/ixgbe_flow.c +2 -0
index b2a2bfc02..a2cb599b1 100644
@@ -2251,6 +2251,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,
 			(((uint16_t)raw_spec->pattern[1]) << 8) |
 			raw_spec->pattern[0];
 		rule->flex_bytes_offset = raw_spec->offset;
+
+		item = next_no_fuzzy_pattern(pattern, item);
 	}
 
 	if (item->type != RTE_FLOW_ITEM_TYPE_END) {
Signature · 1 line
2.17.1
#1 lore raw
Quoted 27 lines

-----Original Message-----
From: Pawel Wodkowski <[email protected]>
Sent: Tuesday, August 11, 2020 4:31 AM
To: [email protected]
Cc: Pawel Wodkowski <[email protected]>; Zhang, Qi Z <[email protected]>; Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>
Subject: [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW

Flows like IP4 / UDP / RAW are not working because after parsing RTE_FLOW_ITEM_TYPE_RAW item pointer is not advanced. This make whole parsing fail.

Fixes f35fec63dde1 ("net/ixgbe: enable flex bytes for generic flow API")
---
 drivers/net/ixgbe/ixgbe_flow.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ixgbe/ixgbe_flow.c +0 -0
index b2a2bfc02..a2cb599b1 100644

drivers/net/ixgbe/ixgbe_flow.c ixgbe_parse_fdir_filter_normal(struct rte_eth_dev · line 2256

Quoted 6 lines
drivers/net/ixgbe/ixgbe_flow.c +2 -0
@@ -2251,6 +2251,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev
 *dev,
 			(((uint16_t)raw_spec->pattern[1]) << 8) |
 			raw_spec->pattern[0];
 		rule->flex_bytes_offset = raw_spec->offset;
+
+		item = next_no_fuzzy_pattern(pattern, item);

why we need to advance item pointer?
The next branch will advance it and compare with RTe_FLOW_ITEM_TYPE_END. Can you double check if your pattern is IPv4/UDP/RAW/END ?

Quoted 5 lines
drivers/net/ixgbe/ixgbe_flow.c +0 -0
 	}
 

if (item->type != RTE_FLOW_ITEM_TYPE_END) {
--
2.17.1

#2 lore raw
Quoted 21 lines · Qi Z
Quoted 21 lines

-----Original Message-----
From: Pawel Wodkowski <[email protected]>
Sent: Tuesday, August 11, 2020 4:31 AM
To: [email protected]
Cc: Pawel Wodkowski <[email protected]>; Zhang, Qi Z <[email protected]>; Zhao1, Wei <[email protected]>; Guo, Jia <[email protected]>
Subject: [PATCH] net/ixgbe: fix fdir flows with RTE_FLOW_ITEM_TYPE_RAW

Flows like IP4 / UDP / RAW are not working because after parsing RTE_FLOW_ITEM_TYPE_RAW item pointer is not advanced. This make whole parsing fail.

Fixes f35fec63dde1 ("net/ixgbe: enable flex bytes for generic flow API")
---
  drivers/net/ixgbe/ixgbe_flow.c | 2 ++
  1 file changed, 2 insertions(+)
Quoted 14 lines

drivers/net/ixgbe/ixgbe_flow.c ixgbe_parse_fdir_filter_normal(struct rte_eth_dev · line 2256

Quoted 11 lines
drivers/net/ixgbe/ixgbe_flow.c +2 -0
index b2a2bfc02..a2cb599b1 100644
@@ -2251,6 +2251,8 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev
 *dev,
  			(((uint16_t)raw_spec->pattern[1]) << 8) |
  			raw_spec->pattern[0];
  		rule->flex_bytes_offset = raw_spec->offset;
+
+		item = next_no_fuzzy_pattern(pattern, item);

why we need to advance item pointer?
The next branch will advance it and compare with RTe_FLOW_ITEM_TYPE_END. Can you double check if your pattern is IPv4/UDP/RAW/END ?

True, pls ignore this patch.

Quoted 6 lines
Quoted 6 lines
drivers/net/ixgbe/ixgbe_flow.c +0 -0
  	}
 

if (item->type != RTE_FLOW_ITEM_TYPE_END) {
--
2.17.1