Skip to contentSkip to conversation

target/i386: Add notes for versioned CPU models

PATCH Applied Tao Xu 3 participants 5 messages Mar 24, 2020 – Jun 23, 2020

lore
Share & tools
lore

Tao Xu

author
#0 lore raw

PATCH v4 1/1 target/i386: Add notes for versioned CPU models

Add which features are added or removed in this version.

---

The output is as follows:
qemu-system-x86_64 -cpu help | grep "\["
x86 Cascadelake-Server-v2 Intel Xeon Processor (Cascadelake) [ARCH_CAPABILITIES] x86 Cascadelake-Server-v3 Intel Xeon Processor (Cascadelake) [ARCH_CAPABILITIES, no TSX]

x86 Denverton-v2          Intel Atom Processor (Denverton) [no MPX, no MONITOR]
x86 Icelake-Client-v2     Intel Core Processor (Icelake) [no TSX]
x86 Icelake-Server-v2     Intel Xeon Processor (Icelake) [no TSX]

Changes in v3:
- Keep the existing custom model-id (Eduardo)

Changes in v2:
- correct the note of Cascadelake v3 (Xiaoyao)

---
 target/i386/cpu.c | 5 +++++
 1 file changed, 5 insertions(+)
target/i386/cpu.c +5 -0
index 34b511f078..1c7690baa0 100644
@@ -3192,6 +3192,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
         .versions = (X86CPUVersionDefinition[]) {
             { .version = 1 },
             { .version = 2,
+              .note = "ARCH_CAPABILITIES",
               .props = (PropValue[]) {
                   { "arch-capabilities", "on" },
                   { "rdctl-no", "on" },
@@ -3203,6 +3204,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
             },
             { .version = 3,
               .alias = "Cascadelake-Server-noTSX",
+              .note = "ARCH_CAPABILITIES, no TSX",
               .props = (PropValue[]) {
                   { "hle", "off" },
                   { "rtm", "off" },
@@ -3424,6 +3426,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
             { .version = 1 },
             {
                 .version = 2,
+                .note = "no TSX",
                 .alias = "Icelake-Client-noTSX",
                 .props = (PropValue[]) {
                     { "hle", "off" },
@@ -3541,6 +3544,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
             { .version = 1 },
             {
                 .version = 2,
+                .note = "no TSX",
                 .alias = "Icelake-Server-noTSX",
                 .props = (PropValue[]) {
                     { "hle", "off" },
@@ -3648,6 +3652,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
             { .version = 1 },
             {
                 .version = 2,
+                .note = "no MPX, no MONITOR",
                 .props = (PropValue[]) {
                     { "monitor", "off" },
                     { "mpx", "off" },
Signature · 1 line
2.20.1
author
#1 lore raw

Ping for comments

Quoted 67 lines · On 3/24/2020 1:10 PM, Xu, Tao3 wrote:

Add which features are added or removed in this version.

---

The output is as follows:
qemu-system-x86_64 -cpu help | grep "\["
x86 Cascadelake-Server-v2 Intel Xeon Processor (Cascadelake) [ARCH_CAPABILITIES] x86 Cascadelake-Server-v3 Intel Xeon Processor (Cascadelake) [ARCH_CAPABILITIES, no TSX]

x86 Denverton-v2          Intel Atom Processor (Denverton) [no MPX, no MONITOR]
x86 Icelake-Client-v2     Intel Core Processor (Icelake) [no TSX]
x86 Icelake-Server-v2     Intel Xeon Processor (Icelake) [no TSX]

Changes in v3:
- Keep the existing custom model-id (Eduardo)

Changes in v2:
- correct the note of Cascadelake v3 (Xiaoyao)

---
  target/i386/cpu.c | 5 +++++
  1 file changed, 5 insertions(+)
target/i386/cpu.c +5 -0
index 34b511f078..1c7690baa0 100644
@@ -3192,6 +3192,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
          .versions = (X86CPUVersionDefinition[]) {
              { .version = 1 },
              { .version = 2,
+              .note = "ARCH_CAPABILITIES",
                .props = (PropValue[]) {
                    { "arch-capabilities", "on" },
                    { "rdctl-no", "on" },
@@ -3203,6 +3204,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
              },
              { .version = 3,
                .alias = "Cascadelake-Server-noTSX",
+              .note = "ARCH_CAPABILITIES, no TSX",
                .props = (PropValue[]) {
                    { "hle", "off" },
                    { "rtm", "off" },
@@ -3424,6 +3426,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
              { .version = 1 },
              {
                  .version = 2,
+                .note = "no TSX",
                  .alias = "Icelake-Client-noTSX",
                  .props = (PropValue[]) {
                      { "hle", "off" },
@@ -3541,6 +3544,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
              { .version = 1 },
              {
                  .version = 2,
+                .note = "no TSX",
                  .alias = "Icelake-Server-noTSX",
                  .props = (PropValue[]) {
                      { "hle", "off" },
@@ -3648,6 +3652,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
              { .version = 1 },
              {
                  .version = 2,
+                .note = "no MPX, no MONITOR",
                  .props = (PropValue[]) {
                      { "monitor", "off" },
                      { "mpx", "off" },
author
#2 lore raw
In reply to Tao Xu

Hi Eduardo

Could you review this patch?

Tao Xu

Quoted 67 lines · On 3/24/2020 1:10 PM, Xu, Tao3 wrote:

Add which features are added or removed in this version.

---

The output is as follows:
qemu-system-x86_64 -cpu help | grep "\["
x86 Cascadelake-Server-v2 Intel Xeon Processor (Cascadelake) [ARCH_CAPABILITIES] x86 Cascadelake-Server-v3 Intel Xeon Processor (Cascadelake) [ARCH_CAPABILITIES, no TSX]

x86 Denverton-v2          Intel Atom Processor (Denverton) [no MPX, no MONITOR]
x86 Icelake-Client-v2     Intel Core Processor (Icelake) [no TSX]
x86 Icelake-Server-v2     Intel Xeon Processor (Icelake) [no TSX]

Changes in v3:
- Keep the existing custom model-id (Eduardo)

Changes in v2:
- correct the note of Cascadelake v3 (Xiaoyao)

---
  target/i386/cpu.c | 5 +++++
  1 file changed, 5 insertions(+)
target/i386/cpu.c +5 -0
index 34b511f078..1c7690baa0 100644
@@ -3192,6 +3192,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
          .versions = (X86CPUVersionDefinition[]) {
              { .version = 1 },
              { .version = 2,
+              .note = "ARCH_CAPABILITIES",
                .props = (PropValue[]) {
                    { "arch-capabilities", "on" },
                    { "rdctl-no", "on" },
@@ -3203,6 +3204,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
              },
              { .version = 3,
                .alias = "Cascadelake-Server-noTSX",
+              .note = "ARCH_CAPABILITIES, no TSX",
                .props = (PropValue[]) {
                    { "hle", "off" },
                    { "rtm", "off" },
@@ -3424,6 +3426,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
              { .version = 1 },
              {
                  .version = 2,
+                .note = "no TSX",
                  .alias = "Icelake-Client-noTSX",
                  .props = (PropValue[]) {
                      { "hle", "off" },
@@ -3541,6 +3544,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
              { .version = 1 },
              {
                  .version = 2,
+                .note = "no TSX",
                  .alias = "Icelake-Server-noTSX",
                  .props = (PropValue[]) {
                      { "hle", "off" },
@@ -3648,6 +3652,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
              { .version = 1 },
              {
                  .version = 2,
+                .note = "no MPX, no MONITOR",
                  .props = (PropValue[]) {
                      { "monitor", "off" },
                      { "mpx", "off" },
#3 lore raw
Quoted 69 lines · Tao Xu

Hi Eduardo

Could you review this patch?

Tao Xu

Quoted 62 lines · On 3/24/2020 1:10 PM, Xu, Tao3 wrote:

Add which features are added or removed in this version.

---

The output is as follows:
qemu-system-x86_64 -cpu help | grep "\["
x86 Cascadelake-Server-v2  Intel Xeon Processor (Cascadelake) [ARCH_CAPABILITIES]
x86 Cascadelake-Server-v3  Intel Xeon Processor (Cascadelake) [ARCH_CAPABILITIES, no TSX]
x86 Denverton-v2          Intel Atom Processor (Denverton) [no MPX, no MONITOR]
x86 Icelake-Client-v2     Intel Core Processor (Icelake) [no TSX] x86 Icelake-Server-v2     Intel Xeon Processor (Icelake) [no TSX]

Changes in v3:
     - Keep the existing custom model-id (Eduardo)

Changes in v2:
     - correct the note of Cascadelake v3 (Xiaoyao)
---
  target/i386/cpu.c | 5 +++++

  1 file changed, 5 insertions(+)
target/i386/cpu.c +4 -0
index 34b511f078..1c7690baa0 100644
@@ -3192,6 +3192,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
           .versions = (X86CPUVersionDefinition[]) {
               { .version = 1 },
               { .version = 2,
+              .note = "ARCH_CAPABILITIES",
                 .props = (PropValue[]) {
                     { "arch-capabilities", "on" },
                     { "rdctl-no", "on" },
@@ -3203,6 +3204,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
               },
               { .version = 3,
                 .alias = "Cascadelake-Server-noTSX",
+              .note = "ARCH_CAPABILITIES, no TSX",
                 .props = (PropValue[]) {
                     { "hle", "off" },
                     { "rtm", "off" },
@@ -3424,6 +3426,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
               { .version = 1 },
               {
                   .version = 2,
+                .note = "no TSX",
                   .alias = "Icelake-Client-noTSX",
                   .props = (PropValue[]) {
                       { "hle", "off" },
@@ -3541,6 +3544,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
               { .version = 1 },
               {
                   .version = 2,
+                .note = "no TSX",
                   .alias = "Icelake-Server-noTSX",
                   .props = (PropValue[]) {
                       { "hle", "off" },
@@ -3648,6 +3652,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
Quoted 9 lines

target/i386/cpu.c static X86CPUDefinition builtin_x86_defs[] = { · line 3658

Quoted 8 lines
target/i386/cpu.c +1 -0
               { .version = 1 },
               {
                   .version = 2,
+                .note = "no MPX, no MONITOR",
                   .props = (PropValue[]) {
                       { "monitor", "off" },
                       { "mpx", "off" },

Queued, thanks.

Paolo

#4 lore raw
Quoted 1 line · Paolo Bonzini

Queued, thanks.

Thanks Paolo, and apologies to everybody for not replying before. I'm severely behind on my upstream mailbox handling.

Signature · 1 line
Eduardo