mt76: mt7921: fix the inconsistent state between bind and unbind
Subsystems (2)
[email protected]
reviewerPATCH 1/1 mt76: mt7921: fix the inconsistent state between bind and unbind
From: Sean Wang <[email protected]>
We shouldn't put back the device into fw own state after wifi reset at driver unbind stage to fix the following error because that is not the consistent state the current driver bind stage expects.
localhost ~ # echo 0000:01:00.0 > /sys/bus/pci/drivers/mt7921e/unbind localhost ~ # echo 0000:01:00.0 > /sys/bus/pci/drivers/mt7921e/bind
...
[ 481.172969] mt7921e 0000:01:00.0: ASIC revision: feed0000 [ 482.133547] mt7921e: probe of 0000:01:00.0 failed with error -110
-bash: echo: write error: No such device
--- drivers/net/wireless/mediatek/mt76/mt7921/init.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/wireless/mediatek/mt76/mt7921/init.c +0 -1
@@ -279,7 +279,6 @@ void mt7921_unregister_device(struct mt7921_dev *dev)mt7921_mcu_drv_pmctrl (dev);mt7921_dma_cleanup (dev);mt7921_mcu_exit (dev); -mt7921_mcu_fw_pmctrl (dev);tasklet_disable (&dev->irq_tasklet);mt76_free_device (&dev->mt76);
Signature · 1 line
2.25.1
Quoted 10 lines · On Mon, Aug 23, 2021 at 10:27 AM <[email protected]> wrote:
From: Sean Wang <[email protected]>
We shouldn't put back the device into fw own state after wifi reset at driver unbind stage to fix the following error because that is not the consistent state the current driver bind stage expects.
localhost ~ # echo 0000:01:00.0 >
/sys/bus/pci/drivers/mt7921e/unbindlocalhost ~ # echo 0000:01:00.0 >/sys/bus/pci/drivers/mt7921e/bind
...
Quoted 8 lines
[ 481.172969] mt7921e 0000:01:00.0: ASIC revision: feed0000 [ 482.133547] mt7921e: probe of 0000:01:00.0 failed with error -110-bash: echo: write error: No such device
Fixes c1af184ba830 ("mt76: mt7921: fix dma hang in rmmod")Co-developed-by YN Chen <[email protected]>Signed-off-by YN Chen <[email protected]>Signed-off-by Sean Wang <[email protected]>
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek