clk: qcom: clk-spmi-pmic-div: Annotate struct spmi_pmic_div_clk_cc with __counted_by
Subsystems (3)
PATCH 1/1 clk: qcom: clk-spmi-pmic-div: Annotate struct spmi_pmic_div_clk_cc with __counted_by
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).
As found with Coccinelle[1], add __counted_by for struct spmi_pmic_div_clk_cc.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
--- drivers/clk/qcom/clk-spmi-pmic-div.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/qcom/clk-spmi-pmic-div.c +1 -1
@@ -177,7 +177,7 @@ static const struct clk_ops clk_spmi_pmic_div_ops = {struct spmi_pmic_div_clk_cc {int nclks; -struct clkdiv clks[]; + struct clkdiv clks[] __counted_by(nclks); }; static struct clk_hw *
Signature · 1 line
2.34.1
Quoted 10 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).As found with Coccinelle[1], add
__counted_byfor structspmi_pmic_div_clk_cc.[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Quoted 8 lines
Cc Bjorn Andersson <[email protected]>Cc Andy Gross <[email protected]>Cc Konrad Dybcio <[email protected]>Cc Michael Turquette <[email protected]>Cc Stephen Boyd <[email protected]>Signed-off-by Kees Cook <[email protected]>
Thanks
--
Gustavo
Quoted 17 lines
--- drivers/clk/qcom/clk-spmi-pmic-div.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/qcom/clk-spmi-pmic-div.c +1
-1@@ -177,7 +177,7 @@ static const struct clk_ops clk_spmi_pmic_div_ops = {struct spmi_pmic_div_clk_cc {int nclks; -struct clkdiv clks[]; + struct clkdiv clks[] __counted_by(nclks); }; static struct clk_hw *
Quoting Kees Cook (2023-08-17 13:29:42)
Quoted 18 lines
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).As found with Coccinelle[1], add
__counted_byfor structspmi_pmic_div_clk_cc.[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc Bjorn Andersson <[email protected]>Cc Andy Gross <[email protected]>Cc Konrad Dybcio <[email protected]>Cc Michael Turquette <[email protected]>Cc Stephen Boyd <[email protected]>Signed-off-by Kees Cook <[email protected]>
Quoted 1 line
---
Applied to clk-next