rk3399: Add four clocks to clock driver needed by framebuffer
Subsystems (2)
PATCH 1/1 rk3399: Add four clocks to clock driver needed by framebuffer
This patch adds the four clock gates
- ACLK_VOP0
- ACLK_VOP1
- HCLK_VOP0
- HCLK_VOP1
to the rockchip rk3399 clock drivers.
These clock gates were referenced by arch/arm/dts/rk3399.dtsi for vopb and vopl.
The driver drivers/video/rockchip/rk3399_vop.c won't get probed without these clocks and the framebuffer does not work.
--- drivers/clk/rockchip/clk_rk3399.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
(quoted diff) +0 -0
b/drivers/clk/rockchip/clk_rk3399.c
index 865b80cc0f..a3628d4a4c 100644
drivers/clk/rockchip/clk_rk3399.c +5 -0
@@ -923,6 +923,11 @@ static ulong rk3399_clk_get_rate(struct clk *clk)case DCLK_VOP0 :case DCLK_VOP1 :break ; +case ACLK_VOP0 : +case ACLK_VOP1 : +case HCLK_VOP0 : +case HCLK_VOP1 : +break ;case PCLK_EFUSE1024NS :break ;case SCLK_SARADC :
@@ -994,6 +999,12 @@ static ulong rk3399_clk_set_rate(struct clk *clk,
ulong rate)
case DCLK_VOP1:
ret = rk3399_vop_set_clk(priv->cru, clk->id, rate); break;
+ case ACLK_VOP0:
+ case ACLK_VOP1:
+ case HCLK_VOP0:
+ case HCLK_VOP1:
+ /* clock gates are enabled by default */
+ break;
case SCLK_DDRCLK:
ret = rk3399_ddr_set_clk(priv->cru, rate); break;
Signature · 1 line
2.25.1
PATCH 1/1 rk3399: Add four clocks to clock driver needed by framebuffer
Quoted 8 lines · Wolfram Joost
This patch adds the four clock gates
-
ACLK_VOP0
-ACLK_VOP1
-HCLK_VOP0
-HCLK_VOP1
Quoted 7 lines
to the rockchip rk3399 clock drivers.
These clock gates were referenced by
arch/arm/dts/rk3399.dtsifor vopb and vopl.The driver
drivers/video/rockchip/rk3399_vop.cwon't get probed without these clocks and the framebuffer does not work.
This needs at least a Signed-off-by: line
Quoted 38 lines
--- drivers/clk/rockchip/clk_rk3399.c | 11 +++++++++++ 1 file changed, 11 insertions(+)drivers/clk/rockchip/clk_rk3399.c +11
-0@@ -923,6 +923,11 @@ static ulong rk3399_clk_get_rate(struct clk *clk)case DCLK_VOP0 :case DCLK_VOP1 :break ; +case ACLK_VOP0 : +case ACLK_VOP1 : +case HCLK_VOP0 : +case HCLK_VOP1 : +break ;case PCLK_EFUSE1024NS :break ;case SCLK_SARADC :@@ -994,6 +999,12 @@ static ulong rk3399_clk_set_rate(struct clk *clk, ulong rate)case DCLK_VOP1 : ret =rk3399_vop_set_clk (priv->cru, clk->id, rate);break ; +case ACLK_VOP0 : +case ACLK_VOP1 : +case HCLK_VOP0 : +case HCLK_VOP1 : +/* clock gates are enabled by default */ +break ;case SCLK_DDRCLK : ret =rk3399_ddr_set_clk (priv->cru, rate);break;--
2.25.1
PATCH 1/1 rk3399: Add four clocks to clock driver needed by framebuffer
Quoted 11 lines · Peter Robinson
Quoted 10 lines · Wolfram Joost
This patch adds the four clock gates
-
ACLK_VOP0
-ACLK_VOP1
-HCLK_VOP0
-HCLK_VOP1to the rockchip rk3399 clock drivers.
Quoted 7 lines
Quoted 5 lines
These clock gates were referenced by
arch/arm/dts/rk3399.dtsifor vopb and vopl.The driver
drivers/video/rockchip/rk3399_vop.cwon't get probed without these clocks and the framebuffer does not work.This needs at least a Signed-off-by: line
Right, I simply forgot it. However, there was a more complete patch set previously posted by Jagan Teki on January, 23.
Wolfram