Update arm,smmu.yaml bindings doc
Subsystems (4)
PATCH 1/1 Update arm,smmu.yaml bindings doc
Patch [1] adds a "mem_iface_clock" in the clocks list for smmu device. This patch updates the yaml doc file for smmu by adding the definition for this new clock.
1: https://patchwork.freedesktop.org/patch/352718/
Sharat Masetty (1):
dt-bindings: arm-smmu: update clocks and bindings for sc7180 SoC
Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ 1 file changed, 3 insertions(+)
--
1.9.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 1/1 dt-bindings: arm-smmu: update the list of clocks
This patch adds a clock definition needed for powering on the GPU TBUs and the GPU TCU.
--- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/iommu/arm,smmu.yaml +3 -0
@@ -28,6 +28,7 @@ properties: - enum: - qcom,msm8996-smmu-v2 - qcom,msm8998-smmu-v2 + - qcom,sc7180-smmu-v2 - qcom,sdm845-smmu-v2 - const: qcom,smmu-v2
@@ -116,6 +117,7 @@ properties: items: - const: bus - const: iface + - const: mem_iface_clk clocks: items:
@@ -123,6 +125,7 @@ properties: smmu ptw - description: interface clock required to access smmu's registers through the TCU's programming interface. + - description: core clock required for the GPU SMMU TBUs and the GPU TCU power-domains: maxItems: 1
--
1.9.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Rob Herring
maintainerRe: [PATCH] dt-bindings: arm-smmu: update the list of clocks
Quoted 8 lines · Sharat Masetty
This patch adds a clock definition needed for powering on the GPU TBUs and the GPU TCU.
Signed-off-by Sharat Masetty <[email protected]>--- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ 1 file changed, 3 insertions(+)
My bot found errors running 'make dt_binding_check' on your patch:
Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@d00000: clock-names: ['bus', 'iface'] is too short /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@d00000: clocks: [[4294967295, 123], [4294967295, 124]] is too short
See https://patchwork.ozlabs.org/patch/1241297
Please check and re-submit.
Re: [PATCH] dt-bindings: arm-smmu: update the list of clocks
Quoted 9 lines · Rob Herring
Quoted 8 lines · Sharat Masetty
This patch adds a clock definition needed for powering on the GPU TBUs and the GPU TCU.
Signed-off-by Sharat Masetty <[email protected]>--- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ 1 file changed, 3 insertions(+)
Quoted 8 lines
My bot found errors running 'make
dt_binding_check' on your patch:Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (
chosen_node_is_root): /example-0/chosen: chosen node must be at root node /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@d00000: clock-names: ['bus', 'iface'] is too short /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@d00000: clocks: [[4294967295, 123], [4294967295, 124]] is too shortSee https://patchwork.ozlabs.org/patch/1241297
Please check and re-submit.
Hi Rob, These issues seem to be from the original code and not related to my patch. Are these going to be blocking errors?
Rob Herring
maintainerRe: [PATCH] dt-bindings: arm-smmu: update the list of clocks
Quoted 14 lines · Sharat Masetty
Quoted 11 lines · Rob Herring
Quoted 8 lines · Sharat Masetty
This patch adds a clock definition needed for powering on the GPU TBUs and the GPU TCU.
Signed-off-by Sharat Masetty <[email protected]>--- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ 1 file changed, 3 insertions(+)My bot found errors running 'make
dt_binding_check' on your patch:
Quoted 8 lines
Quoted 6 lines
Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (
chosen_node_is_root): /example-0/chosen: chosen node must be at root node /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@d00000: clock-names: ['bus', 'iface'] is too short /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@d00000: clocks: [[4294967295, 123], [4294967295, 124]] is too shortSee https://patchwork.ozlabs.org/patch/1241297
Please check and re-submit.Hi Rob, These issues seem to be from the original code and not related to my patch. Are these going to be blocking errors?
There are no errors in this binding in mainline. You've added a 3rd clock when all the existing users have exactly 2 clocks.
Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] dt-bindings: arm-smmu: update the list of clocks
Quoted 18 lines · Rob Herring
Quoted 17 lines · Sharat Masetty
Quoted 15 lines · Rob Herring
Quoted 8 lines · Sharat Masetty
This patch adds a clock definition needed for powering on the GPU TBUs and the GPU TCU.
Signed-off-by Sharat Masetty <[email protected]>--- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ 1 file changed, 3 insertions(+)My bot found errors running 'make
dt_binding_check' on your patch:Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (
chosen_node_is_root): /example-0/chosen: chosen node must be at root node /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@d00000: clock-names: ['bus', 'iface'] is too short /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@d00000: clocks: [[4294967295, 123], [4294967295, 124]] is too short
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
See https://patchwork.ozlabs.org/patch/1241297
Please check and re-submit.Hi Rob, These issues seem to be from the original code and not related to my patch. Are these going to be blocking errors?
There are no errors in this binding in mainline. You've added a 3rd clock when all the existing users have exactly 2 clocks.
Rob,
Adding something like the following seems to be solving the bot errors, but I am not certain if this is the right way to address this issue. Can you please comment?
clock-names:
+ minItems: 2
+ maxItems: 3
items:
- const: bus
- const: iface
+ - const: mem_iface_clk
clocks:
+ minItems: 2
+ maxItems: 3
items:
- description: bus clock required for downstream bus access and for the smmu ptw
- description: interface clock required to access smmu's registers through the TCU's programming interface.
+ - description: core clock required for the GPU SMMU TBUs and the GPU TCU.
Quoted 6 lines
Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] dt-bindings: arm-smmu: update the list of clocks
In reply to Sharat MasettyQuoted 13 lines · Sharat Masetty
This patch adds a clock definition needed for powering on the GPU TBUs and the GPU TCU.
Signed-off-by Sharat Masetty <[email protected]>--- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ 1 file changed, 3 insertions(+)Documentation/devicetree/bindings/iommu/arm,smmu.yaml +0
-0
Documentation/devicetree/bindings/iommu/arm,smmu.yaml properties: · line 31
Quoted 4 lines
Documentation/devicetree/bindings/iommu/arm,smmu.yaml +1
-0@@ -28,6 +28,7 @@ properties: - enum: - qcom,msm8996-smmu-v2 - qcom,msm8998-smmu-v2 + - qcom,sc7180-smmu-v2
The addition of the compatible string isn't (directly) related with $subject, this should be done in a separate patch.
Robin Murphy
reviewerRe: [PATCH] dt-bindings: arm-smmu: update the list of clocks
[ /me fires off MAINTAINERS patch... ]
Quoted 9 lines · Matthias Kaehlcke
Quoted 8 lines · Sharat Masetty
This patch adds a clock definition needed for powering on the GPU TBUs and the GPU TCU.
Signed-off-by Sharat Masetty <[email protected]>--- Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ 1 file changed, 3 insertions(+)
Quoted 12 lines
Documentation/devicetree/bindings/iommu/arm,smmu.yaml properties: · line 31
Quoted 9 lines
Documentation/devicetree/bindings/iommu/arm,smmu.yaml +1
-0@@ -28,6 +28,7 @@ properties: - enum: - qcom,msm8996-smmu-v2 - qcom,msm8998-smmu-v2 + - qcom,sc7180-smmu-v2The addition of the compatible string isn't (directly) related with $subject, this should be done in a separate patch.
...or the patch should just be accurately described as "add support for new variant X, which requires an additional clock Y".
And speaking of which, can anyone clarify how "TCU and TBU core clock" manages to abbreviate to "mem_iface_clk"? I would have naively assumed something like "core" would be most logical.
Robin.