Add mt8186 dsi compatoble & Convert dsi_dtbinding to .yaml
Subsystems (5)
v6 cover Add mt8186 dsi compatoble & Convert dsi_dtbinding to .yaml
Changes since v5:
1. Drop #address-cells, #size-cells.
2. Based on chunkuang.hu/linux.git/mediatek-drm-next
Changes since v4:
1. Modify DSI dt-binding.
2. Add support for MT8186 DSI in mtk_drm_drv.c.
Changes since v3:
1. Add dsi port property.
2. Fix some formatting.
Changes since v2:
1. Added #address-cells, #size-cells two properties.
2. Fix some formatting issues.
Changes since v1:
1. Delete the mediatek,dsi.txt & Add the mediatek,dsi.yaml.
2. Ignore the Move the getting bridge node function patch for V1.
Rex-BC Chen (1):
drm/mediatek: Add MT8186 DSI compatible for mtk_drm_drv.c
Xinlei Lee (3):
dt-bindings: display: mediatek: dsi: Convert dsi_dtbinding to .yaml
dt-bindings: display: mediatek: dsi: Add compatible for MediaTek
MT8186
drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c
.../display/mediatek/mediatek,dsi.txt | 62 ---------- .../display/mediatek/mediatek,dsi.yaml | 116 ++++++++++++++++++ drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 + drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++ 4 files changed, 126 insertions(+), 62 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml
Signature · 1 line
2.18.0
PATCH v6 1/4 dt-bindings: display: mediatek: dsi: Convert dsi_dtbinding to .yaml
From: Xinlei Lee <[email protected]>
Convert mediatek,dsi.txt to mediatek,dsi.yaml format
--- .../display/mediatek/mediatek,dsi.txt | 62 ---------- .../display/mediatek/mediatek,dsi.yaml | 115 ++++++++++++++++++ 2 files changed, 115 insertions(+), 62 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml
Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt deleted +0 -62
@@ -1,62 +0,0 @@ -Mediatek DSI Device -=================== - -The Mediatek DSI function block is a sink of the display subsystem and can -drive up to 4-lane MIPI DSI output. Two DSIs can be synchronized for dual- -channel output. - -Required properties: -- compatible: "mediatek,<chip>-dsi" -- the supported chips are mt2701, mt7623, mt8167, mt8173 and mt8183. -- reg: Physical base address and length of the controller's registers -- interrupts: The interrupt signal from the function block. -- clocks: device clocks - See Documentation/devicetree/bindings/clock/clock-bindings.txt for details. -- clock-names: must contain "engine", "digital", and "hs" -- phys: phandle link to the MIPI D-PHY controller. -- phy-names: must contain "dphy" -- port: Output port node with endpoint definitions as described in - Documentation/devicetree/bindings/graph.txt. This port should be connected - to the input port of an attached DSI panel or DSI-to-eDP encoder chip. - -Optional properties: -- resets: list of phandle + reset specifier pair, as described in [1]. - -[1] Documentation/devicetree/bindings/reset/reset.txt - -MIPI TX Configuration Module -============================ - -See phy/mediatek,dsi-phy.yaml - -Example: - -mipi_tx0: mipi-dphy@10215000 { - compatible = "mediatek,mt8173-mipi-tx"; - reg = <0 0x10215000 0 0x1000>; - clocks = <&clk26m>; - clock-output-names = "mipi_tx0_pll"; - #clock-cells = <0>; - #phy-cells = <0>; - drive-strength-microamp = <4600>; - nvmem-cells= <&mipi_tx_calibration>; - nvmem-cell-names = "calibration-data"; -}; - -dsi0: dsi@1401b000 { - compatible = "mediatek,mt8173-dsi"; - reg = <0 0x1401b000 0 0x1000>; - interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_LOW>; - clocks = <&mmsys MM_DSI0_ENGINE>, <&mmsys MM_DSI0_DIGITAL>, - <&mipi_tx0>; - clock-names = "engine", "digital", "hs"; - resets = <&mmsys MT8173_MMSYS_SW0_RST_B_DISP_DSI0>; - phys = <&mipi_tx0>; - phy-names = "dphy"; - - port { - dsi0_out: endpoint { - remote-endpoint = <&panel_in>; - }; - }; -};
Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml new file +115 -0
115 lines not on this page · raw message
Signature · 1 line
2.18.0
Re: [PATCH v6 1/4] dt-bindings: display: mediatek: dsi: Convert dsi_dtbinding to .yaml
Quoted 214 lines · Rex-BC Chen
From: Xinlei Lee <[email protected]>
Convert mediatek,dsi.txt to mediatek,dsi.yaml format
Signed-off-by Xinlei Lee <[email protected]>Signed-off-by Rex-BC Chen <[email protected]>--- .../display/mediatek/mediatek,dsi.txt | 62 ---------- .../display/mediatek/mediatek,dsi.yaml | 115 ++++++++++++++++++ 2 files changed, 115 insertions(+), 62 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yamldiff --git
a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txtb/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txtdeleted file mode 100644
index 36b01458f45c..000000000000
---a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt+++/dev/nullDocumentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt deleted +0
-4@@ -1,62 +0,0 @@ -Mediatek DSI Device -=================== - -The Mediatek DSI function block is a sink of the display subsystemand can
-drive up to 4-lane MIPI DSI output. Two DSIs can be synchronized for dual-Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt deleted +0
-6-channel output. - -Required properties: -- compatible: "mediatek,<chip>-dsi" -- the supported chips are mt2701, mt7623, mt8167, mt8173 and mt8183. -- reg: Physical base address and length of the controller'sregisters
-- interrupts: The interrupt signal from the function block. -- clocks: device clocks
- SeeDocumentation/devicetree/bindings/clock/clock-bindings.txtfor details.
-- clock-names: must contain "engine", "digital", and "hs" -- phys: phandle link to the MIPI D-PHY controller.
-- phy-names: must contain "dphy"
-- port: Output port node with endpoint definitions as described in
-Documentation/devicetree/bindings/graph.txt. This port should be connected
- to the input port of an attached DSI panel or DSI-to-eDP encoder chip.Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt deleted +0
-3- -Optional properties: -- resets: list of phandle + reset specifier pair, as described in[1].
Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt deleted +0
-39- -[1] Documentation/devicetree/bindings/reset/reset.txt - -MIPI TX Configuration Module -============================ - -See phy/mediatek,dsi-phy.yaml - -Example: - -mipi_tx0: mipi-dphy@10215000 { - compatible = "mediatek,mt8173-mipi-tx"; - reg = <0 0x10215000 0 0x1000>; - clocks = <&clk26m>; - clock-output-names = "mipi_tx0_pll"; - #clock-cells = <0>; - #phy-cells = <0>; - drive-strength-microamp = <4600>; - nvmem-cells= <&mipi_tx_calibration>; - nvmem-cell-names = "calibration-data"; -}; - -dsi0: dsi@1401b000 { - compatible = "mediatek,mt8173-dsi"; - reg = <0 0x1401b000 0 0x1000>; - interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_LOW>; - clocks = <&mmsys MM_DSI0_ENGINE>, <&mmsys MM_DSI0_DIGITAL>, - <&mipi_tx0>; - clock-names = "engine", "digital", "hs"; - resets = <&mmsys MT8173_MMSYS_SW0_RST_B_DISP_DSI0>; - phys = <&mipi_tx0>; - phy-names = "dphy"; - - port { - dsi0_out: endpoint { - remote-endpoint = <&panel_in>; - }; - }; -};diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yam l b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yam l
new file mode 100644
index 000000000000..fa5bdf28668a
---/dev/null
+++
b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yam lDocumentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml new file +4
-0@@ -0,0 +1,115 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id:http://devicetree.org/schemas/display/mediatek/mediatek,dsi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml new file +11
-0+ +title: MediaTek DSI Controller Device Tree Bindings + +maintainers: + - Chun-Kuang Hu <[email protected]> + - Philipp Zabel <[email protected]> + - Jitao Shi <[email protected]> + - Xinlei Lee <[email protected]> + +description: | + The MediaTek DSI function block is a sink of the display subsystemand can
+ drive up to 4-lane MIPI DSI output. Two DSIs can be synchronized for dual-Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml new file +88
-0+ channel output. + +allOf: + - $ref: /schemas/display/dsi-controller.yaml# + +properties: + compatible: + enum: + - mediatek,mt2701-dsi + - mediatek,mt7623-dsi + - mediatek,mt8167-dsi + - mediatek,mt8173-dsi + - mediatek,mt8183-dsi + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + power-domains: + maxItems: 1 + + clocks: + items: + - description: Engine Clock + - description: Digital Clock + - description: HS Clock + + clock-names: + items: + - const: engine + - const: digital + - const: hs + + resets: + maxItems: 1 + + phys: + maxItems: 1 + + phy-names: + items: + - const: dphy + + port: + $ref: /schemas/graph.yaml#/properties/port + description: + Output port node. This port should be connected to the input + port of an attached DSI panel or DSI-to-eDP encoder chip. + +required: + - compatible + - reg + - interrupts + - power-domains + - clocks + - clock-names + - phys + - phy-names + - port + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/mt8183-clk.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/power/mt8183-power.h> + #include <dt-bindings/phy/phy.h> + #include <dt-bindings/reset/mt8183-resets.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + dsi0: dsi@14014000 { + compatible = "mediatek,mt8183-dsi"; + reg = <0 0x14014000 0 0x1000>; + interrupts = <GIC_SPI 236 IRQ_TYPE_LEVEL_LOW>; + power-domains = <&spm MT8183_POWER_DOMAIN_DISP>; + clocks = <&mmsys CLK_MM_DSI0_MM>, + <&mmsys CLK_MM_DSI0_IF>, + <&mipi_tx0>; + clock-names = "engine", "digital", "hs"; + resets = <&mmsys MT8183_MMSYS_SW0_RST_B_DISP_DSI0>; + phys = <&mipi_tx0>;
Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml line 115
Quoted 10 lines
Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml new file +10
-0+ phy-names = "dphy"; + port { + dsi0_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + }; + }; + +...
Hello Rob and Krzysztof,
Can you give us some suggestions for this conversion patch? Thanks!
BRs,
Rex
Re: [PATCH v6 1/4] dt-bindings: display: mediatek: dsi: Convert dsi_dtbinding to .yaml
Quoted 17 lines · Rex-BC Chen
Quoted 15 lines · Rex-BC Chen
From: Xinlei Lee <[email protected]>
Convert mediatek,dsi.txt to mediatek,dsi.yaml format
Signed-off-by Xinlei Lee <[email protected]>Signed-off-by Rex-BC Chen <[email protected]>--- .../display/mediatek/mediatek,dsi.txt | 62 ---------- .../display/mediatek/mediatek,dsi.yaml | 115 ++++++++++++++++++ 2 files changed, 115 insertions(+), 62 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml
[...]
Quoted 4 lines
Hello Rob and Krzysztof,
Can you give us some suggestions for this conversion patch? Thanks!
You can check status for yourself by looking at PW[1] where you will see the review queue is currently ~120 patches and goes back to 5/3. If it is in the queue, I will get to it.
Rob
[1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/
Re: [PATCH v6 1/4] dt-bindings: display: mediatek: dsi: Convert dsi_dtbinding to .yaml
Quoted 29 lines · Rob Herring
On Wed, May 11, 2022 at 2:24 AM Rex-BC Chen <[email protected]
Quoted 20 lines
wrote:
Quoted 17 lines · Rex-BC Chen
From: Xinlei Lee <[email protected]>
Convert mediatek,dsi.txt to mediatek,dsi.yaml format
Signed-off-by Xinlei Lee <[email protected]>Signed-off-by Rex-BC Chen <[email protected]>--- .../display/mediatek/mediatek,dsi.txt | 62 ---------- .../display/mediatek/mediatek,dsi.yaml | 115 ++++++++++++++++++ 2 files changed, 115 insertions(+), 62 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.t xt create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml[...]
Quoted 4 lines
Hello Rob and Krzysztof,
Can you give us some suggestions for this conversion patch? Thanks!
Quoted 7 lines
You can check status for yourself by looking at PW[1] where you will see the review queue is currently ~120 patches and goes back to 5/3. If it is in the queue, I will get to it.
Rob
[1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/
Hello Rob,
Got it.
Thanks for your effort.
I will look at this next time before I send remind mail.
BRs,
Rex
Re: [PATCH v6 1/4] dt-bindings: display: mediatek: dsi: Convert dsi_dtbinding to .yaml
In reply to Rex-BC ChenQuoted 4 lines · Rex-BC Chen
From: Xinlei Lee <[email protected]>
Convert mediatek,dsi.txt to mediatek,dsi.yaml format
Quoted 9 lines
Signed-off-by Xinlei Lee <[email protected]>Signed-off-by Rex-BC Chen <[email protected]>--- .../display/mediatek/mediatek,dsi.txt | 62 ---------- .../display/mediatek/mediatek,dsi.yaml | 115 ++++++++++++++++++ 2 files changed, 115 insertions(+), 62 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml
Re: [PATCH v6 1/4] dt-bindings: display: mediatek: dsi: Convert dsi_dtbinding to .yaml
In reply to Rex-BC ChenHi, Rex:
Quoted 3 lines · Rex-BC Chen
From: Xinlei Lee <[email protected]>
Convert mediatek,dsi.txt to mediatek,dsi.yaml format
Quoted 224 lines
Signed-off-by Xinlei Lee <[email protected]>Signed-off-by Rex-BC Chen <[email protected]>--- .../display/mediatek/mediatek,dsi.txt | 62 ---------- .../display/mediatek/mediatek,dsi.yaml | 115 ++++++++++++++++++ 2 files changed, 115 insertions(+), 62 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yamldiff --git
a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txtb/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txtdeleted file mode 100644
index 36b01458f45c..000000000000
---a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt+++/dev/nullDocumentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt deleted +0
-4@@ -1,62 +0,0 @@ -Mediatek DSI Device -=================== - -The Mediatek DSI function block is a sink of the display subsystemand can
-drive up to 4-lane MIPI DSI output. Two DSIs can be synchronized for dual-Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt deleted +0
-6-channel output. - -Required properties: -- compatible: "mediatek,<chip>-dsi" -- the supported chips are mt2701, mt7623, mt8167, mt8173 and mt8183. -- reg: Physical base address and length of the controller'sregisters
-- interrupts: The interrupt signal from the function block. -- clocks: device clocks
- SeeDocumentation/devicetree/bindings/clock/clock-bindings.txtfor details.
-- clock-names: must contain "engine", "digital", and "hs" -- phys: phandle link to the MIPI D-PHY controller.
-- phy-names: must contain "dphy"
-- port: Output port node with endpoint definitions as described in
-Documentation/devicetree/bindings/graph.txt. This port should be connected
- to the input port of an attached DSI panel or DSI-to-eDP encoder chip.Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt deleted +0
-3- -Optional properties: -- resets: list of phandle + reset specifier pair, as described in[1].
Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt deleted +0
-39- -[1] Documentation/devicetree/bindings/reset/reset.txt - -MIPI TX Configuration Module -============================ - -See phy/mediatek,dsi-phy.yaml - -Example: - -mipi_tx0: mipi-dphy@10215000 { - compatible = "mediatek,mt8173-mipi-tx"; - reg = <0 0x10215000 0 0x1000>; - clocks = <&clk26m>; - clock-output-names = "mipi_tx0_pll"; - #clock-cells = <0>; - #phy-cells = <0>; - drive-strength-microamp = <4600>; - nvmem-cells= <&mipi_tx_calibration>; - nvmem-cell-names = "calibration-data"; -}; - -dsi0: dsi@1401b000 { - compatible = "mediatek,mt8173-dsi"; - reg = <0 0x1401b000 0 0x1000>; - interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_LOW>; - clocks = <&mmsys MM_DSI0_ENGINE>, <&mmsys MM_DSI0_DIGITAL>, - <&mipi_tx0>; - clock-names = "engine", "digital", "hs"; - resets = <&mmsys MT8173_MMSYS_SW0_RST_B_DISP_DSI0>; - phys = <&mipi_tx0>; - phy-names = "dphy"; - - port { - dsi0_out: endpoint { - remote-endpoint = <&panel_in>; - }; - }; -};diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yam l b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yam l
new file mode 100644
index 000000000000..fa5bdf28668a
---/dev/null
+++
b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yam lDocumentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml new file +4
-0@@ -0,0 +1,115 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id:Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml new file +11
-0+ +title: MediaTek DSI Controller Device Tree Bindings + +maintainers: + - Chun-Kuang Hu <[email protected]> + - Philipp Zabel <[email protected]> + - Jitao Shi <[email protected]> + - Xinlei Lee <[email protected]> + +description: | + The MediaTek DSI function block is a sink of the display subsystemand can
+ drive up to 4-lane MIPI DSI output. Two DSIs can be synchronized for dual-Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml new file +98
-0+ channel output. + +allOf: + - $ref: /schemas/display/dsi-controller.yaml# + +properties: + compatible: + enum: + - mediatek,mt2701-dsi + - mediatek,mt7623-dsi + - mediatek,mt8167-dsi + - mediatek,mt8173-dsi + - mediatek,mt8183-dsi + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + power-domains: + maxItems: 1 + + clocks: + items: + - description: Engine Clock + - description: Digital Clock + - description: HS Clock + + clock-names: + items: + - const: engine + - const: digital + - const: hs + + resets: + maxItems: 1 + + phys: + maxItems: 1 + + phy-names: + items: + - const: dphy + + port: + $ref: /schemas/graph.yaml#/properties/port + description: + Output port node. This port should be connected to the input + port of an attached DSI panel or DSI-to-eDP encoder chip. + +required: + - compatible + - reg + - interrupts + - power-domains + - clocks + - clock-names + - phys + - phy-names + - port + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/mt8183-clk.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/power/mt8183-power.h> + #include <dt-bindings/phy/phy.h> + #include <dt-bindings/reset/mt8183-resets.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + dsi0: dsi@14014000 { + compatible = "mediatek,mt8183-dsi"; + reg = <0 0x14014000 0 0x1000>; + interrupts = <GIC_SPI 236 IRQ_TYPE_LEVEL_LOW>; + power-domains = <&spm MT8183_POWER_DOMAIN_DISP>; + clocks = <&mmsys CLK_MM_DSI0_MM>, + <&mmsys CLK_MM_DSI0_IF>, + <&mipi_tx0>; + clock-names = "engine", "digital", "hs"; + resets = <&mmsys MT8183_MMSYS_SW0_RST_B_DISP_DSI0>; + phys = <&mipi_tx0>; + phy-names = "dphy"; + port { + dsi0_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + }; + }; + +...
PATCH v6 2/4 dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8186
In reply to Rex-BC ChenFrom: Xinlei Lee <[email protected]>
Add dt-binding documentation of dsi for MediaTek MT8186 SoC.
--- .../devicetree/bindings/display/mediatek/mediatek,dsi.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml +1 -0
@@ -28,6 +28,7 @@ properties: - mediatek,mt8167-dsi - mediatek,mt8173-dsi - mediatek,mt8183-dsi + - mediatek,mt8186-dsi reg: maxItems: 1
Signature · 1 line
2.18.0
Re: [PATCH v6 2/4] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8186
Hi, Rex:
Quoted 3 lines · Rex-BC Chen
From: Xinlei Lee <[email protected]>
Add dt-binding documentation of dsi for MediaTek MT8186 SoC.
Quoted 31 lines
Signed-off-by Xinlei Lee <[email protected]>Reviewed-by AngeloGioacchino Del Regno <Reviewed-by Rex-BC Chen <[email protected]>Acked-by Rob Herring <[email protected]>--- .../devicetree/bindings/display/mediatek/mediatek,dsi.yaml | 1 + 1 file changed, 1 insertion(+)diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yam l b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yam l
indexfa5bdf28668a..b18d6a57c6e1100644
---
a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yam l
+++
b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.yam lDocumentation/devicetree/bindings/display/mediatek/mediatek,dsi.yaml +1
-0@@ -28,6 +28,7 @@ properties: - mediatek,mt8167-dsi - mediatek,mt8173-dsi - mediatek,mt8183-dsi + - mediatek,mt8186-dsi reg: maxItems: 1
PATCH v6 3/4 drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c
In reply to Rex-BC ChenFrom: Xinlei Lee <[email protected]>
Add the compatible because use different cmdq addresses in mt8186.
--- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpu/drm/mediatek/mtk_dsi.c +8 -0
@@ -1155,6 +1155,12 @@ static const struct mtk_dsi_driver_data mt8183_dsi_driver_data = { .has_size_ctl = true, }; +static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = { + .reg_cmdq_off =0xd00 , + .has_shadow_ctl = true, + .has_size_ctl = true, +}; +static const struct of_device_id mtk_dsi_of_match[] = { { .compatible ="mediatek,mt2701-dsi" , .data = &mt2701_dsi_driver_data },
@@ -1162,6 +1168,8 @@ static const struct of_device_id mtk_dsi_of_match[] = { .data = &mt8173_dsi_driver_data }, { .compatible = "mediatek,mt8183-dsi", .data = &mt8183_dsi_driver_data }, + { .compatible = "mediatek,mt8186-dsi", + .data = &mt8186_dsi_driver_data }, { }, };MODULE_DEVICE_TABLE (of, mtk_dsi_of_match);
Signature · 1 line
2.18.0
Re: [PATCH v6 3/4] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c
Hi, Rex:
Quoted 3 lines · Rex-BC Chen
From: Xinlei Lee <[email protected]>
Add the compatible because use different cmdq addresses in mt8186.
Quoted 38 lines
Signed-off-by Xinlei Lee <[email protected]>Reviewed-by AngeloGioacchino Del Regno <Reviewed-by Rex-BC Chen <[email protected]>--- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpu/drm/mediatek/mtk_dsi.c +6
-0@@ -1155,6 +1155,12 @@ static const struct mtk_dsi_driver_data mt8183_dsi_driver_data = { .has_size_ctl = true, }; +static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = { + .reg_cmdq_off =0xd00 , + .has_shadow_ctl = true, + .has_size_ctl = true, +}; +static const struct of_device_id mtk_dsi_of_match[] = { { .compatible ="mediatek,mt2701-dsi" ,drivers/gpu/drm/mediatek/mtk_dsi.c +2
-0.data = &mt2701_dsi_driver_data },@@ -1162,6 +1168,8 @@ static const struct of_device_id mtk_dsi_of_match[] = { .data = &mt8173_dsi_driver_data }, { .compatible = "mediatek,mt8183-dsi", .data = &mt8183_dsi_driver_data }, + { .compatible = "mediatek,mt8186-dsi", + .data = &mt8186_dsi_driver_data }, { }, };
MODULE_DEVICE_TABLE(of, mtk_dsi_of_match);
PATCH v6 4/4 drm/mediatek: Add MT8186 DSI compatible for mtk_drm_drv.c
In reply to Rex-BC ChenThe compatible "mediatek,mt8186-dsi" is used by MT8186 DSI, so add it to mtk_ddp_comp_dt_ids in mtk_drm_drv.c.
--- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/mediatek/mtk_drm_drv.c +2 -0
@@ -544,6 +544,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { .data = (void *)MTK_DSI }, { .compatible = "mediatek,mt8183-dsi", .data = (void *)MTK_DSI }, + { .compatible = "mediatek,mt8186-dsi", + .data = (void *)MTK_DSI }, { } };
Signature · 1 line
2.18.0
Re: [PATCH v6 4/4] drm/mediatek: Add MT8186 DSI compatible for mtk_drm_drv.c
Hi, Rex:
Quoted 2 lines · Rex-BC Chen
The compatible "mediatek,mt8186-dsi" is used by MT8186 DSI, so add it to
mtk_ddp_comp_dt_idsinmtk_drm_drv.c.
Quoted 23 lines
Signed-off-by Rex-BC Chen <[email protected]>Reviewed-by AngeloGioacchino Del Regno <--- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/mediatek/mtk_drm_drv.c +2
-0@@ -544,6 +544,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { .data = (void *)MTK_DSI }, { .compatible = "mediatek,mt8183-dsi", .data = (void *)MTK_DSI }, + { .compatible = "mediatek,mt8186-dsi", + .data = (void *)MTK_DSI }, { } };