Skip to contentSkip to conversation

xen/x86/hvm: add missing cf_check for hvm_physdev_op()

PATCH In review Juergen Gross 3 participants 3 messages Mar 21, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/x86/hvm: add missing cf_check for hvm_physdev_op()

The hypercall handler hvm_physdev_op() is missing a cf_check attribute.

Fixes cdbe2b0a1aec ("x86: Enable CET Indirect Branch Tracking")
---
 xen/arch/x86/hvm/hypercall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/arch/x86/hvm/hypercall.c +1 -1
index 030243810e..62b5349e7d 100644
@@ -78,7 +78,7 @@ static long cf_check hvm_grant_table_op(
 }
 #endif
 
-static long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+static long cf_check hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     const struct vcpu *curr = current;
     const struct domain *currd = curr->domain;
Signature · 1 line
2.34.1
#2 lore raw
In reply to Juergen Gross
Quoted 4 lines · Juergen Gross

The hypercall handler hvm_physdev_op() is missing a cf_check attribute.

Fixes cdbe2b0a1aec ("x86: Enable CET Indirect Branch Tracking")

https://lore.kernel.org/xen-devel/[email protected]/

The only reason I haven't committed it is because I was chasing someone's bug report against compat_vcpu_op()...

~Andrew

Quoted 17 lines
---
 xen/arch/x86/hvm/hypercall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/arch/x86/hvm/hypercall.c +1 -1
index 030243810e..62b5349e7d 100644
@@ -78,7 +78,7 @@ static long cf_check hvm_grant_table_op(
 }
 #endif
 
-static long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+static long cf_check hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     const struct vcpu *curr = current;
     const struct domain *currd = curr->domain;