Skip to contentSkip to conversation

check for filesystem libraries (for pygrub)

PATCH In review aq 2 participants 3 messages May 19, 2005 – May 25, 2005

lore
Share & tools
lore

aq

author
#0 lore raw

PATCH 1/1 check for filesystem libraries (for pygrub)

hello,

here is a patch to check for filesystem libraries for pygrub. please set +x on it.

$ diffstat checkfslibs.patch 
 check_fslibs_devel |   19 +++++++++++++++++++
 1 files changed, 19 insertions(+)
Signature · 2 lines
regards,
aq

===== tools/check/check_fslibs_devel 1.1 vs edited =====

tools/check/check_fslibs_devel +19 -0
@@ -0,0 +1,19 @@
+#!/bin/bash
+# CHECK-BUILD
+
+function ext2_error {
+    echo 'Check for ext2fs library failed.'
+    exit 1
+}
+
+function reiser_error {
+    echo 'Check for reiserfs library failed.'
+    exit 1
+}
+
+set -e
+[ -e /usr/include/ext2fs ] || ext2_error
+[ -e /usr/include/ext2fs/ext2fs.h ] || ext2_error
+
+[ -e /usr/include/reiserfs ] || reiser_error
+[ -e /usr/include/reiserfs/reiserfs.h ] || reiser_error

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

author
#1 lore raw

here is the follow up message (got no comment so far). please consider applying this patch.

regards,
aq

Quoted 16 lines · aq

hello,

here is a patch to check for filesystem libraries for pygrub. please set +x on it.

$ diffstat checkfslibs.patch
 check_fslibs_devel |   19 +++++++++++++++++++
 1 files changed, 19 insertions(+)
--
regards,
aq
#2 lore raw

pygrub should just not build those fs backends, rather than failing our entire build. Ought to be trivial to detect and alter the build via a script or extra Makefile magic in pygrub/ subdir.

-- Keir

Quoted 24 lines

here is the follow up message (got no comment so far). please consider applying this patch.

regards,
aq

Quoted 5 lines · aq

hello,

here is a patch to check for filesystem libraries for pygrub. please set +x on it.

Quoted 11 lines
$ diffstat checkfslibs.patch
 check_fslibs_devel |   19 +++++++++++++++++++
 1 files changed, 19 insertions(+)
--
regards,
aq
Quoted 5 lines

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

 -=- MIME -=- 

here is the follow up message (got no comment so far). please consider applying this patch.

regards,
aq

Quoted 7 lines · aq

hello,
=20
here is a patch to check for filesystem libraries for pygrub. please set +x on it.
=20

=20

Quoted 9 lines
$ diffstat checkfslibs.patch
 check_fslibs_devel |   19 +++++++++++++++++++
 1 files changed, 19 insertions(+)
--
regards,
aq
=20
=20

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel