balloon bugfix on -TESTING

PATCH In review aq 2 participants 3 messages Jul 18, 2005 – Jul 19, 2005

Share & tools

aq

author

2005-07-18 06:24 UTC #0 lore raw

PATCH 1/1 balloon bugfix on -TESTING

This patch is for -testing, to fix some wrong calculates of max_pages and max_memkb. Now balloon problem goes away (on *testing*).

Unfortunately i cannot confirm the similar fix to -unstable yesterday is able to fix balloon problem, since i got some troubles creating domU with the latest -unstable.

Demonstration:

$ xm list
Name              Id  Mem(MB)  CPU  State  Time(s)  Console
Domain-0           0       92    0  r----     44.3        
tty                1       40    0  -b---      0.9    9601

$ xm balloon tty 45
bun@dewey2:~/projects/myxen$ xm list
Name              Id  Mem(MB)  CPU  State  Time(s)  Console
Domain-0           0       92    0  r----     45.3        
tty                1       45    0  -b---      0.9    9601

bun@dewey2:~/projects/myxen$ xm balloon tty 35
bun@dewey2:~/projects/myxen$ xm list
Name              Id  Mem(MB)  CPU  State  Time(s)  Console
Domain-0           0       92    0  r----     46.1        
tty                1       35    0  -b---      0.9    9601

Signed-off-by Nguyen Anh Quynh <[email protected]>

$ diffstat balloon.patch 
 tools/libxc/xc_domain.c |    2 +-
 xen/common/dom0_ops.c   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

tools/libxc/xc_domain.c +1 -1

diff -r 1cf15df7acf7 tools/libxc/xc_domain.c
@@ -107,7 +107,7 @@
             DOMFLAGS_SHUTDOWNMASK;
 
         info->nr_pages = op.u.getdomaininfo.tot_pages;
-        info->max_memkb = op.u.getdomaininfo.max_pages<<(PAGE_SHIFT);
+        info->max_memkb = op.u.getdomaininfo.max_pages<<(PAGE_SHIFT-10);
         info->shared_info_frame = op.u.getdomaininfo.shared_info_frame;
         info->cpu_time = op.u.getdomaininfo.cpu_time;

xen/common/dom0_ops.c +1 -1

diff -r 1cf15df7acf7 xen/common/dom0_ops.c
@@ -477,7 +477,7 @@
         if ( d != NULL )
         {
             d->max_pages = 
-                (op->u.setdomainmaxmem.max_memkb+PAGE_SIZE-1)>> PAGE_SHIFT;
+                (op->u.setdomainmaxmem.max_memkb)>> (PAGE_SHIFT-10);
             put_domain(d);
             ret = 0;
         }

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Hi aq,
I tested the -testing tree by applying your patch and i can successfully balloon the domain's memory
above the initial allocation now. BTW, you can give either bytes, or m (mega bytes), or k (kilo
bytes) to the "mem=" kernel command line parameter in the "extra" option of the domain's config file. Thanks!
Xuehai

Quoted 57 lines · aq

Quoted 20 lines · aq

This patch is for -testing, to fix some wrong calculates of max_pages and max_memkb. Now balloon problem goes away (on *testing*).
Unfortunately i cannot confirm the similar fix to -unstable yesterday is able to fix balloon problem, since i got some troubles creating domU with the latest -unstable.
Demonstration:
$ xm list
Name              Id  Mem(MB)  CPU  State  Time(s)  Console
Domain-0           0       92    0  r----     44.3
tty                1       40    0  -b---      0.9    9601
$ xm balloon tty 45
bun@dewey2:~/projects/myxen$ xm list
Name              Id  Mem(MB)  CPU  State  Time(s)  Console
Domain-0           0       92    0  r----     45.3
tty                1       45    0  -b---      0.9    9601

Quoted 6 lines

bun@dewey2:~/projects/myxen$ xm balloon tty 35
bun@dewey2:~/projects/myxen$ xm list
Name              Id  Mem(MB)  CPU  State  Time(s)  Console
Domain-0           0       92    0  r----     46.1
tty                1       35    0  -b---      0.9    9601

i can confirm that now (on -testing) "xm maxmem" also works :-)

bun@dewey2:~/projects/myxen$ xm list
Name              Id  Mem(MB)  CPU  State  Time(s)  Console
Domain-0           0       92    0  r----    101.4        tty                3       40    0  -b---      0.7    9603

bun@dewey2:~/projects/myxen$ xm balloon tty 62
bun@dewey2:~/projects/myxen$ xm list
Name              Id  Mem(MB)  CPU  State  Time(s)  Console
Domain-0           0       92    0  r----    102.1        tty                3       60    0  -b---      0.7    9603

bun@dewey2:~/projects/myxen$ xm maxmem tty 62
bun@dewey2:~/projects/myxen$ xm balloon tty 62
bun@dewey2:~/projects/myxen$ xm list
Name              Id  Mem(MB)  CPU  State  Time(s)  Console
Domain-0           0       92    0  r----    103.2        tty                3       62    0  -b---      0.7    9603

regards,
aq

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel