Skip to contentSkip to conversation

ufs: sysfs: Add WB partial flush mode support

PATCH RESEND Superseded Daniel Lee 2 participants 3 messages Nov 16

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Daniel Lee

author
#0 lore raw

PATCH RESEND v3 1/1 ufs: sysfs: Add WB partial flush mode support

Expose the following JEDEC UFS 4.1 Extended WriteBooster attributes and flags to sysfs to support FIFO and Pinned partial flush modes:

- wb_partial_flush_mode
- wb_max_fifo_size
- wb_cur_fifo_size
- wb_pinned_cur_size
- wb_pinned_avail_pct
- wb_pinned_cumulative_write_size
- wb_pinned_size
- wb_non_pinned_min_size
- wb_unpin_enable

Introduce UFS_ATTRIBUTE_RW and UFS_FLAG_RW to support writable attributes and flags.
Document the new entries under Documentation/ABI/testing/sysfs-driver-ufs.

Assisted-by Gemini:gemini-3.1

---
v3:
- Fold ufs_wb_pfm_to_string() into wb_partial_flush_mode_show().
- Propagate actual error codes for non-OCS error (ret < 0), while keeping -EINVAL for OCS errors (ret > 0).
- Clean up blank lines.
v2:
- Change wb_partial_flush_mode attribute to accept and report strings instead of numbers for better usability.
- Order local variable declarations from longest to shortest in new functions.

 Documentation/ABI/testing/sysfs-driver-ufs |  85 ++++++
 drivers/ufs/core/ufs-sysfs.c               | 311 ++++++++++++++++-----
 include/ufs/ufs.h                          |  17 ++
 3 files changed, 350 insertions(+), 63 deletions(-)
Documentation/ABI/testing/sysfs-driver-ufs +85 -0
index 3c422aac7..32dd38eba 100644
@@ -1791,3 +1791,88 @@ Description:
 		will be rejected.
 
 		The attribute is read/write.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_partial_flush_mode
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_partial_flush_mode
+Date:		June 2026
+Contact:	Daniel Lee <[email protected]>
+Description:	This entry controls Extended WriteBooster partial flush modes.
+
+		======== ==============================
+		"none"   No partial flush
+		"fifo"   FIFO mode
+		"pinned" Pinned mode
+		======== ==============================
+
+		The attribute is read-write.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_max_fifo_size
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_max_fifo_size
+Date:		June 2026
+Contact:	Daniel Lee <[email protected]>
+Description:	This entry configures the maximum size in Allocation Units reserved for the
+		WriteBooster FIFO Buffer size.
+		The attribute is read-write.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_cur_fifo_size
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_cur_fifo_size
+Date:		June 2026
+Contact:	Daniel Lee <[email protected]>
+Description:	This entry shows the current size in Allocation Units of the WriteBooster FIFO
+		Buffer size.
+		The attribute is read only.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_pinned_size
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_pinned_size
+Date:		June 2026
+Contact:	Daniel Lee <[email protected]>
+Description:	This entry configures the allocated size in Allocation Units for the UFS
+		Pinned WriteBooster buffer.
+		The attribute is read-write.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_pinned_cur_size
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_pinned_cur_size
+Date:		June 2026
+Contact:	Daniel Lee <[email protected]>
+Description:	This entry shows the current allocated size in Allocation Units for the UFS
+		Pinned WriteBooster buffer.
+		The attribute is read-only.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_pinned_avail_pct
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_pinned_avail_pct
+Date:		June 2026
+Contact:	Daniel Lee <[email protected]>
+Description:	This entry shows the percentage of available space remaining in the
+		Pinned WriteBooster buffer.
+		The attribute is read-only.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_pinned_cumulative_write_size
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_pinned_cumulative_write_size
+Date:		June 2026
+Contact:	Daniel Lee <[email protected]>
+Description:	This entry shows the total cumulative size of data written to the
+		Pinned WriteBooster buffer.
+		The attribute is read-only.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_non_pinned_min_size
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_non_pinned_min_size
+Date:		June 2026
+Contact:	Daniel Lee <[email protected]>
+Description:	This entry configures the minimum size in Allocation Units for the
+		Non-Pinned WriteBooster Buffer area when Pinned partial flush mode is active.
+		The attribute is read-write.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/flags/wb_unpin_enable
+What:		/sys/bus/platform/devices/*.ufs/flags/wb_unpin_enable
+Date:		June 2026
+Contact:	Daniel Lee <[email protected]>
+Description:	This entry controls the Pinned WriteBooster unpin enable flag (fUnpinEn).
+
+		======   ==============================================================
+		0        Unpin Disable: pinned data is not flushed by WriteBooster
+		         Buffer flush operation.
+		1        Unpin Enable: pinned data is flushed by WriteBooster
+		         Buffer flush operation.
+		======   ==============================================================
+
+		The attribute is read-write.
drivers/ufs/core/ufs-sysfs.c +248 -63

375 lines not on this page · raw message

include/ufs/ufs.h +17 -0
index b0207e694..f6011ef1a 100644
@@ -151,6 +151,7 @@ enum flag_idn {
 	QUERY_FLAG_IDN_WB_BUFF_FLUSH_DURING_HIBERN8     = 0x10,
 	QUERY_FLAG_IDN_HPB_RESET                        = 0x11,
 	QUERY_FLAG_IDN_HPB_EN				= 0x12,
+	QUERY_FLAG_IDN_WB_UNPIN_EN			= 0x13,
 };
 
 /* Attribute idn for Query requests */
@@ -196,6 +197,14 @@ enum attr_idn {
 	QUERY_ATTR_IDN_WB_BUF_RESIZE_HINT	= 0x3C,
 	QUERY_ATTR_IDN_WB_BUF_RESIZE_EN		= 0x3D,
 	QUERY_ATTR_IDN_WB_BUF_RESIZE_STATUS	= 0x3E,
+	QUERY_ATTR_IDN_WB_PFM			= 0x3F,
+	QUERY_ATTR_IDN_MAX_FIFO_SIZE_WB_PFM	= 0x40,
+	QUERY_ATTR_IDN_CURRENT_FIFO_SIZE_WB_PFM	= 0x41,
+	QUERY_ATTR_IDN_PINNED_WB_CURRENT_SIZE	= 0x42,
+	QUERY_ATTR_IDN_PINNED_WB_AVAIL_PERC	= 0x43,
+	QUERY_ATTR_IDN_PINNED_WB_CUMMULATIVE_WS	= 0x44,
+	QUERY_ATTR_IDN_PINNED_WB_SIZE		= 0x45,
+	QUERY_ATTR_IDN_NON_PINNED_WB_MIN_SIZE	= 0x46,
 	QUERY_ATTR_IDN_TX_EQ_GN_SETTINGS        = 0x47,
 	QUERY_ATTR_IDN_TX_EQ_GN_SETTINGS_EXT    = 0x48,
 };
@@ -406,6 +415,14 @@ enum {
 	UFS_DEV_WB_BUF_RESIZE	= BIT(0),
 };
 
+/* Possible values for bWriteBoosterBufferPartialFlushMode */
+enum wb_partial_flush_mode {
+	WB_PARTIAL_FLUSH_NONE		= 0,
+	WB_PARTIAL_FLUSH_FIFO		= 1,
+	WB_PARTIAL_FLUSH_PINNED		= 2,
+	NUM_WB_PARTIAL_FLUSH_MODES	= 3,
+};
+
 /* Possible values for dExtendedUFSFeaturesSupport */
 enum {
 	UFS_DEV_HIGH_TEMP_NOTIF		= BIT(4),
Signature · 1 line
2.56.0.611.g1030f0b940-goog
#1 lore raw

Documentation/ABI/testing/sysfs-driver-ufs Description: · line 1807

Quoted 13 lines · Daniel Lee
Documentation/ABI/testing/sysfs-driver-ufs +13 -0
+What:	 /sys/bus/platform/drivers/ufshcd/*/attributes/wb_partial_flush_mode
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_partial_flush_mode
+Date:		June 2026
+Contact:	Daniel Lee <[email protected]>
+Description:	This entry controls Extended WriteBooster partial flush modes.
+
+		======== ==============================
+		"none"   No partial flush
+		"fifo"   FIFO mode
+		"pinned" Pinned mode
+		======== ==============================
+
+		The attribute is read-write.

Please update the Date: field across the new ABI entries (June 2026 has passed).

Also, please drop the quotes around "none", "fifo", and "pinned" to match the other string attributes in this file (such as wb_resize_hint, wb_resize_status, and hid/state), since literal quotes are neither emitted nor accepted.

Documentation/ABI/testing/sysfs-driver-ufs Description: · line 1823

Quoted 11 lines
Documentation/ABI/testing/sysfs-driver-ufs +11 -0
+Description:	This entry configures the maximum size in Allocation Units reserved for the
+		WriteBooster FIFO Buffer size.
+		The attribute is read-write.
+
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_cur_fifo_size
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_cur_fifo_size
+Date:		June 2026
+Contact:	Daniel Lee <[email protected]>
+Description:	This entry shows the current size in Allocation Units of the WriteBooster FIFO
+		Buffer size.
+		The attribute is read only.

Minor: please drop the redundant trailing "size" in "WriteBooster FIFO Buffer size" in both descriptions above.

Documentation/ABI/testing/sysfs-driver-ufs Description: · line 1847

Quoted 7 lines
Documentation/ABI/testing/sysfs-driver-ufs +7 -0
+What:		/sys/bus/platform/drivers/ufshcd/*/attributes/wb_pinned_avail_pct
+What:		/sys/bus/platform/devices/*.ufs/attributes/wb_pinned_avail_pct
+Date:		June 2026
+Contact:	Daniel Lee <[email protected]>
+Description:	This entry shows the percentage of available space remaining in the
+		Pinned WriteBooster buffer.
+		The attribute is read-only.

Per JESD220G Table 14.28 (IDN 43h, bPinnedWriteBoosterBufferAvailablePercentage), this value is reported in 10% granularity (00h: 0%, 01h-09h: 10%-90%, 0Ah: 100%), not 0-100%. Please document the 10% granularity so userspace does not misinterpret 0x0000000A as 10%.

Documentation/ABI/testing/sysfs-driver-ufs Description: · line 1855

Quoted 7 lines
Documentation/ABI/testing/sysfs-driver-ufs +7 -0
+What:	 /sys/bus/platform/drivers/ufshcd/*/attributes/wb_pinned_cumulative_write_size
+What:	 /sys/bus/platform/devices/*.ufs/attributes/wb_pinned_cumulative_write_size
+Date:		June 2026
+Contact:	Daniel Lee <[email protected]>
+Description:	This entry shows the total cumulative size of data written to the
+		Pinned WriteBooster buffer.
+		The attribute is read-only.

Please state the unit here: per JESD220G Table 14.28 (IDN 44h), this value is in units of 10 MB (and saturates at 0xFFFFFFFF).

Quoted 4 lines
Documentation/ABI/testing/sysfs-driver-ufs +4 -0
+What:		/sys/bus/platform/drivers/ufshcd/*/flags/wb_unpin_enable
+What:		/sys/bus/platform/devices/*.ufs/flags/wb_unpin_enable
+Date:		June 2026
+Contact:	Daniel Lee <[email protected]>

Documentation/ABI/testing/sysfs-driver-ufs Description: · line 1878

Quoted 10 lines
Documentation/ABI/testing/sysfs-driver-ufs +10 -0
+Description:	This entry controls the Pinned WriteBooster unpin enable flag (fUnpinEn).
+
+		====== ==============================================================
+		0        Unpin Disable: pinned data is not flushed by WriteBooster
+		         Buffer flush operation.
+		1        Unpin Enable: pinned data is flushed by WriteBooster
+		         Buffer flush operation.
+		====== ==============================================================
+
+		The attribute is read-write.

ufs_sysfs_flag_show() emits "false" or "true" via str_true_false(flag), not 0 or 1, while ufs_sysfs_flag_store() accepts any kstrtobool() value (0/1, false/true, n/y, off/on). Please update this description so it accurately reflects what reading returns and what writing accepts.

drivers/ufs/core/ufs-sysfs.c static const struct attribute_group ufs_sysfs_string_descriptors_group = { · line 1540

Quoted 8 lines

static inline bool ufshcd_is_wb_flags(enum flag_idn idn) {

drivers/ufs/core/ufs-sysfs.c +4 -2
-	return idn >= QUERY_FLAG_IDN_WB_EN &&
-		idn <= QUERY_FLAG_IDN_WB_BUFF_FLUSH_DURING_HIBERN8;
+	return (idn >= QUERY_FLAG_IDN_WB_EN &&
+		idn <= QUERY_FLAG_IDN_WB_BUFF_FLUSH_DURING_HIBERN8) ||
+	       idn == QUERY_FLAG_IDN_WB_UNPIN_EN;
+}

Per JESD220G Table 14.26, fUnpinEn (13h) has Type "D" (device-level, addressed with INDEX = 00h and SELECTOR = 00h per Note 1), unlike flags 0Eh-10h which are "A/LU/0 or D" (Note 4). Including QUERY_FLAG_IDN_WB_UNPIN_EN here will send a non-zero INDEX when WriteBooster uses an LU-dedicated buffer on a non-zero LUN. Please leave ufshcd_is_wb_flags() unchanged.

drivers/ufs/core/ufs-sysfs.c static DEVICE_ATTR_RW(max_number_of_rtt); · line 1740

Quoted 9 lines

static inline bool ufshcd_is_wb_attrs(enum attr_idn idn) {

drivers/ufs/core/ufs-sysfs.c +4 -2
-	return idn >= QUERY_ATTR_IDN_WB_FLUSH_STATUS &&
-		idn <= QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE;
+	return (idn >= QUERY_ATTR_IDN_WB_FLUSH_STATUS &&
+		idn <= QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE) ||
+	       (idn >= QUERY_ATTR_IDN_WB_PFM &&
+		idn <= QUERY_ATTR_IDN_NON_PINNED_WB_MIN_SIZE);
 }

Same issue here. Per JESD220G Table 14.28:
- 3Fh (bWriteBoosterBufferPartialFlushMode),
42h (dPinnedWriteBoosterBufferCurrentAllocUnits),
43h (bPinnedWriteBoosterBufferAvailablePercentage), and 44h (dPinnedWriteBoosterCummulativeWrittenSize) are Type "D" (INDEX =
00h).
- Only 40h, 41h, 45h, and 46h are "A/LU/0 or D" (Note 15).

Please restrict ufshcd_is_wb_attrs() to the LU-indexed attributes (1Ch-1Fh, 40h-41h, and 45h-46h).

drivers/ufs/core/ufs-sysfs.c static ssize_t wb_resize_status_show(struct device *dev, · line 1856

Quoted 11 lines
drivers/ufs/core/ufs-sysfs.c +11 -0
+static ssize_t ufs_sysfs_attr_store(struct device *dev,
+	struct device_attribute *attr, const char *buf, size_t count,
+	enum attr_idn idn)
+{
+	struct ufs_hba *hba = dev_get_drvdata(dev);
+	u8 index = 0;
+	u32 value;
+	int ret;
+
+	if (kstrtou32(buf, 0, &value))
+		return -EINVAL;

Since ufs_sysfs_attr_show() supports 64-bit attributes via ufshcd_is_qword_attr(idn), please either support ufshcd_is_qword_attr(idn) here as well or guard against it (e.g. WARN_ON_ONCE) so a future UFS_ATTRIBUTE_RW() user for a 64-bit attribute cannot silently issue a 32-bit query.

drivers/ufs/core/ufs-sysfs.c UFS_ATTRIBUTE(wb_avail_buf, _AVAIL_WB_BUFF_SIZE); · line 1935

Quoted 4 lines
drivers/ufs/core/ufs-sysfs.c +4 -0
+	ufshcd_rpm_get_sync(hba);
+	ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
+		QUERY_ATTR_IDN_WB_PFM, ufshcd_wb_get_query_index(hba), 0, &value);
+	ufshcd_rpm_put_sync(hba);

Since QUERY_ATTR_IDN_WB_PFM (3Fh) is Type "D" per JESD220G Table 14.28, please pass 0 instead of ufshcd_wb_get_query_index(hba) here and in wb_partial_flush_mode_store().

Also, unlike wb_resize_hint / wb_resize_status / wb_resize_enable, none of the new entries check hba->dev_info.ext_wb_sup (wExtendedWriteBoosterSupport:
BIT(1) for FIFO Partial Flush Mode and BIT(2) for Pinned Partial Flush Mode per JESD220G Table 14.4, plus hba->dev_info.b_presrv_uspc_en for Pinned mode per Section 13.4.18.7). Should we define those capability bits in include/ufs/ufs.h and check them (returning -EOPNOTSUPP or hiding unsupported attributes via .is_visible) rather than waking the device and issuing unsupported queries on devices without these features?

include/ufs/ufs.h enum attr_idn { · line 205

Quoted 1 line
include/ufs/ufs.h +1 -0
+	QUERY_ATTR_IDN_PINNED_WB_CUMMULATIVE_WS	= 0x44,

Please spell this CUMULATIVE (single 'M'), matching the sysfs attribute name wb_pinned_cumulative_write_size and JESD220G Section 13.4.18.7.2.

Thanks,

Bart.

author
#2 lore raw
Quoted 104 lines · Bart Van Assche
Quoted 1 line · Daniel Lee

+What:

/sys/bus/platform/drivers/ufshcd/*/attributes/wb_partial_flush_mode

Documentation/ABI/testing/sysfs-driver-ufs Description:

Quoted 4 lines
Documentation/ABI/testing/sysfs-driver-ufs +4 -0
+What:               /sys/bus/platform/devices/*.ufs/attributes/wb_partial_flush_mode
+Date:               June 2026
+Contact:    Daniel Lee <[email protected]>
+Description:        This entry controls Extended WriteBooster partial flush

modes.

Documentation/ABI/testing/sysfs-driver-ufs Description: · line 1807

Quoted 8 lines
Documentation/ABI/testing/sysfs-driver-ufs +8 -0
+
+            ======== ==============================
+            "none"   No partial flush
+            "fifo"   FIFO mode
+            "pinned" Pinned mode
+            ======== ==============================
+
+            The attribute is read-write.

Please update the Date: field across the new ABI entries (June 2026 has passed).

Also, please drop the quotes around "none", "fifo", and "pinned" to match the other string attributes in this file (such as wb_resize_hint, wb_resize_status, and hid/state), since literal quotes are neither emitted nor accepted.

Quoted 1 line

+Description: This entry configures the maximum size in Allocation

Units reserved for the

Documentation/ABI/testing/sysfs-driver-ufs Description:

Quoted 8 lines
Documentation/ABI/testing/sysfs-driver-ufs +8 -0
+            WriteBooster FIFO Buffer size.
+            The attribute is read-write.
+
+What:               /sys/bus/platform/drivers/ufshcd/*/attributes/wb_cur_fifo_size
+What:               /sys/bus/platform/devices/*.ufs/attributes/wb_cur_fifo_size
+Date:               June 2026
+Contact:    Daniel Lee <[email protected]>
+Description:        This entry shows the current size in Allocation Units

of the WriteBooster FIFO

Documentation/ABI/testing/sysfs-driver-ufs Description: · line 1823

Quoted 2 lines
Documentation/ABI/testing/sysfs-driver-ufs +2 -0
+            Buffer size.
+            The attribute is read only.

Minor: please drop the redundant trailing "size" in "WriteBooster FIFO Buffer size" in both descriptions above.

Documentation/ABI/testing/sysfs-driver-ufs Description:

Quoted 5 lines
Documentation/ABI/testing/sysfs-driver-ufs +5 -0
+What:               /sys/bus/platform/drivers/ufshcd/*/attributes/wb_pinned_avail_pct
+What:               /sys/bus/platform/devices/*.ufs/attributes/wb_pinned_avail_pct
+Date:               June 2026
+Contact:    Daniel Lee <[email protected]>
+Description:        This entry shows the percentage of available space

remaining in the

Review

Quoted 2 lines
(quoted diff) +2 -0
+            Pinned WriteBooster buffer.
+            The attribute is read-only.

Per JESD220G Table 14.28 (IDN 43h, bPinnedWriteBoosterBufferAvailablePercentage),
this value is reported in 10% granularity (00h: 0%, 01h-09h: 10%-90%, 0Ah: 100%), not 0-100%. Please document the 10% granularity so userspace does not misinterpret 0x0000000A as 10%.

Quoted 1 line

+What:

/sys/bus/platform/drivers/ufshcd/*/attributes/wb_pinned_cumulative_write_size

Quoted 1 line

+What:

/sys/bus/platform/devices/*.ufs/attributes/wb_pinned_cumulative_write_size

Documentation/ABI/testing/sysfs-driver-ufs Description:

Quoted 3 lines
Documentation/ABI/testing/sysfs-driver-ufs +3 -0
+Date:               June 2026
+Contact:    Daniel Lee <[email protected]>
+Description:        This entry shows the total cumulative size of data

written to the

Review

Quoted 2 lines
(quoted diff) +2 -0
+            Pinned WriteBooster buffer.
+            The attribute is read-only.

Please state the unit here: per JESD220G Table 14.28 (IDN 44h), this value is in units of 10 MB (and saturates at 0xFFFFFFFF).

Documentation/ABI/testing/sysfs-driver-ufs Description:

Quoted 5 lines
Documentation/ABI/testing/sysfs-driver-ufs +5 -0
+What:               /sys/bus/platform/drivers/ufshcd/*/flags/wb_unpin_enable
+What:               /sys/bus/platform/devices/*.ufs/flags/wb_unpin_enable
+Date:               June 2026
+Contact:    Daniel Lee <[email protected]>
+Description:        This entry controls the Pinned WriteBooster unpin

enable flag (fUnpinEn).

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+            ======

==============================================================

Documentation/ABI/testing/sysfs-driver-ufs Description:

Quoted 5 lines
Documentation/ABI/testing/sysfs-driver-ufs +5 -0
+            0        Unpin Disable: pinned data is not flushed by WriteBooster
+                     Buffer flush operation.
+            1        Unpin Enable: pinned data is flushed by WriteBooster
+                     Buffer flush operation.
+            ======

==============================================================

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+            The attribute is read-write.

ufs_sysfs_flag_show() emits "false" or "true" via str_true_false(flag), not 0 or 1, while ufs_sysfs_flag_store() accepts any kstrtobool() value (0/1, false/true, n/y, off/on). Please update this description so it accurately reflects what reading returns and what writing accepts.

drivers/ufs/core/ufs-sysfs.c static const struct attribute_group ufs_sysfs_string_descriptors_group = { · line 1540

Quoted 8 lines

static inline bool ufshcd_is_wb_flags(enum flag_idn idn) {

drivers/ufs/core/ufs-sysfs.c +4 -2
-    return idn >= QUERY_FLAG_IDN_WB_EN &&
-            idn <= QUERY_FLAG_IDN_WB_BUFF_FLUSH_DURING_HIBERN8;
+    return (idn >= QUERY_FLAG_IDN_WB_EN &&
+            idn <= QUERY_FLAG_IDN_WB_BUFF_FLUSH_DURING_HIBERN8) ||
+           idn == QUERY_FLAG_IDN_WB_UNPIN_EN;
+}
Quoted 6 lines

Per JESD220G Table 14.26, fUnpinEn (13h) has Type "D" (device-level, addressed with INDEX = 00h and SELECTOR = 00h per Note 1), unlike flags 0Eh-10h which are "A/LU/0 or D" (Note 4). Including QUERY_FLAG_IDN_WB_UNPIN_EN here will send a non-zero INDEX when WriteBooster uses an LU-dedicated buffer on a non-zero LUN. Please leave ufshcd_is_wb_flags() unchanged.

Thanks for pointing this out.

By the way, the name ufshcd_is_wb_flags() is a bit confusing with the addition of
Type "D" WB flags and attributes, so it might be good to rename it to ufshcd_is_lu_wb_flag().

For v4, I will keep the exisiting names as requested.

Quoted 49 lines

drivers/ufs/core/ufs-sysfs.c static DEVICE_ATTR_RW(max_number_of_rtt); · line 1740

Quoted 10 lines

static inline bool ufshcd_is_wb_attrs(enum attr_idn idn) {

drivers/ufs/core/ufs-sysfs.c +4 -2
-    return idn >= QUERY_ATTR_IDN_WB_FLUSH_STATUS &&
-            idn <= QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE;
+    return (idn >= QUERY_ATTR_IDN_WB_FLUSH_STATUS &&
+            idn <= QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE) ||
+           (idn >= QUERY_ATTR_IDN_WB_PFM &&
+            idn <= QUERY_ATTR_IDN_NON_PINNED_WB_MIN_SIZE);
 }

Same issue here. Per JESD220G Table 14.28:
- 3Fh (bWriteBoosterBufferPartialFlushMode),
42h (dPinnedWriteBoosterBufferCurrentAllocUnits),
43h (bPinnedWriteBoosterBufferAvailablePercentage), and 44h (dPinnedWriteBoosterCummulativeWrittenSize) are Type "D" (INDEX =
00h).
- Only 40h, 41h, 45h, and 46h are "A/LU/0 or D" (Note 15).

Please restrict ufshcd_is_wb_attrs() to the LU-indexed attributes (1Ch-1Fh, 40h-41h, and 45h-46h).

drivers/ufs/core/ufs-sysfs.c static ssize_t wb_resize_status_show(struct device *dev, · line 1856

Quoted 11 lines
drivers/ufs/core/ufs-sysfs.c +11 -0
+static ssize_t ufs_sysfs_attr_store(struct device *dev,
+    struct device_attribute *attr, const char *buf, size_t count,
+    enum attr_idn idn)
+{
+    struct ufs_hba *hba = dev_get_drvdata(dev);
+    u8 index = 0;
+    u32 value;
+    int ret;
+
+    if (kstrtou32(buf, 0, &value))
+            return -EINVAL;

Since ufs_sysfs_attr_show() supports 64-bit attributes via ufshcd_is_qword_attr(idn), please either support ufshcd_is_qword_attr(idn) here as well or guard against it (e.g. WARN_ON_ONCE) so a future UFS_ATTRIBUTE_RW() user for a 64-bit attribute cannot silently issue a 32-bit query.

drivers/ufs/core/ufs-sysfs.c UFS_ATTRIBUTE(wb_avail_buf, _AVAIL_WB_BUFF_SIZE); · line 1935

Quoted 4 lines
drivers/ufs/core/ufs-sysfs.c +4 -0
+    ufshcd_rpm_get_sync(hba);
+    ret = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
+            QUERY_ATTR_IDN_WB_PFM, ufshcd_wb_get_query_index(hba), 0, &value);
+    ufshcd_rpm_put_sync(hba);

Since QUERY_ATTR_IDN_WB_PFM (3Fh) is Type "D" per JESD220G Table 14.28, please pass 0 instead of ufshcd_wb_get_query_index(hba) here and in wb_partial_flush_mode_store().

Quoted 9 lines

Also, unlike wb_resize_hint / wb_resize_status / wb_resize_enable, none of the new entries check hba->dev_info.ext_wb_sup (wExtendedWriteBoosterSupport:
BIT(1) for FIFO Partial Flush Mode and BIT(2) for Pinned Partial Flush Mode per JESD220G Table 14.4, plus hba->dev_info.b_presrv_uspc_en for Pinned mode per Section 13.4.18.7). Should we define those capability bits in include/ufs/ufs.h and check them (returning -EOPNOTSUPP or hiding unsupported attributes via .is_visible) rather than waking the device and issuing unsupported queries on devices without these features?

Agreed. I will define them and return -EOPNOTSUPP when unsupported (matching wb_resize_hint / wb_resize_status / wb_resize_enable).

Thanks,
Daniel

Quoted 9 lines
Quoted 2 lines

+ QUERY_ATTR_IDN_PINNED_WB_CUMMULATIVE_WS = 0x44,

Please spell this CUMULATIVE (single 'M'), matching the sysfs attribute name wb_pinned_cumulative_write_size and JESD220G Section 13.4.18.7.2.

Thanks,

Bart.