Skip to contentSkip to conversation

virtio-can: define out of rage can-id and sdu

PATCH Superseded Matias Ezequiel Vara Larsen 2 participants 3 messages Jun 27, 2024 – Jul 8, 2024

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio-can: define out of rage can-id and sdu

Explain when a message is out of range.

---
v0 -> v1
* Use length of the field wording to indicate out of range
* Add when sdu length is out of range

---
 device-types/can/description.tex | 8 ++++++++
 1 file changed, 8 insertions(+)
device-types/can/description.tex +8 -0
index 2511d9c..fa56abd 100644
@@ -191,6 +191,14 @@ \subsubsection{Controller Mode}\label{sec:Device Types / CAN Device / Device Ope
 invalid state with VIRTIO_CAN_RESULT_NOT_OK in \field{result} and MUST
 NOT schedule the message for transmission.
 
+Note that the \field{can_id} field of a CAN frame is out of range when its
+length is more than 11 bits for standard frames or more than 29 bits for
+extended frames. The length of the \field{sdu} field is out of range when it
+uses more than 8 bytes for standard frames. If the VIRTIO_CAN_F_CAN_FD feature
+has been negotiated, the lenght of the \field{sdu} field is out of range when
+it uses more than 8 bytes and is not in the set [ 12, 16, 20, 24, 32, 48, 64 ]
+bytes.
+
 If the parameters are valid the message is scheduled for transmission.
 
 If feature VIRTIO_CAN_F_CAN_LATE_TX_ACK has been negotiated the

base-commit: 37c6a406678a5ee891fdf5671298cb4fcfa517f2

Signature · 1 line
2.42.0
#1 lore raw
Quoted 31 lines · Matias Ezequiel Vara Larsen

Explain when a message is out of range.

---
v0 -> v1
* Use length of the field wording to indicate out of range
* Add when sdu length is out of range

---
  device-types/can/description.tex | 8 ++++++++
  1 file changed, 8 insertions(+)
device-types/can/description.tex +8 -0
index 2511d9c..fa56abd 100644
@@ -191,6 +191,14 @@ \subsubsection{Controller Mode}\label{sec:Device Types / CAN Device / Device Ope
  invalid state with VIRTIO_CAN_RESULT_NOT_OK in \field{result} and MUST
  NOT schedule the message for transmission.
 
+Note that the \field{can_id} field of a CAN frame is out of range when its
+length is more than 11 bits for standard frames or more than 29 bits for
+extended frames. The length of the \field{sdu} field is out of range when it
+uses more than 8 bytes for standard frames. If the VIRTIO_CAN_F_CAN_FD feature
+has been negotiated, the lenght of the \field{sdu} field is out of range when
+it uses more than 8 bytes and is not in the set [ 12, 16, 20, 24, 32, 48, 64 ]
+bytes.
+
  If the parameters are valid the message is scheduled for transmission.
 
  If feature VIRTIO_CAN_F_CAN_LATE_TX_ACK has been negotiated the
Quoted 1 line

base-commit: 37c6a406678a5ee891fdf5671298cb4fcfa517f2

"If the VIRTIO_CAN_F_CAN_FD feature has been negotiated, ..."

Would mean that sending a CAN classic frame having an sdu length > 8 over a virtio CAN device capable to send also CAN FD frames would be allowed. This is not the case. The condition is the type of the actual CAN frame to be sent.

Decisive for CAN classic / CAN FD is the presence or absence of VIRTIO_CAN_FLAGS_FD in the flags.

Having an automatism to change a CAN classic frame to a CAN FD frame or the other way around under some conditions is not in the spec.

For example: "If the VIRTIO_CAN_FLAGS_FD bit is set in the \field{flags}, ..."

Or "If the frame is a CAN FD frame, ..."

#2 lore raw
Quoted 43 lines · Harald Mommer
Quoted 29 lines · Matias Ezequiel Vara Larsen

Explain when a message is out of range.

---
v0 -> v1
* Use length of the field wording to indicate out of range
* Add when sdu length is out of range

---
  device-types/can/description.tex | 8 ++++++++
  1 file changed, 8 insertions(+)
device-types/can/description.tex +8 -0
index 2511d9c..fa56abd 100644
@@ -191,6 +191,14 @@ \subsubsection{Controller Mode}\label{sec:Device Types / CAN Device / Device Ope
  invalid state with VIRTIO_CAN_RESULT_NOT_OK in \field{result} and MUST
  NOT schedule the message for transmission.
+Note that the \field{can_id} field of a CAN frame is out of range when its
+length is more than 11 bits for standard frames or more than 29 bits for
+extended frames. The length of the \field{sdu} field is out of range when it
+uses more than 8 bytes for standard frames. If the VIRTIO_CAN_F_CAN_FD feature
+has been negotiated, the lenght of the \field{sdu} field is out of range when
+it uses more than 8 bytes and is not in the set [ 12, 16, 20, 24, 32, 48, 64 ]
+bytes.
+
  If the parameters are valid the message is scheduled for transmission.
  If feature VIRTIO_CAN_F_CAN_LATE_TX_ACK has been negotiated the
 
Quoted 1 line

base-commit: 37c6a406678a5ee891fdf5671298cb4fcfa517f2

"If the VIRTIO_CAN_F_CAN_FD feature has been negotiated, ..."

Would mean that sending a CAN classic frame having an sdu length > 8 over a virtio CAN device capable to send also CAN FD frames would be allowed. This is not the case. The condition is the type of the actual CAN frame to be sent.

Decisive for CAN classic / CAN FD is the presence or absence of VIRTIO_CAN_FLAGS_FD in the flags.

Quoted 9 lines

Having an automatism to change a CAN classic frame to a CAN FD frame or the other way around under some conditions is not in the spec.

For example: "If the VIRTIO_CAN_FLAGS_FD bit is set in the \field{flags}, ..."

Or "If the frame is a CAN FD frame, ..."

Thanks Harald, I will add it to v2.

Matias