Skip to contentSkip to conversation

arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant

PATCH Applied Patrick Wildt 10 participants 18 messages Jul 15, 2024 – Jan 3, 2025

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

cover arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant

This series adds the missing calibration variant devicetree property which is needed to load the calibration data and use the ath12k wifi on the Lenovo Yoga Slim 7x.

Patrick Wildt (2):
dt-bindings: net: wireless: add ath12k pcie bindings
arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant

 .../net/wireless/qcom,ath12k-pci.yaml         | 59 +++++++++++++++++++
 .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts  |  9 +++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi        | 10 ++++
 3 files changed, 78 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml
Signature · 1 line
2.45.2
#1 lore raw

PATCH 1/2 dt-bindings: net: wireless: add ath12k pcie bindings

Add devicetree bindings for Qualcomm ath12k PCIe devices such as WCN7850 for which the calibration data variant may need to be described.

---
 .../net/wireless/qcom,ath12k-pci.yaml         | 59 +++++++++++++++++++
 1 file changed, 59 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml
Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml new file +59 -0
new file mode 100644
index 000000000000..8f18868ee726
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (c) 2024 Linaro Limited
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k-pci.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies ath12k wireless devices (PCIe)
+
+maintainers:
+  - Kalle Valo <[email protected]>
+  - Jeff Johnson <[email protected]>
+
+description: |
+  Qualcomm Technologies IEEE 802.11ax PCIe devices
+
+properties:
+  compatible:
+    enum:
+      - pci17cb,1107  # WCN7850
+
+  reg:
+    maxItems: 1
+
+  qcom,ath12k-calibration-variant:
+    $ref: /schemas/types.yaml#/definitions/string
+    description: |
+      string to uniquely identify variant of the calibration data for designs
+      with colliding bus and device ids
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    pcie {
+        #address-cells = <3>;
+        #size-cells = <2>;
+
+        pcie@0 {
+            device_type = "pci";
+            reg = <0x0 0x0 0x0 0x0 0x0>;
+            #address-cells = <3>;
+            #size-cells = <2>;
+            ranges;
+
+            bus-range = <0x01 0xff>;
+
+            wifi@0 {
+                compatible = "pci17cb,1107";
+                reg = <0x10000 0x0 0x0 0x0 0x0>;
+
+                qcom,ath12k-calibration-variant = "LES790";
+            };
+        };
+    };
Signature · 1 line
2.45.2
#2 lore raw

Re: [PATCH 1/2] dt-bindings: net: wireless: add ath12k pcie bindings

Quoted 2 lines · Patrick Wildt

Add devicetree bindings for Qualcomm ath12k PCIe devices such as WCN7850 for which the calibration data variant may need to be described.

Hi Patrick

General, the device tree binding and the needed changes to the driver to implement the binding are in the same patchset. I don't see anything implementing qcom,ath12k-calibration-variant here? Does the driver already support this, and you are just fixing up missing documentation?

Andrew

#3 lore raw

Re: [PATCH 1/2] dt-bindings: net: wireless: add ath12k pcie bindings

Am Mon, Jul 15, 2024 at 10:54:18PM +0200 schrieb Andrew Lunn:

Quoted 6 lines · Patrick Wildt
Quoted 2 lines

Add devicetree bindings for Qualcomm ath12k PCIe devices such as WCN7850 for which the calibration data variant may need to be described.

Hi Patrick

Quoted 7 lines

General, the device tree binding and the needed changes to the driver to implement the binding are in the same patchset. I don't see anything implementing qcom,ath12k-calibration-variant here? Does the driver already support this, and you are just fixing up missing documentation?

Andrew

Hi there,

technically I could try and make that change, but I don't actually run this driver or Linux at all; this change is for running OpenBSD on that machine with a correctly defined device tree.

The realities of Linux being the de facto upstream for device tree bindings force me to submit changes here so they end up being usable for other operating systems as well.

I would assume that eventually someone that runs Linux will adjust the ath12k driver as well, because this kind of binding has been used for both ath10k and ath11k and this is just a copy with a name change for ath12k.

Cheers,
Patrick

#4 lore raw

Re: [PATCH 1/2] dt-bindings: net: wireless: add ath12k pcie bindings

Quoted 21 lines · Patrick Wildt

Am Mon, Jul 15, 2024 at 10:54:18PM +0200 schrieb Andrew Lunn:

Quoted 6 lines · Patrick Wildt
Quoted 2 lines

Add devicetree bindings for Qualcomm ath12k PCIe devices such as WCN7850 for which the calibration data variant may need to be described.

Hi Patrick

Quoted 7 lines

General, the device tree binding and the needed changes to the driver to implement the binding are in the same patchset. I don't see anything implementing qcom,ath12k-calibration-variant here? Does the driver already support this, and you are just fixing up missing documentation?

Andrew

Hi there,

technically I could try and make that change, but I don't actually run this driver or Linux at all; this change is for running OpenBSD on that machine with a correctly defined device tree.

Quoted 8 lines

The realities of Linux being the de facto upstream for device tree bindings force me to submit changes here so they end up being usable for other operating systems as well.

I would assume that eventually someone that runs Linux will adjust the ath12k driver as well, because this kind of binding has been used for both ath10k and ath11k and this is just a copy with a name change for ath12k.

Paraphrasing a certain company.. Linux <3 OpenBSD!

Since as you mentioned Linux is the de facto upstream for dt-bindings, many people identify those two.. I think a solution that would keep everyone reasonably happy is dropping a line about your usage in the cover letter

Konrad

#5 lore raw

Re: [PATCH 1/2] dt-bindings: net: wireless: add ath12k pcie bindings

In reply to Patrick Wildt
Quoted 25 lines · Patrick Wildt

Add devicetree bindings for Qualcomm ath12k PCIe devices such as WCN7850 for which the calibration data variant may need to be described.

---
 .../net/wireless/qcom,ath12k-pci.yaml         | 59 +++++++++++++++++++
 1 file changed, 59 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml
Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml new file +10 -0
new file mode 100644
index 000000000000..8f18868ee726
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (c) 2024 Linaro Limited
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k-pci.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies ath12k wireless devices (PCIe)
+
+maintainers:

Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml line 20

Quoted 10 lines
Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml new file +10 -0
+  - Kalle Valo <[email protected]>
+  - Jeff Johnson <[email protected]>
+
+description: |
+  Qualcomm Technologies IEEE 802.11ax PCIe devices
+
+properties:
+  compatible:
+    enum:
+      - pci17cb,1107  # WCN7850

That's a duplicate of:
https://lore.kernel.org/all/[email protected]/

AFAIK, this was already merged. I don't get why after ~1 month it is not in the linux-next.

Best regards,
Krzysztof

#6 lore raw

PATCH 2/2 arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant

In reply to Patrick Wildt

Describe the bus topology for PCIe domain 4 and add the ath12k calibration variant so that the board file (calibration data) can be loaded.

---
 .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts      |  9 +++++++++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi                 | 10 ++++++++++
 2 files changed, 19 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +9 -0
index fbff558f5b07..f569f0fbd1fc 100644
@@ -635,6 +635,15 @@ &pcie4_phy {
 	status = "okay";
 };
 
+&pcie4_port0 {
+	wifi@0 {
+		compatible = "pci17cb,1107";
+		reg = <0x10000 0x0 0x0 0x0 0x0>;
+
+		qcom,ath12k-calibration-variant = "LES790";
+	};
+};
+
 &pcie6a {
 	perst-gpios = <&tlmm 152 GPIO_ACTIVE_LOW>;
 	wake-gpios = <&tlmm 154 GPIO_ACTIVE_LOW>;
arch/arm64/boot/dts/qcom/x1e80100.dtsi +10 -0
index 7bca5fcd7d52..70eeacd4f9ad 100644
@@ -3085,6 +3085,16 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 			phy-names = "pciephy";
 
 			status = "disabled";
+
+			pcie4_port0: pcie@0 {
+				device_type = "pci";
+				reg = <0x0 0x0 0x0 0x0 0x0>;
+				bus-range = <0x01 0xff>;
+
+				#address-cells = <3>;
+				#size-cells = <2>;
+				ranges;
+			};
 		};
 
 		pcie4_phy: phy@1c0e000 {
Signature · 1 line
2.45.2
#7 lore raw
Quoted 15 lines · Patrick Wildt

Describe the bus topology for PCIe domain 4 and add the ath12k calibration variant so that the board file (calibration data) can be loaded.

---
 .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts      |  9 +++++++++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi                 | 10 ++++++++++
 2 files changed, 19 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +0 -0
index fbff558f5b07..f569f0fbd1fc 100644

arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts &pcie4_phy { · line 643

Quoted 9 lines
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +6 -0
@@ -635,6 +635,15 @@ &pcie4_phy {
 	status = "okay";
 };
 
+&pcie4_port0 {
+	wifi@0 {
+		compatible = "pci17cb,1107";
+		reg = <0x10000 0x0 0x0 0x0 0x0>;
+
+		qcom,ath12k-calibration-variant = "LES790";

It doesn't look like it follows the rest of the calibration variants.

Something like "Lenovo_Y7x" or "Lenovo_Yoga7x" sounds more logical.

Quoted 30 lines
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +3 -0
+	};
+};
+
 &pcie6a {
 	perst-gpios = <&tlmm 152 GPIO_ACTIVE_LOW>;
 	wake-gpios = <&tlmm 154 GPIO_ACTIVE_LOW>;
arch/arm64/boot/dts/qcom/x1e80100.dtsi +10 -0
index 7bca5fcd7d52..70eeacd4f9ad 100644
@@ -3085,6 +3085,16 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 			phy-names = "pciephy";
 
 			status = "disabled";
+
+			pcie4_port0: pcie@0 {
+				device_type = "pci";
+				reg = <0x0 0x0 0x0 0x0 0x0>;
+				bus-range = <0x01 0xff>;
+
+				#address-cells = <3>;
+				#size-cells = <2>;
+				ranges;
+			};
 		};
 
 		pcie4_phy: phy@1c0e000 {
Signature · 1 line
2.45.2
Signature · 2 lines
With best wishes
Dmitry
#8 lore raw

Am Tue, Jul 16, 2024 at 12:51:53AM +0300 schrieb Dmitry Baryshkov:

Quoted 28 lines · Patrick Wildt
Quoted 15 lines

Describe the bus topology for PCIe domain 4 and add the ath12k calibration variant so that the board file (calibration data) can be loaded.

---
 .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts      |  9 +++++++++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi                 | 10 ++++++++++
 2 files changed, 19 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +0 -0
index fbff558f5b07..f569f0fbd1fc 100644

arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts &pcie4_phy { · line 643

Quoted 9 lines
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +6 -0
@@ -635,6 +635,15 @@ &pcie4_phy {
 	status = "okay";
 };
 
+&pcie4_port0 {
+	wifi@0 {
+		compatible = "pci17cb,1107";
+		reg = <0x10000 0x0 0x0 0x0 0x0>;
+
+		qcom,ath12k-calibration-variant = "LES790";

It doesn't look like it follows the rest of the calibration variants.

Quoted 1 line

Something like "Lenovo_Y7x" or "Lenovo_Yoga7x" sounds more logical.

This is what's both in the DSDT

  Device (WLN)
  {
    [...]
    Name (BDFE, "BDF_LES790")

and kvalo's board-2.bin for this machine:

  $ strings board-2.bin | grep LES
  bus=pci,vendor=17cb,device=1107,subsystem-vendor=17aa,subsystem-device=e0e9,qmi-chip-id=2,qmi-board-id=255,variant=LES790

I don't think we can hand-pick these strings, they come from whoever decided upon them and fed them into ACPI tables and QC's binaries.

Reviewed-by
#9 lore raw
Quoted 38 lines · Patrick Wildt

Am Tue, Jul 16, 2024 at 12:51:53AM +0300 schrieb Dmitry Baryshkov:

Quoted 28 lines · Patrick Wildt
Quoted 15 lines

Describe the bus topology for PCIe domain 4 and add the ath12k calibration variant so that the board file (calibration data) can be loaded.

---
 .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts      |  9 +++++++++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi                 | 10 ++++++++++
 2 files changed, 19 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +0 -0
index fbff558f5b07..f569f0fbd1fc 100644

arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts &pcie4_phy { · line 643

Quoted 9 lines
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +6 -0
@@ -635,6 +635,15 @@ &pcie4_phy {
 	status = "okay";
 };
 
+&pcie4_port0 {
+	wifi@0 {
+		compatible = "pci17cb,1107";
+		reg = <0x10000 0x0 0x0 0x0 0x0>;
+
+		qcom,ath12k-calibration-variant = "LES790";

It doesn't look like it follows the rest of the calibration variants.

Quoted 1 line

Something like "Lenovo_Y7x" or "Lenovo_Yoga7x" sounds more logical.

This is what's both in the DSDT

  Device (WLN)
  {
    [...]
    Name (BDFE, "BDF_LES790")
Quoted 7 lines

and kvalo's board-2.bin for this machine:

  $ strings board-2.bin | grep LES
  bus=pci,vendor=17cb,device=1107,subsystem-vendor=17aa,subsystem-device=e0e9,qmi-chip-id=2,qmi-board-id=255,variant=LES790

I don't think we can hand-pick these strings, they come from whoever decided upon them and fed them into ACPI tables and QC's binaries.

Huh, great nod from qca!
Looks like there's even a bit more hw supported in there..

Konrad

#10 lore raw
Quoted 44 lines · Konrad Dybcio
Quoted 43 lines · Patrick Wildt

Am Tue, Jul 16, 2024 at 12:51:53AM +0300 schrieb Dmitry Baryshkov:

Quoted 28 lines · Patrick Wildt
Quoted 15 lines

Describe the bus topology for PCIe domain 4 and add the ath12k calibration variant so that the board file (calibration data) can be loaded.

---
 .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts      |  9 +++++++++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi                 | 10 ++++++++++
 2 files changed, 19 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +0 -0
index fbff558f5b07..f569f0fbd1fc 100644

arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts &pcie4_phy { · line 643

Quoted 9 lines
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +6 -0
@@ -635,6 +635,15 @@ &pcie4_phy {
 	status = "okay";
 };
 
+&pcie4_port0 {
+	wifi@0 {
+		compatible = "pci17cb,1107";
+		reg = <0x10000 0x0 0x0 0x0 0x0>;
+
+		qcom,ath12k-calibration-variant = "LES790";

It doesn't look like it follows the rest of the calibration variants.

Quoted 1 line

Something like "Lenovo_Y7x" or "Lenovo_Yoga7x" sounds more logical.

This is what's both in the DSDT

  Device (WLN)
  {
    [...]
    Name (BDFE, "BDF_LES790")

and kvalo's board-2.bin for this machine:

  $ strings board-2.bin | grep LES
  bus=pci,vendor=17cb,device=1107,subsystem-vendor=17aa,subsystem-device=e0e9,qmi-chip-id=2,qmi-board-id=255,variant=LES790
Quoted 7 lines
Quoted 2 lines

I don't think we can hand-pick these strings, they come from whoever decided upon them and fed them into ACPI tables and QC's binaries.

Huh, great nod from qca!
Looks like there's even a bit more hw supported in there..

Ref: https://git.codelinaro.org/clo/ath-firmware/ath12k-firmware/-/blob/main/WCN7850/hw2.0/board-2.bin

Konrad

Reviewed-by
#11 lore raw
In reply to Patrick Wildt
Quoted 38 lines · Patrick Wildt

Am Tue, Jul 16, 2024 at 12:51:53AM +0300 schrieb Dmitry Baryshkov:

Quoted 28 lines · Patrick Wildt
Quoted 15 lines

Describe the bus topology for PCIe domain 4 and add the ath12k calibration variant so that the board file (calibration data) can be loaded.

---
 .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts      |  9 +++++++++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi                 | 10 ++++++++++
 2 files changed, 19 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +0 -0
index fbff558f5b07..f569f0fbd1fc 100644

arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts &pcie4_phy { · line 643

Quoted 9 lines
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +6 -0
@@ -635,6 +635,15 @@ &pcie4_phy {
 	status = "okay";
 };
 
+&pcie4_port0 {
+	wifi@0 {
+		compatible = "pci17cb,1107";
+		reg = <0x10000 0x0 0x0 0x0 0x0>;
+
+		qcom,ath12k-calibration-variant = "LES790";

It doesn't look like it follows the rest of the calibration variants.

Quoted 1 line

Something like "Lenovo_Y7x" or "Lenovo_Yoga7x" sounds more logical.

This is what's both in the DSDT

  Device (WLN)
  {
    [...]
    Name (BDFE, "BDF_LES790")
Quoted 7 lines

and kvalo's board-2.bin for this machine:

  $ strings board-2.bin | grep LES
  bus=pci,vendor=17cb,device=1107,subsystem-vendor=17aa,subsystem-device=e0e9,qmi-chip-id=2,qmi-board-id=255,variant=LES790

I don't think we can hand-pick these strings, they come from whoever decided upon them and fed them into ACPI tables and QC's binaries.

Ack, if Kalle has already selected this string, we can't argue.

Signature · 2 lines
With best wishes
Dmitry
Reviewed-by on v1 2/2
#12 lore raw
In reply to Patrick Wildt
Quoted 5 lines · Patrick Wildt

Describe the bus topology for PCIe domain 4 and add the ath12k calibration variant so that the board file (calibration data) can be loaded.

- Mani

Quoted 50 lines
---
 .../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts      |  9 +++++++++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi                 | 10 ++++++++++
 2 files changed, 19 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +9 -0
index fbff558f5b07..f569f0fbd1fc 100644
@@ -635,6 +635,15 @@ &pcie4_phy {
 	status = "okay";
 };
 
+&pcie4_port0 {
+	wifi@0 {
+		compatible = "pci17cb,1107";
+		reg = <0x10000 0x0 0x0 0x0 0x0>;
+
+		qcom,ath12k-calibration-variant = "LES790";
+	};
+};
+
 &pcie6a {
 	perst-gpios = <&tlmm 152 GPIO_ACTIVE_LOW>;
 	wake-gpios = <&tlmm 154 GPIO_ACTIVE_LOW>;
arch/arm64/boot/dts/qcom/x1e80100.dtsi +10 -0
index 7bca5fcd7d52..70eeacd4f9ad 100644
@@ -3085,6 +3085,16 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 			phy-names = "pciephy";
 
 			status = "disabled";
+
+			pcie4_port0: pcie@0 {
+				device_type = "pci";
+				reg = <0x0 0x0 0x0 0x0 0x0>;
+				bus-range = <0x01 0xff>;
+
+				#address-cells = <3>;
+				#size-cells = <2>;
+				ranges;
+			};
 		};
 
 		pcie4_phy: phy@1c0e000 {
Signature · 1 line
2.45.2
Signature · 1 line
மணிவண்ணன் சதாசிவம்
#13 lore raw
In reply to Patrick Wildt
Quoted 6 lines · Patrick Wildt

Describe the bus topology for PCIe domain 4 and add the ath12k calibration variant so that the board file (calibration data) can be loaded.

+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi

arch/arm64/boot/dts/qcom/x1e80100.dtsi &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, · line 3092

Quoted 8 lines
arch/arm64/boot/dts/qcom/x1e80100.dtsi +5 -0
@@ -3085,6 +3085,16 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 			phy-names = "pciephy";
 
 			status = "disabled";
+
+			pcie4_port0: pcie@0 {
+				device_type = "pci";
+				reg = <0x0 0x0 0x0 0x0 0x0>;
+				bus-range = <0x01 0xff>;

Hi Patrick, what's the purpose of this bus-range? IIUC this describes a Root Port, where we can read and configure the secondary/subordinate bus numbers from the RP config space, so it seems like we don't need to describe them here.

Quoted 10 lines
arch/arm64/boot/dts/qcom/x1e80100.dtsi +4 -0
+				#address-cells = <3>;
+				#size-cells = <2>;
+				ranges;
+			};
 		};
 
 		pcie4_phy: phy@1c0e000 {
Signature · 1 line
2.45.2
#14 lore raw
In reply to Patrick Wildt
Quoted 8 lines · Patrick Wildt

This series adds the missing calibration variant devicetree property which is needed to load the calibration data and use the ath12k wifi on the Lenovo Yoga Slim 7x.

Patrick Wildt (2):
dt-bindings: net: wireless: add ath12k pcie bindings
arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant

Quoted 6 lines
 .../net/wireless/qcom,ath12k-pci.yaml         | 59 +++++++++++++++++++
 .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts  |  9 +++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi        | 10 ++++
 3 files changed, 78 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml

+ath12k mailing list.

Qualcomm expects, on x86 and Qualcomm-based ARM devices, that this information come from ACPI.

That support is currently under review:
https://lore.kernel.org/all/[email protected]/

/jeff

#15 lore raw
Quoted 17 lines · Jeff Johnson
Quoted 8 lines · Patrick Wildt

This series adds the missing calibration variant devicetree property which is needed to load the calibration data and use the ath12k wifi on the Lenovo Yoga Slim 7x.

Patrick Wildt (2):
dt-bindings: net: wireless: add ath12k pcie bindings
arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant

Quoted 6 lines
 .../net/wireless/qcom,ath12k-pci.yaml         | 59 +++++++++++++++++++
 .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts  |  9 +++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi        | 10 ++++
 3 files changed, 78 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml
Quoted 4 lines

+ath12k mailing list.

Qualcomm expects, on x86 and Qualcomm-based ARM devices, that this information come from ACPI.

That is fine for acpi boot. But it never prevented adding needed information in dt.

BR,
-R

Quoted 5 lines

That support is currently under review:
https://lore.kernel.org/all/[email protected]/

/jeff

#16 lore raw
In reply to Jeff Johnson
Quoted 16 lines · Jeff Johnson
Quoted 8 lines · Patrick Wildt

This series adds the missing calibration variant devicetree property which is needed to load the calibration data and use the ath12k wifi on the Lenovo Yoga Slim 7x.

Patrick Wildt (2):
dt-bindings: net: wireless: add ath12k pcie bindings
arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant

Quoted 6 lines
 .../net/wireless/qcom,ath12k-pci.yaml         | 59 +++++++++++++++++++
 .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts  |  9 +++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi        | 10 ++++
 3 files changed, 78 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml
Quoted 4 lines

+ath12k mailing list.

Qualcomm expects, on x86 and Qualcomm-based ARM devices, that this information come from ACPI.

Unfortunately we can not use ACPI on Qualcomm-based ARM devices. They all are manually converted to DT.

Quoted 5 lines

That support is currently under review:
https://lore.kernel.org/all/[email protected]/

/jeff

Signature · 2 lines
With best wishes
Dmitry
maintainer Applied
#17 lore raw

Re: (subset) [PATCH 0/2] arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant

In reply to Patrick Wildt
Quoted 9 lines · Patrick Wildt

This series adds the missing calibration variant devicetree property which is needed to load the calibration data and use the ath12k wifi on the Lenovo Yoga Slim 7x.

Patrick Wildt (2):
dt-bindings: net: wireless: add ath12k pcie bindings
arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant

[...]

Applied, thanks!

[2/2] arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant

      commit: 8bc7cb73df8644423758c79d4504d501c8ef3854

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>