platform/x86/intel: Fix pmt_crashlog array reference
Subsystems (2)
PATCH 1/1 platform/x86/intel: Fix pmt_crashlog array reference
The probe function pmt_crashlog_probe() may incorrectly reference the 'priv->entry array' as it uses 'i' to reference the array instead of 'priv->num_entries' as it should. This is similar to the problem that was addressed in pmt_telemetry_probe via commit 2cdfa0c20d58 ("platform/x86/intel: Fix 'rmmod pmt_telemetry' panic").
--- drivers/platform/x86/intel/pmt/crashlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel/pmt/crashlog.c +1 -1
@@ -282,7 +282,7 @@ static int pmt_crashlog_probe(struct auxiliary_device *auxdev,auxiliary_set_drvdata (auxdev, priv);for (i =0 ; i < intel_vsec_dev->num_resources; i++) { -struct intel_pmt_entry *entry = &priv->entry[i].entry; +struct intel_pmt_entry *entry = &priv->entry[priv->num_entries].entry; ret =intel_pmt_dev_create (entry, &pmt_crashlog_ns, intel_vsec_dev, i);if (ret <0 )
Signature · 1 line
2.27.0
Quoted 29 lines · David Arcari
The probe function
pmt_crashlog_probe()may incorrectly reference the 'priv->entryarray' as it uses 'i' to reference the array instead of 'priv->num_entries' as it should. This is similar to the problem that was addressed inpmt_telemetry_probevia commit2cdfa0c20d58("platform/x86/intel: Fix 'rmmodpmt_telemetry' panic").Cc "David E. Box" <[email protected]>Cc Hans de Goede <[email protected]>Cc Mark Gross <[email protected]>Signed-off-by David Arcari <[email protected]>--- drivers/platform/x86/intel/pmt/crashlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/intel/pmt/crashlog.c +1
-1@@ -282,7 +282,7 @@ static int pmt_crashlog_probe(struct auxiliary_device *auxdev,auxiliary_set_drvdata (auxdev, priv);for (i =0 ; i < intel_vsec_dev->num_resources; i++) { -struct intel_pmt_entry *entry = &priv->entry[i].entry; +struct intel_pmt_entry *entry = &priv->entry[priv- >num_entries].entry;
Quoted 3 lines
ret = intel_pmt_dev_create(entry,
&pmt_crashlog_ns,intel_vsec_dev, i);
if (ret < 0)
Thanks
Hi,
Quoted 11 lines · David Arcari
The probe function
pmt_crashlog_probe()may incorrectly reference the 'priv->entryarray' as it uses 'i' to reference the array instead of 'priv->num_entries' as it should. This is similar to the problem that was addressed inpmt_telemetry_probevia commit2cdfa0c20d58("platform/x86/intel: Fix 'rmmodpmt_telemetry' panic").Cc "David E. Box" <[email protected]>Cc Hans de Goede <[email protected]>Cc Mark Gross <[email protected]>Signed-off-by David Arcari <[email protected]>
Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.
Regards,
Hans
Quoted 17 lines
--- drivers/platform/x86/intel/pmt/crashlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/intel/pmt/crashlog.c +1
-1@@ -282,7 +282,7 @@ static int pmt_crashlog_probe(struct auxiliary_device *auxdev,auxiliary_set_drvdata (auxdev, priv);for (i =0 ; i < intel_vsec_dev->num_resources; i++) { -struct intel_pmt_entry *entry = &priv->entry[i].entry; +struct intel_pmt_entry *entry = &priv->entry[priv->num_entries].entry; ret =intel_pmt_dev_create (entry, &pmt_crashlog_ns, intel_vsec_dev, i);if (ret <0 )