Skip to contentSkip to conversation

m68knommu: Fix warnings in io_no.h: Delete one of repeated word 'readw readl writew writel' in comment. WARNING: Possible repeated word: 'readw' WARNING: Possible repeated word: 'readl' WARNING: Possible repeated word: 'writew' WARNING: Possible repeated word: 'writel'

PATCH In review [email protected] 2 participants 2 messages Jul 24, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 m68knommu: Fix warnings in io_no.h: Delete one of repeated word 'readw readl writew writel' in comment. WARNING: Possible repeated word: 'readw' WARNING: Possible repeated word: 'readl' WARNING: Possible repeated word: 'writew' WARNING: Possible repeated word: 'writel'

---
 arch/m68k/include/asm/io_no.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/m68k/include/asm/io_no.h +4 -4
index 2c96e8480173..b24eb741e666 100644
@@ -62,7 +62,7 @@ static int cf_internalio(const volatile void __iomem *addr)
  * endian on m68k/ColdFire. Bus based address ranges, like the PCI bus,
  * are accessed little endian - so we need to byte swap those.
  */
-#define readw readw
+#define readw
 static inline u16 readw(const volatile void __iomem *addr)
 {
     if (cf_internalio(addr))
@@ -70,7 +70,7 @@ static inline u16 readw(const volatile void __iomem *addr)
     return swab16(__raw_readw(addr));
 }
 
-#define readl readl
+#define readl
 static inline u32 readl(const volatile void __iomem *addr)
 {
     if (cf_internalio(addr))
@@ -78,7 +78,7 @@ static inline u32 readl(const volatile void __iomem *addr)
     return swab32(__raw_readl(addr));
 }
 
-#define writew writew
+#define writew
 static inline void writew(u16 value, volatile void __iomem *addr)
 {
     if (cf_internalio(addr))
@@ -87,7 +87,7 @@ static inline void writew(u16 value, volatile void __iomem *addr)
         __raw_writew(swab16(value), addr);
 }
 
-#define writel writel
+#define writel
 static inline void writel(u32 value, volatile void __iomem *addr)
 {
     if (cf_internalio(addr))
#2 lore raw

Hi,

please reconsider - "#define something something" is legitimate use, and quite intentional.

Pattern matching can only get you so far, sorry ...

Cheers,

    Michael

Am 24.07.23 um 12:40 schrieb [email protected]:

Quoted 50 lines

---
 arch/m68k/include/asm/io_no.h | 8 ++++----

 1 file changed, 4 insertions(+), 4 deletions(-)
arch/m68k/include/asm/io_no.h +1 -1
index 2c96e8480173..b24eb741e666 100644
@@ -62,7 +62,7 @@ static int cf_internalio(const volatile void __iomem
 *addr)
   * endian on m68k/ColdFire. Bus based address ranges, like the PCI bus,
   * are accessed little endian - so we need to byte swap those.
   */
-#define readw readw
+#define readw
  static inline u16 readw(const volatile void __iomem *addr)
  {

     if (cf_internalio(addr))

arch/m68k/include/asm/io_no.h +1 -1
@@ -70,7 +70,7 @@ static inline u16 readw(const volatile void __iomem
 *addr)
      return swab16(__raw_readw(addr));
  }
 
-#define readl readl
+#define readl
  static inline u32 readl(const volatile void __iomem *addr)
  {

     if (cf_internalio(addr))

arch/m68k/include/asm/io_no.h +1 -1
@@ -78,7 +78,7 @@ static inline u32 readl(const volatile void __iomem
 *addr)
      return swab32(__raw_readl(addr));
  }
 
-#define writew writew
+#define writew
  static inline void writew(u16 value, volatile void __iomem *addr)
  {

     if (cf_internalio(addr))

arch/m68k/include/asm/io_no.h +1 -1
@@ -87,7 +87,7 @@ static inline void writew(u16 value, volatile void
 __iomem *addr)
          __raw_writew(swab16(value), addr);
  }
 
-#define writel writel
+#define writel
  static inline void writel(u32 value, volatile void __iomem *addr)
  {

     if (cf_internalio(addr))