media: platform: mtk-mdp3: fix Kconfig dependencies
Subsystems (2)
PATCH 1/1 media: platform: mtk-mdp3: fix Kconfig dependencies
From: Arnd Bergmann <[email protected]>
The new mdp3 driver uses 'select' to force-enable a couple of drivers it depends on. This is error-prone and likely to cause dependency loops as well as warnings like:
WARNING: unmet direct dependencies detected for VIDEO_MEDIATEK_VPU
Depends on [n]: MEDIA_SUPPORT [=m] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_MEM2MEM_DRIVERS [=n] && VIDEO_DEV [=m] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=y])
Selected by [m]:
- VIDEO_MEDIATEK_MDP3 [=m] && MEDIA_SUPPORT [=m] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && (MTK_IOMMU [=m] || COMPILE_TEST [=y]) && VIDEO_DEV [=m] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=y]) && HAS_DMA [=y] && REMOTEPROC [=y]
This specific warning was already addressed in a previous patch, but there are similar unnecessary 'select' statements, so turn those into 'depends on'. This also means the dependency on ARCH_MEDIATEK is redundant and can be dropped.
--- drivers/media/platform/mediatek/mdp3/Kconfig | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/media/platform/mediatek/mdp3/Kconfig +3 -4
@@ -3,14 +3,13 @@ config VIDEO_MEDIATEK_MDP3 tristate "MediaTek MDP v3 driver" depends on MTK_IOMMU || COMPILE_TEST depends on VIDEO_DEV - depends on ARCH_MEDIATEK || COMPILE_TEST depends on HAS_DMA depends on REMOTEPROC + depends on MTK_MMSYS + depends on MTK_CMDQ + depends on MTK_SCP select VIDEOBUF2_DMA_CONTIG select V4L2_MEM2MEM_DEV - select MTK_MMSYS - select MTK_CMDQ - select MTK_SCP default n help It is a v4l2 driver and present in MediaTek MT8183 SoC.
Signature · 1 line
2.35.1
Il 15/12/22 17:40, Arnd Bergmann ha scritto:
Quoted 11 lines
From: Arnd Bergmann <[email protected]>
The new mdp3 driver uses 'select' to force-enable a couple of drivers it depends on. This is error-prone and likely to cause dependency loops as well as warnings like:
WARNING: unmet direct dependencies detected for
VIDEO_MEDIATEK_VPU
Depends on [n]:MEDIA_SUPPORT[=m] &&MEDIA_PLATFORM_SUPPORT[=y] &&MEDIA_PLATFORM_DRIVERS[=y] &&V4L_MEM2MEM_DRIVERS[=n] &&VIDEO_DEV[=m] && (ARCH_MEDIATEK[=y] ||COMPILE_TEST[=y])
Selected by [m]:
-VIDEO_MEDIATEK_MDP3[=m] &&MEDIA_SUPPORT[=m] &&MEDIA_PLATFORM_SUPPORT[=y] &&MEDIA_PLATFORM_DRIVERS[=y] && (MTK_IOMMU[=m] ||COMPILE_TEST[=y]) &&VIDEO_DEV[=m] && (ARCH_MEDIATEK[=y] ||COMPILE_TEST[=y]) &&HAS_DMA[=y] && REMOTEPROC [=y]
Quoted 8 lines
This specific warning was already addressed in a previous patch, but there are similar unnecessary 'select' statements, so turn those into 'depends on'. This also means the dependency on
ARCH_MEDIATEKis redundant and can be dropped.Fixes 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")Fixes 9195a860ef0a ("media: platform: mtk-mdp3: remove unused VIDEO_MEDIATEK_VPU config")Signed-off-by Arnd Bergmann <[email protected]>