leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908
Subsystems (2)
PATCH 1/1 leds: bcm63138: refer to ARCH_BCMBCA instead of ARCH_BCM4908
Commit dd5c672d7ca9 ("arm64: bcmbca: Merge ARCH_BCM4908 to ARCH_BCMBCA") removes config ARCH_BCM4908 as config ARCH_BCMBCA has the same intent.
Probably due to concurrent development, commit a0ba692072d8 ("leds:
bcm63138: add support for BCM63138 controller") introduces 'LED Support for Broadcom BCM63138 SoC' that depends on ARCH_BCM4908, but this use was not visible during the config refactoring from the commit above. Hence, these two changes create a reference to a non-existing config symbol.
Adjust the LEDS_BCM63138 definition to refer to ARCH_BCMBCA instead of ARCH_BCM4908 to remove the reference to the non-existing config symbol ARCH_BCM4908.
--- drivers/leds/blink/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/leds/blink/Kconfig +2 -2
@@ -1,10 +1,10 @@ config LEDS_BCM63138 tristate "LED Support for Broadcom BCM63138 SoC" depends on LEDS_CLASS - depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST + depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST depends on HAS_IOMEM depends on OF - default ARCH_BCM4908 + default ARCH_BCMBCA help This option enables support for LED controller that is part of BCM63138 SoC. The same hardware block is known to be also used
Signature · 1 line
2.17.1
Quoted 7 lines · Lukas Bulwahn
drivers/leds/blink/Kconfig +0
-0@@ -1,10 +1,10 @@ config LEDS_BCM63138 tristate "LED Support for Broadcom BCM63138 SoC"
drivers/leds/blink/Kconfig line 10
Quoted 10 lines
drivers/leds/blink/Kconfig +2
-2depends on LEDS_CLASS - depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST + depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST depends on HAS_IOMEM depends on OF - default ARCH_BCM4908 + default ARCH_BCMBCA help This option enables support for LED controller that is part of BCM63138 SoC. The same hardware block is known to be also used
William: do we want LEDS_BCM63138 default on all BCMBCA devices?
Hi Rafal,
Quoted 12 lines · Rafał Miłecki
Quoted 11 lines · Lukas Bulwahn
drivers/leds/blink/Kconfig +0
-0@@ -1,10 +1,10 @@config
LEDS_BCM63138
tristate "LED Support for Broadcom BCM63138 SoC" depends onLEDS_CLASS- depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST + depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TESTdepends on
HAS_IOMEM
Quoted 8 lines
Quoted 6 lines
depends on OF
- defaultARCH_BCM4908
+ defaultARCH_BCMBCA
help
This option enables support for LED controller that is part of BCM63138 SoC. The same hardware block is known to be also usedWilliam: do we want
LEDS_BCM63138default on all BCMBCA devices?
Yes that is fine. We can always build this driver for BCMBCA but it will be only probed and running if dts enable such device.
Quoted 26 lines · Lukas Bulwahn
Commit
dd5c672d7ca9("arm64: bcmbca: MergeARCH_BCM4908toARCH_BCMBCA") removes configARCH_BCM4908as configARCH_BCMBCAhas the same intent.Probably due to concurrent development, commit
a0ba692072d8("leds:
bcm63138: add support for BCM63138 controller") introduces 'LED Support for Broadcom BCM63138 SoC' that depends onARCH_BCM4908, but this use was not visible during the config refactoring from the commit above. Hence, these two changes create a reference to a non-existing config symbol.Adjust the
LEDS_BCM63138definition to refer toARCH_BCMBCAinstead ofARCH_BCM4908to remove the reference to the non-existing config symbolARCH_BCM4908.Signed-off-by Lukas Bulwahn <[email protected]>--- drivers/leds/blink/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/leds/blink/Kconfig +0
-0@@ -1,10 +1,10 @@ config LEDS_BCM63138 tristate "LED Support for Broadcom BCM63138 SoC"
drivers/leds/blink/Kconfig line 10
Quoted 10 lines
drivers/leds/blink/Kconfig +2
-2depends on LEDS_CLASS - depends on ARCH_BCM4908 || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST + depends on ARCH_BCMBCA || ARCH_BCM_5301X || BCM63XX || COMPILE_TEST depends on HAS_IOMEM depends on OF - default ARCH_BCM4908 + default ARCH_BCMBCA help This option enables support for LED controller that is part of BCM63138 SoC. The same hardware block is known to be also used
Quoted 9 lines · Lukas Bulwahn
Commit
dd5c672d7ca9("arm64: bcmbca: MergeARCH_BCM4908toARCH_BCMBCA") removes configARCH_BCM4908as configARCH_BCMBCAhas the same intent.Probably due to concurrent development, commit
a0ba692072d8("leds:
bcm63138: add support for BCM63138 controller") introduces 'LED Support for Broadcom BCM63138 SoC' that depends onARCH_BCM4908, but this use was not visible during the config refactoring from the commit above. Hence, these two changes create a reference to a non-existing config symbol.
Quoted 5 lines
Adjust the
LEDS_BCM63138definition to refer toARCH_BCMBCAinstead ofARCH_BCM4908to remove the reference to the non-existing config symbolARCH_BCM4908.Signed-off-by Lukas Bulwahn <[email protected]>
Quoted 9 lines · Lukas Bulwahn
Commit
dd5c672d7ca9("arm64: bcmbca: MergeARCH_BCM4908toARCH_BCMBCA") removes configARCH_BCM4908as configARCH_BCMBCAhas the same intent.Probably due to concurrent development, commit
a0ba692072d8("leds:
bcm63138: add support for BCM63138 controller") introduces 'LED Support for Broadcom BCM63138 SoC' that depends onARCH_BCM4908, but this use was not visible during the config refactoring from the commit above. Hence, these two changes create a reference to a non-existing config symbol.
Quoted 5 lines
Adjust the
LEDS_BCM63138definition to refer toARCH_BCMBCAinstead ofARCH_BCM4908to remove the reference to the non-existing config symbolARCH_BCM4908.Signed-off-by Lukas Bulwahn <[email protected]>
Do we really want this "default Y" on those architectures? I'd understand it for something critical but LED is not, and if it is not even present on all such machines...
BR,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 9 lines · Lukas Bulwahn
Commit
dd5c672d7ca9("arm64: bcmbca: MergeARCH_BCM4908toARCH_BCMBCA") removes configARCH_BCM4908as configARCH_BCMBCAhas the same intent.Probably due to concurrent development, commit
a0ba692072d8("leds:
bcm63138: add support for BCM63138 controller") introduces 'LED Support for Broadcom BCM63138 SoC' that depends onARCH_BCM4908, but this use was not visible during the config refactoring from the commit above. Hence, these two changes create a reference to a non-existing config symbol.
Quoted 5 lines
Adjust the
LEDS_BCM63138definition to refer toARCH_BCMBCAinstead ofARCH_BCM4908to remove the reference to the non-existing config symbolARCH_BCM4908.Signed-off-by Lukas Bulwahn <[email protected]>
Signature · 1 line
Florian