bpf: support BPF_PROG_QUERY for progs attached to sockmap
Quoted 12 lines · Yonghong Song
Quoted 2 lines
Quoted 2 lines
-static int sock_map_prog_update(struct
bpf_map*map, structbpf_prog*prog,
Quoted 2 lines
Review
Quoted 2 lines
(quoted diff) +1
-1- struct bpf_prog *old, u32 which) +static int sock_map_prog_lookup(struct bpf_map *map, struct bpf_prog**pprog[],
Quoted 4 lines
Can we just change "**pprog[]" to "***pprog"? In the code, you really just pass the address of the decl "struct
bpf_prog**pprog;" to the function.
Quoted 5 lines
Di,
this feedback was given twice already.
You also didn't address several other points from the earlier reviews. Please do not resubmit until you address all points.
Maybe i miss something...
I will recheck the review comments.