Skip to contentSkip to conversation

Add DT to get PCIe working in J721E SoC

PATCH RESEND Superseded Kishon Vijay Abraham I 2 participants 11 messages Sep 1, 2020 – Sep 14, 2020

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Add DT to get PCIe working in J721E SoC

Now that J721E PCIe support is merged (including the YAML bindings), add PCIe device tree nodes to get PCIe working in J721E SoC both in RC mode and EP mode.

Series has been rebased to:
git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux ti-k3-dts-next

No changes from the previous version sent to
http://lore.kernel.org/r/[email protected]

Kishon Vijay Abraham I (2):
arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes
arm64: dts: ti: k3-j721e-common-proc-board: Configure the PCIe
instances

 .../dts/ti/k3-j721e-common-proc-board.dts     |  80 +++++++
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     | 218 ++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-j721e.dtsi          |   5 +-
 3 files changed, 302 insertions(+), 1 deletion(-)
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

PATCH RESEND 1/2 arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes

Add PCIe device tree node (both RC and EP) for the four PCIe instances here.

---
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218 ++++++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-j721e.dtsi      |   5 +-
 2 files changed, 222 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +218 -0
index 00a36a14efe7..a36909d8b8c3 100644
@@ -28,6 +28,26 @@
 		#size-cells = <1>;
 		ranges = <0x0 0x0 0x00100000 0x1c000>;
 
+		pcie0_ctrl: pcie-ctrl@4070 {
+			compatible = "syscon";
+			reg = <0x00004070 0x4>;
+		};
+
+		pcie1_ctrl: pcie-ctrl@4074 {
+			compatible = "syscon";
+			reg = <0x00004074 0x4>;
+		};
+
+		pcie2_ctrl: pcie-ctrl@4078 {
+			compatible = "syscon";
+			reg = <0x00004078 0x4>;
+		};
+
+		pcie3_ctrl: pcie-ctrl@407c {
+			compatible = "syscon";
+			reg = <0x0000407c 0x4>;
+		};
+
 		serdes_ln_ctrl: serdes-ln-ctrl@4080 {
 			compatible = "mmio-mux";
 			reg = <0x00004080 0x50>;
@@ -576,6 +596,204 @@
 		};
 	};
 
+	pcie0_rc: pcie@2900000 {
+		compatible = "ti,j721e-pcie-host";
+		reg = <0x00 0x02900000 0x00 0x1000>,
+		      <0x00 0x02907000 0x00 0x400>,
+		      <0x00 0x0d000000 0x00 0x00800000>,
+		      <0x00 0x10000000 0x00 0x00001000>;
+		reg-names = "intd_cfg", "user_cfg", "reg", "cfg";
+		interrupt-names = "link_state";
+		interrupts = <GIC_SPI 318 IRQ_TYPE_EDGE_RISING>;
+		device_type = "pci";
+		ti,syscon-pcie-ctrl = <&pcie0_ctrl>;
+		max-link-speed = <3>;
+		num-lanes = <2>;
+		power-domains = <&k3_pds 239 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 239 1>;
+		clock-names = "fck";
+		#address-cells = <3>;
+		#size-cells = <2>;
+		bus-range = <0x0 0xf>;
+		vendor-id = <0x104c>;
+		device-id = <0xb00d>;
+		msi-map = <0x0 &gic_its 0x0 0x10000>;
+		dma-coherent;
+		ranges = <0x01000000 0x0 0x10001000 0x0 0x10001000 0x0 0x0010000>,
+			 <0x02000000 0x0 0x10011000 0x0 0x10011000 0x0 0x7fef000>;
+		dma-ranges = <0x02000000 0x0 0x0 0x0 0x0 0x10000 0x0>;
+	};
+
+	pcie0_ep: pcie-ep@2900000 {
+		compatible = "ti,j721e-pcie-ep";
+		reg = <0x00 0x02900000 0x00 0x1000>,
+		      <0x00 0x02907000 0x00 0x400>,
+		      <0x00 0x0d000000 0x00 0x00800000>,
+		      <0x00 0x10000000 0x00 0x08000000>;
+		reg-names = "intd_cfg", "user_cfg", "reg", "mem";
+		interrupt-names = "link_state";
+		interrupts = <GIC_SPI 318 IRQ_TYPE_EDGE_RISING>;
+		ti,syscon-pcie-ctrl = <&pcie0_ctrl>;
+		max-link-speed = <3>;
+		num-lanes = <2>;
+		power-domains = <&k3_pds 239 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 239 1>;
+		clock-names = "fck";
+		cdns,max-outbound-regions = <16>;
+		max-functions = /bits/ 8 <6>;
+		max-virtual-functions = /bits/ 16 <4 4 4 4 0 0>;
+		dma-coherent;
+	};
+
+	pcie1_rc: pcie@2910000 {
+		compatible = "ti,j721e-pcie-host";
+		reg = <0x00 0x02910000 0x00 0x1000>,
+		      <0x00 0x02917000 0x00 0x400>,
+		      <0x00 0x0d800000 0x00 0x00800000>,
+		      <0x00 0x18000000 0x00 0x00001000>;
+		reg-names = "intd_cfg", "user_cfg", "reg", "cfg";
+		interrupt-names = "link_state";
+		interrupts = <GIC_SPI 330 IRQ_TYPE_EDGE_RISING>;
+		device_type = "pci";
+		ti,syscon-pcie-ctrl = <&pcie1_ctrl>;
+		max-link-speed = <3>;
+		num-lanes = <2>;
+		power-domains = <&k3_pds 240 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 240 1>;
+		clock-names = "fck";
+		#address-cells = <3>;
+		#size-cells = <2>;
+		bus-range = <0x0 0xf>;
+		vendor-id = <0x104c>;
+		device-id = <0xb00d>;
+		msi-map = <0x0 &gic_its 0x10000 0x10000>;
+		dma-coherent;
+		ranges = <0x01000000 0x0 0x18001000 0x0 0x18001000 0x0 0x0010000>,
+			 <0x02000000 0x0 0x18011000 0x0 0x18011000 0x0 0x7fef000>;
+		dma-ranges = <0x02000000 0x0 0x0 0x0 0x0 0x10000 0x0>;
+	};
+
+	pcie1_ep: pcie-ep@2910000 {
+		compatible = "ti,j721e-pcie-ep";
+		reg = <0x00 0x02910000 0x00 0x1000>,
+		      <0x00 0x02917000 0x00 0x400>,
+		      <0x00 0x0d800000 0x00 0x00800000>,
+		      <0x00 0x18000000 0x00 0x08000000>;
+		reg-names = "intd_cfg", "user_cfg", "reg", "mem";
+		interrupt-names = "link_state";
+		interrupts = <GIC_SPI 330 IRQ_TYPE_EDGE_RISING>;
+		ti,syscon-pcie-ctrl = <&pcie1_ctrl>;
+		max-link-speed = <3>;
+		num-lanes = <2>;
+		power-domains = <&k3_pds 240 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 240 1>;
+		clock-names = "fck";
+		cdns,max-outbound-regions = <16>;
+		max-functions = /bits/ 8 <6>;
+		max-virtual-functions = /bits/ 16 <4 4 4 4 0 0>;
+		dma-coherent;
+	};
+
+	pcie2_rc: pcie@2920000 {
+		compatible = "ti,j721e-pcie-host";
+		reg = <0x00 0x02920000 0x00 0x1000>,
+		      <0x00 0x02927000 0x00 0x400>,
+		      <0x00 0x0e000000 0x00 0x00800000>,
+		      <0x44 0x00000000 0x00 0x00001000>;
+		reg-names = "intd_cfg", "user_cfg", "reg", "cfg";
+		interrupt-names = "link_state";
+		interrupts = <GIC_SPI 342 IRQ_TYPE_EDGE_RISING>;
+		device_type = "pci";
+		ti,syscon-pcie-ctrl = <&pcie2_ctrl>;
+		max-link-speed = <3>;
+		num-lanes = <2>;
+		power-domains = <&k3_pds 241 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 241 1>;
+		clock-names = "fck";
+		#address-cells = <3>;
+		#size-cells = <2>;
+		bus-range = <0x0 0xf>;
+		vendor-id = <0x104c>;
+		device-id = <0xb00d>;
+		msi-map = <0x0 &gic_its 0x20000 0x10000>;
+		dma-coherent;
+		ranges = <0x01000000 0x0 0x00001000 0x44 0x00001000 0x0 0x0010000>,
+			 <0x02000000 0x0 0x00011000 0x44 0x00011000 0x0 0x7fef000>;
+		dma-ranges = <0x02000000 0x0 0x0 0x0 0x0 0x10000 0x0>;
+	};
+
+	pcie2_ep: pcie-ep@2920000 {
+		compatible = "ti,j721e-pcie-ep";
+		reg = <0x00 0x02920000 0x00 0x1000>,
+		      <0x00 0x02927000 0x00 0x400>,
+		      <0x00 0x0e000000 0x00 0x00800000>,
+		      <0x44 0x00000000 0x00 0x08000000>;
+		reg-names = "intd_cfg", "user_cfg", "reg", "mem";
+		interrupt-names = "link_state";
+		interrupts = <GIC_SPI 342 IRQ_TYPE_EDGE_RISING>;
+		ti,syscon-pcie-ctrl = <&pcie2_ctrl>;
+		max-link-speed = <3>;
+		num-lanes = <2>;
+		power-domains = <&k3_pds 241 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 241 1>;
+		clock-names = "fck";
+		cdns,max-outbound-regions = <16>;
+		max-functions = /bits/ 8 <6>;
+		max-virtual-functions = /bits/ 16 <4 4 4 4 0 0>;
+		dma-coherent;
+	};
+
+	pcie3_rc: pcie@2930000 {
+		compatible = "ti,j721e-pcie-host";
+		reg = <0x00 0x02930000 0x00 0x1000>,
+		      <0x00 0x02937000 0x00 0x400>,
+		      <0x00 0x0e800000 0x00 0x00800000>,
+		      <0x44 0x10000000 0x00 0x00001000>;
+		reg-names = "intd_cfg", "user_cfg", "reg", "cfg";
+		interrupt-names = "link_state";
+		interrupts = <GIC_SPI 354 IRQ_TYPE_EDGE_RISING>;
+		device_type = "pci";
+		ti,syscon-pcie-ctrl = <&pcie3_ctrl>;
+		max-link-speed = <3>;
+		num-lanes = <2>;
+		power-domains = <&k3_pds 242 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 242 1>;
+		clock-names = "fck";
+		#address-cells = <3>;
+		#size-cells = <2>;
+		bus-range = <0x0 0xf>;
+		vendor-id = <0x104c>;
+		device-id = <0xb00d>;
+		msi-map = <0x0 &gic_its 0x30000 0x10000>;
+		dma-coherent;
+		ranges = <0x01000000 0x0 0x00001000 0x44 0x10001000 0x0 0x0010000>,
+			 <0x02000000 0x0 0x00011000 0x44 0x10011000 0x0 0x7fef000>;
+		dma-ranges = <0x02000000 0x0 0x0 0x0 0x0 0x10000 0x0>;
+	};
+
+	pcie3_ep: pcie-ep@2930000 {
+		compatible = "ti,j721e-pcie-ep";
+		reg = <0x00 0x02930000 0x00 0x1000>,
+		      <0x00 0x02937000 0x00 0x400>,
+		      <0x00 0x0e800000 0x00 0x00800000>,
+		      <0x44 0x10000000 0x00 0x08000000>;
+		reg-names = "intd_cfg", "user_cfg", "reg", "mem";
+		interrupt-names = "link_state";
+		interrupts = <GIC_SPI 354 IRQ_TYPE_EDGE_RISING>;
+		ti,syscon-pcie-ctrl = <&pcie3_ctrl>;
+		max-link-speed = <3>;
+		num-lanes = <2>;
+		power-domains = <&k3_pds 242 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 242 1>;
+		clock-names = "fck";
+		cdns,max-outbound-regions = <16>;
+		max-functions = /bits/ 8 <6>;
+		max-virtual-functions = /bits/ 16 <4 4 4 4 0 0>;
+		dma-coherent;
+		#address-cells = <2>;
+		#size-cells = <2>;
+	};
+
 	main_uart0: serial@2800000 {
 		compatible = "ti,j721e-uart", "ti,am654-uart";
 		reg = <0x00 0x02800000 0x00 0x100>;
arch/arm64/boot/dts/ti/k3-j721e.dtsi +4 -1
index f787aa73aaae..eeb02115b966 100644
@@ -132,9 +132,12 @@
 			 <0x00 0x06400000 0x00 0x06400000 0x00 0x00400000>, /* USBSS1 */
 			 <0x00 0x01000000 0x00 0x01000000 0x00 0x0af02400>, /* Most peripherals */
 			 <0x00 0x30000000 0x00 0x30000000 0x00 0x0c400000>, /* MAIN NAVSS */
-			 <0x00 0x0d000000 0x00 0x0d000000 0x00 0x01000000>, /* PCIe Core*/
+			 <0x00 0x0d000000 0x00 0x0d000000 0x00 0x01800000>, /* PCIe Core*/
+			 <0x00 0x0e000000 0x00 0x0e000000 0x00 0x01800000>, /* PCIe Core*/
 			 <0x00 0x10000000 0x00 0x10000000 0x00 0x10000000>, /* PCIe DAT */
 			 <0x00 0x64800000 0x00 0x64800000 0x00 0x00800000>, /* C71 */
+			 <0x44 0x00000000 0x44 0x00000000 0x00 0x08000000>, /* PCIe2 DAT */
+			 <0x44 0x10000000 0x44 0x10000000 0x00 0x08000000>, /* PCIe3 DAT */
 			 <0x4d 0x80800000 0x4d 0x80800000 0x00 0x00800000>, /* C66_0 */
 			 <0x4d 0x81800000 0x4d 0x81800000 0x00 0x00800000>, /* C66_1 */
 			 <0x4e 0x20000000 0x4e 0x20000000 0x00 0x00080000>, /* GPU */
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer
#2 lore raw

Re: [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes

Quoted 8 lines · Kishon Vijay Abraham I

Add PCIe device tree node (both RC and EP) for the four PCIe instances here.

---
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218 ++++++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-j721e.dtsi      |   5 +-
 2 files changed, 222 insertions(+), 1 deletion(-)

Did you look at the diff of the dtbs_check before and after this series? I see: https://pastebin.ubuntu.com/p/9fyfrTjx9M/

arch/arm64/boot/dts/ti/k3-j721e-main.dtsi line 31

Quoted 10 lines
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +1 -0
index 00a36a14efe7..a36909d8b8c3 100644
@@ -28,6 +28,26 @@
 		#size-cells = <1>;
 		ranges = <0x0 0x0 0x00100000 0x1c000>;
 
+		pcie0_ctrl: pcie-ctrl@4070 {

https://github.com/devicetree-org/devicetree-specification/releases/download/v0.3/devicetree-specification-v0.3.pdf
Section 2.2.2: why not use syscon@4070 and so on?

Quoted 45 lines
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +38 -0
+			compatible = "syscon";
+			reg = <0x00004070 0x4>;
+		};
+
+		pcie1_ctrl: pcie-ctrl@4074 {
+			compatible = "syscon";
+			reg = <0x00004074 0x4>;
+		};
+
+		pcie2_ctrl: pcie-ctrl@4078 {
+			compatible = "syscon";
+			reg = <0x00004078 0x4>;
+		};
+
+		pcie3_ctrl: pcie-ctrl@407c {
+			compatible = "syscon";
+			reg = <0x0000407c 0x4>;
+		};
+
 		serdes_ln_ctrl: serdes-ln-ctrl@4080 {
 			compatible = "mmio-mux";
 			reg = <0x00004080 0x50>;
@@ -576,6 +596,204 @@
 		};
 	};
 
+	pcie0_rc: pcie@2900000 {
+		compatible = "ti,j721e-pcie-host";
+		reg = <0x00 0x02900000 0x00 0x1000>,
+		      <0x00 0x02907000 0x00 0x400>,
+		      <0x00 0x0d000000 0x00 0x00800000>,
+		      <0x00 0x10000000 0x00 0x00001000>;
+		reg-names = "intd_cfg", "user_cfg", "reg", "cfg";
+		interrupt-names = "link_state";
+		interrupts = <GIC_SPI 318 IRQ_TYPE_EDGE_RISING>;
+		device_type = "pci";
+		ti,syscon-pcie-ctrl = <&pcie0_ctrl>;
+		max-link-speed = <3>;
+		num-lanes = <2>;
+		power-domains = <&k3_pds 239 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 239 1>;
+		clock-names = "fck";
+		#address-cells = <3>;
+		#size-cells = <2>;
+		bus-range = <0x0 0xf>;

arch/arm64/boot/dts/ti/k3-j721e-main.dtsi line 627

Quoted 10 lines
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +10 -0
+		vendor-id = <0x104c>;
+		device-id = <0xb00d>;
+		msi-map = <0x0 &gic_its 0x0 0x10000>;
+		dma-coherent;
+		ranges = <0x01000000 0x0 0x10001000 0x0 0x10001000 0x0 0x0010000>,
+			 <0x02000000 0x0 0x10011000 0x0 0x10011000 0x0 0x7fef000>;
+		dma-ranges = <0x02000000 0x0 0x0 0x0 0x0 0x10000 0x0>;
+	};
+
+	pcie0_ep: pcie-ep@2900000 {

Not related to this patch, but just a suggestion: pcie-ep -> do we need to add that to the Generic names in DT spec?

[...]

arch/arm64/boot/dts/ti/k3-j721e.dtsi line 137

Quoted 12 lines
arch/arm64/boot/dts/ti/k3-j721e.dtsi +2 -1
index f787aa73aaae..eeb02115b966 100644
@@ -132,9 +132,12 @@
 			 <0x00 0x06400000 0x00 0x06400000 0x00 0x00400000>, /* USBSS1 */
 			 <0x00 0x01000000 0x00 0x01000000 0x00 0x0af02400>, /* Most peripherals */
 			 <0x00 0x30000000 0x00 0x30000000 0x00 0x0c400000>, /* MAIN NAVSS */
-			 <0x00 0x0d000000 0x00 0x0d000000 0x00 0x01000000>, /* PCIe Core*/
+			 <0x00 0x0d000000 0x00 0x0d000000 0x00 0x01800000>, /* PCIe Core*/
+			 <0x00 0x0e000000 0x00 0x0e000000 0x00 0x01800000>, /* PCIe Core*/
 			 <0x00 0x10000000 0x00 0x10000000 0x00 0x10000000>, /* PCIe DAT */
										^^
									should be PCIe1?

Just because you are introducing PCIe2,3 in this patch, the net result does'nt look consistent? Also might want to cover this change in the $commit_message.
[...]

Quoted 9 lines
arch/arm64/boot/dts/ti/k3-j721e.dtsi +2 -0
 			 <0x00 0x64800000 0x00 0x64800000 0x00 0x00800000>, /* C71 */
+			 <0x44 0x00000000 0x44 0x00000000 0x00 0x08000000>, /* PCIe2 DAT */
+			 <0x44 0x10000000 0x44 0x10000000 0x00 0x08000000>, /* PCIe3 DAT */
 			 <0x4d 0x80800000 0x4d 0x80800000 0x00 0x00800000>, /* C66_0 */
 			 <0x4d 0x81800000 0x4d 0x81800000 0x00 0x00800000>, /* C66_1 */
 			 <0x4e 0x20000000 0x4e 0x20000000 0x00 0x00080000>, /* GPU */
Signature · 1 line
2.17.1
Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#3 lore raw

Re: [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes

Hi Nishanth,

Quoted 11 lines · Nishanth Menon
Quoted 8 lines · Kishon Vijay Abraham I

Add PCIe device tree node (both RC and EP) for the four PCIe instances here.

---
  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218 ++++++++++++++++++++++
  arch/arm64/boot/dts/ti/k3-j721e.dtsi      |   5 +-
  2 files changed, 222 insertions(+), 1 deletion(-)
Quoted 2 lines

Did you look at the diff of the dtbs_check before and after this series? I see: https://pastebin.ubuntu.com/p/9fyfrTjx9M/

I didn't see any errors when I checked for individual bindings

a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml"
  SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml
  DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml
  DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml
  CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml
  CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml
a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml"
  SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml
  DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml
  DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml
  CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml
  CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml
Quoted 10 lines
Quoted 10 lines
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +0 -0
index 00a36a14efe7..a36909d8b8c3 100644
@@ -28,6 +28,26 @@
  		#size-cells = <1>;
  		ranges = <0x0 0x0 0x00100000 0x1c000>;
 
Quoted 3 lines

arch/arm64/boot/dts/ti/k3-j721e-main.dtsi line 31

Quoted 1 line
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +1 -0
+		pcie0_ctrl: pcie-ctrl@4070 {

https://github.com/devicetree-org/devicetree-specification/releases/download/v0.3/devicetree-specification-v0.3.pdf
Section 2.2.2: why not use syscon@4070 and so on?

okay, will change to generic name.

Quoted 74 lines
Quoted 46 lines
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +38 -0
+			compatible = "syscon";
+			reg = <0x00004070 0x4>;
+		};
+
+		pcie1_ctrl: pcie-ctrl@4074 {
+			compatible = "syscon";
+			reg = <0x00004074 0x4>;
+		};
+
+		pcie2_ctrl: pcie-ctrl@4078 {
+			compatible = "syscon";
+			reg = <0x00004078 0x4>;
+		};
+
+		pcie3_ctrl: pcie-ctrl@407c {
+			compatible = "syscon";
+			reg = <0x0000407c 0x4>;
+		};
+
  		serdes_ln_ctrl: serdes-ln-ctrl@4080 {
  			compatible = "mmio-mux";
  			reg = <0x00004080 0x50>;
@@ -576,6 +596,204 @@
  		};
  	};
 
+	pcie0_rc: pcie@2900000 {
+		compatible = "ti,j721e-pcie-host";
+		reg = <0x00 0x02900000 0x00 0x1000>,
+		      <0x00 0x02907000 0x00 0x400>,
+		      <0x00 0x0d000000 0x00 0x00800000>,
+		      <0x00 0x10000000 0x00 0x00001000>;
+		reg-names = "intd_cfg", "user_cfg", "reg", "cfg";
+		interrupt-names = "link_state";
+		interrupts = <GIC_SPI 318 IRQ_TYPE_EDGE_RISING>;
+		device_type = "pci";
+		ti,syscon-pcie-ctrl = <&pcie0_ctrl>;
+		max-link-speed = <3>;
+		num-lanes = <2>;
+		power-domains = <&k3_pds 239 TI_SCI_PD_EXCLUSIVE>;
+		clocks = <&k3_clks 239 1>;
+		clock-names = "fck";
+		#address-cells = <3>;
+		#size-cells = <2>;
+		bus-range = <0x0 0xf>;

arch/arm64/boot/dts/ti/k3-j721e-main.dtsi line 627

Quoted 10 lines
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +10 -0
+		vendor-id = <0x104c>;
+		device-id = <0xb00d>;
+		msi-map = <0x0 &gic_its 0x0 0x10000>;
+		dma-coherent;
+		ranges = <0x01000000 0x0 0x10001000 0x0 0x10001000 0x0 0x0010000>,
+			 <0x02000000 0x0 0x10011000 0x0 0x10011000 0x0 0x7fef000>;
+		dma-ranges = <0x02000000 0x0 0x0 0x0 0x0 0x10000 0x0>;
+	};
+
+	pcie0_ep: pcie-ep@2900000 {

Not related to this patch, but just a suggestion: pcie-ep -> do we need to add that to the Generic names in DT spec?

[...]

arch/arm64/boot/dts/ti/k3-j721e.dtsi line 137

Quoted 12 lines
arch/arm64/boot/dts/ti/k3-j721e.dtsi +2 -1
index f787aa73aaae..eeb02115b966 100644
@@ -132,9 +132,12 @@
  			 <0x00 0x06400000 0x00 0x06400000 0x00 0x00400000>, /* USBSS1 */
  			 <0x00 0x01000000 0x00 0x01000000 0x00 0x0af02400>, /* Most peripherals */
  			 <0x00 0x30000000 0x00 0x30000000 0x00 0x0c400000>, /* MAIN NAVSS */
-			 <0x00 0x0d000000 0x00 0x0d000000 0x00 0x01000000>, /* PCIe Core*/
+			 <0x00 0x0d000000 0x00 0x0d000000 0x00 0x01800000>, /* PCIe Core*/
+			 <0x00 0x0e000000 0x00 0x0e000000 0x00 0x01800000>, /* PCIe Core*/
  			 <0x00 0x10000000 0x00 0x10000000 0x00 0x10000000>, /* PCIe DAT */
										^^
									should be PCIe1?
Quoted 3 lines

Just because you are introducing PCIe2,3 in this patch, the net result does'nt look consistent? Also might want to cover this change in the $commit_message.

yeah, we could have a separate patch for this change.

Thanks
Kishon

Quoted 11 lines

[...]

Quoted 9 lines

<0x00 0x64800000 0x00 0x64800000 0x00 0x00800000>, /* C71 */

arch/arm64/boot/dts/ti/k3-j721e.dtsi +2 -0
+			 <0x44 0x00000000 0x44 0x00000000 0x00 0x08000000>, /* PCIe2 DAT */
+			 <0x44 0x10000000 0x44 0x10000000 0x00 0x08000000>, /* PCIe3 DAT */
  			 <0x4d 0x80800000 0x4d 0x80800000 0x00 0x00800000>, /* C66_0 */
  			 <0x4d 0x81800000 0x4d 0x81800000 0x00 0x00800000>, /* C66_1 */
  			 <0x4e 0x20000000 0x4e 0x20000000 0x00 0x00080000>, /* GPU */
Signature · 1 line
2.17.1
#4 lore raw

Re: [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes

Hi Rob,

Quoted 25 lines · Kishon Vijay Abraham I

Hi Nishanth,

Quoted 11 lines · Nishanth Menon
Quoted 8 lines · Kishon Vijay Abraham I

Add PCIe device tree node (both RC and EP) for the four PCIe instances here.

---
  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218 ++++++++++++++++++++++ arch/arm64/boot/dts/ti/k3-j721e.dtsi      |   5 +-

  2 files changed, 222 insertions(+), 1 deletion(-)
Quoted 2 lines

Did you look at the diff of the dtbs_check before and after this series? I see: https://pastebin.ubuntu.com/p/9fyfrTjx9M/

I didn't see any errors when I checked for individual bindings

a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml" 

  SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml

Quoted 7 lines
a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml" 

  SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml

Can you give hint on why I get ranges is too long error
https://pastebin.ubuntu.com/p/cPm2tg3dcV/ which I give mkconfig64 dtbs_check but don't see an error when I include "DT_SCHEMA_FILES"?

Thanks
Kishon

Quoted 114 lines
Quoted 12 lines

arch/arm64/boot/dts/ti/k3-j721e-main.dtsi line 30

Quoted 10 lines
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +1 -0
index 00a36a14efe7..a36909d8b8c3 100644
@@ -28,6 +28,26 @@
           #size-cells = <1>;
           ranges = <0x0 0x0 0x00100000 0x1c000>;
+        pcie0_ctrl: pcie-ctrl@4070 {

https://github.com/devicetree-org/devicetree-specification/releases/download/v0.3/devicetree-specification-v0.3.pdf

Quoted 1 line

Section 2.2.2: why not use syscon@4070 and so on?

okay, will change to generic name.

Quoted 72 lines
Quoted 46 lines
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +39 -0
+            compatible = "syscon";
+            reg = <0x00004070 0x4>;
+        };
+
+        pcie1_ctrl: pcie-ctrl@4074 {
+            compatible = "syscon";
+            reg = <0x00004074 0x4>;
+        };
+
+        pcie2_ctrl: pcie-ctrl@4078 {
+            compatible = "syscon";
+            reg = <0x00004078 0x4>;
+        };
+
+        pcie3_ctrl: pcie-ctrl@407c {
+            compatible = "syscon";
+            reg = <0x0000407c 0x4>;
+        };
+
           serdes_ln_ctrl: serdes-ln-ctrl@4080 {
               compatible = "mmio-mux";
               reg = <0x00004080 0x50>;
@@ -576,6 +596,204 @@
           };
       };
+    pcie0_rc: pcie@2900000 {
+        compatible = "ti,j721e-pcie-host";
+        reg = <0x00 0x02900000 0x00 0x1000>,
+              <0x00 0x02907000 0x00 0x400>,
+              <0x00 0x0d000000 0x00 0x00800000>,
+              <0x00 0x10000000 0x00 0x00001000>;
+        reg-names = "intd_cfg", "user_cfg", "reg", "cfg";
+        interrupt-names = "link_state";
+        interrupts = <GIC_SPI 318 IRQ_TYPE_EDGE_RISING>;
+        device_type = "pci";
+        ti,syscon-pcie-ctrl = <&pcie0_ctrl>;
+        max-link-speed = <3>;
+        num-lanes = <2>;
+        power-domains = <&k3_pds 239 TI_SCI_PD_EXCLUSIVE>;
+        clocks = <&k3_clks 239 1>;
+        clock-names = "fck";
+        #address-cells = <3>;
+        #size-cells = <2>;
+        bus-range = <0x0 0xf>;
+        vendor-id = <0x104c>;

arch/arm64/boot/dts/ti/k3-j721e-main.dtsi line 627

Quoted 10 lines
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +9 -0
+        device-id = <0xb00d>;
+        msi-map = <0x0 &gic_its 0x0 0x10000>;
+        dma-coherent;
+        ranges = <0x01000000 0x0 0x10001000 0x0 0x10001000 0x0 
 0x0010000>,
+             <0x02000000 0x0 0x10011000 0x0 0x10011000 0x0 0x7fef000>;
+        dma-ranges = <0x02000000 0x0 0x0 0x0 0x0 0x10000 0x0>;
+    };
+
+    pcie0_ep: pcie-ep@2900000 {

Not related to this patch, but just a suggestion: pcie-ep -> do we need to add that to the Generic names in DT spec?

[...]

Quoted 12 lines
arch/arm64/boot/dts/ti/k3-j721e.dtsi +0 -0
index f787aa73aaae..eeb02115b966 100644
@@ -132,9 +132,12 @@

               <0x00 0x06400000 0x00 0x06400000 0x00 0x00400000>, /* USBSS1 */ <0x00 0x01000000 0x00 0x01000000 0x00 0x0af02400>, /* Most peripherals */ <0x00 0x30000000 0x00 0x30000000 0x00 0x0c400000>, /* MAIN NAVSS */ -             <0x00 0x0d000000 0x00 0x0d000000 0x00 0x01000000>, /*
PCIe Core*/
+             <0x00 0x0d000000 0x00 0x0d000000 0x00 0x01800000>, /*
PCIe Core*/

Quoted 8 lines
Quoted 3 lines

+             <0x00 0x0e000000 0x00 0x0e000000 0x00 0x01800000>, /* PCIe Core*/
               <0x00 0x10000000 0x00 0x10000000 0x00 0x10000000>, /* PCIe DAT */

                                        ^^
                                    should be PCIe1?
Just because you are introducing PCIe2,3 in this patch, the net result does'nt look consistent? Also might want to cover this change in the $commit_message.

yeah, we could have a separate patch for this change.

Thanks
Kishon

Quoted 13 lines

[...]

Quoted 11 lines

               <0x00 0x64800000 0x00 0x64800000 0x00 0x00800000>, /* C71 */ +             <0x44 0x00000000 0x44 0x00000000 0x00 0x08000000>, /* PCIe2 DAT */
+             <0x44 0x10000000 0x44 0x10000000 0x00 0x08000000>, /* PCIe3 DAT */
               <0x4d 0x80800000 0x4d 0x80800000 0x00 0x00800000>, /* C66_0 */ <0x4d 0x81800000 0x4d 0x81800000 0x00 0x00800000>, /* C66_1 */ <0x4e 0x20000000 0x4e 0x20000000 0x00 0x00080000>, /* GPU */

Signature · 1 line
2.17.1
#5 lore raw

Re: [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes

Hi Rob,

Quoted 39 lines · Kishon Vijay Abraham I

Hi Rob,

Quoted 27 lines · Kishon Vijay Abraham I

Hi Nishanth,

Quoted 12 lines · Nishanth Menon
Quoted 9 lines · Kishon Vijay Abraham I

Add PCIe device tree node (both RC and EP) for the four PCIe instances here.

---
  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218
++++++++++++++++++++++
  arch/arm64/boot/dts/ti/k3-j721e.dtsi      |   5 +-

  2 files changed, 222 insertions(+), 1 deletion(-)
Quoted 2 lines

Did you look at the diff of the dtbs_check before and after this series? I see: https://pastebin.ubuntu.com/p/9fyfrTjx9M/

I didn't see any errors when I checked for individual bindings

a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check
DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml"

   SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml

Quoted 8 lines
a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check
DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml"

   SCHEMA  Documentation/devicetree/bindings/processed-schema.yamlsimple-bus DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml

Quoted 3 lines

Can you give hint on why I get ranges is too long error
https://pastebin.ubuntu.com/p/cPm2tg3dcV/ which I give mkconfig64 dtbs_check but don't see an error when I include "DT_SCHEMA_FILES"?

I debugged this and looks like PCIe "ranges" property conflicts with simple-bus.

A diff like below helps to solve the issue

schemas/simple-bus.yaml +1 -1
index 248ac9d..ed818ef 100644
@@ -39,7 +39,7 @@ patternProperties:
         oneOf:
           - items:
               minItems: 3
-              maxItems: 6
+              maxItems: 7
             minItems: 0
             maxItems: 1024
           - $ref: "types.yaml#/definitions/flag"

If this looks right to you, I can post a patch for it. Without fixing this we would see false errors for PCIe DT nodes.

Thanks
Kishon

maintainer
#6 lore raw

Re: [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes

Quoted 64 lines · Kishon Vijay Abraham I

Hi Rob,

Quoted 39 lines · Kishon Vijay Abraham I

Hi Rob,

Quoted 27 lines · Kishon Vijay Abraham I

Hi Nishanth,

Quoted 12 lines · Nishanth Menon
Quoted 9 lines · Kishon Vijay Abraham I

Add PCIe device tree node (both RC and EP) for the four PCIe instances here.

---
  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218
++++++++++++++++++++++
  arch/arm64/boot/dts/ti/k3-j721e.dtsi      |   5 +-

  2 files changed, 222 insertions(+), 1 deletion(-)
Quoted 2 lines

Did you look at the diff of the dtbs_check before and after this series? I see: https://pastebin.ubuntu.com/p/9fyfrTjx9M/

I didn't see any errors when I checked for individual bindings

a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check
DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml"

   SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml

Quoted 8 lines
a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check
DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml"

   SCHEMA  Documentation/devicetree/bindings/processed-schema.yamlsimple-bus DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml

Quoted 3 lines

Can you give hint on why I get ranges is too long error
https://pastebin.ubuntu.com/p/cPm2tg3dcV/ which I give mkconfig64 dtbs_check but don't see an error when I include "DT_SCHEMA_FILES"?

I debugged this and looks like PCIe "ranges" property conflicts with simple-bus.

A diff like below helps to solve the issue

schemas/simple-bus.yaml +1 -1
index 248ac9d..ed818ef 100644
@@ -39,7 +39,7 @@ patternProperties:
         oneOf:
           - items:
               minItems: 3
-              maxItems: 6
+              maxItems: 7
             minItems: 0
             maxItems: 1024
           - $ref: "types.yaml#/definitions/flag"
Quoted 2 lines

If this looks right to you, I can post a patch for it. Without fixing this we would see false errors for PCIe DT nodes.

https://github.com/devicetree-org/dt-schema/commit/3baf308b01786788e3ccb9824fce6d7136b21214

Part of v2020.08.1? Am i missing something?

Signature · 8 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#7 lore raw

Re: [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes

Hi Nishanth,

Quoted 65 lines · Nishanth Menon
Quoted 64 lines · Kishon Vijay Abraham I

Hi Rob,

Quoted 39 lines · Kishon Vijay Abraham I

Hi Rob,

Quoted 27 lines · Kishon Vijay Abraham I

Hi Nishanth,

Quoted 12 lines · Nishanth Menon
Quoted 9 lines · Kishon Vijay Abraham I

Add PCIe device tree node (both RC and EP) for the four PCIe instances here.

---
  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218
++++++++++++++++++++++
  arch/arm64/boot/dts/ti/k3-j721e.dtsi      |   5 +-

  2 files changed, 222 insertions(+), 1 deletion(-)
Quoted 2 lines

Did you look at the diff of the dtbs_check before and after this series? I see: https://pastebin.ubuntu.com/p/9fyfrTjx9M/

I didn't see any errors when I checked for individual bindings

a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check
DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml"

   SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml

Quoted 8 lines
a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check
DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml"

   SCHEMA  Documentation/devicetree/bindings/processed-schema.yamlsimple-bus DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml

Quoted 3 lines

Can you give hint on why I get ranges is too long error
https://pastebin.ubuntu.com/p/cPm2tg3dcV/ which I give mkconfig64 dtbs_check but don't see an error when I include "DT_SCHEMA_FILES"?

I debugged this and looks like PCIe "ranges" property conflicts with simple-bus.

A diff like below helps to solve the issue

schemas/simple-bus.yaml +1 -1
index 248ac9d..ed818ef 100644
@@ -39,7 +39,7 @@ patternProperties:
         oneOf:
           - items:
               minItems: 3
-              maxItems: 6
+              maxItems: 7
             minItems: 0
             maxItems: 1024
           - $ref: "types.yaml#/definitions/flag"
Quoted 6 lines
Quoted 2 lines

If this looks right to you, I can post a patch for it. Without fixing this we would see false errors for PCIe DT nodes.

https://github.com/devicetree-org/dt-schema/commit/3baf308b01786788e3ccb9824fce6d7136b21214

Part of v2020.08.1? Am i missing something?

I think I was using a different repo
https://github.com/robherring/dt-schema.git.

Do you see the following issues you reported earlier with v2020.08.1?

+/home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@100000: pcie@2900000:ranges: [[16777216, 0, 268439552, 0, 268439552,
0, 65536], [33554432, 0, 268505088, 0, 268505088, 0, 134148096]] is not
valid under any of the given schemas (Possible causes of the failure):
+ /home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@100000: pcie@2900000:ranges: True was expected
+ /home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@100000: pcie@2900000:ranges:0: [16777216, 0, 268439552, 0,
268439552, 0, 65536] is too long
+ /home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@100000: pcie@2900000:ranges:1: [33554432, 0, 268505088, 0,
268505088, 0, 134148096] is too long
+

Thanks
Kishon

Quoted 1 line

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#8 lore raw

Re: [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes

Quoted 80 lines · Kishon Vijay Abraham I

Hi Nishanth,

Quoted 65 lines · Nishanth Menon
Quoted 64 lines · Kishon Vijay Abraham I

Hi Rob,

Quoted 39 lines · Kishon Vijay Abraham I

Hi Rob,

Quoted 27 lines · Kishon Vijay Abraham I

Hi Nishanth,

Quoted 12 lines · Nishanth Menon
Quoted 9 lines · Kishon Vijay Abraham I

Add PCIe device tree node (both RC and EP) for the four PCIe instances here.

---
  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218
++++++++++++++++++++++
  arch/arm64/boot/dts/ti/k3-j721e.dtsi      |   5 +-

  2 files changed, 222 insertions(+), 1 deletion(-)
Quoted 2 lines

Did you look at the diff of the dtbs_check before and after this series? I see: https://pastebin.ubuntu.com/p/9fyfrTjx9M/

I didn't see any errors when I checked for individual bindings

a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check
DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml"

   SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml

Quoted 8 lines
a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check
DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml"

   SCHEMA  Documentation/devicetree/bindings/processed-schema.yamlsimple-bus DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml

Quoted 3 lines

Can you give hint on why I get ranges is too long error
https://pastebin.ubuntu.com/p/cPm2tg3dcV/ which I give mkconfig64 dtbs_check but don't see an error when I include "DT_SCHEMA_FILES"?

I debugged this and looks like PCIe "ranges" property conflicts with simple-bus.

A diff like below helps to solve the issue

schemas/simple-bus.yaml +1 -1
index 248ac9d..ed818ef 100644
@@ -39,7 +39,7 @@ patternProperties:
         oneOf:
           - items:
               minItems: 3
-              maxItems: 6
+              maxItems: 7
             minItems: 0
             maxItems: 1024
           - $ref: "types.yaml#/definitions/flag"
Quoted 6 lines
Quoted 2 lines

If this looks right to you, I can post a patch for it. Without fixing this we would see false errors for PCIe DT nodes.

https://github.com/devicetree-org/dt-schema/commit/3baf308b01786788e3ccb9824fce6d7136b21214

Part of v2020.08.1? Am i missing something?

I think I was using a different repo
https://github.com/robherring/dt-schema.git.

Do you see the following issues you reported earlier with v2020.08.1?

Quoted 15 lines

+/home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@100000: pcie@2900000:ranges: [[16777216, 0, 268439552, 0, 268439552,
0, 65536], [33554432, 0, 268505088, 0, 268505088, 0, 134148096]] is not
valid under any of the given schemas (Possible causes of the failure):
+ /home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@100000: pcie@2900000:ranges: True was expected
+ /home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@100000: pcie@2900000:ranges:0: [16777216, 0, 268439552, 0,
268439552, 0, 65536] is too long
+ /home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@100000: pcie@2900000:ranges:1: [33554432, 0, 268505088, 0,
268505088, 0, 134148096] is too long

Arrgh.. you are right.. Looks like one of my PCs still had 2020.8 instead of 2020.8.1. We just need to figure out what is going on with syscon.yaml as against ti,j721e-system-controller.yaml..

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#9 lore raw

Re: [RESEND PATCH 1/2] arm64: dts: ti: k3-j721e-main: Add PCIe device tree nodes

Hi Nishanth,

Quoted 93 lines · Nishanth Menon
Quoted 92 lines · Kishon Vijay Abraham I

Hi Nishanth,

Quoted 65 lines · Nishanth Menon
Quoted 64 lines · Kishon Vijay Abraham I

Hi Rob,

Quoted 39 lines · Kishon Vijay Abraham I

Hi Rob,

Quoted 27 lines · Kishon Vijay Abraham I

Hi Nishanth,

Quoted 12 lines · Nishanth Menon
Quoted 9 lines · Kishon Vijay Abraham I

Add PCIe device tree node (both RC and EP) for the four PCIe instances here.

---
  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 218
++++++++++++++++++++++
  arch/arm64/boot/dts/ti/k3-j721e.dtsi      |   5 +-

  2 files changed, 222 insertions(+), 1 deletion(-)
Quoted 2 lines

Did you look at the diff of the dtbs_check before and after this series? I see: https://pastebin.ubuntu.com/p/9fyfrTjx9M/

I didn't see any errors when I checked for individual bindings

a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check
DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml"

   SCHEMA  Documentation/devicetree/bindings/processed-schema.yaml DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml

Quoted 8 lines
a0393678@a0393678-ssd:~/repos/linux$ mkconfig64 dtbs_check
DT_SCHEMA_FILES="Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml"

   SCHEMA  Documentation/devicetree/bindings/processed-schema.yamlsimple-bus DTC     arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml DTC     arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml CHECK   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml

Quoted 3 lines

Can you give hint on why I get ranges is too long error
https://pastebin.ubuntu.com/p/cPm2tg3dcV/ which I give mkconfig64 dtbs_check but don't see an error when I include "DT_SCHEMA_FILES"?

I debugged this and looks like PCIe "ranges" property conflicts with simple-bus.

A diff like below helps to solve the issue

schemas/simple-bus.yaml +1 -1
index 248ac9d..ed818ef 100644
@@ -39,7 +39,7 @@ patternProperties:
         oneOf:
           - items:
               minItems: 3
-              maxItems: 6
+              maxItems: 7
             minItems: 0
             maxItems: 1024
           - $ref: "types.yaml#/definitions/flag"
Quoted 6 lines
Quoted 2 lines

If this looks right to you, I can post a patch for it. Without fixing this we would see false errors for PCIe DT nodes.

https://github.com/devicetree-org/dt-schema/commit/3baf308b01786788e3ccb9824fce6d7136b21214

Part of v2020.08.1? Am i missing something?

I think I was using a different repo
https://github.com/robherring/dt-schema.git.

Do you see the following issues you reported earlier with v2020.08.1?

+/home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@100000: pcie@2900000:ranges: [[16777216, 0, 268439552, 0, 268439552,
0, 65536], [33554432, 0, 268505088, 0, 268505088, 0, 134148096]] is not
valid under any of the given schemas (Possible causes of the failure):
+ /home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@100000: pcie@2900000:ranges: True was expected
+ /home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@100000: pcie@2900000:ranges:0: [16777216, 0, 268439552, 0,
268439552, 0, 65536] is too long
+

Quoted 8 lines
Quoted 3 lines

/home/nmenon/Src/opensource/linux/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml:
bus@100000: pcie@2900000:ranges:1: [33554432, 0, 268505088, 0,
268505088, 0, 134148096] is too long

Arrgh.. you are right.. Looks like one of my PCs still had 2020.8 instead of 2020.8.1. We just need to figure out what is going on with syscon.yaml as against ti,j721e-system-controller.yaml..

I think I'll use the existing TI specific compatible string for syscon here.

Thanks
Kishon

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#10 lore raw

PATCH RESEND 2/2 arm64: dts: ti: k3-j721e-common-proc-board: Configure the PCIe instances

In reply to Kishon Vijay Abraham I

J721E Common Processor Board has PCIe connectors for the 1st three PCIe instances. Configure the three PCIe instances in RC mode and disable the 4th PCIe instance.

---
 .../dts/ti/k3-j721e-common-proc-board.dts     | 80 +++++++++++++++++++
 1 file changed, 80 insertions(+)
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts +80 -0
index c355692796a9..8b57d22ca3cc 100644
@@ -558,3 +558,83 @@
 
 	status = "okay";
 };
+
+&serdes0 {
+	serdes0_pcie_link: link@0 {
+		reg = <0>;
+		cdns,num-lanes = <1>;
+		#phy-cells = <0>;
+		cdns,phy-type = <PHY_TYPE_PCIE>;
+		resets = <&serdes_wiz0 1>;
+	};
+};
+
+&serdes1 {
+	serdes1_pcie_link: link@0 {
+		reg = <0>;
+		cdns,num-lanes = <2>;
+		#phy-cells = <0>;
+		cdns,phy-type = <PHY_TYPE_PCIE>;
+		resets = <&serdes_wiz1 1>, <&serdes_wiz1 2>;
+	};
+};
+
+&serdes2 {
+	serdes2_pcie_link: link@0 {
+		reg = <0>;
+		cdns,num-lanes = <2>;
+		#phy-cells = <0>;
+		cdns,phy-type = <PHY_TYPE_PCIE>;
+		resets = <&serdes_wiz2 1>, <&serdes_wiz2 2>;
+	};
+};
+
+&pcie0_rc {
+	reset-gpios = <&exp1 6 GPIO_ACTIVE_HIGH>;
+	phys = <&serdes0_pcie_link>;
+	phy-names = "pcie-phy";
+	num-lanes = <1>;
+};
+
+&pcie1_rc {
+	reset-gpios = <&exp1 2 GPIO_ACTIVE_HIGH>;
+	phys = <&serdes1_pcie_link>;
+	phy-names = "pcie-phy";
+	num-lanes = <2>;
+};
+
+&pcie2_rc {
+	reset-gpios = <&exp2 20 GPIO_ACTIVE_HIGH>;
+	phys = <&serdes2_pcie_link>;
+	phy-names = "pcie-phy";
+	num-lanes = <2>;
+};
+
+&pcie0_ep {
+	phys = <&serdes0_pcie_link>;
+	phy-names = "pcie-phy";
+	num-lanes = <1>;
+	status = "disabled";
+};
+
+&pcie1_ep {
+	phys = <&serdes1_pcie_link>;
+	phy-names = "pcie-phy";
+	num-lanes = <2>;
+	status = "disabled";
+};
+
+&pcie2_ep {
+	phys = <&serdes2_pcie_link>;
+	phy-names = "pcie-phy";
+	num-lanes = <2>;
+	status = "disabled";
+};
+
+&pcie3_rc {
+	status = "disabled";
+};
+
+&pcie3_ep {
+	status = "disabled";
+};
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel