i2c: at91: Initialize dma_buf in at91_twi_xfer()
PATCH 1/1 i2c: at91: Initialize dma_buf in at91_twi_xfer()
Clang warns:
drivers/i2c/busses/i2c-at91-master.c:707:6: warning: variable 'dma_buf' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (dev->use_dma) {
^~~~~~~~~~~~
drivers/i2c/busses/i2c-at91-master.c:717:27: note: uninitialized use occurs here
i2c_put_dma_safe_msg_buf(dma_buf, m_start, !ret);
^~~~~~~Initialize dma_buf to NULL, as i2c_put_dma_safe_msg_buf() is a no-op when the first argument is NULL, which will work for the !dev->use_dma case.
--- drivers/i2c/busses/i2c-at91-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-at91-master.c +1 -1
@@ -656,7 +656,7 @@ static int at91_twi_xfer(struct i2c_adapter *adap, struct i2c_msg *msg, int num)unsigned int_addr_flag =0 ;struct i2c_msg *m_start = msg;bool is_read; -u8 *dma_buf; +u8 *dma_buf =NULL ;dev_dbg (&adap->dev,"at91_xfer: processing %d messages:\n" , num);
base-commit: a181b8d187319bf265a2019ddde856a3d2f107a6
Signature · 1 line
2.36.0
Am 2022-05-05 17:27, schrieb Nathan Chancellor:
Quoted 12 lines
Clang warns:
drivers/i2c/busses/i2c-at91-master.c:707:6: warning: variable
'dma_buf' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]if (dev->use_dma) { ^~~~~~~~~~~~ drivers/i2c/busses/i2c-at91-master.c:717:27: note: uninitialized use occurs here i2c_put_dma_safe_msg_buf(dma_buf, m_start, !ret); ^~~~~~~
Quoted 7 lines
Initialize
dma_bufto NULL, asi2c_put_dma_safe_msg_buf()is a no-op when the first argument is NULL, which will work for the !dev->use_dma case.Fixes 03fbb903c8bf ("i2c: at91: use dma safe buffers")Signed-off-by Nathan Chancellor <[email protected]>
Thanks for fixing.
-michael
Ping? This is a pretty obvious fix and this warning turns into an error with CONFIG_WERROR so some of our -next builds have been broken for over a week now.
Quoted 39 lines · Nathan Chancellor
Clang warns:
drivers/i2c/busses/i2c-at91-master.c:707:6: warning: variable 'dma_buf' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]if (dev->use_dma) { ^~~~~~~~~~~~ drivers/i2c/busses/i2c-at91-master.c:717:27: note: uninitialized use occurs here i2c_put_dma_safe_msg_buf(dma_buf, m_start, !ret); ^~~~~~~Initialize
dma_bufto NULL, asi2c_put_dma_safe_msg_buf()is a no-op when the first argument is NULL, which will work for the !dev->use_dma case.Fixes 03fbb903c8bf ("i2c: at91: use dma safe buffers")Signed-off-by Nathan Chancellor <[email protected]>--- drivers/i2c/busses/i2c-at91-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/i2c/busses/i2c-at91-master.c +1
-1@@ -656,7 +656,7 @@ static int at91_twi_xfer(struct i2c_adapter *adap, struct i2c_msg *msg, int num)unsigned int_addr_flag =0 ;struct i2c_msg *m_start = msg;bool is_read; -u8 *dma_buf; +u8 *dma_buf =NULL ;dev_dbg (&adap->dev,"at91_xfer: processing %d messages:\n" , num);base-commit:
a181b8d187319bf265a2019ddde856a3d2f107a6Signature · 1 line
2.36.0
Wolfram Sang
AppliedQuoted 9 lines · Nathan Chancellor
Clang warns:
drivers/i2c/busses/i2c-at91-master.c:707:6: warning: variable 'dma_buf' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]if (dev->use_dma) { ^~~~~~~~~~~~ drivers/i2c/busses/i2c-at91-master.c:717:27: note: uninitialized use occurs here i2c_put_dma_safe_msg_buf(dma_buf, m_start, !ret); ^~~~~~~
Quoted 7 lines
Initialize
dma_bufto NULL, asi2c_put_dma_safe_msg_buf()is a no-op when the first argument is NULL, which will work for the !dev->use_dma case.Fixes 03fbb903c8bf ("i2c: at91: use dma safe buffers")Signed-off-by Nathan Chancellor <[email protected]>
Applied to for-next, thanks!
Quoted 14 lines · Wolfram Sang
Quoted 13 lines · Nathan Chancellor
Clang warns:
drivers/i2c/busses/i2c-at91-master.c:707:6: warning: variable 'dma_buf' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]if (dev->use_dma) { ^~~~~~~~~~~~ drivers/i2c/busses/i2c-at91-master.c:717:27: note: uninitialized use occurs here i2c_put_dma_safe_msg_buf(dma_buf, m_start, !ret); ^~~~~~~Initialize
dma_bufto NULL, asi2c_put_dma_safe_msg_buf()is a no-op when the first argument is NULL, which will work for the !dev->use_dma case.
Quoted 6 lines
Quoted 3 lines
Fixes 03fbb903c8bf ("i2c: at91: use dma safe buffers")Signed-off-by Nathan Chancellor <[email protected]>Applied to for-next, thanks!
Thank you!
Cheers,
Nathan